Re: [PATCH 11/34] brcmfmac: Split brcmf_sdiod_buffrw function up.

On 07/08/17 12:26, Arend van Spriel wrote: >> +err = brcmf_sdiod_buff_write(sdiodev, SDIO_FUNC_2, addr, mypkt); >> >> brcmu_pkt_buf_free_skb(mypkt); >> + > > You are keen on sprinkling whitespace here and there. Could you please > use separate patches for that as much as possible.

Re: [PATCH 11/34] brcmfmac: Split brcmf_sdiod_buffrw function up.

On 7/26/2017 10:25 PM, Ian Molton wrote: This function needs to be split up into separate read / write variants for clarity. Reviewed-by: Arend van Spriel Signed-off-by: Ian Molton more comments below... # Conflicts: #

[PATCH 11/34] brcmfmac: Split brcmf_sdiod_buffrw function up.

This function needs to be split up into separate read / write variants for clarity. Signed-off-by: Ian Molton # Conflicts: # drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c --- .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 69 +++---

[PATCH 11/34] brcmfmac: Split brcmf_sdiod_buffrw function up.

This function needs to be split up into separate read / write variants for clarity. Signed-off-by: Ian Molton --- .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 64 +++--- 1 file changed, 45 insertions(+), 19 deletions(-) diff --git