Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-09-29 Thread Jes Sorensen
Kalle Valo writes: > Jes Sorensen writes: > > I doubt that this will be in active enough development that a separate > git tree is needed. wireless-drivers trees should be enough and this > line can be removed. I would like to

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-09-29 Thread Kalle Valo
Jes Sorensen writes: I doubt that this will be in active enough development that a separate git tree is needed. wireless-drivers trees should be enough and this line can be removed. >>> >>> I would like to keep this line, it points to my development tree,

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-09-09 Thread Jes Sorensen
Larry Finger writes: > On 09/07/2015 01:43 PM, Jes Sorensen wrote: >> Kalle Valo writes: >>> Hi, >>> >>> replying to an old thread first. >>> >>> Jes Sorensen writes: >>> Kalle Valo writes:

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-09-07 Thread Kalle Valo
Larry Finger writes: >> It's easier that the driver has it's on directory as everything >> (makefile, kconfig etc) is cleanly separated. And actually I would like >> to create a new vendor directory for realtek and have this in >>

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-09-07 Thread Jes Sorensen
Kalle Valo writes: > Hi, > > replying to an old thread first. > > Jes Sorensen writes: > >> Kalle Valo writes: >>> jes.soren...@redhat.com writes: >>> MAINTAINERS |8 +

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-09-07 Thread Larry Finger
On 09/07/2015 01:43 PM, Jes Sorensen wrote: Kalle Valo writes: Hi, replying to an old thread first. Jes Sorensen writes: Kalle Valo writes: jes.soren...@redhat.com writes: MAINTAINERS |

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-09-06 Thread Kalle Valo
Hi, replying to an old thread first. Jes Sorensen writes: > Kalle Valo writes: >> jes.soren...@redhat.com writes: >> >>> MAINTAINERS |8 + >>> drivers/net/wireless/Kconfig | 19 + >>>

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-09-06 Thread Larry Finger
On 09/06/2015 08:38 AM, Kalle Valo wrote: Hi, replying to an old thread first. Jes Sorensen writes: Kalle Valo writes: jes.soren...@redhat.com writes: MAINTAINERS |8 + drivers/net/wireless/Kconfig |

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-04-28 Thread Jes Sorensen
Kalle Valo kv...@codeaurora.org writes: jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. After spending months cleaning up the vendor provided

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-04-28 Thread Kalle Valo
Kalle Valo kv...@codeaurora.org writes: And I pushed this to wireless-drivers-next.git pending branch so that kbuild will run it's tests with this driver. There was one warning from kbuild, but I didn't check if it's just a false warning or what: drivers/net/wireless/rtl8xxxu.c: In function

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-04-28 Thread Larry Finger
On 04/28/2015 09:27 AM, Jes Sorensen wrote: Kalle Valo kv...@codeaurora.org writes: jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. After spending

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-04-28 Thread Kalle Valo
jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. After spending months cleaning up the vendor provided rtl8723au driver, which comes with it's own

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-23 Thread Joe Perches
On Mon, 2015-03-23 at 16:25 -0400, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. trivia: diff --git a/drivers/net/wireless/rtl8xxxu.c

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-23 Thread Jes Sorensen
Joe Perches j...@perches.com writes: On Mon, 2015-03-23 at 16:25 -0400, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. trivia: diff --git

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-09 Thread Jes Sorensen
Larry Finger larry.fin...@lwfinger.net writes: Quilt reports the following when this patch is refreshed: Warning: trailing whitespace in lines 2862,3273,3492,3521 of drivers/net/wireless/rtl8xxxu.c Hi Larry, I fixed up the trailing whitespaces in v2 (and added a (setq

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-09 Thread Joe Perches
On Mon, 2015-03-09 at 13:00 -0400, jes.soren...@redhat.com wrote: This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. Mostly trivial comments: diff --git a/MAINTAINERS b/MAINTAINERS [] +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) +M:

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-09 Thread Johannes Berg
Hi Jes, Many thanks to Johannes Berg for 802.11 insights and help and Larry Finger for help with the vendor driver. :-) Just a few comments since this is really the first time I'm looking closely at the code. + h2c.ramask.cmd = H2C_SET_RATE_MASK; + put_unaligned_le16(ramask

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-09 Thread Joe Perches
On Mon, 2015-03-09 at 15:02 -0400, Jes Sorensen wrote: Joe Perches j...@perches.com writes: On Mon, 2015-03-09 at 14:43 -0400, Jes Sorensen wrote: Joe Perches j...@perches.com writes: On Mon, 2015-03-09 at 13:00 -0400, jes.soren...@redhat.com wrote: This is an alternate driver for the

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-09 Thread Johannes Berg
On Mon, 2015-03-09 at 14:35 -0400, Jes Sorensen wrote: + if (sta-ht_cap.ht_supported) { + ampdu_factor = sta-ht_cap.ampdu_factor; + ampdu_density = sta-ht_cap.ampdu_density; + sifs = 0x0e; + } else { +

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-09 Thread Jes Sorensen
Johannes Berg johan...@sipsolutions.net writes: Hi Jes, Many thanks to Johannes Berg for 802.11 insights and help and Larry Finger for help with the vendor driver. :-) Just a few comments since this is really the first time I'm looking closely at the code. Thanks! +h2c.ramask.cmd =

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-09 Thread Jes Sorensen
Joe Perches j...@perches.com writes: On Mon, 2015-03-09 at 13:00 -0400, jes.soren...@redhat.com wrote: This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. Mostly trivial comments: diff --git a/MAINTAINERS b/MAINTAINERS []

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-09 Thread Jes Sorensen
Joe Perches j...@perches.com writes: On Mon, 2015-03-09 at 14:43 -0400, Jes Sorensen wrote: Joe Perches j...@perches.com writes: On Mon, 2015-03-09 at 13:00 -0400, jes.soren...@redhat.com wrote: This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-09 Thread Joe Perches
On Mon, 2015-03-09 at 14:43 -0400, Jes Sorensen wrote: Joe Perches j...@perches.com writes: On Mon, 2015-03-09 at 13:00 -0400, jes.soren...@redhat.com wrote: This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. Mostly trivial

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-07 Thread Larry Finger
On 03/06/2015 04:15 PM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. After spending months cleaning up the vendor provided rtl8723au driver, which

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-06 Thread Joe Perches
On Fri, 2015-03-06 at 17:15 -0500, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. After spending months cleaning up the vendor provided rtl8723au

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-06 Thread Jes Sorensen
Joe Perches j...@perches.com writes: On Sat, 2015-03-07 at 00:18 -0500, Jes Sorensen wrote: The long strings are an outright nack. Pity. There's a specific exclusion in CodingStyle. Chapter 2: Breaking long lines and strings never break user-visible strings such as printk messages,

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-06 Thread Joe Perches
On Sat, 2015-03-07 at 00:18 -0500, Jes Sorensen wrote: The long strings are an outright nack. Pity. There's a specific exclusion in CodingStyle. Chapter 2: Breaking long lines and strings never break user-visible strings such as printk messages, because that breaks the ability to grep

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-06 Thread Jes Sorensen
Joe Perches j...@perches.com writes: On Fri, 2015-03-06 at 17:15 -0500, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. After spending months