Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
(adding back lists) Sebastian Gottschall writes: > Am 06.04.2018 um 10:25 schrieb Kalle Valo: >> Sebastian Gottschall writes: >> >>> Am 06.04.2018 um 10:09 schrieb Kalle Valo: (adding back the lists, please don't top post and trim your

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
Sebastian Gottschall writes: > Am 06.04.2018 um 10:09 schrieb Kalle Valo: >> (adding back the lists, please don't top post and trim your quotes) >> >> Sebastian Gottschall writes: >> >>> okay. ath10k-check is buggy and doesnt work. so it doesnt

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Sebastian Gottschall
Am 06.04.2018 um 10:09 schrieb Kalle Valo: (adding back the lists, please don't top post and trim your quotes) Sebastian Gottschall writes: okay. ath10k-check is buggy and doesnt work. so it doesnt help much with code styles root@seg-desktop:/xfs/ath10k/ath.gpio#

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Sebastian Gottschall
Am 06.04.2018 um 10:07 schrieb Kalle Valo: Sebastian Gottschall writes: i have some comments about your check warnings. some of them are bogus. for instance they advise to use "unsigned int" instead of "unsigned". this might be better, but the original kernel header

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
(adding back the lists, please don't top post and trim your quotes) Sebastian Gottschall writes: > okay. ath10k-check is buggy and doesnt work. so it doesnt help much > with code styles > > root@seg-desktop:/xfs/ath10k/ath.gpio# ./ath10k-check > global:

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
Sebastian Gottschall writes: > i have some comments about your check warnings. > some of them are bogus. for instance they advise to use "unsigned int" > instead of "unsigned". this might be better, but > the original kernel header uses "unsigned" as api definition. so i

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
Sebastian Gottschall writes: > Am 05.04.2018 um 16:44 schrieb Kalle Valo: >> s.gottsch...@dd-wrt.com writes: >> >>> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 >>> based chipsets with on chipset connected led's using WMI Firmware API. >>> The LED

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-05 Thread Sebastian Gottschall
i have some comments about your check warnings. some of them are bogus. for instance they advise to use "unsigned int" instead of "unsigned". this might be better, but the original kernel header uses "unsigned" as api definition. so i decided to use the same declarations here. for the rest

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-05 Thread Sebastian Gottschall
Am 05.04.2018 um 16:44 schrieb Kalle Valo: s.gottsch...@dd-wrt.com writes: Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based chipsets with on chipset connected led's using WMI Firmware API. The LED device will get available named as "ath10k-phyX" at sysfs and can be

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-05 Thread Kalle Valo
s.gottsch...@dd-wrt.com writes: > Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 > based chipsets with on chipset connected led's using WMI Firmware API. > The LED device will get available named as "ath10k-phyX" at sysfs and > can be controlled with various triggers. adds

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-12 Thread Sebastian Gottschall
Am 12.03.2018 um 08:53 schrieb Mathias Kresin: 10.03.2018 08:56, Sebastian Gottschall: taken a look at the specific code, and from my point of view the code that sets up the LED (including callback) is so trivial that it's simply not worth dealing with adding the leds-gpio driver to the

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-12 Thread Mathias Kresin
10.03.2018 08:56, Sebastian Gottschall: taken a look at the specific code, and from my point of view the code that sets up the LED (including callback) is so trivial that it's simply not worth dealing with adding the leds-gpio driver to the mix. It adds extra complexity and an extra dependency

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-09 Thread Sebastian Gottschall
taken a look at the specific code, and from my point of view the code that sets up the LED (including callback) is so trivial that it's simply not worth dealing with adding the leds-gpio driver to the mix. It adds extra complexity and an extra dependency for no reason at all. There's no extra

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-09 Thread Julian Calaby
Hi Felix, On Fri, Mar 9, 2018 at 2:46 AM, Felix Fietkau wrote: > On 2018-03-08 15:05, Pavel Machek wrote: >> On Thu 2018-03-08 13:33:29, Sebastian Gottschall wrote: >>> Am 08.03.2018 um 10:02 schrieb Pavel Machek: >>> >On Wed 2018-03-07 18:54:41, Sebastian Gottschall wrote: >>>

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-08 Thread Felix Fietkau
On 2018-03-08 15:05, Pavel Machek wrote: > On Thu 2018-03-08 13:33:29, Sebastian Gottschall wrote: >> Am 08.03.2018 um 10:02 schrieb Pavel Machek: >> >On Wed 2018-03-07 18:54:41, Sebastian Gottschall wrote: >> >>Am 07.03.2018 um 17:22 schrieb Rafał Miłecki: >> >>>On 2 March 2018 at 10:22,

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-08 Thread Sebastian Gottschall
Am 08.03.2018 um 16:04 schrieb Pavel Machek: Hi! show me a proof that its copy & paste. because its not I don't have to prove you anything. Sorry. then i will deny your argument because its false. But you said: see ath9k. its exact the same implementation. We don't want to have exact

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-08 Thread Pavel Machek
Hi! > show me a proof that its copy & paste. because its not I don't have to prove you anything. Sorry. But you said: > >>see ath9k. its exact the same implementation. We don't want to have exact same code multiple times in the tree.

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-08 Thread Sebastian Gottschall
Am 08.03.2018 um 15:29 schrieb Kalle Valo: Pavel Machek writes: ath10k_leds.gpio = ar->hw_params.led_pin; gpio_led_register_device(0, _leds); the problem are other architectures which have already registered gpio_led at system start like ar71xx you cannot register a second one.

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-08 Thread Sebastian Gottschall
Am 08.03.2018 um 15:05 schrieb Pavel Machek: On Thu 2018-03-08 13:33:29, Sebastian Gottschall wrote: Am 08.03.2018 um 10:02 schrieb Pavel Machek: On Wed 2018-03-07 18:54:41, Sebastian Gottschall wrote: Am 07.03.2018 um 17:22 schrieb Rafał Miłecki: On 2 March 2018 at 10:22, Sebastian

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-08 Thread Kalle Valo
Pavel Machek writes: >> >>>ath10k_leds.gpio = ar->hw_params.led_pin; >> >>>gpio_led_register_device(0, _leds); >> >> >> >>the problem are other architectures which have already registered gpio_led >> >>at system start like ar71xx >> >>you cannot register a second one. so a

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-08 Thread Pavel Machek
On Thu 2018-03-08 13:33:29, Sebastian Gottschall wrote: > Am 08.03.2018 um 10:02 schrieb Pavel Machek: > >On Wed 2018-03-07 18:54:41, Sebastian Gottschall wrote: > >>Am 07.03.2018 um 17:22 schrieb Rafał Miłecki: > >>>On 2 March 2018 at 10:22, Sebastian Gottschall >

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-08 Thread Sebastian Gottschall
Am 08.03.2018 um 10:02 schrieb Pavel Machek: On Wed 2018-03-07 18:54:41, Sebastian Gottschall wrote: Am 07.03.2018 um 17:22 schrieb Rafał Miłecki: On 2 March 2018 at 10:22, Sebastian Gottschall wrote: leds-gpio is crap and limited. you can just register one platform

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-08 Thread Pavel Machek
On Wed 2018-03-07 18:54:41, Sebastian Gottschall wrote: > Am 07.03.2018 um 17:22 schrieb Rafał Miłecki: > >On 2 March 2018 at 10:22, Sebastian Gottschall > >wrote: > leds-gpio is crap and limited. you can just register one platform data at > kernel runtime since

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-07 Thread Sebastian Gottschall
Am 07.03.2018 um 17:22 schrieb Rafał Miłecki: On 2 March 2018 at 10:22, Sebastian Gottschall wrote: leds-gpio is crap and limited. you can just register one platform data at kernel runtime since its identified by its object name "led-gpio" but the kernel forbidds to

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-07 Thread Rafał Miłecki
On 2 March 2018 at 10:22, Sebastian Gottschall wrote: >>> leds-gpio is crap and limited. you can just register one platform data at >>> kernel runtime since its identified by its object name "led-gpio" but the >>> kernel forbidds to register 2 platform datas with the same

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-02 Thread Pavel Machek
Hi! > >>adds also debugfs interface for gpio control. > >Hi Sebastian, > > > >I just noticed this patch and have one question. It seems you register > >GPIO chip and that WiFi LED is controller by a GPIO. Shouldn't you use > >leds-gpio driver and just register platform device with >

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-02 Thread Sebastian Gottschall
leds-gpio is crap and limited. you can just register one platform data at kernel runtime since its identified by its object name "led-gpio" but the kernel forbidds to register 2 platform datas with the same name consider the ar71xx devices with qca988x wifi chipsets. they all have already a led

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-27 Thread Sebastian Gottschall
Am 27.02.2018 um 23:08 schrieb Rafał Miłecki: On 26 February 2018 at 09:44, wrote: From: Sebastian Gottschall Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based chipsets with on chipset connected led's using WMI

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-27 Thread Rafał Miłecki
On 26 February 2018 at 09:44, wrote: > From: Sebastian Gottschall > > Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based > chipsets with on chipset connected led's > using WMI Firmware API. > The LED device will get

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-27 Thread Sebastian Gottschall
Am 27.02.2018 um 18:03 schrieb Steve deRosier: On Mon, Feb 26, 2018 at 12:44 AM, wrote: From: Sebastian Gottschall Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based chipsets with on chipset connected led's using

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-27 Thread Steve deRosier
On Mon, Feb 26, 2018 at 12:44 AM, wrote: > > From: Sebastian Gottschall > > Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based > chipsets with on chipset connected led's > using WMI Firmware API. > The LED device will