Re: [PATCH v2 09/12] qtnfmac: implement scan timeout

2017-08-07 Thread Kalle Valo
Sergey Matyukevich writes: >> > + if (timer_pending(>scan_timeout)) >> > + del_timer_sync(>scan_timeout); >> >> What if the device is removed while the timer is pending, is that >> handled? > > Good point. I took another look at this kind of

Re: [PATCH v2 09/12] qtnfmac: implement scan timeout

2017-08-04 Thread Sergey Matyukevich
> > + if (timer_pending(>scan_timeout)) > > + del_timer_sync(>scan_timeout); > > What if the device is removed while the timer is pending, is that > handled? Good point. I took another look at this kind of corner cases. Timer is not disabled explicitely. But ongoing scan request

Re: [PATCH v2 09/12] qtnfmac: implement scan timeout

2017-08-03 Thread Kalle Valo
Sergey Matyukevich writes: > Userspace tools may hang on scan in the case when scan completion event > is not returned by firmware. This patch implements the scan timeout > to avoid such situation. > > Signed-off-by: Igor Mitsyanko