Re: [Linux-zigbee-devel] [PATCHv4 00/11] minor fixes.

2013-07-15 Thread Alexander Aring
Seems, the mail server doesn't like me. On Mon, Jul 15, 2013 at 10:35:24PM +0200, Alexander Aring wrote: > Version 3 of my patch series for the 6lowpan stack. There is also a known > issue with the payload length on fragmentation which don't fix this series. > I am working on it... > > v4: > - G

[Linux-zigbee-devel] [PATCH 05/11] 6lowpan: Fix fragmentation with link-local compressed addresses

2013-07-15 Thread Alexander Aring
From: David Hauweele When a new 6lowpan fragment is received, a skbuff is allocated for the reassembled packet. However when a 6lowpan packet compresses link-local addresses based on link-layer addresses, the processing function relies on the skb mac control block to find the related link-layer a

[Linux-zigbee-devel] [PATCH 02/11] 6lowpan: fix return value with comment operator

2013-07-15 Thread Alexander Aring
Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 1ec14ef..8e0fbb8 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -819,7 +819,8 @@ low

[Linux-zigbee-devel] [PATCHv4 00/11] minor fixes.

2013-07-15 Thread Alexander Aring
Version 3 of my patch series for the 6lowpan stack. There is also a known issue with the payload length on fragmentation which don't fix this series. I am working on it... v4: - Got a "Mail delivery failed" - I resend this patch series v3: - add David Hauweele patch to fix fragmentation with li

[Linux-zigbee-devel] [PATCH 01/11] 6lowpan: fix small comment issue

2013-07-15 Thread Alexander Aring
Fix a little comment issue. Number 2 is 10 in bits and 1 is 01. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 55e1fd5..1ec14ef 100644 --- a/net/ieee8021

[Linux-zigbee-devel] [PATCH 03/11] 6lowpan: init 6lowpan header and ipv6hdr to zero

2013-07-15 Thread Alexander Aring
When we set it to zero, we can assume that the memory is already zero while parsing. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 8e0fbb8..fd0a5bc 1006

[Linux-zigbee-devel] [PATCH 04/11] 6lowpan: remove setting some memory regions to zero

2013-07-15 Thread Alexander Aring
While we can assume that the memory is already be zero, we can drop some memsets while parsing. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index fd0a5bc..f3406dac 1

[Linux-zigbee-devel] [PATCH 08/11] 6lowpan: lowpan_uncompress_addr with address_mode

2013-07-15 Thread Alexander Aring
This patch drop the pre and postcount calculation from the lowpan_uncompress_addr function. We use instead a switch case over address_mode value, it's easier to understand what's going on there. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 123 ++

[Linux-zigbee-devel] [PATCH 10/11] 6lowpan: add warning for DAC bit

2013-07-15 Thread Alexander Aring
We don't handle the DAC bit currently, so I add a warning and drop the package. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 706

[Linux-zigbee-devel] [PATCH 06/11] 6lowpan: use _saddr and _daddr instead of skb data

2013-07-15 Thread Alexander Aring
Pointers _saddr and _daddr points to source and destination address. Use this for a link-layer compression to get these addresses. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ie

[Linux-zigbee-devel] [PATCH 07/11] 6lowpan: add function to uncompress multicast addr

2013-07-15 Thread Alexander Aring
Add function to uncompress multicast address. This function split the uncompress function for a multicast address in a seperate function. To uncompress a multicast address is different than a other non-multicasts addresses according to rfc6282. Signed-off-by: Alexander Aring --- net/ieee802154/

[Linux-zigbee-devel] [PATCH 09/11] 6lowpan: add warning for CID bit

2013-07-15 Thread Alexander Aring
We don't handle the CID bit currently, so I add a warning and drop the package. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 51fb55c..7062dad 10064

[Linux-zigbee-devel] [PATCH 08/11] 6lowpan: lowpan_uncompress_addr with address_mode

2013-07-15 Thread Alexander Aring
This patch drop the pre and postcount calculation from the lowpan_uncompress_addr function. We use instead a switch case over address_mode value, it's easier to understand what's going on there. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 123 ++

[Linux-zigbee-devel] [PATCH 01/11] 6lowpan: fix small comment issue

2013-07-15 Thread Alexander Aring
Fix a little comment issue. Number 2 is 10 in bits and 1 is 01. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 55e1fd5..1ec14ef 100644 --- a/net/ieee8021

[Linux-zigbee-devel] [PATCH 11/11] 6lowpan: handle SAC bit to :: address

2013-07-15 Thread Alexander Aring
Some protocolls has a unspecific address as source address like "Multicast Listener Report Message v2" or "Neighbor Soliciation" decode the SAC bit as :: address. The header create part set this bit when a :: address is used. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 15

[Linux-zigbee-devel] [PATCH 05/11] 6lowpan: Fix fragmentation with link-local compressed addresses

2013-07-15 Thread Alexander Aring
From: David Hauweele When a new 6lowpan fragment is received, a skbuff is allocated for the reassembled packet. However when a 6lowpan packet compresses link-local addresses based on link-layer addresses, the processing function relies on the skb mac control block to find the related link-layer a

[Linux-zigbee-devel] [PATCH 07/11] 6lowpan: add function to uncompress multicast addr

2013-07-15 Thread Alexander Aring
Add function to uncompress multicast address. This function split the uncompress function for a multicast address in a seperate function. To uncompress a multicast address is different than a other non-multicasts addresses according to rfc6282. Signed-off-by: Alexander Aring --- net/ieee802154/

[Linux-zigbee-devel] [PATCH 02/11] 6lowpan: fix return value with comment operator

2013-07-15 Thread Alexander Aring
Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 1ec14ef..8e0fbb8 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -819,7 +819,8 @@ low

[Linux-zigbee-devel] [PATCHv3 00/11] minor fixes.

2013-07-15 Thread Alexander Aring
Version 3 of my patch series for the 6lowpan stack. There is also a known issue with the payload length on fragmentation which don't fix this series. I am working on it... v3: - add David Hauweele patch to fix fragmentation with link-local compressed addresses - add warnings for CID and DAC b

[Linux-zigbee-devel] [PATCH 09/11] 6lowpan: add warning for CID bit

2013-07-15 Thread Alexander Aring
We don't handle the CID bit currently, so I add a warning and drop the package. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 51fb55c..7062dad 10064

[Linux-zigbee-devel] [PATCH 10/11] 6lowpan: add warning for DAC bit

2013-07-15 Thread Alexander Aring
We don't handle the DAC bit currently, so I add a warning and drop the package. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 706

[Linux-zigbee-devel] [PATCH 03/11] 6lowpan: init 6lowpan header and ipv6hdr to zero

2013-07-15 Thread Alexander Aring
When we set it to zero, we can assume that the memory is already zero while parsing. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 8e0fbb8..fd0a5bc 1006

Re: [Linux-zigbee-devel] [PATCH 3/5] 6lowpan: use _saddr and _daddr instead of skb data

2013-07-15 Thread Alexander Aring
Hi Ralph, thanks for your reply. > > Right. And there is some additional special-casing, including (again, > assuming I'm recalling the details correctly) using 0 to represent 16. It's > an interesting observation that the various decompression mechanisms share > the construct of copying a

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-07-15 Thread Tony Cheneau
>> Yes, simpleRPL handle system with multiple network interfaces. I >> haven't >> tested a mix of IEEE 802.15.4 and Ethernet, but I don't see any >> reason why >> it would fail. I tested the two of link technologies independently, >> and I >> tested the multi-interface aspects using ethernet-onl

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-07-15 Thread jonsm...@gmail.com
On Mon, Jul 15, 2013 at 1:24 PM, Tony Cheneau wrote: > Hi Jon, > > [...] > > >> I haven't tried running the code yet, but does it support routing >> between two network interfaces? For example could it route between >> 802.15.4 and Ethernet? That is one of the key features of the BATMAN >> impleme

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-07-15 Thread Tony Cheneau
Hi Jon, [...] > I haven't tried running the code yet, but does it support routing > between two network interfaces? For example could it route between > 802.15.4 and Ethernet? That is one of the key features of the BATMAN > implementation. Yes, simpleRPL handle system with multiple network interf

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-07-15 Thread jonsm...@gmail.com
On Mon, Jul 15, 2013 at 11:44 AM, Tony Cheneau wrote: > Hi Werner, > > Thanks a lot for your email and your patches. I'm sorry it took me so > long to reply. > >> Good news: I got it to talk to Contiki. While I'm not sure it's >> working perfectly, a lot of things look right and pings between >> t

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-07-15 Thread Tony Cheneau
Hi Werner, Thanks a lot for your email and your patches. I'm sorry it took me so long to reply. > Good news: I got it to talk to Contiki. While I'm not sure it's > working perfectly, a lot of things look right and pings between > the two systems pass nicely. This is a excellent news indeed! > I

Re: [Linux-zigbee-devel] [PATCH 7/7] 6lowpan: lowpan_uncompress_addr with address_mode

2013-07-15 Thread Alexander Aring
Hi Ralph, On Mon, Jul 15, 2013 at 10:18:35AM +, Ralph Droms (rdroms) wrote: > I haven't tested these patches but they look OK to me. > > One editorial comment - s/layer_addr/macaddr/ or s/layer_addr/lladdr/ with a > comment that lladdr stands for "link-layer address" > thanks for this hint.

Re: [Linux-zigbee-devel] [PATCH 6/7] 6lowpan: add function to uncompress multicast addr

2013-07-15 Thread Ralph Droms (rdroms)
I haven't tested these patches but they look OK to me, based on my experience with similar code for a different stack. - Ralph On Jul 14, 2013, at 7:29 PM 7/14/13, Alexander Aring wrote: > Add function to uncompress multicast address. > This function split the uncompress function for a multic

Re: [Linux-zigbee-devel] [PATCH 7/7] 6lowpan: lowpan_uncompress_addr with address_mode

2013-07-15 Thread Ralph Droms (rdroms)
I haven't tested these patches but they look OK to me. One editorial comment - s/layer_addr/macaddr/ or s/layer_addr/lladdr/ with a comment that lladdr stands for "link-layer address" - Ralph On Jul 14, 2013, at 7:29 PM 7/14/13, Alexander Aring wrote: > This patch drop the pre and postcount

Re: [Linux-zigbee-devel] [PATCH 3/5] 6lowpan: use _saddr and _daddr instead of skb data

2013-07-15 Thread Ralph Droms (rdroms)
On Jul 15, 2013, at 9:27 AM 7/15/13, Alexander Aring wrote: > Hi Ralph, > > thanks for your reply. You're welcome, and thanks for your followup... > > On Fri, Jul 12, 2013 at 12:40:49PM +, Ralph Droms (rdroms) wrote: >> >> On Jul 12, 2013, at 7:33 AM 7/12/13, Alexander Aring >> wrote:

Re: [Linux-zigbee-devel] [PATCH 3/5] 6lowpan: use _saddr and _daddr instead of skb data

2013-07-15 Thread Alexander Aring
Hi Ralph, thanks for your reply. On Fri, Jul 12, 2013 at 12:40:49PM +, Ralph Droms (rdroms) wrote: > > On Jul 12, 2013, at 7:33 AM 7/12/13, Alexander Aring > wrote: > > > Pointers _saddr and _daddr points to source and destination address. > > Use this for a link-layer compression to get