Re: [Linux-zigbee-devel] [PATCH 5/7] 6lowpan: allow to skip bytes in lowpan_fetch_skb

2013-09-28 Thread Werner Almesberger
Alexander Aring wrote: > This is necessary for upcomming patches. Hmm, I didn't spot any case where you'd pass NULL, but maybe I didn't search hard enough. Is this for patchs in this set or in a future set ? If it's in the current set, do you have an example where this check is needed ? - Werner

Re: [Linux-zigbee-devel] [PATCH 2/7] 6lowpan: clean lowpan netdev setup

2013-09-28 Thread Werner Almesberger
Alexander Aring wrote: > This patch removes some magic number. > Instead of magic numbers we use some defines. This may be misunderstood. When I read it, my first question was in which other patch you defined MAC802154_FRAME_HARD_HEADER_LEN. But of course, it already exists. So I'd say something l

[Linux-zigbee-devel] [PATCH 4/7] 6lowpan: fix fragmentation on sending side

2013-09-28 Thread Alexander Aring
This patch fixes the fragmentation on sending side according to rfc4944. Also add improvemnt to use the full payload of a PDU which calculate the nearest divided to 8 payload length for the fragmentation datagram offset attribute. Signed-off-by: Alexander Aring Acked-by: Werner Almesberger ---

[Linux-zigbee-devel] [PATCH 5/7] 6lowpan: allow to skip bytes in lowpan_fetch_skb

2013-09-28 Thread Alexander Aring
This will add support to skip bytes from skb with the lowpan_fetch_skb function. This is necessary for upcomming patches. Signed-off-by: Alexander Aring Acked-by: Werner Almesberger --- net/ieee802154/6lowpan.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/ieee8021

[Linux-zigbee-devel] [PATCH 6/7] 6lowpan: fix fragmentation on receiving side

2013-09-28 Thread Alexander Aring
This patch fixes the fragmentation of receiving 6lowpan packets. The current fragmentation isn't rfc4944 compatible. Add support for fragmentation frame match with source and destination addresses, instead of using tag id of fragmentation header only. Signed-off-by: Alexander Aring Acked-by: Wer

[Linux-zigbee-devel] [PATCH 1/7] 6lowpan: set and use mac_len for mac header length

2013-09-28 Thread Alexander Aring
Set the mac header length while creating the 802.15.4 mac header. Drop the function for recalculate mac header length in upper layers which was static and works for intra pan communication only. Signed-off-by: Alexander Aring Acked-by: Werner Almesberger --- net/ieee802154/6lowpan.c | 13 +

[Linux-zigbee-devel] [PATCH 3/7] 6lowpan: remove several copies of sk_buff

2013-09-28 Thread Alexander Aring
The current implementation does many copies of the sk_buff for increasing headroom which are not necessary. This patch increases the headroom in the maclayer for a worst case scenario of (sizeof(struct ipv6hdr) + sizeof(struct udphdr)). Signed-off-by: Alexander Aring Acked-by: Werner Almesberger

[Linux-zigbee-devel] [PATCH 2/7] 6lowpan: clean lowpan netdev setup

2013-09-28 Thread Alexander Aring
This patch removes some magic number. Instead of magic numbers we use some defines. Signed-off-by: Alexander Aring Acked-by: Werner Almesberger --- net/ieee802154/6lowpan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpa

[Linux-zigbee-devel] [PATCH 7/7] 6lowpan: fix udp compression/uncompression

2013-09-28 Thread Alexander Aring
The current udp compression/uncompression have several issues. A list of founded issues: 1. Byteordering issues in both functions which indicate that these functions never worked correctly. 2. Fixing derefecening issue which occurs a deferencing nullpointer sometimes. 3. Compress source p

[Linux-zigbee-devel] [PATCH/RFC 0/7] 6lowpan: fragmentation and udp fixes

2013-09-28 Thread Alexander Aring
This patch series fixes the fragmentation implementation according to rfc4944. So ping (with fragmentation) to contiki(or other rfc4944 compatible 6lowpan stacks) comes possible. I wanted to made a fragmentation implementation with the internal fragmentation api(include/net/inet_frag.h). The curre