On Tue, 2014-07-01 at 21:49 -0700, Florian Fainelli wrote:
> 2014-07-01 21:40 GMT-07:00 Joe Perches :
> > On Tue, 2014-07-01 at 21:20 -0700, Florian Fainelli wrote:
> >> Hi,
> >>
> >> 2014-07-01 20:31 GMT-07:00 Varka Bhadram :
> >> > This
On Tue, 2014-07-01 at 21:20 -0700, Florian Fainelli wrote:
> Hi,
>
> 2014-07-01 20:31 GMT-07:00 Varka Bhadram :
> > This patch fixed the coding style issues reported by checkpatch.pl
> >
> > following issues fixed:
> > CHECK: Alignment should match open parenthesis
>
> It seems to me like
On Tue, 2014-03-18 at 21:35 -0700, Eric Dumazet wrote:
> On Tue, 2014-03-18 at 20:42 -0700, Joe Perches wrote:
> > On Tue, 2014-03-18 at 20:32 -0700, Eric Dumazet wrote:
> > > On Tue, 2014-03-18 at 21:19 -0600, Jean Sacren wrote:
> > >
> > > > 2) Fix the ini
On Tue, 2014-03-18 at 22:56 -0600, Jean Sacren wrote:
> Stating it is a "fix" is not a false statement at all. !! falsely
> changes the value to be int TWICE for nothing! Are you still not
> convinced?
Not so fast Jean. There's no logic change.
Changing the type to bool does exactly the same thi
On Tue, 2014-03-18 at 20:32 -0700, Eric Dumazet wrote:
> On Tue, 2014-03-18 at 21:19 -0600, Jean Sacren wrote:
>
> > 2) Fix the initializer by deleting the double logical negation
> >operators as they don't serve any purpose.
> >
> ...
> >
> > static int phy_set_lbt(struct wpan_phy *phy, s
The use of __constant_ has been unnecessary for quite awhile now.
Make these uses consistent with the rest of the kernel.
Signed-off-by: Joe Perches
---
net/ieee802154/6lowpan_rtnl.c | 2 +-
net/ieee802154/af_ieee802154.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a
Joe Perches (6):
8021q: Convert uses of __constant_ to
bluetooth: Convert uses of __constant_ to
net: Convert uses of __constant_ to
ieee802154: Convert uses of __constant_ to
netfilter: Convert uses of __constant_ to
tipc: Convert uses of __constant_ to
net/8021q/vlan.h
On Wed, 2014-02-26 at 19:32 +0100, Alexander Aring wrote:
> On Wed, Feb 26, 2014 at 10:24:45AM -0800, Joe Perches wrote:
[]
> > Perhaps the compiler would inline the assignment
> > anyway if addr_mode is __builtin_constant_p
[]
> I am not sure what I should do now, ch
On Wed, 2014-02-26 at 16:10 +, David Laight wrote:
> From: Alexander Aring
[]
> > diff --git a/net/ieee802154/6lowpan.h b/net/ieee802154/6lowpan.h
[]
> > +static inline u8 lowpan_addr_mode_size(const u8 addr_mode)
> > +{
> > + switch (addr_mode) {
> > + case LOWPAN_IPHC_ADDR_00:
> > +
On Wed, 2014-02-26 at 17:05 +0100, Alexander Aring wrote:
> Detected with:
>
> ./scripts/checkpatch.pl --strict -f net/ieee802154/6lowpan_rtnl.c
Hello Alexander.
Can I suggest to you (and to David) that the
multiline comment style:
/*
* comment
*/
is fine and doesn't need correcting here at
On Fri, 2014-02-21 at 16:15 +0100, Alexander Aring wrote:
> diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c
[]
> @@ -484,8 +475,8 @@ lowpan_skb_fragmentation(struct sk_buff *skb, struct
> net_device *dev)
> err = lowpan_fragment_xmit(skb, head, header_lengt
On Thu, 2013-11-14 at 16:48 +0100, Alexander Aring wrote:
> Bit 5 of "UDP LOWPAN_NHC Format" indicate that the checksum can be elided.
> The host need to calculate the udp checksum afterwards but this isn't
> supported right now.
[]
> diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
On Sat, 2013-10-26 at 01:42 -0400, David Miller wrote:
> From: Alexander Aring
> Date: Thu, 24 Oct 2013 22:51:42 +0200
>
> > @@ -1127,12 +1127,12 @@ lowpan_fragment_xmit(struct sk_buff *skb, u8 *head,
> >
> > lowpan_raw_dump_inline(__func__, "6lowpan fragment header", head, hlen);
> >
> >
On Fri, 2013-10-25 at 07:28 +0400, Alexander Smirnov wrote:
> > 25 окт. 2013 г., в 0:51, Alexander Aring написал(а):
[]
> > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
[]
> > @@ -440,7 +440,6 @@ lowpan_uncompress_udp_header(struct sk_buff *skb,
> > struct udphdr *uh)
> >
On Sun, 2013-10-06 at 14:44 -0700, Guenter Roeck wrote:
> net_devce doesn't exist.
[]
> diff --git a/net/ieee802154/af802154.h b/net/ieee802154/af802154.h
[]
> @@ -25,7 +25,7 @@
> #define AF802154_H
>
> struct sk_buff;
> -struct net_devce;
> +struct net_device;
That argues more for deletion th
On Mon, 2011-12-19 at 14:43 -0500, David Miller wrote:
> From: Alexander Smirnov
> > + if ((--priv->hw->open_count) == 0)
> This is more canonical as "if (!--priv->hw->open_count)".
Shrug. I think this is more readable and
intelligible with the == 0.
A test of a non-bool or non-ptr to a spec
Signed-off-by: Joe Perches
---
MAINTAINERS |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f4175c5..2375de3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2850,7 +2850,7 @@ W:http://apps.sourceforge.net/trac/linux-zigbee
T
17 matches
Mail list logo
