Hello,
Please don't top-post on the ML, it is considered a bad taste and bad etiquette.
On Sat, Mar 3, 2012 at 9:20 AM, Prajosh Premdas
wrote:
> Hi All & Dmitry
>
> Now i see your point there and understand the design better. But i
> have a few more doubts.
Yes, not all configurations are logic
On 24/02/12 13:02, Prajosh Premdas wrote:
> From: Felix Varghese
>
> Added function prototypes, structure definitions and netlink attributes for
> supporting PIB get/set functionality
First, why do you need PIB functionality? Except standard conformance,
of course.
Second, union containing all
On 24/02/12 13:02, Prajosh Premdas wrote:
> From: Felix Varghese
>
> Added #defines for MAC PIB attribute ids and default values for PIB attributes
Unnecessary whitespace changes. Unused constants. Camel case. NAK.
Please add constants together with code that will use them.
>
> Signed-off-by:
On 24/02/12 13:02, Prajosh Premdas wrote:
> -/* MIB callbacks */
> -void mac802154_dev_set_ieee_addr(struct net_device *dev);
> +/* MLME_GET request and confirm function definitions */
> +extern int mlme_get_req(struct net_device *dev, u8 PIBattr);
> +extern int internal_get_mac_pib(struct net_devi
Summary on all the patchset below.
Prajosh, Felix. Thanks for your work on IEEE 802.15.4 for Linux. Please
don't find my mails as discouraging or otherwise demoting your work.
There are some coding standards. There are some ideas behind code. There
is more than just blindly following standard text
Hello,
Prajosh. Please in future also send a cover letter containing a
description of your changes and a summary of patchset (check git
request-pull for a sample message format).
On 24/02/12 13:02, Prajosh Premdas wrote:
> mlme reset functionality has been added for netlink socket interface
> att
On 24/02/12 13:02, Prajosh Premdas wrote:
> From: Felix Varghese
>
> Adds structure definitions and function prototypes for implementing PIB
> get and set primitives
NAK. I have already commented about PIB get/set. Now about
set_trx_state. If you care about direct radio access from MCU, you
prob
On 3 March 2012 02:48, Dmitry Eremin-Solenikov wrote:
> On Fri, Mar 2, 2012 at 3:52 PM, Felix Varghese wrote:
>> Guys, I'd like to join the foray too :)
>>
>>> I'm sorry but your suggestions make nearly no sense. The current design
>>> is targeted different applications and different types of int
Hello,
On Sat, Mar 3, 2012 at 10:10 PM, Felix Varghese wrote:
> On 3 March 2012 02:48, Dmitry Eremin-Solenikov wrote:
>> On Fri, Mar 2, 2012 at 3:52 PM, Felix Varghese wrote:
>>> Guys, I'd like to join the foray too :)
>>>
I'm sorry but your suggestions make nearly no sense. The current de
On Sat, Mar 03, 2012 at 10:33:49PM +0400, Dmitry Eremin-Solenikov wrote:
>
> >
> > Most 802.15.4 transceivers in the market today provide a lot of
> > hardware acceleration, such as support for address filtering, auto
> > acknowledgement, CRC checking, retries and CSMA, etc. To use this kind
> > o
On Sat, Mar 3, 2012 at 10:49 PM, Mariano Alvira wrote:
> On Sat, Mar 03, 2012 at 10:33:49PM +0400, Dmitry Eremin-Solenikov wrote:
>>
>> >
>> > Most 802.15.4 transceivers in the market today provide a lot of
>> > hardware acceleration, such as support for address filtering, auto
>> > acknowledgemen
11 matches
Mail list logo
