Hi Martin,
On Wed, Sep 10, 2014 at 03:06:06PM +0100, Martin Townsend wrote:
> Currently there are a number of error paths in the lowpan_rcv function that
> free the skb before returning, this patch simplifies the receive path by
> ensuring that the skb is only freed from this function.
>
> Signed
On Thu, Sep 11, 2014 at 09:58:30AM +0200, Alexander Aring wrote:
...
> >
> > @@ -490,14 +490,14 @@ static int lowpan_rcv(struct sk_buff *skb, struct
> > net_device *dev,
> > } else {
> > switch (skb->data[0] & 0xe0) {
> > case LOWPAN_DISPATCH_IPHC: /* ipv6 datagr
On Wed, Sep 10, 2014 at 03:06:07PM +0100, Martin Townsend wrote:
> Passing the skb from 6lowpan up to the higher layers is not a
> function of IPHC. By moving it out of IPHC we also remove the
> need to support error code returns with NET_RX codes.
> It also makes the lowpan_rcv function more exte
Hi Alex,
On 11/09/14 09:18, Alexander Aring wrote:
> On Wed, Sep 10, 2014 at 03:06:07PM +0100, Martin Townsend wrote:
>> Passing the skb from 6lowpan up to the higher layers is not a
>> function of IPHC. By moving it out of IPHC we also remove the
>> need to support error code returns with NET_RX
Hi Alex,
Thanks for reviewing, this patch is part of the solution with the next patch,
please take this into consideration. Sorry I should have put this in the cover
letter.
The idea is to finally split skb delivery out of IPHC so the iphc decompress
function(s) just return an error code at w
Hi Martin,
On Wed, Sep 10, 2014 at 03:06:08PM +0100, Martin Townsend wrote:
> Currently we support uncompressed IPv6 headers after performing fragmentation.
>
This patch is for wpan-next.
> Signed-off-by: Martin Townsend
> ---
> include/net/6lowpan.h | 17
> net/ieee80215
Hi Martin,
On Thu, Sep 11, 2014 at 09:25:56AM +0100, Martin Townsend wrote:
> Hi Alex,
>
> On 11/09/14 09:18, Alexander Aring wrote:
> > On Wed, Sep 10, 2014 at 03:06:07PM +0100, Martin Townsend wrote:
> >> Passing the skb from 6lowpan up to the higher layers is not a
> >> function of IPHC. By m
Hi Martin,
On Thu, Sep 11, 2014 at 10:53:53AM +0200, Alexander Aring wrote:
...
>
> I know this issue and we should not do that in this way.
>
> Why?
>
> Because this works only for fragmentation with IPHC, for example if we
> support mesh or Broadcast or HC1 compression. We should call after
>
On Thu, Sep 11, 2014 at 11:09:50AM +0200, Alexander Aring wrote:
> Hi Martin,
>
> On Thu, Sep 11, 2014 at 10:53:53AM +0200, Alexander Aring wrote:
> ...
> >
> > I know this issue and we should not do that in this way.
> >
> > Why?
> >
> > Because this works only for fragmentation with IPHC, for
Hi Alex,
On 11/09/14 09:53, Alexander Aring wrote:
> Hi Martin,
>
> On Wed, Sep 10, 2014 at 03:06:08PM +0100, Martin Townsend wrote:
>> Currently we support uncompressed IPv6 headers after performing
>> fragmentation.
>>
> This patch is for wpan-next.
ok, but it depends on the previous patches so
Hi Alex,
On 11/09/14 10:01, Alexander Aring wrote:
> Hi Martin,
>
> On Thu, Sep 11, 2014 at 09:25:56AM +0100, Martin Townsend wrote:
>> Hi Alex,
>>
>> On 11/09/14 09:18, Alexander Aring wrote:
>>> On Wed, Sep 10, 2014 at 03:06:07PM +0100, Martin Townsend wrote:
Passing the skb from 6lowpan up
On Thu, Sep 11, 2014 at 10:30:46AM +0100, Martin Townsend wrote:
> Hi Alex,
>
> On 11/09/14 09:53, Alexander Aring wrote:
> > Hi Martin,
> >
> > On Wed, Sep 10, 2014 at 03:06:08PM +0100, Martin Townsend wrote:
> >> Currently we support uncompressed IPv6 headers after performing
> >> fragmentation
On Thu, Sep 11, 2014 at 10:33:33AM +0100, Martin Townsend wrote:
> Hi Alex,
>
> On 11/09/14 10:01, Alexander Aring wrote:
> > Hi Martin,
> >
> > On Thu, Sep 11, 2014 at 09:25:56AM +0100, Martin Townsend wrote:
> >> Hi Alex,
> >>
> >> On 11/09/14 09:18, Alexander Aring wrote:
> >>> On Wed, Sep 10,
Hi Alex,
Reposting to everyone this time :)
On 11/09/14 10:50, Alexander Aring wrote:
> On Thu, Sep 11, 2014 at 10:30:46AM +0100, Martin Townsend wrote:
>> Hi Alex,
>>
>> On 11/09/14 09:53, Alexander Aring wrote:
>>> Hi Martin,
>>>
>>> On Wed, Sep 10, 2014 at 03:06:08PM +0100, Martin Townsend wro
Hi Alex,
On 11/09/14 10:53, Alexander Aring wrote:
> On Thu, Sep 11, 2014 at 10:33:33AM +0100, Martin Townsend wrote:
>> Hi Alex,
>>
>> On 11/09/14 10:01, Alexander Aring wrote:
>>> Hi Martin,
>>>
>>> On Thu, Sep 11, 2014 at 09:25:56AM +0100, Martin Townsend wrote:
Hi Alex,
On 11/09
Hi Martin,
On Thu, Sep 11, 2014 at 11:12:09AM +0100, Martin Townsend wrote:
> Hi Alex,
>
> On 11/09/14 10:53, Alexander Aring wrote:
> > On Thu, Sep 11, 2014 at 10:33:33AM +0100, Martin Townsend wrote:
> >> Hi Alex,
> >>
> >> On 11/09/14 10:01, Alexander Aring wrote:
> >>> Hi Martin,
> >>>
> >>>
On Thu, Sep 11, 2014 at 11:09:26AM +0100, Martin Townsend wrote:
> Hi Alex,
>
> Reposting to everyone this time :)
>
ok
...
> >>> I know this issue and we should not do that in this way.
> >>>
> >>> Why?
> >>>
> >>> Because this works only for fragmentation with IPHC, for example if we
> >>> supp
Hi Alex,
On 11/09/14 11:33, Alexander Aring wrote:
> On Thu, Sep 11, 2014 at 11:09:26AM +0100, Martin Townsend wrote:
>> Hi Alex,
>>
>> Reposting to everyone this time :)
>>
> ok
> ...
> I know this issue and we should not do that in this way.
>
> Why?
>
> Because this works on
On Thu, Sep 11, 2014 at 11:45:58AM +0100, Martin Townsend wrote:
> Hi Alex,
>
> On 11/09/14 11:33, Alexander Aring wrote:
> > On Thu, Sep 11, 2014 at 11:09:26AM +0100, Martin Townsend wrote:
> >> Hi Alex,
> >>
> >> Reposting to everyone this time :)
> >>
> > ok
> > ...
> > I know this issue an
Hi Martin,
On Thu, Sep 11, 2014 at 12:55:05PM +0200, Alexander Aring wrote:
> On Thu, Sep 11, 2014 at 11:45:58AM +0100, Martin Townsend wrote:
> > Hi Alex,
> >
> > On 11/09/14 11:33, Alexander Aring wrote:
> > > On Thu, Sep 11, 2014 at 11:09:26AM +0100, Martin Townsend wrote:
> > >> Hi Alex,
> >
Hi Alex,
>> Passing the skb from 6lowpan up to the higher layers is not a
>> function of IPHC. By moving it out of IPHC we also remove the
>> need to support error code returns with NET_RX codes.
>> It also makes the lowpan_rcv function more extendable as we
>> can support more compression scheme
21 matches
Mail list logo
