[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread maksis
I don't see how "TL-1" would protect from misbehavior in the IDENTIFY state, as the error is not being sent in that state. I don't even believe that the author of that code had a clear intention to send TL-1 in that case, and I'd rather consider it to be a bug (which would be fixed by my patch).

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread eMTee
Whaterver else the whole function is possibly made to prevent from above the denial of a legitimate login attempt when 25% or more of the hub's total online users' socket buffer is overflown. Isn't there any more purpose in this code in your opinion? -- You received this bug notification

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread maksis
"dropping protection against clients possibly misbehaving in the IDENTIFY state and so endangering the hub stability" What kind of misbehavior are you thinking? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++.

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread eMTee
The reporter complains about network issues "lot of line microcuts affecting all the devices connected to the router) ... with this ISP" and increasing OverflowTimeout might help avoid the initial disconnects (which you see from the log above isn't because of the error of the topic of this bug

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread maksis
Hmm, I don't follow. How does increasing OverflowTimeout help with this issue? I can't spot any explanation from the code for that. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1088638 Title:

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread eMTee
Alright so maksis was right about this issue isn't being fully understood. I thought these disconnects can happen at anytime. This puts it into a slightly different perspective. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++.

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread laurent
I think it may happen on a hub restart or when the hub looses connectivity due to ISP line problems. The user reporting the issue uses 2 different clients, ndcd and Apex, both have experienced the same behaviour at differents times. 20:28:27 Read error: Error in the pull function. 20:28:27

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread eMTee
I don't believe that the error is related to running out of bandwidth, either, hence I am in contact with the reporter and we're currently trying to tweak things. None of the reporters mentioned that this problem to happen only after the hub has been restarted. That would need a confirmation as