Re: How to add platform specific data to a of_device

2007-07-16 Thread Robert Schwebel
On Sun, Jul 15, 2007 at 06:48:53AM +1000, Benjamin Herrenschmidt wrote: Your approach would work I suppose though it's a bit ugly. Speaking of uggly, I'm still wondering why this oftree stuff for powerpc must be s complicated. If you come from the ARM-linux world like we do, the whole

Re: [Cbe-oss-dev] PS3 improved video mode autodetection for HDMI/DVI

2007-07-16 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, Ranulf Doswell wrote: Since 720p is a broadcast mode, I can't make it default to fullscreen, as a part of the image will fall off on most monitors. Do you have any info from the EDID block that would tell you whether the monitor displays the full picture

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-07-16 Thread Albert Lee
Mikael Pettersson wrote: On Wed, 11 Jul 2007 10:45:35 +0800, Albert Lee wrote: So, it seems both mdelay(37) and do_gettimeofday() are working properly on PowerMac G3. Maybe the calculated wrong PLL input is due to wrong reading of the counter register? Could you please try the attached debug

Re: possible dead CONFIG-related content under arch/powerpc

2007-07-16 Thread Geert Uytterhoeven
On Sat, 14 Jul 2007, Robert P. J. Day wrote: == SPE_BASE == arch/powerpc/mm/hash_utils_64.c:612:#ifdef CONFIG_SPE_BASE arch/powerpc/mm/hash_utils_64.c:747:#ifdef CONFIG_SPE_BASE Interesting, should this one be CONFIG_SPU_BASE? With kind regards, Geert Uytterhoeven Software

Re: [patch] use __attribute__ in asm-powerpc

2007-07-16 Thread Robert P. J. Day
On Mon, 16 Jul 2007, Geert Uytterhoeven wrote: On Sat, 14 Jul 2007, Mike Frysinger wrote: Pretty much everyone uses __attribute__ or attribute, no one uses __attribute. This patch tweaks the three places in asm-powerpc where this comes up. While only asm-powerpc/types.h is interesting

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: Ah, that explains it. flush_dcache_page() is used in some drivers. I'll update my patches. Thanks for the comments! Does this look OK? - Replaced KM_USER0 by KM_IRQ0 (all routines are either called from an interrupt handler, from .request_fn

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Segher Boessenkool
I'm pretty sure that no ppc64 machine needs alias resolution in the kernel, although some are VIPT. Last time we discussed this, Segher explained it to me, but I don't remember which way Cell does it. IIRC, it automatically flushes cache lines that are accessed through aliases. Ah

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, Geert Uytterhoeven wrote: On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: Ah, that explains it. flush_dcache_page() is used in some drivers. I'll update my patches. Thanks for the comments! Does this look OK? - Replaced KM_USER0 by KM_IRQ0 (all routines are either

Re: Legacy ISA registers/interrupts in PCI device tree node

2007-07-16 Thread Segher Boessenkool
I wonder, if there is a recommended way to specify ISA register addresses and interrupts for a PCI device (unlike for a PCI2ISA bridge)? The PCI binding describes the required way to do this. The device in question is the integrated IDE controller of the VIA686B southbridge, which works

Re: [PATCH v2] Allow exec on 32-bit from readable, non-exec pages, with a warning.

2007-07-16 Thread Segher Boessenkool
Actually I see no good reason to enforce no-exec at all if we can't do it consistently. And if we're not going to enforce it then there is no point whinging about it. I have a new patch with just this behaviour, Scott is testing it on old glibc (I think it succeeded, need

Re: possible dead CONFIG-related content under arch/powerpc

2007-07-16 Thread Michael Ellerman
On Mon, 2007-07-16 at 11:16 +0200, Geert Uytterhoeven wrote: On Sat, 14 Jul 2007, Robert P. J. Day wrote: == SPE_BASE == arch/powerpc/mm/hash_utils_64.c:612:#ifdef CONFIG_SPE_BASE arch/powerpc/mm/hash_utils_64.c:747:#ifdef CONFIG_SPE_BASE Interesting, should this one be

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-16 Thread Segher Boessenkool
is this the only fix, I've already applied a version of this to my tree (with the irq sense fix) and just want to make sure there isn't anything else. I do not get more. I'd like to enroll Segher's suggestion together with VIA chip function in next step. We need to make basic pcie work on

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Geert Uytterhoeven
On Mon, 16 Jul 2007, Geert Uytterhoeven wrote: On Mon, 16 Jul 2007, Jens Axboe wrote: On Mon, Jul 16 2007, Geert Uytterhoeven wrote: On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: Ah, that explains it. flush_dcache_page() is used in some drivers. I'll update my patches. Thanks for

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, Geert Uytterhoeven wrote: On Mon, 16 Jul 2007, Geert Uytterhoeven wrote: On Mon, 16 Jul 2007, Jens Axboe wrote: On Mon, Jul 16 2007, Geert Uytterhoeven wrote: On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: Ah, that explains it. flush_dcache_page() is used in

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-16 Thread Kumar Gala
On Jul 16, 2007, at 8:05 AM, Segher Boessenkool wrote: is this the only fix, I've already applied a version of this to my tree (with the irq sense fix) and just want to make sure there isn't anything else. I do not get more. I'd like to enroll Segher's suggestion together with VIA chip

Re: [PATCH 1/4] Add DMA sector to Documentation/powerpc/booting-without-of.txt file.

2007-07-16 Thread Segher Boessenkool
I thought the idea of the dts/of was for the hardware specific boot loader to tell the kernel about hardware that the kernel couldn't otherwise know about, because its not detectable by a bus probe method, etc. Its not there to tell you how to use the device or arbitrate which other

Re: How to add platform specific data to a of_device

2007-07-16 Thread Segher Boessenkool
Hmm, as I stated above: Handling the SPI slave devices is done in the SPI framework. But including this data into the dts sounds better than including it into the BSP. Is there some documentation around how to describe such a SPI bus with its devices in the dts? I don't think so, I

Re: How to add platform specific data to a of_device

2007-07-16 Thread Segher Boessenkool
Is there a reason why there is sooo much interaction of the platform code with the oftree? Yes. Since the decision has been made to require a device tree for every platform, arch/powerpc is in the luxury position that we can actually exploit the benefits of _having_ a tree for every platform.

[patch 1/3] ps3: Disk Storage Driver

2007-07-16 Thread Geert Uytterhoeven
From: Geert Uytterhoeven [EMAIL PROTECTED] Add a Disk Storage Driver for the PS3: - Implemented as a block device driver with a dynamic major - Disk names (and partitions) are of the format ps3d%c(%u) - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor doesn't

[patch 3/3] ps3: FLASH ROM Storage Driver

2007-07-16 Thread Geert Uytterhoeven
From: Geert Uytterhoeven [EMAIL PROTECTED] Add a FLASH ROM Storage Driver for the PS3: - Implemented as a misc character device driver - Uses a fixed 256 KiB buffer allocated from boot memory as the hypervisor requires the writing of aligned 256 KiB blocks CC: Geoff Levand [EMAIL

[PATCH] cell: CONFIG_SPE_BASE is a typo (was: Re: possible dead CONFIG-related content under arch/powerpc)

2007-07-16 Thread Geert Uytterhoeven
The config symbol for SPE support is called CONFIG_SPU_BASE, not CONFIG_SPE_BASE. Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index 4f2f453..0b25d42 100644 --- a/arch/powerpc/mm/hash_utils_64.c +++

Re: [patch] use __attribute__ in asm-powerpc

2007-07-16 Thread Mike Frysinger
On Monday 16 July 2007, Geert Uytterhoeven wrote: On Sat, 14 Jul 2007, Mike Frysinger wrote: Pretty much everyone uses __attribute__ or attribute, no one uses __attribute. This patch tweaks the three places in asm-powerpc where this comes up. While only asm-powerpc/types.h is interesting

Re: [PATCH 2/2] Add PCI/PCI Express node for 8544DS board]

2007-07-16 Thread Segher Boessenkool
It looks real good now :-) One tiny comment... + [EMAIL PROTECTED] { + compatible = fsl,mpc8548-pcie; I would name the node [EMAIL PROTECTED] instead; generic names aren't for machine consumption anyway, and most humans want to know which buses are plain PCI

Re: [PATCH 04/10] IB/ehca: use common error code mapping instead of specific ones

2007-07-16 Thread Roland Dreier
@@ -161,8 +161,11 @@ static inline int ehca2ib_return_code(u64 ehca_rc) applied, but as a further cleanup it seems that ehca2ib_return_code() should be moved into a .c file and moved out of line -- I think it would probably shrink the compiled code quite a bit, and as far as I can see it is

Re: [PATCH] crash in 2.6.22-git2 sysctl_set_parent()

2007-07-16 Thread Linas Vepstas
On Fri, Jul 13, 2007 at 07:06:56PM -0600, Eric W. Biederman wrote: .data = ipv4_devconf.loop, .maxlen = sizeof(int), .mode = 0644, + .child = 0x0, .proc_handler

[PATCH] Fix Tsi108 ethernet driver performance

2007-07-16 Thread Alexandre Bounine
From: Alexandre Bounine [EMAIL PROTECTED] This patch improves performance of the Tsi108 Ethernet driver by changing interrupt handling for frame receive path. It reduces number of interrupts generated for received frames and therefore lowers CPU utilization by the device driver.

Re: [PATCH 10/10] IB/ehca: Support large page MRs

2007-07-16 Thread Roland Dreier
Add support for MR pages larger than 4K on eHCA2. This reduces firmware memory consumption. If enabled via the mr_largepage module parameter, the MR page size will be determined based on the MR length and the hardware capabilities - if the MR is = 16M, 16M pages are used, for example. Why

Re: [PATCH] Update mpc7448hpc2 device tree to be compatible for tsi109 chip

2007-07-16 Thread Segher Boessenkool
Update mpc7448hpc2 device tree to be compatible for tsi109 chip. Signed-off-by: Roy Zang [EMAIL PROTECTED] Looks good, thanks! Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 2/3] 82xx: Parse SMC serial device node in DTS

2007-07-16 Thread Mark Zhan
This patch makes 'cpm_uart_of_init' be able to parses SMC serial device node in DTS Signed-off-by: Mark Zhan [EMAIL PROTECTED] --- arch/powerpc/sysdev/fsl_soc.c | 37 - 1 file changed, 20 insertions(+), 17 deletions(-) Index:

[PATCH 3/3] 82xx: SBCPQ2 board platform support

2007-07-16 Thread Mark Zhan
This patch addes the powerpc support to Wind River SBC PowerQUICCII 82xx board. Signed-off-by: Mark Zhan [EMAIL PROTECTED] --- arch/powerpc/boot/dts/sbcpq2.dts | 191 +++ arch/powerpc/configs/sbcpq2_defconfig | 917 ++

[PATCH 1/2] adb: create class devices for each adb device

2007-07-16 Thread Aristeu Rozanski
This patch adds a class device for each adb device that has a handler. The class device contents will be accessible by /sys/class/adb/handlerN directory. This patch is needed in order to add an class device attribute to all keyboards that will determine the sysrq key for each keyboard.

Re: [PATCH 10/10] IB/ehca: Support large page MRs

2007-07-16 Thread Joachim Fenkes
Roland Dreier [EMAIL PROTECTED] wrote on 16.07.2007 19:37:09: If enabled via the mr_largepage module parameter, Why the module parameter? Is there any reason a user would want to turn this off? Or conversely, why is it off by default? We're pretty confident this new feature works, but

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 17:18 -0500, Scott Wood wrote: OK... but if you're doing a pure IRQ number conversion, the only useful #address-cells would be zero, which makes it a reasonable default IMHO (unlike the arbitrary 2 for regular traversal). It does make a reasonable default. The thing,

Re: [PATCH 1/2] adb: create class devices for each adb device

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 16:53 -0400, Aristeu Rozanski wrote: This patch adds a class device for each adb device that has a handler. The class device contents will be accessible by /sys/class/adb/handlerN directory. This patch is needed in order to add an class device attribute to all keyboards

[PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-07-16 Thread Vitaly Bordug
device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function, it is broken and

[PATCH] USB_DR host support for FSL MPC831x

2007-07-16 Thread Vitaly Bordug
Modifies fsl_ehci code so that to get USB host working on mpc831x platform. Verified with MPC8313RDB reference board. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8313erdb.dts |1 + drivers/usb/host/ehci-fsl.c |4 +++-

[PATCH] USB_DR device support for FSL MPC831x

2007-07-16 Thread Vitaly Bordug
This adds support for USB device mode on mpc831x series. Devicetree node modification is required to make it work - dr_mode =peripheral; which should be commented out if host mode is desired onboot. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- arch/powerpc/sysdev/fsl_soc.c |1 +

Re: [PATCH 2/3] 82xx: Parse SMC serial device node in DTS

2007-07-16 Thread Arnd Bergmann
On Monday 16 July 2007, Mark Zhan wrote: -   cpm_uart_data.uart_clk = ppc_proc_freq; +   if (strstr(model, SMC)) { +   cpm_uart_dev = platform_device_register_simple(fsl-cpm-smc:uart, +   i, r[0],

[PATCH] POWERPC 8xx: bump up initial memory limit for 8xx

2007-07-16 Thread Vitaly Bordug
From: John Traill [EMAIL PROTECTED] The 8xx can only support a max of 8M during early boot ( it seems a lot of 8xx boards only have 8M so the bug was never triggered ). The following change makes it able to run with 128M. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] ---

[PATCH 2.6.22-rc7 0/4] phy/gianfar: Fixes for gianfar and vitesse RGMII-ID support

2007-07-16 Thread Andy Fleming
A few bugs in the Vitesse PHY driver were found on the 8641D HPCN board. Originally, they were masked by a bug in the PHY Lib which was fixed by patch 5f708dd91d15876e26d7a57f97a255cedffca463 (Fix phy_id for Vitesse 824x PHY). That patch allowed the Vitesse PHY to bind on the 8641D HPCN board,

[PATCH 1/4] phy: Fix Vitesse 824x PHY interrupt acking

2007-07-16 Thread Andy Fleming
The Vitesse 824x PHY doesn't allow an interrupt to be cleared if the mask bit for that interrupt isn't set. This means that the PHY Lib's order of handling interrupts (disable, then clear) breaks on this PHY. However, clearing then disabling the interrupt opens up the code for a silly race

[PATCH 2/4] gianfar: Add phy-connection-type to gianfar nodes

2007-07-16 Thread Andy Fleming
The TSEC/eTSEC automatically detect their PHY interface type, unless the type is RGMII-ID (RGMII with internal delay). In that situation, it just detects RGMII. In order to fix this, we need to pass in rgmii-id if that is the connection type. Signed-off-by: Andy Fleming [EMAIL PROTECTED] ---

[PATCH 3/4] phy: Fix Vitesse RGMII-ID support

2007-07-16 Thread Andy Fleming
The Vitesse PHY on the 8641D needs to be set up with internal delay to work in RGMII mode. So we add skew when it is set to RGMII_ID mode. Signed-off-by: Andy Fleming [EMAIL PROTECTED] Signed-off-by: Haruki Dai [EMAIL PROTECTED] Signed-off-by: Haiying Wang [EMAIL PROTECTED] ---

Re: [PATCH 3/3] 82xx: SBCPQ2 board platform support

2007-07-16 Thread Arnd Bergmann
On Monday 16 July 2007, Mark Zhan wrote: This patch addes the powerpc support to Wind River SBC PowerQUICCII 82xx board. Hi Mark! I've got lots of small comments about your code, but mostly it comes down to one problem: your new platform code is not able to coexist with other platforms

Re: [PATCH 1/2] adb: create class devices for each adb device

2007-07-16 Thread Aristeu Rozanski
Hi Benjamin, I don't think class device is the right approach. Classes are supposed to be a functional binding, ie, in this case, input devices. ADB is a bus, and as such, you should create an adb bus type and and adb_device that is an extension of struct device, not struct class device. ok,

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-16 Thread Zang Roy-r61911
On Mon, 2007-07-16 at 23:00, Segher Boessenkool wrote: is this the only fix, I've already applied a version of this to my tree (with the irq sense fix) and just want to make sure there isn't anything else. I do not get more. I'd like to enroll Segher's suggestion together with VIA

Re: [PATCH] Allow exec on 32-bit from readable, non-exec pages, with a warning.

2007-07-16 Thread David Gibson
On Wed, Jul 11, 2007 at 02:03:24AM +0200, Segher Boessenkool wrote: Yeah. Giving the warning is a good thing though. No, it isn't; it's just noise, if we're not ever going to do anything to prevent the behaviour - and we can't. The same userland code will not run correctly on PPC64 or

[PATCH] Change the pci express controller node name from pci to pcie

2007-07-16 Thread Zang Roy-r61911
From: Roy Zang [EMAIL PROTECTED] Change the pci express controller node name from pci to pcie in device tree. Signed-off-by: Roy Zang [EMAIL PROTECTED] --- Based on Kumar tree and my previous patch for 8544DS board. arch/powerpc/boot/dts/mpc8544ds.dts|6 +++---

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-16 Thread Roland Dreier
No, I've no figures to provide here. The background of this dist_eqs option is actually to allow us testing across all event queues without to change the testcases resp consumers to use certain event queue number. Thus, I should comment it as EXPERIMENTAL? Seems like it's just

Re: [PATCH 10/10] IB/ehca: Support large page MRs

2007-07-16 Thread Roland Dreier
Why the module parameter? Is there any reason a user would want to turn this off? Or conversely, why is it off by default? We're pretty confident this new feature works, but as with all new and possibly experimental features, there are chances it might explode your machine when

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-16 Thread Michael S. Tsirkin
I still haven't seen much code using the feature or even any anecdotal information about the performance impact. Here's some anecdotal evidence :) http://lists.openfabrics.org/pipermail/general/2007-May/035758.html -- MST ___ Linuxppc-dev mailing

Re: [PATCH 2/3] 82xx: Parse SMC serial device node in DTS

2007-07-16 Thread Mark Zhan
Hello Arnd, I think, the function of_find_compatible_node(), which is called in the for loop, has already done that. So definitely, no need to call of_device_is_compatible() any more. Thanks Mark Zhan On Tue, 2007-07-17 at 03:02 +0200, Arnd Bergmann wrote: On Monday 16 July 2007, Mark Zhan

Re: [PATCH 2.6.22-rc7 0/4] phy/gianfar: Fixes for gianfar and vitesse RGMII-ID support

2007-07-16 Thread Jeff Garzik
Andy Fleming wrote: A few bugs in the Vitesse PHY driver were found on the 8641D HPCN board. Originally, they were masked by a bug in the PHY Lib which was fixed by patch 5f708dd91d15876e26d7a57f97a255cedffca463 (Fix phy_id for Vitesse 824x PHY). That patch allowed the Vitesse PHY to bind on

Re: [PATCH 2.6.22-rc7 0/4] phy/gianfar: Fixes for gianfar and vitesse RGMII-ID support

2007-07-16 Thread Kumar Gala
Greg, Can you look at pulling these fixes for the next 2.6.22.x stable release. - k On Jul 17, 2007, at 12:07 AM, Jeff Garzik wrote: Andy Fleming wrote: A few bugs in the Vitesse PHY driver were found on the 8641D HPCN board. Originally, they were masked by a bug in the PHY Lib which

Re: [PATCH 2.6.22-rc7 0/4] phy/gianfar: Fixes for gianfar and vitesse RGMII-ID support

2007-07-16 Thread Greg KH
On Tue, Jul 17, 2007 at 12:16:27AM -0500, Kumar Gala wrote: Greg, Can you look at pulling these fixes for the next 2.6.22.x stable release. Can you send them as patches, to the [EMAIL PROTECTED] address, after they go into Linus's tree? thanks, greg k-h

Re: [PATCH 0/3] 82xx: Add the support for Wind River SBC PowerQUICCII

2007-07-16 Thread Mark Zhan
Hi Vitaly, When you will send out your 8xx/82xx series patches? Thanks Mark Zhan On Tue, 2007-07-17 at 04:44 +0400, Vitaly Bordug wrote: On Mon, 16 Jul 2007 17:01:28 +0800 Mark Zhan wrote: These 3 patches add the powerpc support of Wind River SBC PowerQUICCII. I am sorry, but this