Re: [PATCH 2/2] fix showing xmon help

2007-07-18 Thread Milton Miller
On Jul 18, 2007, at 11:12 AM, Andreas Schwab wrote: > Milton Miller <[EMAIL PROTECTED]> writes: > >>> case '?': >>> - printf(help_string); >>> + xmon_puts(help_string); >>> break; >>> >> >> nonstdio.h #defines pri

Re: [PATCH 10/61] bootwrapper: flatdevtree fixes

2007-07-18 Thread Milton Miller
On Jul 18, 2007, at 1:56 PM, Scott Wood wrote: > Milton Miller wrote: >> In-Reply-To: <[EMAIL PROTECTED]> >> On Wed Jul 18 11:33:08 EST 2007, Scott Wood wrote: >>> 1. ft_create_node was returning the internal pointer rather than a >>> phandle. >>> 2. ft_find_device_rel was treating lookups relativ

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Andrew Morton wrote: > On Mon, 16 Jul 2007 18:15:40 +0200 > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > > > Add a Disk Storage Driver for the PS3: > > Your patchset significantly hits powerpc, scsi and block. So who g

Re: Powerpc - Include pagemap.h in asm/powerpc/tlb.h

2007-07-18 Thread Andrew Morton
On Fri, 13 Jul 2007 21:20:33 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > Powerpc - Include pagemap.h in asm/powerpc/tlb.h > > Fixes this powerpc build error in 2.6.22-rc6-mm1 for powerpc 64 : > > In file included from include2/asm/tlb.h:60, > from > /home/compudj/git/l

Re: [PATCH 02/11] dtc: move declaration of yyerror

2007-07-18 Thread David Gibson
On Sat, Jul 07, 2007 at 01:18:47AM -0500, Milton Miller wrote: > yyerror() is used by both dtc-parser.y and dtc-lexer.l, so move > the declaration to srcpos.h. > > Signed-off-by: Milton Miller <[EMAIL PROTECTED]> > --- > eliminates implicit declaration warning. Eck. This wasn't necessary: that

Re: [PATCH 2/15] boot: record header bytes in gunzip_start

2007-07-18 Thread Milton Miller
On Jul 18, 2007, at 9:11 PM, David Gibson wrote: > On Tue, Jul 10, 2007 at 05:08:05PM -0500, Milton Miller wrote: >> >> Record the number of header bytes skipped in the total bytes read >> field. >> >> This is needed for the initramfs parsing code to find the end of the >> zip file. >> >> Signe

Re: [PATCH 3/15] boot: simplfy gunzip_finish

2007-07-18 Thread David Gibson
On Wed, Jul 18, 2007 at 11:01:37PM -0500, Milton Miller wrote: > > On Jul 18, 2007, at 9:39 PM, David Gibson wrote: > > > On Tue, Jul 10, 2007 at 05:08:32PM -0500, Milton Miller wrote: > >> > >> Call gunzip_partial to calculate the remaining length and copy the > >> data to the user buffer. Thi

Re: [PATCH 3/15] boot: simplfy gunzip_finish

2007-07-18 Thread Milton Miller
On Jul 18, 2007, at 9:39 PM, David Gibson wrote: > On Tue, Jul 10, 2007 at 05:08:32PM -0500, Milton Miller wrote: >> >> Call gunzip_partial to calculate the remaining length and copy the >> data to the user buffer. This makes it shorter and reduces >> duplication. >> >> Signed-off-by: Milton Mi

Re: [PATCH] fix future firmware feature fixups function failure

2007-07-18 Thread Michael Neuling
> On Wednesday 18 July 2007, Michael Neuling wrote: > > Move firmware feature initialisation from pSeries_init_early to the > > earlier pSeries_probe_hypertas so they are initialised before firmware > > feature fixups are applied. > >=20 > > Currently firmware feature sections are only used for iSe

Re: [PATCH 3/15] boot: simplfy gunzip_finish

2007-07-18 Thread David Gibson
On Tue, Jul 10, 2007 at 05:08:32PM -0500, Milton Miller wrote: > > Call gunzip_partial to calculate the remaining length and copy the > data to the user buffer. This makes it shorter and reduces > duplication. > > Signed-off-by: Milton Miller <[EMAIL PROTECTED]> Hrm... I guess this is sufficie

Re: [PATCH 2/15] boot: record header bytes in gunzip_start

2007-07-18 Thread David Gibson
On Tue, Jul 10, 2007 at 05:08:05PM -0500, Milton Miller wrote: > > Record the number of header bytes skipped in the total bytes read field. > > This is needed for the initramfs parsing code to find the end of the zip file. > > Signed-off-by: Milton Miller <[EMAIL PROTECTED]> Ok... I assume you'

Re: [PATCH 1/15] boot: find initrd location from device-tree

2007-07-18 Thread David Gibson
On Tue, Jul 10, 2007 at 05:07:38PM -0500, Milton Miller wrote: > Some platforms have a boot agent that can create or modify properties in > the device-tree and load images into memory. Provide a helper to set > loader_info used by prep_initrd(). > > Signed-off-by: Milton Miller <[EMAIL PROTECTED]

Re: [PATCH 17/61] bootwrapper: Add 8xx support.

2007-07-18 Thread David Gibson
On Wed, Jul 18, 2007 at 11:13:05AM -0500, Scott Wood wrote: > David Gibson wrote: > > On Tue, Jul 17, 2007 at 08:33:18PM -0500, Scott Wood wrote: > > [snip] > > > >>diff --git a/arch/powerpc/boot/cuboot-8xx.c b/arch/powerpc/boot/cuboot-8xx.c > >>new file mode 100644 > >>index 000..35476a0 > >>

Re: [PATCH 05/61] bootwrapper: Change cuImage .gitignore entry to cuImage.*

2007-07-18 Thread David Gibson
On Wed, Jul 18, 2007 at 11:09:11AM -0500, Scott Wood wrote: > David Gibson wrote: > > On Tue, Jul 17, 2007 at 08:33:01PM -0500, Scott Wood wrote: > > > >>Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > >>--- > >> arch/powerpc/boot/.gitignore |4 +--- > >> 1 files changed, 1 insertions(+), 3 del

Re: [PATCH] Treat ISI faults as read faults on classic 32-bit PowerPC

2007-07-18 Thread Paul Mackerras
Segher Boessenkool writes: > Some old software on ppc32 executes from pages it hasn't marked > executable. Since "classic" hardware doesn't distinguish between > execute and read accesses, the do_page_fault() code shouldn't > either. This makes glibc-2.2 work again on such hardware. > > Signed-

Re: [PATCH] make powerpc pci compile again

2007-07-18 Thread Arnd Bergmann
On Thursday 19 July 2007, Michael Ellerman wrote: > Your patch is correct, but I think Tony has already sent it. > yes, it's already upstream as of Wed Jul 18 11:03:55 2007 +1000 Arnd <>< ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org ht

Re: [PATCH 27/61] cpm2: Fix whitespace in cpm2_clk_setup().

2007-07-18 Thread Arnd Bergmann
On Wednesday 18 July 2007, Scott Wood wrote: > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- >  arch/powerpc/sysdev/cpm2_common.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/sysdev/cpm2_common.c > b/arch/powerpc/sysdev/cpm2_common.c > index 4e

Re: [PATCH 37/61] cpm2: Rework 8272ads initialization, and eliminate init_fcc_ioports().

2007-07-18 Thread Arnd Bergmann
On Thursday 19 July 2007, Arnd Bergmann wrote: > I guess you considered moving such tables into the device tree at some point, > which doesn't seem that difficult at all to an ignorant reviewer like me. > > What's the reasoning for putting it into the platform code after all? > Ok, I think I fou

Re: [PATCH] make powerpc pci compile again

2007-07-18 Thread Michael Ellerman
On Wed, 2007-07-18 at 19:26 +0200, Johannes Berg wrote: > Looks like we got a new declaration in the generic header... This fixes > compile but I don't know whether it's correct. We got a new declaration, along with updated C code in pci_64.c and pci_32.c, but when that was merged with the creatio

Re: [PATCH 37/61] cpm2: Rework 8272ads initialization, and eliminate init_fcc_ioports().

2007-07-18 Thread Arnd Bergmann
On Wednesday 18 July 2007, Scott Wood wrote: > +static struct cpm_pin mpc8272ads_pins[] = { > +   /* SCC1 */ > +   {3, 30, CPM_PIN_OUTPUT | CPM_PIN_SECONDARY}, > +   {3, 31, CPM_PIN_INPUT | CPM_PIN_PRIMARY}, > + > +   /* SCC4 */ > +   {3, 21, CPM_PIN_OUTPUT | CPM_PIN_PRIMARY}, >

Re: [PATCH 51/61] cpm_uart: Be an of_platform device when using arch/powerpc.

2007-07-18 Thread Arnd Bergmann
On Wednesday 18 July 2007, Scott Wood wrote: > + > +static struct of_device_id cpm_uart_match[] = { > +   { > +   .compatible = "fsl,cpm-uart", > +   }, > +   {} >  }; > + I guess it's fine as it is, but it might be nicer if you change this to have separate entries for scc

Re: [PATCH 56/61] 82xx: Add pq2fads board support.

2007-07-18 Thread Arnd Bergmann
On Wednesday 18 July 2007, Scott Wood wrote: > +static void __init pq2fads_setup_arch(void) > +{ > + struct device_node *np; > + struct resource r; > + u32 *bcsr; bcsr should be __iomem, right? Did you run your code through sparse? Arnd <><

Re: [patch 3/3] ps3: FLASH ROM Storage Driver

2007-07-18 Thread Andrew Morton
On Mon, 16 Jul 2007 18:15:42 +0200 Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > Add a FLASH ROM Storage Driver for the PS3: > - Implemented as a misc character device driver > - Uses a fixed 256 KiB buffer allocated from boot memory as the h

[PATCH] tg3: add PCI error recovery support

2007-07-18 Thread Linas Vepstas
Add support for PCI Error Recovery for the tg3 ethernet device driver. The general principles of operation are described in Documentation/pci-error-recovery.txt Other drivers having similar structure include e100, e1000, ixgb, s2io, ipr, sym53c8xx_2, and lpfc Signed-off-by: Linas Vepstas <[EMAIL

Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-18 Thread Andrew Morton
On Mon, 16 Jul 2007 18:15:41 +0200 Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > Add a BD/DVD/CD-ROM Storage Driver for the PS3: > - Implemented as a SCSI device driver > - Uses software scatter-gather with a 64 KiB bounce buffer as the hyper

[PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-18 Thread Vitaly Bordug
device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function, it is broken and mu

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Andrew Morton
On Mon, 16 Jul 2007 18:15:40 +0200 Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > Add a Disk Storage Driver for the PS3: Your patchset significantly hits powerpc, scsi and block. So who gets to merge this? Jens? James? Paul? Me, I guess ;)

Re: [PATCH] fix future firmware feature fixups function failure

2007-07-18 Thread Arnd Bergmann
On Wednesday 18 July 2007, Michael Neuling wrote: > Move firmware feature initialisation from pSeries_init_early to the > earlier pSeries_probe_hypertas so they are initialised before firmware > feature fixups are applied. > > Currently firmware feature sections are only used for iSeries which > i

Re: [PATCH] eHEA: Fix bonding support

2007-07-18 Thread Jeff Garzik
Thomas Klein wrote: > The driver didn't allow an interface's MAC address to be modified if the > respective interface wasn't setup - a failing Hcall was the result. Thus > bonding wasn't usable. The fix moves the failing Hcall which was registering > a MAC address for the reception of BC packets in

Re: [PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-07-18 Thread Jeff Garzik
Vitaly Bordug wrote: > device_bind_driver() error code returning has been fixed. > release() function has been written, so that to free resources > in correct way; the release path is now clean. > > Before the rework, it used to cause > Device '[EMAIL PROTECTED]:1' does not have a release()

Re: [PATCH 4/4] ibmveth: Add ethtool driver stats hooks

2007-07-18 Thread Jeff Garzik
Brian King wrote: > Add ethtool hooks to ibmveth to retrieve driver statistics. > > ACK patches 3-4 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-18 Thread Jeff Garzik
Brian King wrote: > This patch adds the appropriate ethtool hooks to allow for enabling/disabling > of hypervisor assisted checksum offload for TCP. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > linux-2.6-bjking1/drivers/net/ibmveth.c | 120 > +++- > l

Re: [PATCH 1/4] ibmveth: Enable TCP checksum offload

2007-07-18 Thread Jeff Garzik
Brian King wrote: > This patchset enables TCP checksum offload support for IPV4 > on ibmveth. This completely eliminates the generation and checking of > the checksum for packets that are completely virtual and never > touch a physical network. A simple TCP_STREAM netperf run on > a virtual network

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic (IPv6)

2007-07-18 Thread David Miller
From: Jan-Bernd Themann <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 15:00:59 +0200 > Hi, > > I suggest we keep the interface open for IPv6 support by adding > an additional parameter but first just get IPv4 support only > into the kernel. IPv6 support can then incrementially be added. > Would th

[PATCH] fix future firmware feature fixups function failure

2007-07-18 Thread Michael Neuling
Move firmware feature initialisation from pSeries_init_early to the earlier pSeries_probe_hypertas so they are initialised before firmware feature fixups are applied. Currently firmware feature sections are only used for iSeries which initialises the these features much earlier. This is a bug in

Re: [PATCH] Add StorCenter DTS first draft.

2007-07-18 Thread Benjamin Herrenschmidt
On Wed, 2007-07-18 at 18:13 +0200, Segher Boessenkool wrote: > >> + PowerPC,603e { /* Really 8241 */ > >> + device_type = "cpu"; > >> + reg = <0>; > >> + clock-frequency = ; /* Hz */ > >> + timebase-

Re: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 July 2007, Kumar Gala wrote: > > On Jul 18, 2007, at 5:47 AM, Bartlomiej Zolnierkiewicz wrote: > > > > > Hi, > > > > On Wednesday 18 July 2007, Kumar Gala wrote: > >> M: [EMAIL PROTECTED] > >> L: [EMAIL PROTECTED] > >> > >> We get the following compile error if CONFIG_BL

Re: [patch 14/14] Bamboo zImage wrapper

2007-07-18 Thread Josh Boyer
On Wed, 2007-07-18 at 12:51 -0500, Josh Boyer wrote: > > Is there some reason they should not all be merged into this one > > platform file? > > "they" meaning what? > > > I can understand wanting the dcr fixups as a library, but lets wait to > > do the file splits until there are actually user

Re: [PATCH 53/61] 82xx: Set NOT_COHERENT_CACHE on 8272 with PCI.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: > On Jul 17, 2007, at 10:28 PM, David Gibson wrote: >> Hrm... I for one would be a lot more comfortable with this patch if >> you had a theoretical explanation for why it's necessary, in addition >> to the "seems to fix things". Sure, so would I; I just wanted to point out the is

Re: [PATCH 06/61] 8xx: Don't call non-existent Soft_emulate_8xx from SoftwareEmulation.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: > I don't see any reason to break people that might not have updated > their toolchains. Full math emulation is still an option... > There is no reason for us to drop a feature like > this w/o some additional warning. ...as is arch/ppc, whose remaining life expectancy can

Re: [PATCH 46/61] mpc885ads: Rework initialization.

2007-07-18 Thread Scott Wood
Vitaly Bordug wrote: >>The conflict is in register space, not pins -- why would the smc1 >>pins matter? > > ok, I may have confused this with something else. Possibly the conflict between FEC2 and SMC2 (which is still done via kconfig option)? -Scott

Re: PS3 Storage Driver O_DIRECT issue

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Geert Uytterhoeven wrote: > On Fri, 13 Jul 2007, Olaf Hering wrote: > > This driver (or the generic PS3 code) has appearently problems with > > O_DIRECT. > > glibc aborts parted because the malloc metadata get corrupted. While it > > is reproducible, the place where it crashes

Re: [PATCH 52/61] cpm_uart: Issue STOP_TX command before initializing console.

2007-07-18 Thread Vitaly Bordug
On Wed, 18 Jul 2007 11:35:58 -0500 Scott Wood wrote: > Vitaly Bordug wrote: > >>+ cpm_line_cr_cmd(pinfo, CPM_CR_STOP_TX); > >>+ > > > > > > I am recalling exactly the contrary patch that removes stuff to get > > the non-console UARTs work. Let's better revalidate this once other > > pieces wil

Re: [PATCH 46/61] mpc885ads: Rework initialization.

2007-07-18 Thread Vitaly Bordug
On Wed, 18 Jul 2007 11:40:07 -0500 Scott Wood wrote: > Vitaly Bordug wrote: > >>-#ifdef CONFIG_SERIAL_CPM_SMC1 > >>- clrbits32(bcsr_io, BCSR1_RS232EN_1); > >>- clrbits32(&cp->cp_simode, 0xe000 >> 17);/* brg1 > >>*/ > >>- tmpval8 = in_8(&(cp->cp_smc[0].smc_smcm)) | (SMCM_RX | > >>SMCM

Re: [PATCH 06/61] 8xx: Don't call non-existent Soft_emulate_8xx from SoftwareEmulation.

2007-07-18 Thread Kumar Gala
On Jul 18, 2007, at 11:22 AM, Scott Wood wrote: > Kumar Gala wrote: >> On Jul 17, 2007, at 8:33 PM, Scott Wood wrote: >>> On arch/ppc, Soft_emulate_8xx was used when full math emulation was >>> turned off to emulate a minimal subset of floating point load/store >>> instructions, to avoid needing

Re: [PATCH] Add StorCenter DTS first draft.

2007-07-18 Thread Kumar Gala
On Jul 18, 2007, at 11:19 AM, Segher Boessenkool wrote: + compatible = "storcenter"; >>> >>> Needs a manufacturer name in there. >> >> Right. Will use: >> compatible = "iomega,storcenter" > > Okido. > + PowerPC,603e { /* Really 8241 */ >>> >>> So say "Po

[PATCH] make powerpc pci compile again

2007-07-18 Thread Johannes Berg
Looks like we got a new declaration in the generic header... This fixes compile but I don't know whether it's correct. --- arch/powerpc/kernel/pci-common.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) --- linux-2.6-git.orig/arch/powerpc/kernel/pci-common.c 2007-07-17 19:11:57.5

Re: [PATCH 10/61] bootwrapper: flatdevtree fixes

2007-07-18 Thread Scott Wood
Milton Miller wrote: > In-Reply-To: <[EMAIL PROTECTED]> > > On Wed Jul 18 11:33:08 EST 2007, Scott Wood wrote: > >> 1. ft_create_node was returning the internal pointer rather than a >> phandle. >> 2. ft_find_device_rel was treating lookups relative to root as an error. > > > No, it is treatin

Re: [PATCH 1/2] Fix error checking in Vitesse IRQ config

2007-07-18 Thread Andy Fleming
On Jul 18, 2007, at 02:00, pradeep singh wrote: > On 7/18/07, Andy Fleming <[EMAIL PROTECTED]> wrote: >> - if (err) >> + if (err < 0) >> return err; > > but would that mean, if phy_read returns > 0 it is a success? Yes. phy_read() returns a 3

Re: [PATCH 46/61] mpc885ads: Rework initialization.

2007-07-18 Thread Scott Wood
Vitaly Bordug wrote: > On Wed, 18 Jul 2007 11:40:07 -0500 > Scott Wood wrote: >>The CPM reset should take care of that. >> > > IIRC we had CPM reset prior, and it didn't help, making all those stuff added. You previously only did the CPM reset when CONFIG_UCODE_PATH was enabled. I saw the same

Re: [PATCH 28/61] Add cpm2_set_pin().

2007-07-18 Thread Scott Wood
Kumar Gala wrote: > On Jul 17, 2007, at 8:35 PM, Scott Wood wrote: >> + >> +struct cpm2_ioports { >> +u32dir, par, sor, odr, dat; > > __be32? OK. >> +u32res[3]; >> +}; >> + >> +void cpm2_set_pin(int port, int pin, int flags) > > > Can we make the function take a pointer to the

Re: [patch 14/14] Bamboo zImage wrapper

2007-07-18 Thread Milton Miller
Sorry for the broken reply but the list is broken. On Wed Jul 18 04:16:01 EST 2007, Josh Boyer wrote: > Add a bootwrapper for Bamboo bamboo is what, an evaluation board? for which processor? > Signed-off-by: Josh Boyer > > --- > arch/powerpc/boot/44x.h |1 > arch/powerpc/boot/M

Re: [patch 14/14] Bamboo zImage wrapper

2007-07-18 Thread Josh Boyer
On Wed, 2007-07-18 at 12:21 -0500, Milton Miller wrote: > Sorry for the broken reply but the list is broken. > > On Wed Jul 18 04:16:01 EST 2007, Josh Boyer wrote: > > Add a bootwrapper for Bamboo > > bamboo is what, an evaluation board? for which processor? Yes, 440EP. > > --- linux-2.6.orig/a

Re: [PATCH v2] Allow exec on 32-bit from readable, non-exec pages, with a warning.

2007-07-18 Thread Linas Vepstas
On Tue, Jul 17, 2007 at 05:44:14PM -0500, Jon Loeliger wrote: > > > A: They haven't been posted yet. > > Q: How do we know Segher has new patches? > > rotfl -- rolling on the floor loeliger ! ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH 09/61] bootwrapper: Add dt_is_compatible().

2007-07-18 Thread Scott Wood
Milton Miller wrote: >> + for (pos = 0; pos + compat_len < len; pos++) { >> + if (!strcmp(buf + pos, compat)) >> + return 1; >> + >> + while (buf[pos] && pos + compat_len < len) >> + pos++; > > > This is buggy: if you a

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-18 Thread Scott Wood
Segher Boessenkool wrote: > Yes indeed. The problem with your suggested "obvious way" I said it was obvious, not obviously correct. :-) > is that you wouldn't get a unit address included if your > interrupt-map points (for some entry) at your device tree > parent, either. Not all that hypotheti

Re: [PATCH 38/61] cpm2: Update device trees.

2007-07-18 Thread Scott Wood
Vitaly Bordug wrote: > On Tue, 17 Jul 2007 20:35:50 -0500 > Scott Wood wrote: > > >>+ "fsl,cpm-uart"; >> reg = <11a00 20 8000 100>; >>- current-speed = <1c200>; > > Hmm, how is it supposed to work w

Re: [PATCH 46/61] mpc885ads: Rework initialization.

2007-07-18 Thread Scott Wood
Vitaly Bordug wrote: >>-#ifdef CONFIG_SERIAL_CPM_SMC1 >>- clrbits32(bcsr_io, BCSR1_RS232EN_1); >>- clrbits32(&cp->cp_simode, 0xe000 >> 17);/* brg1 >>*/ >>- tmpval8 = in_8(&(cp->cp_smc[0].smc_smcm)) | (SMCM_RX | >>SMCM_TX); >>- out_8(&(cp->cp_smc[0].smc_smcm), tmpval8); >>-

Re: [PATCH 52/61] cpm_uart: Issue STOP_TX command before initializing console.

2007-07-18 Thread Scott Wood
Vitaly Bordug wrote: >>+ cpm_line_cr_cmd(pinfo, CPM_CR_STOP_TX); >>+ > > > I am recalling exactly the contrary patch that removes stuff to get the > non-console UARTs work. > Let's better revalidate this once other pieces will be in before applying. I tried non-console UARTs and had no prob

Re: [PATCH 32/61] mpc82xx: Move PQ2 restart and halt functions out of mpc8272-specific code.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: > Kill pq2_halt, if this is all it does just dont set ppc_md.halt() and > get the generic behavior which is the same. OK. >> diff --git a/include/asm-ppc/immap_cpm2.h b/include/asm-ppc/ immap_cpm2.h >> index 3c23d9c..8795bcc 100644 >> --- a/include/asm-ppc/immap_cpm2.h >> +++

Re: [PATCH 30/61] fsl_soc: Update the way get_brgfreq() finds things in the device tree.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: >> diff --git a/arch/powerpc/boot/dts/mpc8272ads.dts b/arch/powerpc/ >> boot/dts/mpc8272ads.dts >> index 4d09dca..16a77f4 100644 >> --- a/arch/powerpc/boot/dts/mpc8272ads.dts >> +++ b/arch/powerpc/boot/dts/mpc8272ads.dts >> @@ -119,12 +119,11 @@ >> #address-cells = <

[PATCH 19/61] 8xx: Fix CONFIG_PIN_TLB.

2007-07-18 Thread Scott Wood
1. Only map 512K of the IMMR, rather than 8M, to avoid conflicting with the default ioremap region. 2. The wrong register was being loaded into SPRN_MD_RPN. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- Apparently I missed sending this one yesterday... arch/powerpc/kernel/head_8xx.S |8 +

Re: [PATCH 06/61] 8xx: Don't call non-existent Soft_emulate_8xx from SoftwareEmulation.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: > > On Jul 17, 2007, at 8:33 PM, Scott Wood wrote: > >> On arch/ppc, Soft_emulate_8xx was used when full math emulation was >> turned off to emulate a minimal subset of floating point load/store >> instructions, to avoid needing a soft-float toolchain. This function >> is calle

Re: [PATCH 10/61] bootwrapper: flatdevtree fixes

2007-07-18 Thread Milton Miller
On Wed Jul 18 11:33:08 EST 2007, Scott Wood wrote: > 1. ft_create_node was returning the internal pointer rather than a > phandle. > 2. ft_find_device_rel was treating lookups relative to root as an > error. No, it is treating lookups relative to NULL as an error. Your patch changes it to treat

Re: [PATCH 09/61] bootwrapper: Add dt_is_compatible().

2007-07-18 Thread Milton Miller
On Wed Jul 18 11:33:06 EST 2007, Scott Wood wrote: > +int dt_is_compatible(void *node, const char *compat) > +{ > + char *buf = (char *)prop_buf; > + int compat_len = strlen(compat); > + int len, pos; > + > + len = getprop(node, "compatible", buf, MAX_PROP_LEN); > + if

Re: [PATCH] Add StorCenter DTS first draft.

2007-07-18 Thread Segher Boessenkool
>>> + compatible = "storcenter"; >> >> Needs a manufacturer name in there. > > Right. Will use: > compatible = "iomega,storcenter" Okido. >>> + PowerPC,603e { /* Really 8241 */ >> >> So say "PowerPC,[EMAIL PROTECTED]", or "PowerPC,[EMAIL PROTECTED]" (or >> wha

Re: [PATCH 01/61] Use strcasecmp() rather than strncasecmp() when determining device node compatibility.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: > Can these patches be broken into logical clumps? Probably... I just wanted to get them out there quickly as there've been numerous people lately inquiring about 82xx support and posting patches. > Would be easier to review and obviously the fs_enet patches need to go > vi

Re: [PATCH] Add StorCenter DTS first draft.

2007-07-18 Thread Segher Boessenkool
>> +PowerPC,603e { /* Really 8241 */ >> +device_type = "cpu"; >> +reg = <0>; >> +clock-frequency = ; /* Hz */ >> +timebase-frequency = ; /* Hz */ >> +bus-freque

Re: [PATCH 17/61] bootwrapper: Add 8xx support.

2007-07-18 Thread Scott Wood
David Gibson wrote: > On Tue, Jul 17, 2007 at 08:33:18PM -0500, Scott Wood wrote: > [snip] > >>diff --git a/arch/powerpc/boot/cuboot-8xx.c b/arch/powerpc/boot/cuboot-8xx.c >>new file mode 100644 >>index 000..35476a0 >>--- /dev/null >>+++ b/arch/powerpc/boot/cuboot-8xx.c >>@@ -0,0 +1,47 @@ >>+/

Re: [PATCH 2/2] fix showing xmon help

2007-07-18 Thread Andreas Schwab
Milton Miller <[EMAIL PROTECTED]> writes: >> case '?': >> - printf(help_string); >> + xmon_puts(help_string); >> break; >> > > nonstdio.h #defines printf to xmon_printf. Please add a similar line > for puts, and

Re: PS3 Storage Driver O_DIRECT issue

2007-07-18 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, Olaf Hering wrote: > This driver (or the generic PS3 code) has appearently problems with > O_DIRECT. > glibc aborts parted because the malloc metadata get corrupted. While it > is reproducible, the place where it crashes changes with every version > of the debug attempt. > I d

Re: [PATCH 22/61] Rename mpc82xx_ads to mpc8272ads.

2007-07-18 Thread Scott Wood
Mark Zhan wrote: > Scott, > > It seems the old name "mpc82xx ads" is still used in your code. > It will be nice that your file name match your code name, you know, less > confusion. See patch 24. AIUI, it's generally preferred when moving large chunks of code to first have a patch that just mov

Re: [PATCH 05/61] bootwrapper: Change cuImage .gitignore entry to cuImage.*

2007-07-18 Thread Scott Wood
David Gibson wrote: > On Tue, Jul 17, 2007 at 08:33:01PM -0500, Scott Wood wrote: > >>Signed-off-by: Scott Wood <[EMAIL PROTECTED]> >>--- >> arch/powerpc/boot/.gitignore |4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) >> >>diff --git a/arch/powerpc/boot/.gitignore b/arch/powerpc/bo

Re: [PATCH 3/3] First cut at PReP support for arch/powerpc

2007-07-18 Thread Segher Boessenkool
>>> Too big for the list, the patch is at: >>> http://ozlabs.org/~dgibson/home/prep-support >> >> Too lazy to split the patch into bite-size chunks, you mean ;-) > > Well... much as I like small patches, I don't really like having a big > string of patches, each of which does basically nothing

Re: [PATCH 2/2] fix showing xmon help

2007-07-18 Thread Milton Miller
On Wed Jul 18 19:26:40 EST 2007, Ishizaki Kou wrote: > In some configuration, xmon help string is larger than xmon_printf > buffer. We need not to use printf. This patch adds xmon_puts and > change to use it to show help string. [Since I'm requesting changes I'll suggest a new change log.] In so

Re: [PATCH 09/61] bootwrapper: Add dt_is_compatible().

2007-07-18 Thread Milton Miller
In-Reply-To: <[EMAIL PROTECTED]> On Wed Jul 18 11:33:06 EST 2007, Scott Wood wrote: > +int dt_is_compatible(void *node, const char *compat) > +{ > + char *buf = (char *)prop_buf; > + int compat_len = strlen(compat); > + int len, pos; > + > + len = getprop(node, "compatible"

Re: [PATCH 10/61] bootwrapper: flatdevtree fixes

2007-07-18 Thread Milton Miller
In-Reply-To: <[EMAIL PROTECTED]> On Wed Jul 18 11:33:08 EST 2007, Scott Wood wrote: > 1. ft_create_node was returning the internal pointer rather than a > phandle. > 2. ft_find_device_rel was treating lookups relative to root as an > error. No, it is treating lookups relative to NULL as an erro

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Geert Uytterhoeven
On Wed, 18 Jul 2007, Jan Engelhardt wrote: > On Jul 16 2007 18:15, Geert Uytterhoeven wrote: > >Add a Disk Storage Driver for the PS3: > > - Implemented as a block device driver with a dynamic major > > - Disk names (and partitions) are of the format ps3d%c(%u) > > - Uses software scatter-gather

[PATCH] eHEA: Fix bonding support

2007-07-18 Thread Thomas Klein
The driver didn't allow an interface's MAC address to be modified if the respective interface wasn't setup - a failing Hcall was the result. Thus bonding wasn't usable. The fix moves the failing Hcall which was registering a MAC address for the reception of BC packets in firmware from the port up a

[PATCH] Treat ISI faults as read faults on classic 32-bit PowerPC

2007-07-18 Thread Segher Boessenkool
Some old software on ppc32 executes from pages it hasn't marked executable. Since "classic" hardware doesn't distinguish between execute and read accesses, the do_page_fault() code shouldn't either. This makes glibc-2.2 work again on such hardware. Signed-off-by: Segher Boessenkool <[EMAIL PROTE

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Jan Engelhardt
On Jul 16 2007 18:15, Geert Uytterhoeven wrote: > >Add a Disk Storage Driver for the PS3: > - Implemented as a block device driver with a dynamic major > - Disk names (and partitions) are of the format ps3d%c(%u) > - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor >

Re: [PATCH 28/61] Add cpm2_set_pin().

2007-07-18 Thread Kumar Gala
On Jul 17, 2007, at 8:35 PM, Scott Wood wrote: > This provides a generic way for board code to set up CPM pins, rather > than directly poking magic values into registers. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > arch/powerpc/sysdev/cpm2_common.c | 28 ++

Re: [PATCH] PPC: Prevent direct inclusion of .

2007-07-18 Thread Robert P. J. Day
On Wed, 18 Jul 2007, Kumar Gala wrote: > > On Jul 18, 2007, at 8:36 AM, Robert P. J. Day wrote: > > > > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> > > Can you provide some commit description as to why we are doing this? > > - k > > > > > --- > > > > not compile-tested, so if there's a

Re: [PATCH] PPC: Prevent direct inclusion of .

2007-07-18 Thread Kumar Gala
On Jul 18, 2007, at 8:36 AM, Robert P. J. Day wrote: > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Can you provide some commit description as to why we are doing this? - k > > --- > > not compile-tested, so if there's a flaw here somewhere, feel free > to tweak it. > > arch/ppc/sy

Re: [PATCH v2] Allow exec on 32-bit from readable, non-exec pages, with a warning.

2007-07-18 Thread Kumar Gala
On Jul 18, 2007, at 7:07 AM, Segher Boessenkool wrote: > A: They haven't been posted yet. > > Q: How do we know Segher has new patches? He sent it to me to test, and I told him it worked... >>> >>> And I sent it to the list hours later, over a week ago. >> >> Can someone s

Re: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-18 Thread Kumar Gala
On Jul 18, 2007, at 5:47 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday 18 July 2007, Kumar Gala wrote: >> M: [EMAIL PROTECTED] >> L: [EMAIL PROTECTED] >> >> We get the following compile error if CONFIG_BLOCK isn't enabled: >> >> CC arch/powerpc/kernel/setup_32.o >

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-18 Thread Segher Boessenkool
>> See above. Besides, as I said, default values are crap. And no, >> it's not >> obvious which nodes define a physical address space or not, at >> least not >> for a generic parser. > > The obvious way (which indeed isn't what the suggested algorithm > does -- > but the suggested algorithm d

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-18 Thread Segher Boessenkool
>> Yes, I shouldn't say "defaulted" -- a unit interrupt specifier >> simply has no unit address part, in an interrupt domain that >> doesn't correspond to a "normal" bus. But saying it like this >> is a little bit inexact, and it uses more words. >> >>> which is why I tend to prefer having it >>>

[PATCH] PPC: Prevent direct inclusion of .

2007-07-18 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- not compile-tested, so if there's a flaw here somewhere, feel free to tweak it. arch/ppc/syslib/ocp.c |2 +- include/asm-powerpc/rwsem.h |4 include/asm-ppc/ocp.h |2 +- 3 files changed, 6 insertions(+), 2 d

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic (IPv6)

2007-07-18 Thread Jan-Bernd Themann
Hi, I suggest we keep the interface open for IPv6 support by adding an additional parameter but first just get IPv4 support only into the kernel. IPv6 support can then incrementially be added. Would that be ok? On Sunday 15 July 2007 11:40, David Miller wrote: > From: Christoph Hellwig <[EMAI

Re: [PATCH 38/61] cpm2: Update device trees.

2007-07-18 Thread Vitaly Bordug
On Tue, 17 Jul 2007 20:35:50 -0500 Scott Wood wrote: > + "fsl,cpm-uart"; > reg = <11a00 20 8000 100>; > - current-speed = <1c200>; Hmm, how is it supposed to work without speed? I was testing my u-bo

Re: [PATCH v2] Allow exec on 32-bit from readable, non-exec pages, with a warning.

2007-07-18 Thread Segher Boessenkool
A: They haven't been posted yet. Q: How do we know Segher has new patches? >>> >>> He sent it to me to test, and I told him it worked... >> >> And I sent it to the list hours later, over a week ago. > > Can someone send a ozlabs linuxppc list link or patchworks to the > "new" pat

Re: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-18 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 18 July 2007, Kumar Gala wrote: > M: [EMAIL PROTECTED] > L: [EMAIL PROTECTED] > > We get the following compile error if CONFIG_BLOCK isn't enabled: > > CC arch/powerpc/kernel/setup_32.o > In file included from arch/powerpc/kernel/setup_32.c:14: > include/linux/

Re: [PATCH 51/61] cpm_uart: Be an of_platform device when using arch/powerpc.

2007-07-18 Thread Vitaly Bordug
On Tue, 17 Jul 2007 20:36:06 -0500 Scott Wood wrote: > The existing OF glue code was crufty and broken. Rather than fix it, > it has been removed, and the serial driver now talks to the device > tree directly. > > The non-CONFIG_PPC_MERGE code can do away once CPM platforms are > dropped from ar

Re: [PATCH 46/61] mpc885ads: Rework initialization.

2007-07-18 Thread Vitaly Bordug
Overall looks good, though mentioned mutually exclusive SoC devices adding some pain and extra code having relevant parts removed but not covered (see below). I think it makes sense to work ontop of this code to address known quirks/issues though, hence will cover this. yet, there are little cha

Re: [PATCH 52/61] cpm_uart: Issue STOP_TX command before initializing console.

2007-07-18 Thread Vitaly Bordug
On Tue, 17 Jul 2007 20:36:08 -0500 Scott Wood wrote: > This prevents some bootloader/bootwrapper characters from being lost. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > drivers/serial/cpm_uart/cpm_uart_core.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff

[PATCH 1/2] Make xmon_write accept a const buffer

2007-07-18 Thread Ishizaki Kou
Because xmon_write doesn't change the buffer, we should add 'const' qualifier to the argument which points it. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> --- Index: linux-powerpc-git/arch/powerpc/xmon/start.c === --- linux-power

[PATCH 2/2] fix showing xmon help

2007-07-18 Thread Ishizaki Kou
In some configuration, xmon help string is larger than xmon_printf buffer. We need not to use printf. This patch adds xmon_puts and change to use it to show help string. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> --- This patch depends on [PATCH 1/2]. Index: linux-powerpc-git/arch/powerpc

[PATCH] Add 8548CDS with Arcadia 3.0 support

2007-07-18 Thread Zang Roy-r61911
From: Roy Zang <[EMAIL PROTECTED]> Add 8548CDS with Arcadia 3.0 support. Arcadia 3.0 has different pci irq routing comparing with Arcadia 3.1. Signed-off-by: Roy Zang <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8548cds_legacy.dts | 327 +++ 1 files changed, 327 inse

Re: [PATCH 1/2] Fix error checking in Vitesse IRQ config

2007-07-18 Thread pradeep singh
On 7/18/07, Andy Fleming <[EMAIL PROTECTED]> wrote: > phy_read() returns a negative number if there's an error, but the > error-checking code in the Vitesse driver's config_intr function > triggers if phy_read() returns non-zero. Correct that. > > Signed-off-by: Andy Fleming <[EMAIL PROTECTED]> >

  1   2   >