Re: [PATCH 2/2] powerpc: Move mpc83xx_add_bridge to fsl_pci.c [rev2]

2008-06-29 Thread Grant Likely
On Thu, Jun 26, 2008 at 11:07:57AM -0600, John Rigby wrote: This allows other platforms with the same pci block like MPC5121 to use it. Signed-off-by: John Rigby [EMAIL PROTECTED] Acked-by: Grant Likely [EMAIL PROTECTED] --- arch/powerpc/platforms/83xx/Kconfig |2 +-

Re: [Resend][PATCH 1/8][Version 2] MPC5121 Update MPC5121ADS device tree

2008-06-29 Thread Grant Likely
On Wed, Jun 18, 2008 at 02:24:46PM -0600, John Rigby wrote: Updated device tree for MPC5121ADS Really should be more detailed in the commit message. Signed-off-by: John Rigby [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc5121ads.dts | 309 - 1 files

Re: [Resend][PATCH 1/8][Version 2] MPC5121 Update MPC5121ADS device tree

2008-06-29 Thread Grant Likely
On Thu, Jun 26, 2008 at 09:40:57PM -0600, John Rigby wrote: On Thu, Jun 26, 2008 at 7:42 PM, David Gibson [EMAIL PROTECTED] wrote: On Wed, Jun 18, 2008 at 02:24:46PM -0600, John Rigby wrote: [EMAIL PROTECTED] { compatible = fsl,mpc5121-immr; + device_type =

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-29 Thread Jean Delvare
Hi Jon, Grant, On Sat, 28 Jun 2008 22:49:40 -0600, Grant Likely wrote: On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote: On 6/25/08, Jean Delvare [EMAIL PROTECTED] wrote: i2c-adap = mpc_ops; - i2c-adap.nr = pdev-id; i2c_set_adapdata(i2c-adap, i2c);

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-29 Thread Grant Likely
On Sun, Jun 29, 2008 at 08:31:43AM +0200, Jean Delvare wrote: Hi Jon, Grant, On Sat, 28 Jun 2008 22:49:40 -0600, Grant Likely wrote: On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote: The driver was previously using i2c_add_numbered_adapter(), giving MPC platform the

Re: [Resend][PATCH 1/8][Version 2] MPC5121 Update MPC5121ADS device tree

2008-06-29 Thread Grant Likely
On Sun, Jun 29, 2008 at 12:15 AM, Grant Likely [EMAIL PROTECTED] wrote: On Thu, Jun 26, 2008 at 09:40:57PM -0600, John Rigby wrote: Because get_immrbase in fsl_soc.c does not work without it. I think I'd rather see get_immrbase() instead then. er, I think I'd rather see get_immrbase() *fixed*

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-29 Thread Jean Delvare
On Sun, 29 Jun 2008 00:58:12 -0600, Grant Likely wrote: On Sun, Jun 29, 2008 at 08:31:43AM +0200, Jean Delvare wrote: Hi Jon, Grant, On Sat, 28 Jun 2008 22:49:40 -0600, Grant Likely wrote: On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote: The driver was previously

Re: [PATCH 3/8][Version 2] MPC5121 Add generic board support

2008-06-29 Thread Grant Likely
On Tue, Jun 24, 2008 at 3:24 PM, John Rigby [EMAIL PROTECTED] wrote: Move shared code from mpc5121_ads.c to mpc512x_shared.c. Add new generic board setup mpc5121_generic.c Signed-off-by: John Rigby [EMAIL PROTECTED] --- +void __init mpc512x_init_IRQ(void) +{ + struct device_node *np;

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-29 Thread Sean MacLennan
On Sun, 29 Jun 2008 09:17:25 +0200 Jean Delvare [EMAIL PROTECTED] wrote: Ah, OK. If you use i2c_new_device() then it's alright. Correct. I have done the same thing for the i2c-ibm_iic.c driver. Jean, I think you will like this. It gets rid of the index and the numbered drivers. And the walking

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-29 Thread Jean Delvare
On Sun, 29 Jun 2008 12:24:39 -0400, Sean MacLennan wrote: On Sun, 29 Jun 2008 09:17:25 +0200 Jean Delvare [EMAIL PROTECTED] wrote: Ah, OK. If you use i2c_new_device() then it's alright. Correct. I have done the same thing for the i2c-ibm_iic.c driver. Jean, I think you will like this.

[PATCH] Convert i2c-mpc from a platform driver into a of_platform driver, V2

2008-06-29 Thread Jon Smirl
This version adds of_find_i2c_device_by_node() which is needed by ASOC drivers. To make it work I had to make the i2c bus struct visible. It also picks up a couple of other minor fixes that have been posted to the lists. Signed-off-by: Jon Smirl [EMAIL PROTECTED] ---

Re: [RFC] Non-numbered ibm iic driver

2008-06-29 Thread Jon Loeliger
Sean MacLennan wrote: P.S. Do I need a signed-off-by for an RFC? Signed-off-by: Sean MacLennan [EMAIL PROTECTED] --- Not usually. Some intentionally leave the S-o-b: off of and RFC specifically to ensure that it stays RFC-ish and doesn't slip into patchness. jdl

Re: [PATCH] Convert i2c-mpc from a platform driver into a of_platform driver, V2

2008-06-29 Thread Jochen Friedrich
Hi Jon, This version adds of_find_i2c_device_by_node() which is needed by ASOC drivers. Cool. I was about to do something similar (of_get_adapter_nr_by_node). IMHO, the patch should be splitted into the addition of of_find_i2c_device_by_node() and the actual patch of i2c-mpc. Thanks,

RE: [PATCH] powerpc/bootwrapper: Add documentation of boot wrappertargets

2008-06-29 Thread Stephen Neuendorffer
simpleImage should also create an .elf (for xmd or systemAce loading) If dtbImage and simpleImage could be merged, I'd be all for it... At some point of course, I need to figure merge the Device Tree in BRAM code that I've been using, which would be a simpleImage which wouldn't need a device

Re: [PATCH 12/60] microblaze_v4: Generic dts file for platforms

2008-06-29 Thread John Williams
On Sat, Jun 28, 2008 at 3:49 PM, Grant Likely [EMAIL PROTECTED] wrote: On Thu, Jun 26, 2008 at 5:29 AM, [EMAIL PROTECTED] wrote: From: Michal Simek [EMAIL PROTECTED] arch/microblaze/platform/generic/system.dts | 300 +++ Since this is a generated file, and

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-29 Thread David Brownell
On Sunday 29 June 2008, Jean Delvare wrote: After the i2c adapter registers itself, of_register_i2c_devices() is called which walks through the child nodes of the i2c adapter node in the device tree.  Each child node is an i2c device, and it immediately get registered with the adapter.  

RE: [PATCH] [POWERPC] Xilinx: add compatibility for 'simple-bus'.

2008-06-29 Thread Stephen Neuendorffer
Is there really much of a chance of that, given the differences with the bootwrappers? Does anyone care enough about legacy_serial for this to matter? My impression was that legacy serial was not preferred anyway... Steve -Original Message- From: [EMAIL PROTECTED] on behalf of Grant

Re: Please pull from 'powerpc-next' branch

2008-06-29 Thread Michael Ellerman
On Fri, 2008-06-27 at 08:00 -0500, Kumar Gala wrote: On Jun 27, 2008, at 6:27 AM, Paul Mackerras wrote: Kumar Gala writes: Paul, any update on when we might see some of the various patches pulled into powerpc-next? I've got some work I'd like to see in .27 but it needs Michael's code

Re: [PATCH 5/6] MPC5121 Add PCI support

2008-06-29 Thread John Rigby
Yes, Kumar made the same comment. The newer patch that moves the 83xx add bridge routine to fsl_soc obsoletes this patch. On Sat, Jun 28, 2008 at 11:38 PM, Grant Likely [EMAIL PROTECTED] wrote: On Fri, Jun 20, 2008 at 10:58:38AM -0600, John Rigby wrote: Copied from 83xx minus support for two

Re: [PATCH 12/60] microblaze_v4: Generic dts file for platforms

2008-06-29 Thread John Williams
Hi Steve, In my opionion, we should only include dts files for reference designs, and it must be documented how to get the design that the dts corresponds to. I'm not sure you (or Xilinx) are quite ready for the pain this implies - have you tried browsing reference designs on Xilinx.com

RE: [PATCH 12/60] microblaze_v4: Generic dts file for platforms

2008-06-29 Thread Stephen Neuendorffer
In my opionion, we should only include dts files for reference designs, and it must be documented how to get the design that the dts corresponds to. MD5 hashing might be one way to prevent people from getting the dts file wrong, however without some way of checking it automatically, I don't

Re: [PATCH 4/6] MPC5121 Add MPC5121ADS cpld support

2008-06-29 Thread John Rigby
On Sat, Jun 28, 2008 at 11:36 PM, Grant Likely [EMAIL PROTECTED] wrote: Minor comments below. On Fri, Jun 20, 2008 at 10:58:37AM -0600, John Rigby wrote: Add a interrupt host for the interrupt controller in the mpc5121ads cpld. PCI interrupts are 0-7 the rest are 8-15 Touchscreen pendown

Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

2008-06-29 Thread David Brownell
On Friday 23 May 2008, Grant Likely wrote: Question:  spi_alloc_device() (and the original code) does a spi_master_get() on the spi_master device.  Doesn't spi_master_put() need to be called when the device is discarded?  spi_dev_put() doesn't do that explicitly; is it an implicit operation

Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

2008-06-29 Thread David Brownell
On Tuesday 17 June 2008, Grant Likely wrote: This patch splits the allocation and registration portions of code out of spi_new_device() and creates three new functions; spi_alloc_device(), spi_register_device(), and spi_device_release(). I have no problem with the first two, but why the

Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards

2008-06-29 Thread David Gibson
On Fri, Jun 27, 2008 at 04:10:17PM -0500, Kumar Gala wrote: Added DMA nodes for the elo/elo-plus DMA engines. Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so that its the same as all the other boards. Signed-off-by: Kumar Gala [EMAIL PROTECTED] [snip] diff --git

Re: [PATCH 08/18 v2] powerpc: Do not probe PCI buses or eBus devices if CMO is enabled

2008-06-29 Thread Paul Mackerras
Robert Jennings writes: From: Brian King [EMAIL PROTECTED] The Cooperative Memory Overcommit (CMO) on System p does not currently support native PCI devices or eBus devices when enabled. Then why would we get any native PCI or eBus devices in the device tree? Paul.

Re: [PATCH v2] powerpc/bootwrapper: Add documentation of boot wrapper targets

2008-06-29 Thread Paul Mackerras
Grant Likely writes: From: Grant Likely [EMAIL PROTECTED] There have been many questions on and off the mailing list about how exactly the bootwrapper is used for embedded targets. Add some documentation and help text to try and clarify the system. Signed-off-by: Grant Likely [EMAIL

[POWERPC] mpc7448hpc2.dts: remove chosen node from dts

2008-06-29 Thread Chunbo Luo
Modern versions of u-boot create a chosen node automatically. So if we set the chosen node in the dts file, there will be 2 chosen nodes passed in to the kernel, and the kernel command line will be taken from the wrong node. So, remove the extra chosen node from the dts file. Signed-off-by: