[PATCH 4/4] powerpc: Fix oops when echoing bad values to /sys/devices/system/memory/probe

2011-08-10 Thread Anton Blanchard
If we echo an address the hypervisor doesn't like to /sys/devices/system/memory/probe we oops the box: # echo 0x100 > /sys/devices/system/memory/probe kernel BUG at arch/powerpc/mm/hash_utils_64.c:541! The backtrace is: create_section_mapping arch_add_memory add_memory memory_probe_stor

[PATCH 3/4] [PATCH] powerpc: Coding style cleanups

2011-08-10 Thread Anton Blanchard
While converting code to use for_each_node_by_type I noticed a number of coding style issues. Signed-off-by: Anton Blanchard --- Index: linux-powerpc/arch/powerpc/kernel/setup_64.c === --- linux-powerpc.orig/arch/powerpc/kernel/setu

[PATCH 2/4] [PATCH] powerpc: Use for_each_node_by_type instead of open coding it

2011-08-10 Thread Anton Blanchard
Use for_each_node_by_type instead of open coding it. Signed-off-by: Anton Blanchard --- Index: linux-powerpc/arch/powerpc/kernel/machine_kexec_64.c === --- linux-powerpc.orig/arch/powerpc/kernel/machine_kexec_64.c 2011-08-10 16:1

[PATCH 1/4] [PATCH] powerpc: numa: Remove double of_node_put in hot_add_node_scn_to_nid

2011-08-10 Thread Anton Blanchard
During memory hotplug testing, I got the following warning: ERROR: Bad of_node_put() on /memory@0 of_node_release kref_put of_node_put of_find_node_by_type hot_add_node_scn_to_nid hot_add_scn_to_nid memory_add_physaddr_to_nid ... of_find_node_by_type() loop does the of_node_put for us so we on

44x/pci: Add __init annotations for *init_port_hw() functions.

2011-08-10 Thread Tony Breeds
The various port_init_hw methods of ppc4xx_pciex_hwops should have been marked __init and when I added ppc4xx_pciex_port_reset_sdr(), which is __init. This added many section mismatch warnings like: WARNING: arch/powerpc/sysdev/built-in.o(.text+0x5c68): Section mismatch in reference from the fun

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-10 Thread Kumar Gala
On Aug 10, 2011, at 1:16 PM, Wolfgang Grandegger wrote: > On 08/10/2011 07:01 PM, Kumar Gala wrote: >> >> On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: >> >>> I added a simple clock source for the p1010rdb so the flexcan driver >>> could determine a clock frequency. The p1010 flexcan device

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 08:16:33PM +0200, Wolfgang Grandegger wrote: > On 08/10/2011 07:01 PM, Kumar Gala wrote: > > > > On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: > > > >> I added a simple clock source for the p1010rdb so the flexcan driver > >> could determine a clock frequency. The p1010

Re: [PATCH 1/3] KVM: PPC: Assemble book3s{, _hv}_rmhandlers.S separately

2011-08-10 Thread Alexander Graf
Am 11.08.2011 um 01:58 schrieb Paul Mackerras : > On Tue, Aug 02, 2011 at 02:20:28PM +0200, Alexander Graf wrote: >> On 07/23/2011 09:41 AM, Paul Mackerras wrote: >>> This makes arch/powerpc/kvm/book3s_rmhandlers.S and >>> arch/powerpc/kvm/book3s_hv_rmhandlers.S be assembled as >>> separate co

Re: [PATCH 1/3] KVM: PPC: Assemble book3s{,_hv}_rmhandlers.S separately

2011-08-10 Thread Paul Mackerras
On Tue, Aug 02, 2011 at 02:20:28PM +0200, Alexander Graf wrote: > On 07/23/2011 09:41 AM, Paul Mackerras wrote: > >This makes arch/powerpc/kvm/book3s_rmhandlers.S and > >arch/powerpc/kvm/book3s_hv_rmhandlers.S be assembled as > >separate compilation units rather than having them #included in > >arc

Re: [PATCH] powerpc/kvm: fix build errors with older toolchains

2011-08-10 Thread Alexander Graf
On 10.08.2011, at 20:56, Benjamin Herrenschmidt wrote: > On Wed, 2011-08-10 at 16:58 +0200, Alexander Graf wrote: >> On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote: >>> On a box with gcc 4.3.2, I see errors like: >>> >>> arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode

Re: [PATCH] powerpc/kvm: fix build errors with older toolchains

2011-08-10 Thread Benjamin Herrenschmidt
On Wed, 2011-08-10 at 16:58 +0200, Alexander Graf wrote: > On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote: > > On a box with gcc 4.3.2, I see errors like: > > > > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: > > stxvd2x > > arch/powerpc/kvm/book3s_hv_rmhandlers.S:13

Re: [git pull] Please pull powerpc.git merge branch

2011-08-10 Thread Benjamin Herrenschmidt
On Wed, 2011-08-10 at 11:07 -0700, Linus Torvalds wrote: > On Wed, Aug 10, 2011 at 8:27 AM, Benjamin Herrenschmidt > wrote: > > > > Here are a few fixes for powerpc. Mostly innocuous stuff, in fact most of > > it has been in my tree for a while, I just hadn't got a chance to actually > > send it a

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 01:40:30PM -0500, Scott Wood wrote: > On 08/10/2011 01:30 PM, Robin Holt wrote: > > On Wed, Aug 10, 2011 at 12:36:22PM -0500, Scott Wood wrote: > >> On 08/10/2011 12:19 PM, Robin Holt wrote: > >>> On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote: > Also may wa

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Scott Wood
On 08/10/2011 01:30 PM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 12:36:22PM -0500, Scott Wood wrote: >> On 08/10/2011 12:19 PM, Robin Holt wrote: >>> On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote: Also may want to list fsl,p1010-rdb as a "canonical compatible" for anything

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Scott Wood
On 08/10/2011 01:35 PM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 01:27:52PM -0500, Scott Wood wrote: >> "...and then associate the label with an alias." >> >> The alias can then be used if you want "can0" versus "can1". > > Does the alias get used by either the kernel or something else or is it

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 01:27:52PM -0500, Scott Wood wrote: > On 08/10/2011 01:23 PM, Wolfgang Grandegger wrote: > > On 08/10/2011 06:00 PM, Robin Holt wrote: > >> On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: > > ... > >> It looks like the way to do that is to assign a label to

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 12:36:22PM -0500, Scott Wood wrote: > On 08/10/2011 12:19 PM, Robin Holt wrote: > > On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote: > >> On 08/10/2011 11:27 AM, Robin Holt wrote: > >>> -CPI Clock- Can Protocol Interface Clock > >>> - This CLK_SRC bit of CTRL(cont

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Scott Wood
On 08/10/2011 01:23 PM, Wolfgang Grandegger wrote: > On 08/10/2011 06:00 PM, Robin Holt wrote: >> On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: > ... >> It looks like the way to do that is to assign a label to those devices >> and then associate the label with an alias. I have

Please pull 'next' branch of 4xx tree

2011-08-10 Thread Josh Boyer
Hi Ben, Finally somewhat caught up. Now that -rc1 is out, here are some patches for the next merge window. josh The following changes since commit 53d1e658df6e26d62500410719aaee2b82067c03: Merge branch 'devicetree/merge' of git://git.secretlab.ca/git/linux-2.6 (2011-08-04 06:37:07 -1000) ar

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Wolfgang Grandegger
On 08/10/2011 06:00 PM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: ... > It looks like the way to do that is to assign a label to those devices > and then associate the label with an alias. I have no idea how that > works under the hood, but it is the way

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-10 Thread Wolfgang Grandegger
On 08/10/2011 07:01 PM, Kumar Gala wrote: > > On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: > >> I added a simple clock source for the p1010rdb so the flexcan driver >> could determine a clock frequency. The p1010 flexcan device only has >> an oscillator of system bus frequency divided by 2. >

Re: [git pull] Please pull powerpc.git merge branch

2011-08-10 Thread Linus Torvalds
On Wed, Aug 10, 2011 at 8:27 AM, Benjamin Herrenschmidt wrote: > > Here are a few fixes for powerpc. Mostly innocuous stuff, in fact most of > it has been in my tree for a while, I just hadn't got a chance to actually > send it as I was travelling. > > Cheers, > Ben. > > The following changes sinc

Re: union/struct representations for MAS Registers

2011-08-10 Thread Kumar Gala
On Aug 10, 2011, at 12:38 PM, David Laight wrote: > >>> Bitfields are rather non-portable, the compiler has a lot of choice >>> about how to align the bits in memory. >> >> I'm ok with the masking stuff. >> However, I'm actually surprised this is true given the >> maturity of our ABIs. > > Th

RE: union/struct representations for MAS Registers

2011-08-10 Thread David Laight
> > Bitfields are rather non-portable, the compiler has a lot of choice > > about how to align the bits in memory. > > I'm ok with the masking stuff. > However, I'm actually surprised this is true given the > maturity of our ABIs. The C standard says nothing at all about how bitfields are impl

Re: [PATCH v3] powerpc: 85xx: separate e500 from e500mc

2011-08-10 Thread Paul Gortmaker
On 11-08-10 12:01 PM, Scott Wood wrote: > On 08/10/2011 10:39 AM, Paul Gortmaker wrote: >> On Wed, Aug 10, 2011 at 1:21 AM, Baruch Siach wrote: >>> CONFIG_E500MC breaks e500/e500v2 systems. It defines L1_CACHE_SHIFT to 6, >>> thus >>> breaking clear_pages(), probably others too. >>> >>> This patc

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Scott Wood
On 08/10/2011 12:19 PM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote: >> On 08/10/2011 11:27 AM, Robin Holt wrote: >>> -CPI Clock- Can Protocol Interface Clock >>> - This CLK_SRC bit of CTRL(control register) selects the clock source to >>> - the CAN Protocol I

Re: union/struct representations for MAS Registers

2011-08-10 Thread Jimi Xenidis
On Aug 10, 2011, at 12:25 PM, David Laight wrote: > >> I have some and use them in some code, they represent ISA >> 2.06 MAVN=1 (version 2) >> Can I keep them? >> if so, should I put them somewhere useful to others? >> >> Examples: >> union mas1 { >> u32 _val; >> struct { >>

Re: union/struct representations for MAS Registers

2011-08-10 Thread Jimi Xenidis
On Aug 10, 2011, at 12:25 PM, Kumar Gala wrote: > > On Aug 10, 2011, at 12:21 PM, Jimi Xenidis wrote: > >> I have some and use them in some code, they represent ISA 2.06 MAVN=1 >> (version 2) >> Can I keep them? >> if so, should I put them somewhere useful to others? >> >> Examples: >> union

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Kumar Gala
>>> So the node names should be >>> can@1c000 { >>> can@1d000 { >>> correct? >>> >> [Bhaskar] As there are two CAN controllers on P1010,So won't it be better >> to distinguish it by can0 and can1 instead by simple "can" ? >

RE: union/struct representations for MAS Registers

2011-08-10 Thread David Laight
> I have some and use them in some code, they represent ISA > 2.06 MAVN=1 (version 2) > Can I keep them? > if so, should I put them somewhere useful to others? > > Examples: > union mas1 { > u32 _val; > struct { > u32 v:1; > u32 iprot:1; > u

Re: union/struct representations for MAS Registers

2011-08-10 Thread Kumar Gala
On Aug 10, 2011, at 12:21 PM, Jimi Xenidis wrote: > I have some and use them in some code, they represent ISA 2.06 MAVN=1 > (version 2) > Can I keep them? > if so, should I put them somewhere useful to others? > > Examples: > union mas1 { > u32 _val; > struct { > u32 v

union/struct representations for MAS Registers

2011-08-10 Thread Jimi Xenidis
I have some and use them in some code, they represent ISA 2.06 MAVN=1 (version 2) Can I keep them? if so, should I put them somewhere useful to others? Examples: union mas1 { u32 _val; struct { u32 v:1; u32 iprot:1; u32 tid:14;

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 12:17:45PM -0500, Kumar Gala wrote: > > On Aug 10, 2011, at 12:16 PM, Robin Holt wrote: > > > On Wed, Aug 10, 2011 at 11:53:15AM -0500, Kumar Gala wrote: > >> > >> On Aug 10, 2011, at 11:00 AM, Robin Holt wrote: > >> > >>> On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhas

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote: > On 08/10/2011 11:27 AM, Robin Holt wrote: > > -CPI Clock- Can Protocol Interface Clock > > - This CLK_SRC bit of CTRL(control register) selects the clock source to > > - the CAN Protocol Interface(CPI) to be either the peripheral clo

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Kumar Gala
On Aug 10, 2011, at 12:16 PM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 11:53:15AM -0500, Kumar Gala wrote: >> >> On Aug 10, 2011, at 11:00 AM, Robin Holt wrote: >> >>> On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: > -Original Message- > From: R

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 11:53:15AM -0500, Kumar Gala wrote: > > On Aug 10, 2011, at 11:00 AM, Robin Holt wrote: > > > On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: > >> > >> > >>> -Original Message- > >>> From: Robin Holt [mailto:h...@sgi.com] > >>> Sent: Wednesday,

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-10 Thread Kumar Gala
On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: > I added a simple clock source for the p1010rdb so the flexcan driver > could determine a clock frequency. The p1010 flexcan device only has > an oscillator of system bus frequency divided by 2. > > Signed-off-by: Robin Holt > Acked-by: Marc Kle

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Scott Wood
On 08/10/2011 11:27 AM, Robin Holt wrote: > -CPI Clock- Can Protocol Interface Clock > - This CLK_SRC bit of CTRL(control register) selects the clock source to > - the CAN Protocol Interface(CPI) to be either the peripheral clock > - (driven by the PLL) or the crystal oscillator clock.

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Kumar Gala
On Aug 10, 2011, at 11:00 AM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: >> >> >>> -Original Message- >>> From: Robin Holt [mailto:h...@sgi.com] >>> Sent: Wednesday, August 10, 2011 7:46 PM >>> To: Wolfgang Grandegger >>> Cc: Robin Holt; Marc K

[PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
This patch cleans up the documentation of the device-tree binding for the Flexcan devices on Freescale's PowerPC and ARM cores. Extra properties are not needed as the frequency of the source clock is fixed, there is not external divider beyond what the driver already works with, and the clock sourc

[PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-10 Thread Robin Holt
I added a simple clock source for the p1010rdb so the flexcan driver could determine a clock frequency. The p1010 flexcan device only has an oscillator of system bus frequency divided by 2. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , Acked-by: Wolfgang Grandegger , Cc: U Bhaskar-B223

[PATCH v11 3/5] flexcan: Add of_match to platform_device definition.

2011-08-10 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: Grant Lik

[PATCH v11 2/5] flexcan: Abstract off read/write for big/little endian.

2011-08-10 Thread Robin Holt
Make flexcan driver handle register reads in the appropriate endianess. This was a basic search and replace and then define some inlines. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net...@vger

[PATCH v11 1/5] flexcan: Remove #include

2011-08-10 Thread Robin Holt
powerpc does not have a mach-/clock.h. When testing, I found neither arm nor powerpc needed the mach/clock.h at all so I removed it. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net...@vger

[PATCH v11 0/5] flexcan/powerpc: Add support for powerpc flexcan (freescale p1010)

2011-08-10 Thread Robin Holt
With all the patches applied, my p1010rdb works for communicating between its two can ports and also can communicate with an external PSOC. I have done no testing beyond compile testing on an arm system as I have no access to an arm based system. For the first three patches in the series, I belie

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 09:52:07AM -0500, Kumar Gala wrote: > > On Aug 9, 2011, at 3:59 PM, Robin Holt wrote: > > > I guess my poor wording may have gotten me in trouble. I am getting > > ready to repost this patch, but I want to ensure I am getting it as > > right as possible. > > > > I think

Re: [PATCH v3] powerpc: 85xx: separate e500 from e500mc

2011-08-10 Thread Scott Wood
On 08/10/2011 10:39 AM, Paul Gortmaker wrote: > On Wed, Aug 10, 2011 at 1:21 AM, Baruch Siach wrote: >> CONFIG_E500MC breaks e500/e500v2 systems. It defines L1_CACHE_SHIFT to 6, >> thus >> breaking clear_pages(), probably others too. >> >> This patch adds a new "Processor Type" entry for e500mc,

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: > > > > -Original Message- > > From: Robin Holt [mailto:h...@sgi.com] > > Sent: Wednesday, August 10, 2011 7:46 PM > > To: Wolfgang Grandegger > > Cc: Robin Holt; Marc Kleine-Budde; U Bhaskar-B22300; Wood Scott-B07421; > >

Re: [PATCH v3] powerpc: 85xx: separate e500 from e500mc

2011-08-10 Thread Paul Gortmaker
On Wed, Aug 10, 2011 at 1:21 AM, Baruch Siach wrote: > CONFIG_E500MC breaks e500/e500v2 systems. It defines L1_CACHE_SHIFT to 6, thus > breaking clear_pages(), probably others too. > > This patch adds a new "Processor Type" entry for e500mc, and makes e500 > systems > depend on PPC_E500_V1_V2. I

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 09:45:17AM -0500, Kumar Gala wrote: > > On Aug 10, 2011, at 9:15 AM, Robin Holt wrote: > > > On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: > >> Hi Robin, > >> > >> On 08/10/2011 05:06 AM, Robin Holt wrote: > >>> In working with the socketcan develop

[git pull] Please pull powerpc.git merge branch

2011-08-10 Thread Benjamin Herrenschmidt
Hi Linus ! Here are a few fixes for powerpc. Mostly innocuous stuff, in fact most of it has been in my tree for a while, I just hadn't got a chance to actually send it as I was travelling. Cheers, Ben. The following changes since commit 53d1e658df6e26d62500410719aaee2b82067c03: Merge branch '

Re: [PATCH] powerpc/kvm: fix build errors with older toolchains

2011-08-10 Thread Alexander Graf
On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote: On a box with gcc 4.3.2, I see errors like: arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: stxvd2x arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized opcode: lxvd2x Paul, mind to ack? Alex Signed-

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Kumar Gala
On Aug 9, 2011, at 3:59 PM, Robin Holt wrote: > I guess my poor wording may have gotten me in trouble. I am getting > ready to repost this patch, but I want to ensure I am getting it as > right as possible. > > I think I should reword the commit message to indicate we are removing > the Documen

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Kumar Gala
On Aug 10, 2011, at 9:41 AM, Wolfgang Grandegger wrote: > On 08/10/2011 04:15 PM, Robin Holt wrote: >> On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: > ... >> Done, except the >>> compatible = "fsl,p1010-flexcan", "fsl,flexcan"; >> >> line is >> compatible = "

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Kumar Gala
On Aug 10, 2011, at 9:15 AM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: >> Hi Robin, >> >> On 08/10/2011 05:06 AM, Robin Holt wrote: >>> In working with the socketcan developers, we have come to the conclusion >>> the Documentation...fsl-flexcan.txt

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Wolfgang Grandegger
On 08/10/2011 04:15 PM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: ... > Done, except the >> compatible = "fsl,p1010-flexcan", "fsl,flexcan"; > > line is > compatible = "fsl,flexcan", "fsl,flexcan-p1010"; IIRC, there order is more to l

RE: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread U Bhaskar-B22300
> -Original Message- > From: Robin Holt [mailto:h...@sgi.com] > Sent: Wednesday, August 10, 2011 7:46 PM > To: Wolfgang Grandegger > Cc: Robin Holt; Marc Kleine-Budde; U Bhaskar-B22300; Wood Scott-B07421; > net...@vger.kernel.org; Kumar Gala; socketcan-c...@lists.berlios.de; PPC > list >

Re: [PATCH v10 3/5] [flexcan] Add of_match to platform_device definition.

2011-08-10 Thread Robin Holt
On Tue, Aug 09, 2011 at 10:06:02PM -0500, Robin Holt wrote: > On powerpc, the OpenFirmware devices are not matched without specifying > an of_match array. Introduce that array as that is used for matching > on the Freescale P1010 processor. > > Signed-off-by: Robin Holt > To: Marc Kleine-Budde

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: > Hi Robin, > > On 08/10/2011 05:06 AM, Robin Holt wrote: > > In working with the socketcan developers, we have come to the conclusion > > the Documentation...fsl-flexcan.txt device tree documentation needs to > > be cleaned up.

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Wolfgang Grandegger
Hi Robin, On 08/10/2011 05:06 AM, Robin Holt wrote: > In working with the socketcan developers, we have come to the conclusion > the Documentation...fsl-flexcan.txt device tree documentation needs to > be cleaned up. The driver does not depend upon any properties other Your first sentence could

[PATCH 11/10] KVM: PPC: Add sanity checking to vcpu_run

2011-08-10 Thread Alexander Graf
There are multiple features in PowerPC KVM that can now be enabled depending on the user's wishes. Some of the combinations don't make sense or don't work though. So this patch adds a way to check if the executing environment would actually be able to run the guest properly. It also adds sanity ch

Re: [PATCH 10/10] KVM: PPC: Enable the PAPR CAP for Book3S

2011-08-10 Thread Alexander Graf
On 08/10/2011 02:26 PM, Paul Mackerras wrote: On Wed, Aug 10, 2011 at 09:59:41AM +0200, Alexander Graf wrote: Am 10.08.2011 um 06:42 schrieb Paul Mackerras: On Tue, Aug 09, 2011 at 06:31:48PM +0200, Alexander Graf wrote: Now that Book3S PV mode can also run PAPR guests, we can add a PAPR cap

Re: [PATCH 10/10] KVM: PPC: Enable the PAPR CAP for Book3S

2011-08-10 Thread Paul Mackerras
On Wed, Aug 10, 2011 at 09:59:41AM +0200, Alexander Graf wrote: > > Am 10.08.2011 um 06:42 schrieb Paul Mackerras : > > > On Tue, Aug 09, 2011 at 06:31:48PM +0200, Alexander Graf wrote: > > > >> Now that Book3S PV mode can also run PAPR guests, we can add a PAPR cap and > >> enable it for all Bo

Re: [PATCH 1/3] powerpc: numa: Remove double of_node_put in hot_add_node_scn_to_nid

2011-08-10 Thread Anton Blanchard
Hi Stephen, > > Index: linux-powerpc/arch/powerpc/mm/numa.c > > === > > --- linux-powerpc.orig/arch/powerpc/mm/numa.c 2011-06-06 > > 08:07:35.148708089 +1000 +++ > > linux-powerpc/arch/powerpc/mm/numa.c2011-08-10 > > 11:

Re: [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010)

2011-08-10 Thread Marc Kleine-Budde
On 08/10/2011 05:05 AM, Robin Holt wrote: > With all the patches applied, my p1010rdb works for communicating between > its two can ports and also can communicate with an external PSOC. I have > done no testing beyond compile testing on an arm system as I have no > access to an arm based system. >

Re: [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010)

2011-08-10 Thread Marc Kleine-Budde
On 08/10/2011 12:11 PM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 12:01:58PM +0200, Marc Kleine-Budde wrote: >> On 08/10/2011 05:05 AM, Robin Holt wrote: >>> With all the patches applied, my p1010rdb works for communicating between >>> its two can ports and also can communicate with an external P

Re: [PATCH v10 4/5] [powerpc] Add flexcan device support for p1010rdb.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 11:56:01AM +0200, Marc Kleine-Budde wrote: > On 08/10/2011 05:06 AM, Robin Holt wrote: > > diff --git a/arch/powerpc/platforms/85xx/clock.c > > b/arch/powerpc/platforms/85xx/clock.c > > new file mode 100644 > > index 000..16fae04 > > --- /dev/null > > +++ b/arch/powerpc

Re: [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010)

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 12:01:58PM +0200, Marc Kleine-Budde wrote: > On 08/10/2011 05:05 AM, Robin Holt wrote: > > With all the patches applied, my p1010rdb works for communicating between > > its two can ports and also can communicate with an external PSOC. I have > > done no testing beyond compi

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
Grant, Do you need this patch resent with you on the Cc: list or can you pick up the discussion from here? I am just trying to minimize noise on the mailing lists if it is not needed. The essence of the discussion to this point is: 1) Freescale built a board support package for a new processor

Re: [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010)

2011-08-10 Thread Marc Kleine-Budde
On 08/10/2011 05:05 AM, Robin Holt wrote: > With all the patches applied, my p1010rdb works for communicating between > its two can ports and also can communicate with an external PSOC. I have > done no testing beyond compile testing on an arm system as I have no > access to an arm based system. >

Re: [PATCH v10 4/5] [powerpc] Add flexcan device support for p1010rdb.

2011-08-10 Thread Marc Kleine-Budde
On 08/10/2011 05:06 AM, Robin Holt wrote: > I added a simple clock source for the p1010rdb so the flexcan driver > could determine a clock frequency. The p1010 can device only has an > oscillator of system bus frequency divided by 2. > > Signed-off-by: Robin Holt > Acked-by: Marc Kleine-Budde ,

Re: [PATCH 1/3] powerpc: numa: Remove double of_node_put in hot_add_node_scn_to_nid

2011-08-10 Thread Stephen Rothwell
Hi Anton, On Wed, 10 Aug 2011 16:49:34 +1000 Anton Blanchard wrote: > > During memory hotplug testing, I got the following warning: > > > ERROR: Bad of_node_put() on /memory@0 > > of_find_node_by_type() loop does of_node_put for us so remove the > duplicate one inside the loop. But does an of

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robert Schwebel
Robin, On Tue, Aug 09, 2011 at 10:06:04PM -0500, Robin Holt wrote: > In working with the socketcan developers, we have come to the conclusion > the Documentation...fsl-flexcan.txt device tree documentation needs to > be cleaned up. The driver does not depend upon any properties other > than the r

Re: [PATCH 10/10] KVM: PPC: Enable the PAPR CAP for Book3S

2011-08-10 Thread Alexander Graf
Am 10.08.2011 um 06:42 schrieb Paul Mackerras : > On Tue, Aug 09, 2011 at 06:31:48PM +0200, Alexander Graf wrote: > >> Now that Book3S PV mode can also run PAPR guests, we can add a PAPR cap and >> enable it for all Book3S targets. Enabling that CAP switches KVM into PAPR >> mode. > > Don't we