Re: [PATCH] fsl/smp: add low power boot support to replace spin boot

2015-01-15 Thread York Sun
On 01/14/2015 10:05 PM, Dongsheng Wang wrote: From: Wang Dongsheng dongsheng.w...@freescale.com U-boot put non-boot cpus into an low power state(PW10/PW20 or DOZE) when cpu powered up. To exit low power state kernel will send DOORBELL or MPIC-IPI signal to all those CPUs. e500/e500v2

[PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon

2015-01-15 Thread Laurent Dufour
The commit 3b8a3c010969 (powerpc/pseries: Fix endiannes issue in RTAS call from xmon) was fixing an endianness issue in the call made from xmon to RTAS. However, as Michael Ellerman noticed, this fix was not complete, the token value was not byte swapped. This lead to call an unexpected and most

Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon

2015-01-15 Thread Tyrel Datwyler
On 01/15/2015 09:23 AM, Laurent Dufour wrote: The commit 3b8a3c010969 (powerpc/pseries: Fix endiannes issue in RTAS call from xmon) was fixing an endianness issue in the call made from xmon to RTAS. However, as Michael Ellerman noticed, this fix was not complete, the token value was not

Re: [PATCH 2/3] CXL: Snoop control

2015-01-15 Thread Ryan Grimm
On 01/15/2015 12:16 AM, Ian Munsie wrote: Excerpts from Ryan Grimm's message of 2015-01-15 13:56:40 +1100: Add mode to opal call. SNOOP control turns CAPP unit snooping on/off. This is needed for the following reset patch, which turns snoops off in the CAPP recovery path. Looking at patch 3

Re: [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE-READ_ONCE

2015-01-15 Thread Oleg Nesterov
On 01/15, Christian Borntraeger wrote: Am 15.01.2015 um 20:38 schrieb Oleg Nesterov: On 01/15, Christian Borntraeger wrote: --- a/arch/x86/include/asm/spinlock.h +++ b/arch/x86/include/asm/spinlock.h @@ -186,7 +186,7 @@ static inline void arch_spin_unlock_wait(arch_spinlock_t *lock)

Re: [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE-READ_ONCE

2015-01-15 Thread Christian Borntraeger
Am 15.01.2015 um 20:38 schrieb Oleg Nesterov: On 01/15, Christian Borntraeger wrote: --- a/arch/x86/include/asm/spinlock.h +++ b/arch/x86/include/asm/spinlock.h @@ -186,7 +186,7 @@ static inline void arch_spin_unlock_wait(arch_spinlock_t *lock) __ticket_t head =

Re: [PATCH 3/3] CXL: Add reset to sysfs

2015-01-15 Thread Ryan Grimm
On 01/15/2015 12:42 AM, Ian Munsie wrote: Excerpts from Ryan Grimm's message of 2015-01-15 13:56:41 +1100: This allows an image to be downloaded to the flash without rebooting the machine. The driver perform a PERST, which results in FPGA image downloaded to flash and the CAPP unit enters

Re: offlining cpus breakage

2015-01-15 Thread Alexey Kardashevskiy
On 01/16/2015 02:22 AM, Preeti U Murthy wrote: Hi Alexey, Can you let me know if the following patch fixes the issue for you ? It did for us on one of our machines that we were investigating on. This fixes the issue for me as well, thanks! Tested-by: Alexey Kardashevskiy a...@ozlabs.ru

Re: How to make use of SPE instructions?

2015-01-15 Thread Michael Ellerman
On Thu, 2015-01-08 at 09:58 +, Markus Stockhausen wrote: Hello, I developed a SHA224/256 kernel crypto module with SPE instructions. The result looks quite promising (~ +50% speedup). Nevertheless the flooding of kernel messages SPE used in kernel makes me feel uncomfortable. My

Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon

2015-01-15 Thread Michael Ellerman
On Thu, 2015-01-15 at 11:44 -0800, Tyrel Datwyler wrote: On 01/15/2015 09:23 AM, Laurent Dufour wrote: The commit 3b8a3c010969 (powerpc/pseries: Fix endiannes issue in RTAS call from xmon) was fixing an endianness issue in the call made from xmon to RTAS. However, as Michael Ellerman

[PATCH 1/3] CXL: Add image control to sysfs

2015-01-15 Thread Ryan Grimm
reset_image_select identifies whether a PERST will cause the image to be flashed to the card. And if so, which image. Valid entries are: none, user and factory. A value of none means PERST will not cause the image to be flashed. A power cycle to the pcie slot is required to load the image.

Re: [PATCH 1/8] ppc/kvm: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread Michael Ellerman
On Thu, 2015-01-15 at 09:58 +0100, Christian Borntraeger wrote: ACCESS_ONCE does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step

Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon

2015-01-15 Thread Tyrel Datwyler
On 01/15/2015 02:19 PM, Michael Ellerman wrote: On Thu, 2015-01-15 at 11:44 -0800, Tyrel Datwyler wrote: On 01/15/2015 09:23 AM, Laurent Dufour wrote: The commit 3b8a3c010969 (powerpc/pseries: Fix endiannes issue in RTAS call from xmon) was fixing an endianness issue in the call made from

Re: How to make use of SPE instructions?

2015-01-15 Thread Scott Wood
On Thu, 2015-01-08 at 09:58 +, Markus Stockhausen wrote: Hello, I developed a SHA224/256 kernel crypto module with SPE instructions. The result looks quite promising (~ +50% speedup). Nevertheless the flooding of kernel messages SPE used in kernel makes me feel uncomfortable. My

[PATCH 3/3] CXL: Add ability to reset the card

2015-01-15 Thread Ryan Grimm
Adds reset to sysfs which will PERST the card. If load_image_on_perst is set to user or factory, the PERST will cause that image to be loaded. load_image_on_perst is set to user for production. none could be used for debugging. The PSL trace arrays are preserved which then can be read through

[PATCH 2/3] CXL: Enable CAPP recovery

2015-01-15 Thread Ryan Grimm
Turning snoops on is the last step in CAPP recovery. Sapphire is expected to have reinitialized the PHB and done the previous recovery steps. Add mode argument to opal call to do this. Driver can turn snoops off although it does not currently. Signed-off-by: Ryan Grimm gr...@linux.vnet.ibm.com

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-15 Thread Ian Munsie
Hi Ryan, Excerpts from Ryan Grimm's message of 2015-01-16 09:27:15 +1100: reset_image_select identifies whether a PERST will cause the image to be s/reset_image_select/load_image_on_perst/ +What: /sys/class/cxl/card/load_image_on_perst +Date: December 2014 +Contact:

Re: [PATCH 2/3] CXL: Enable CAPP recovery

2015-01-15 Thread Ian Munsie
Acked-by: Ian Munsie imun...@au1.ibm.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 3/3] CXL: Add ability to reset the card

2015-01-15 Thread Ian Munsie
Hi Ryan, Excerpts from Ryan Grimm's message of 2015-01-16 09:27:17 +1100: Adds reset to sysfs which will PERST the card. If load_image_on_perst is set to user or factory, the PERST will cause that image to be loaded. load_image_on_perst is set to user for production. While it generally

AW: How to make use of SPE instructions?

2015-01-15 Thread Markus Stockhausen
Von: Scott Wood [scottw...@freescale.com] Gesendet: Donnerstag, 15. Januar 2015 23:56 An: Markus Stockhausen Cc: linuxppc-dev@lists.ozlabs.org Betreff: Re: How to make use of SPE instructions? On Thu, 2015-01-08 at 09:58 +, Markus Stockhausen wrote: Hello, I developed a

Re: [RFC 01/11] i2c: add quirk structure to describe adapter flaws

2015-01-15 Thread Eddie Huang
Hi Wolfram, On Fri, 2015-01-09 at 18:21 +0100, Wolfram Sang wrote: + */ +struct i2c_adapter_quirks { + u64 flags; + int max_num_msgs; + u16 max_write_len; + u16 max_read_len; + u16 max_comb_write_len; + u16 max_comb_read_len; +}; + +#define

Re: [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE-READ_ONCE

2015-01-15 Thread Oleg Nesterov
On 01/15, Christian Borntraeger wrote: --- a/arch/x86/include/asm/spinlock.h +++ b/arch/x86/include/asm/spinlock.h @@ -186,7 +186,7 @@ static inline void arch_spin_unlock_wait(arch_spinlock_t *lock) __ticket_t head = ACCESS_ONCE(lock-tickets.head); for (;;) { -

Re: [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE-READ_ONCE

2015-01-15 Thread Christian Borntraeger
Am 15.01.2015 um 21:01 schrieb Oleg Nesterov: On 01/15, Christian Borntraeger wrote: Am 15.01.2015 um 20:38 schrieb Oleg Nesterov: On 01/15, Christian Borntraeger wrote: --- a/arch/x86/include/asm/spinlock.h +++ b/arch/x86/include/asm/spinlock.h @@ -186,7 +186,7 @@ static inline void

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-15 Thread Ryan Grimm
Ian, Thanks for reviewing! On 01/14/2015 11:41 PM, Ian Munsie wrote: Excerpts from Ryan Grimm's message of 2015-01-15 13:56:39 +1100: Add reset_loads_image and reset_image_select to sysfs. reset_image_select identifies which image will be loaded to the card on the next PERST. Valid entries

Re: [PATCH 13/28] pci: host: drop owner assignment from platform_drivers

2015-01-15 Thread Bjorn Helgaas
[+cc Julia] On Sun, Dec 21, 2014 at 10:14:34PM +0100, Wolfram Sang wrote: This platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang w...@the-dreams.de I already applied the equivalent patch from Julia for v3.20, thanks! (I

Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon

2015-01-15 Thread Michael Ellerman
On Thu, 2015-01-15 at 15:41 -0800, Tyrel Datwyler wrote: On 01/15/2015 02:19 PM, Michael Ellerman wrote: On Thu, 2015-01-15 at 11:44 -0800, Tyrel Datwyler wrote: On 01/15/2015 09:23 AM, Laurent Dufour wrote: The commit 3b8a3c010969 (powerpc/pseries: Fix endiannes issue in RTAS call from

Re: offlining cpus breakage

2015-01-15 Thread Michael Ellerman
On Fri, 2015-01-16 at 13:28 +1300, Alexey Kardashevskiy wrote: On 01/16/2015 02:22 AM, Preeti U Murthy wrote: Hi Alexey, Can you let me know if the following patch fixes the issue for you ? It did for us on one of our machines that we were investigating on. This fixes the issue for me

RE: [PATCH] fsl/smp: add low power boot support to replace spin boot

2015-01-15 Thread dongsheng.w...@freescale.com
Thanks for your review. -Original Message- From: Sun York-R58495 Sent: Friday, January 16, 2015 1:09 AM To: Wang Dongsheng-B40534; Wood Scott-B07421; Li Yang-Leo-R58472 Cc: linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] fsl/smp: add low power boot support to replace spin boot

[PATCH 5/8] mm/gup: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread Christian Borntraeger
ACCESS_ONCE does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145) Fixup gup_pmd_range. Signed-off-by: Christian

Re: [Xen-devel] [PATCH 3/8] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread Christian Borntraeger
Am 15.01.2015 um 11:43 schrieb David Vrabel: On 15/01/15 08:58, Christian Borntraeger wrote: ACCESS_ONCE does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step

Re: [Xen-devel] [PATCH 3/8] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread David Vrabel
On 15/01/15 08:58, Christian Borntraeger wrote: ACCESS_ONCE does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145)

Re: [PATCH 3/8] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread Jürgen Groß
On 01/15/2015 09:58 AM, Christian Borntraeger wrote: ACCESS_ONCE does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145)

[PATCH 0/8] current ACCESS_ONCE patch queue

2015-01-15 Thread Christian Borntraeger
Folks, fyi, this is my current patch queue for the next merge window. It does contain a patch that will disallow ACCESS_ONCE on non-scalar types. The tree is part of linux-next and can be found at git://git.kernel.org/pub/scm/linux/kernel/git/borntraeger/linux.git linux-next Christian

[PATCH 8/8] kernel: Fix sparse warning for ACCESS_ONCE

2015-01-15 Thread Christian Borntraeger
Commit a91ed664749c (kernel: tighten rules for ACCESS ONCE) results in sparse warnings like Using plain integer as NULL pointer - Let's add a type cast to the dummy assignment. To avoid warnings lik sparse: warning: cast to restricted __hc32 we also use __force on that cast. Fixes: a91ed664749c

Re: linux-next: Tree for Jan 12 (build failures: m68k, ppc)

2015-01-15 Thread Geert Uytterhoeven
On Mon, Jan 12, 2015 at 6:59 PM, Guenter Roeck li...@roeck-us.net wrote: Build failures, seen since next-20150109: m68k:allmodconfig powerpc:ppc6xx_defconfig It looks like parisc is also suffering: http://kisskb.ellerman.id.au/kisskb/buildresult/12343847/ Due to:

[PATCH 2/8] ppc/hugetlbfs: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread Christian Borntraeger
ACCESS_ONCE does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145) Change the ppc/hugetlbfs code to replace ACCESS_ONCE with

[PATCH 1/8] ppc/kvm: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread Christian Borntraeger
ACCESS_ONCE does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145) Change the ppc/kvm code to replace ACCESS_ONCE with

[PATCH 6/8] kernel: tighten rules for ACCESS ONCE

2015-01-15 Thread Christian Borntraeger
Now that all non-scalar users of ACCESS_ONCE have been converted to READ_ONCE or ASSIGN once, lets tighten ACCESS_ONCE to only work on scalar types. This variant was proposed by Alexei Starovoitov. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Reviewed-by: Paul E. McKenney

[PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE-READ_ONCE

2015-01-15 Thread Christian Borntraeger
commit 78bff1c8684f (x86/ticketlock: Fix spin_unlock_wait() livelock) introduced another ACCESS_ONCE case in x86 spinlock.h. Change that as well. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Cc: Oleg Nesterov o...@redhat.com --- arch/x86/include/asm/spinlock.h | 2 +- 1 file

[PATCH 3/8] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread Christian Borntraeger
ACCESS_ONCE does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145) Change the p2m code to replace ACCESS_ONCE with

[PATCH 7/8] next: sh: Fix compile error

2015-01-15 Thread Christian Borntraeger
From: Guenter Roeck li...@roeck-us.net Commit a91ed664749c (kernel: tighten rules for ACCESS ONCE) results in a compile failure for sh builds with CONFIG_X2TLB enabled. arch/sh/mm/gup.c: In function 'gup_get_pte': arch/sh/mm/gup.c:20:2: error: invalid initializer make[1]: *** [arch/sh/mm/gup.o]

Re: offlining cpus breakage

2015-01-15 Thread Preeti U Murthy
Hi Alexey, Can you let me know if the following patch fixes the issue for you ? It did for us on one of our machines that we were investigating on. Anton, Can you let me know if the patch fixes the odd perf report that you observed? This is the latest fix that there is to it.

Re: [PATCH] pseries/le: Fix endiannes issue in RTAS call from xmon

2015-01-15 Thread Laurent Dufour
On 15/01/2015 05:25, Michael Ellerman wrote: On Mon, 2014-11-24 at 15:07 +0100, Laurent Dufour wrote: On pseries system (LPAR) xmon failed to enter when running in LE mode, system is hunging. Inititating xmon will lead to such an output on the console: SysRq : Entering xmon cpu 0x15: Vector:

Re: linux-next: Tree for Jan 12 (build failures: m68k, ppc)

2015-01-15 Thread Guenter Roeck
On 01/15/2015 02:12 AM, Geert Uytterhoeven wrote: On Mon, Jan 12, 2015 at 6:59 PM, Guenter Roeck li...@roeck-us.net wrote: Build failures, seen since next-20150109: m68k:allmodconfig powerpc:ppc6xx_defconfig It looks like parisc is also suffering: