ASMedia ASM2142 USB host controller tries to DMA to address zero when doing bulk reads from multiple devices

2020-07-20 Thread Forest Crossman
Hello, again! After fixing the issue in my previous thread using this patch[1], I decided to do some stress-testing of the controller to make sure it could handle my intended workloads and that there were no further DMA address issues that would need to be fixed. Unfortunately, it looks like

Re: [PATCH 2/2] KVM: PPC: Book3S HV: rework secure mem slot dropping

2020-07-20 Thread Paul Mackerras
On Wed, Jul 08, 2020 at 02:16:36PM +0200, Laurent Dufour wrote: > Le 08/07/2020 à 13:25, Bharata B Rao a écrit : > > On Fri, Jul 03, 2020 at 05:59:14PM +0200, Laurent Dufour wrote: > > > When a secure memslot is dropped, all the pages backed in the secure > > > device > > > (aka really backed by

Re: [PATCH] KVM: PPC: Book3S HV: Use feature flag CPU_FTR_P9_TIDR when accessing TIDR

2020-07-20 Thread David Gibson
On Tue, Jul 21, 2020 at 03:04:45PM +1000, Paul Mackerras wrote: > On Tue, Jun 23, 2020 at 06:50:27PM +0200, Cédric Le Goater wrote: > > The TIDR register is only available on POWER9 systems and code > > accessing this register is not always protected by the CPU_FTR_P9_TIDR > > flag. Fix that to

Re: [PATCH] KVM: PPC: Book3S HV: Use feature flag CPU_FTR_P9_TIDR when accessing TIDR

2020-07-20 Thread Paul Mackerras
On Tue, Jun 23, 2020 at 06:50:27PM +0200, Cédric Le Goater wrote: > The TIDR register is only available on POWER9 systems and code > accessing this register is not always protected by the CPU_FTR_P9_TIDR > flag. Fix that to make sure POWER10 systems won't use it as TIDR has > been removed. I'm

Re: [PATCH v4 5/7] powerpc/iommu: Move iommu_table cleaning routine to iommu_table_clean

2020-07-20 Thread Alexey Kardashevskiy
On 16/07/2020 17:16, Leonardo Bras wrote: > Move the part of iommu_table_free() that does struct iommu_table cleaning > into iommu_table_clean, so we can invoke it separately. > > This new function is useful for cleaning struct iommu_table before > initializing it again with a new DMA window,

Re: [v3 02/15] KVM: PPC: Book3S HV: Cleanup updates for kvm vcpu MMCR

2020-07-20 Thread Paul Mackerras
On Fri, Jul 17, 2020 at 10:38:14AM -0400, Athira Rajeev wrote: > Currently `kvm_vcpu_arch` stores all Monitor Mode Control registers > in a flat array in order: mmcr0, mmcr1, mmcra, mmcr2, mmcrs > Split this to give mmcra and mmcrs its own entries in vcpu and > use a flat array for mmcr0 to mmcr2.

Re: [PATCH v3 0/4] powerpc/mm/radix: Memory unplug fixes

2020-07-20 Thread Aneesh Kumar K.V
On 7/21/20 7:15 AM, Michael Ellerman wrote: Nathan Lynch writes: "Aneesh Kumar K.V" writes: This is the next version of the fixes for memory unplug on radix. The issues and the fix are described in the actual patches. I guess this isn't actually causing problems at runtime right now, but I

Re: [PATCH v4 09/10] powerpc/watchpoint: Return available watchpoints dynamically

2020-07-20 Thread Jordan Niethe
On Tue, Jul 21, 2020 at 1:57 PM Ravi Bangoria wrote: > > > > On 7/20/20 9:12 AM, Jordan Niethe wrote: > > On Fri, Jul 17, 2020 at 2:11 PM Ravi Bangoria > > wrote: > >> > >> So far Book3S Powerpc supported only one watchpoint. Power10 is > >> introducing 2nd DAWR. Enable 2nd DAWR support for

Re: [PATCH v2 13/16] scripts/kallsyms: move ignored symbol types to is_ignored_symbol()

2020-07-20 Thread Finn Thain
On Mon, 20 Jul 2020, Masahiro Yamada wrote: > > I got a similar report before. > > I'd like to know whether or not > this is the same issue as fixed by > 7883a14339299773b2ce08dcfd97c63c199a9289 > The problem can be observed with 3d77e6a8804ab ("Linux 5.7"). So it appears that 7883a14339299

Re: [PATCH v4 09/10] powerpc/watchpoint: Return available watchpoints dynamically

2020-07-20 Thread Ravi Bangoria
On 7/20/20 9:12 AM, Jordan Niethe wrote: On Fri, Jul 17, 2020 at 2:11 PM Ravi Bangoria wrote: So far Book3S Powerpc supported only one watchpoint. Power10 is introducing 2nd DAWR. Enable 2nd DAWR support for Power10. Availability of 2nd DAWR will depend on CPU_FTR_DAWR1. Signed-off-by:

Re: [v3 01/15] powerpc/perf: Update cpu_hw_event to use `struct` for storing MMCR registers

2020-07-20 Thread Jordan Niethe
On Sat, Jul 18, 2020 at 12:48 AM Athira Rajeev wrote: > > core-book3s currently uses array to store the MMCR registers as part > of per-cpu `cpu_hw_events`. This patch does a clean up to use `struct` > to store mmcr regs instead of array. This will make code easier to read > and reduces chance of

Re: [PATCH v3 0/4] powerpc/mm/radix: Memory unplug fixes

2020-07-20 Thread Bharata B Rao
On Tue, Jul 21, 2020 at 11:45:20AM +1000, Michael Ellerman wrote: > Nathan Lynch writes: > > "Aneesh Kumar K.V" writes: > >> This is the next version of the fixes for memory unplug on radix. > >> The issues and the fix are described in the actual patches. > > > > I guess this isn't actually

Re: [PATCH v4 10/10] powerpc/watchpoint: Remove 512 byte boundary

2020-07-20 Thread Ravi Bangoria
Hi Jordan, On 7/20/20 12:24 PM, Jordan Niethe wrote: On Fri, Jul 17, 2020 at 2:11 PM Ravi Bangoria wrote: Power10 has removed 512 bytes boundary from match criteria. i.e. The watch range can cross 512 bytes boundary. It looks like this change is not mentioned in ISA v3.1 Book III 9.4 Data

Re: [powerpc:next-test 103/106] arch/powerpc/mm/book3s64/radix_pgtable.c:513:21: error: use of undeclared identifier 'SECTION_SIZE_BITS'

2020-07-20 Thread Michael Ellerman
Christophe Leroy writes: > "Aneesh Kumar K.V" a écrit : ... >> >> diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c >> b/arch/powerpc/mm/book3s64/radix_pgtable.c >> index bba45fc0b7b2..c5bf2ef73c36 100644 >> --- a/arch/powerpc/mm/book3s64/radix_pgtable.c >> +++

Re: [PATCH 07/11] Powerpc/numa: Detect support for coregroup

2020-07-20 Thread Srikar Dronamraju
* Michael Ellerman [2020-07-20 23:56:19]: > Srikar Dronamraju writes: > > > Add support for grouping cores based on the device-tree classification. > > - The last domain in the associativity domains always refers to the > > core. > > - If primary reference domain happens to be the penultimate

Re: [PATCH v3 0/4] powerpc/mm/radix: Memory unplug fixes

2020-07-20 Thread Michael Ellerman
Nathan Lynch writes: > "Aneesh Kumar K.V" writes: >> This is the next version of the fixes for memory unplug on radix. >> The issues and the fix are described in the actual patches. > > I guess this isn't actually causing problems at runtime right now, but I > notice calls to

Re: Question about NUMA distance calculation in powerpc/mm/numa.c

2020-07-20 Thread Michael Ellerman
Daniel Henrique Barboza writes: > Hello, > > > I didn't find an explanation about the 'double the distance' logic in > 'git log' or anywhere in the kernel docs: > > > (arch/powerpc/mm/numa.c, __node_distance()): Adding more context: int distance = LOCAL_DISTANCE; ... > for (i = 0; i <

Re: [PATCH] powerpc/fault: kernel can extend a user process's stack

2020-07-20 Thread Daniel Axtens
Michael Ellerman writes: > Michal Suchánek writes: >> Hello, >> >> On Wed, Dec 11, 2019 at 08:37:21PM +1100, Daniel Axtens wrote: >>> > Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in >>> > arch/powerpc.") >>> >>> Wow, that's pretty ancient! I'm also not sure it's right - in

Re: [PATCH net-next] net: fs_enet: remove redundant null check

2020-07-20 Thread David Miller
From: Zhang Changzhong Date: Mon, 20 Jul 2020 19:12:33 +0800 > Because clk_prepare_enable and clk_disable_unprepare already > checked NULL clock parameter, so the additional checks are > unnecessary, just remove them. > > Signed-off-by: Zhang Changzhong Applied.

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-07-20 Thread Segher Boessenkool
Hi! On Sat, Jul 18, 2020 at 09:50:50AM +0200, Geert Uytterhoeven wrote: > On Wed, Jun 24, 2020 at 6:02 AM Nathan Chancellor > wrote: > > /* If we have an image attached to us, it overrides anything > > * supplied by the loader. */ > > - if (_initrd_end > _initrd_start) { >

Re: [RFC PATCH] powerpc/pseries/svm: capture instruction faulting on MMIO access, in sprg0 register

2020-07-20 Thread Segher Boessenkool
On Mon, Jul 20, 2020 at 03:10:41PM -0500, Segher Boessenkool wrote: > On Mon, Jul 20, 2020 at 11:39:56AM +0200, Laurent Dufour wrote: > > Le 16/07/2020 à 10:32, Ram Pai a écrit : > > >+ if (is_secure_guest()) {\ > > >+ __asm__ __volatile__("mfsprg0

Re: [RFC PATCH] powerpc/pseries/svm: capture instruction faulting on MMIO access, in sprg0 register

2020-07-20 Thread Segher Boessenkool
On Mon, Jul 20, 2020 at 11:39:56AM +0200, Laurent Dufour wrote: > Le 16/07/2020 à 10:32, Ram Pai a écrit : > >+if (is_secure_guest()) {\ > >+__asm__ __volatile__("mfsprg0 %3;" \ > >+"lnia %2;"

Re: [RFC PATCH 4/7] x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode

2020-07-20 Thread Mathieu Desnoyers
- On Jul 19, 2020, at 11:03 PM, Nicholas Piggin npig...@gmail.com wrote: > Excerpts from Mathieu Desnoyers's message of July 17, 2020 11:42 pm: >> - On Jul 16, 2020, at 7:26 PM, Nicholas Piggin npig...@gmail.com wrote: >> [...] >>> >>> membarrier does replace barrier instructions on

Re: [powerpc:next-test 103/106] arch/powerpc/mm/book3s64/radix_pgtable.c:513:21: error: use of undeclared identifier 'SECTION_SIZE_BITS'

2020-07-20 Thread Christophe Leroy
"Aneesh Kumar K.V" a écrit : kernel test robot writes: tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test head: 5fed3b3e21db21f9a7002426f456fd3a8a8c0772 commit: 21407f39b9d547da527ad5224c4323e1f62bb514 [103/106] powerpc/mm/radix: Create separate

Re: [PATCH v6] ima: move APPRAISE_BOOTPARAM dependency on ARCH_POLICY to runtime

2020-07-20 Thread Bruno Meneguele
On Mon, Jul 20, 2020 at 10:56:55AM -0400, Mimi Zohar wrote: > On Mon, 2020-07-20 at 10:40 -0400, Nayna wrote: > > On 7/13/20 12:48 PM, Bruno Meneguele wrote: > > > The IMA_APPRAISE_BOOTPARAM config allows enabling different > > > "ima_appraise=" > > > modes - log, fix, enforce - at run time, but

Re: [PATCH v6] ima: move APPRAISE_BOOTPARAM dependency on ARCH_POLICY to runtime

2020-07-20 Thread Mimi Zohar
On Mon, 2020-07-20 at 10:40 -0400, Nayna wrote: > On 7/13/20 12:48 PM, Bruno Meneguele wrote: > > The IMA_APPRAISE_BOOTPARAM config allows enabling different "ima_appraise=" > > modes - log, fix, enforce - at run time, but not when IMA architecture > > specific policies are enabled.  This prevents

Re: [PATCH v6] ima: move APPRAISE_BOOTPARAM dependency on ARCH_POLICY to runtime

2020-07-20 Thread Nayna
On 7/13/20 12:48 PM, Bruno Meneguele wrote: The IMA_APPRAISE_BOOTPARAM config allows enabling different "ima_appraise=" modes - log, fix, enforce - at run time, but not when IMA architecture specific policies are enabled.  This prevents properly labeling the filesystem on systems where secure

Re: [FIX PATCH] powerpc/prom: Enable Radix GTSE in cpu pa-features

2020-07-20 Thread Michael Ellerman
On Mon, 20 Jul 2020 10:12:58 +0530, Bharata B Rao wrote: > When '029ab30b4c0a ("powerpc/mm: Enable radix GTSE only if supported.")' > made GTSE an MMU feature, it was enabled by default in > powerpc-cpu-features but was missed in pa-features. This causes > random memory corruption during boot of

Re: [PATCH 11/11] powerpc/smp: Provide an ability to disable coregroup

2020-07-20 Thread Michael Ellerman
Srikar Dronamraju writes: > If user wants to enable coregroup sched_domain then they can boot with > kernel parameter "coregroup_support=on" Why would they want to do that? Adding options like this increases our test matrix by 2x (though in reality the non-default case will never be tested).

Re: [PATCH 07/11] Powerpc/numa: Detect support for coregroup

2020-07-20 Thread Michael Ellerman
Srikar Dronamraju writes: > Add support for grouping cores based on the device-tree classification. > - The last domain in the associativity domains always refers to the > core. > - If primary reference domain happens to be the penultimate domain in > the associativity domains device-tree

Re: [PATCH] powerpc/fault: kernel can extend a user process's stack

2020-07-20 Thread Michael Ellerman
Michal Suchánek writes: > Hello, > > On Wed, Dec 11, 2019 at 08:37:21PM +1100, Daniel Axtens wrote: >> > Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in >> > arch/powerpc.") >> >> Wow, that's pretty ancient! I'm also not sure it's right - in that same >> patch,

Re: [PATCH v4 03/12] powerpc/kexec_file: add helper functions for getting memory ranges

2020-07-20 Thread Hari Bathini
On 20/07/20 6:21 pm, Hari Bathini wrote: > In kexec case, the kernel to be loaded uses the same memory layout as > the running kernel. So, passing on the DT of the running kernel would > be good enough. > > But in case of kdump, different memory ranges are needed to manage > loading the kdump

[PATCH v4 12/12] ppc64/kexec_file: fix kexec load failure with lack of memory hole

2020-07-20 Thread Hari Bathini
The kexec purgatory has to run in real mode. Only the first memory block maybe accessible in real mode. And, unlike the case with panic kernel, no memory is set aside for regular kexec load. Another thing to note is, the memory for crashkernel is reserved at an offset of 128MB. So, when

[PATCH v4 11/12] ppc64/kexec_file: add appropriate regions for memory reserve map

2020-07-20 Thread Hari Bathini
While initrd, elfcorehdr and backup regions are already added to the reserve map, there are a few missing regions that need to be added to the memory reserve map. Add them here. And now that all the changes to load panic kernel are in place, claim likewise. Signed-off-by: Hari Bathini Tested-by:

[PATCH v4 10/12] ppc64/kexec_file: prepare elfcore header for crashing kernel

2020-07-20 Thread Hari Bathini
Prepare elf headers for the crashing kernel's core file using crash_prepare_elf64_headers() and pass on this info to kdump kernel by updating its command line with elfcorehdr parameter. Also, add elfcorehdr location to reserve map to avoid it from being stomped on while booting. Signed-off-by:

[PATCH v4 09/12] ppc64/kexec_file: setup backup region for kdump kernel

2020-07-20 Thread Hari Bathini
Though kdump kernel boots from loaded address, the first 64K bytes of it is copied down to real 0. So, setup a backup region to copy the first 64K bytes of crashed kernel, in purgatory, before booting into kdump kernel. Also, update reserve map with backup region and crashed kernel's memory to

[PATCH v4 08/12] ppc64/kexec_file: setup the stack for purgatory

2020-07-20 Thread Hari Bathini
To avoid any weird errors, the purgatory should run with its own stack. Set one up by adding the stack buffer to .data section of the purgatory. Also, setup opal base & entry values in r8 & r9 registers to help early OPAL debugging. Signed-off-by: Hari Bathini Tested-by: Pingfan Liu

[PATCH v4 07/12] ppc64/kexec_file: add support to relocate purgatory

2020-07-20 Thread Hari Bathini
Right now purgatory implementation is only minimal. But if purgatory code is to be enhanced to copy memory to the backup region and verify sha256 digest, relocations may have to be applied to the purgatory. So, add support to relocate purgatory in kexec_file_load system call by setting up TOC

[PATCH v4 06/12] ppc64/kexec_file: restrict memory usage of kdump kernel

2020-07-20 Thread Hari Bathini
Kdump kernel, used for capturing the kernel core image, is supposed to use only specific memory regions to avoid corrupting the image to be captured. The regions are crashkernel range - the memory reserved explicitly for kdump kernel, memory used for the tce-table, the OPAL region and RTAS region

[PATCH v4 05/12] powerpc/drmem: make lmb walk a bit more flexible

2020-07-20 Thread Hari Bathini
Currently, numa & prom are the users of drmem lmb walk code. Loading kdump with kexec_file also needs to walk the drmem LMBs to setup the usable memory ranges for kdump kernel. But there are couple of issues in using the code as is. One, walk_drmem_lmb() code is built into the .init section

[PATCH v4 02/12] powerpc/kexec_file: mark PPC64 specific code

2020-07-20 Thread Hari Bathini
Some of the kexec_file_load code isn't PPC64 specific. Move PPC64 specific code from kexec/file_load.c to kexec/file_load_64.c. Also, rename purgatory/trampoline.S to purgatory/trampoline_64.S in the same spirit. No functional changes. Signed-off-by: Hari Bathini Tested-by: Pingfan Liu

[PATCH v4 04/12] ppc64/kexec_file: avoid stomping memory used by special regions

2020-07-20 Thread Hari Bathini
crashkernel region could have an overlap with special memory regions like opal, rtas, tce-table & such. These regions are referred to as exclude memory ranges. Setup this ranges during image probe in order to avoid them while finding the buffer for different kdump segments. Override

[PATCH v4 03/12] powerpc/kexec_file: add helper functions for getting memory ranges

2020-07-20 Thread Hari Bathini
In kexec case, the kernel to be loaded uses the same memory layout as the running kernel. So, passing on the DT of the running kernel would be good enough. But in case of kdump, different memory ranges are needed to manage loading the kdump kernel, booting into it and exporting the elfcore of the

[PATCH v4 01/12] kexec_file: allow archs to handle special regions while locating memory hole

2020-07-20 Thread Hari Bathini
Some architectures may have special memory regions, within the given memory range, which can't be used for the buffer in a kexec segment. Implement weak arch_kexec_locate_mem_hole() definition which arch code may override, to take care of special regions, while trying to locate a memory hole.

Re: [PATCH v3] powerpc/pseries: Avoid using addr_to_pfn in realmode

2020-07-20 Thread kernel test robot
Hi Ganesh, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on v5.8-rc6 next-20200720] [cannot apply to mpe/next scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH v4 00/12] ppc64: enable kdump support for kexec_file_load syscall

2020-07-20 Thread Hari Bathini
This patch series enables kdump support for kexec_file_load system call (kexec -s -p) on PPC64. The changes are inspired from kexec-tools code but heavily modified for kernel consumption. The first patch adds a weak arch_kexec_locate_mem_hole() function to override locate memory hole logic

[PATCH net-next] net: fs_enet: remove redundant null check

2020-07-20 Thread Zhang Changzhong
Because clk_prepare_enable and clk_disable_unprepare already checked NULL clock parameter, so the additional checks are unnecessary, just remove them. Signed-off-by: Zhang Changzhong --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 6 ++ 1 file changed, 2 insertions(+), 4

Re: [PATCH] powerpc/fault: kernel can extend a user process's stack

2020-07-20 Thread Michal Suchánek
Hello, On Wed, Dec 11, 2019 at 08:37:21PM +1100, Daniel Axtens wrote: > > Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in > > arch/powerpc.") > > Wow, that's pretty ancient! I'm also not sure it's right - in that same > patch, arch/ppc64/mm/fault.c contains: > > ^1da177e4c3f4

Re: [PATCH 10/11] powerpc/smp: Implement cpu_to_coregroup_id

2020-07-20 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-07-20 14:40:25]: > Hi Srikar, > > > On Mon, Jul 20, 2020 at 11:18:16AM +0530, Srikar Dronamraju wrote: > > * Gautham R Shenoy [2020-07-17 13:56:53]: > > > > > On Tue, Jul 14, 2020 at 10:06:23AM +0530, Srikar Dronamraju wrote: > > > > Lookup the coregroup id from the

Re: [PATCH] HID: udraw-ps3: Replace HTTP links with HTTPS ones

2020-07-20 Thread Jiri Kosina
On Sat, 18 Jul 2020, Bastien Nocera wrote: > > Rationale: > > Reduces attack surface on kernel devs opening the links for MITM > > as HTTPS traffic is much harder to manipulate. > > > > Deterministic algorithm: > > For each file: > > If not .svg: > > For each line: > > If doesn't

Re: [v3 11/15] powerpc/perf: BHRB control to disable BHRB logic when not used

2020-07-20 Thread Gautham R Shenoy
On Fri, Jul 17, 2020 at 10:38:23AM -0400, Athira Rajeev wrote: > PowerISA v3.1 has few updates for the Branch History Rolling Buffer(BHRB). > > BHRB disable is controlled via Monitor Mode Control Register A (MMCRA) > bit, namely "BHRB Recording Disable (BHRBRD)". This field controls > whether

Re: [RFC PATCH] powerpc/pseries/svm: capture instruction faulting on MMIO access, in sprg0 register

2020-07-20 Thread Laurent Dufour
Le 16/07/2020 à 10:32, Ram Pai a écrit : An instruction accessing a mmio address, generates a HDSI fault. This fault is appropriately handled by the Hypervisor. However in the case of secureVMs, the fault is delivered to the ultravisor. Unfortunately the Ultravisor has no correct-way to fetch

Re: [PATCH 10/11] powerpc/smp: Implement cpu_to_coregroup_id

2020-07-20 Thread Gautham R Shenoy
Hi Srikar, On Mon, Jul 20, 2020 at 11:18:16AM +0530, Srikar Dronamraju wrote: > * Gautham R Shenoy [2020-07-17 13:56:53]: > > > On Tue, Jul 14, 2020 at 10:06:23AM +0530, Srikar Dronamraju wrote: > > > Lookup the coregroup id from the associativity array. > > > > > > If unable to detect the

Re: [PATCH 06/11] powerpc/smp: Generalize 2nd sched domain

2020-07-20 Thread Gautham R Shenoy
On Mon, Jul 20, 2020 at 11:49:11AM +0530, Srikar Dronamraju wrote: > * Gautham R Shenoy [2020-07-17 12:07:55]: > > > On Tue, Jul 14, 2020 at 10:06:19AM +0530, Srikar Dronamraju wrote: > > > Currently "CACHE" domain happens to be the 2nd sched domain as per > > > powerpc_topology. This domain

Re: [PATCH 05/11] powerpc/smp: Dont assume l2-cache to be superset of sibling

2020-07-20 Thread Gautham R Shenoy
Hi Srikar, On Mon, Jul 20, 2020 at 12:15:04PM +0530, Srikar Dronamraju wrote: > * Gautham R Shenoy [2020-07-17 11:30:11]: > > > Hi Srikar, > > > > On Tue, Jul 14, 2020 at 10:06:18AM +0530, Srikar Dronamraju wrote: > > > Current code assumes that cpumask of cpus sharing a l2-cache mask will > >

Re: [PATCH 04/11] powerpc/smp: Enable small core scheduling sooner

2020-07-20 Thread Srikar Dronamraju
* Jordan Niethe [2020-07-20 17:47:27]: > On Tue, Jul 14, 2020 at 2:44 PM Srikar Dronamraju > wrote: > > > > Enable small core scheduling as soon as we detect that we are in a > > system that supports thread group. Doing so would avoid a redundant > > check. > > > > Cc: linuxppc-dev > > Cc:

Re: [v3 12/15] powerpc/perf: Add support for outputting extended regs in perf intr_regs

2020-07-20 Thread Athira Rajeev
> On 19-Jul-2020, at 4:47 PM, kernel test robot wrote: > > Hi Athira, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on powerpc/next] > [also build test ERROR on tip/perf/core v5.8-rc5 next-20200717] > [If your patch is applied to the wrong git tree, kindly

Re: [PATCH 02/11] powerpc/smp: Merge Power9 topology with Power topology

2020-07-20 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-07-17 11:14:36]: > Hi Srikar, > > On Tue, Jul 14, 2020 at 10:06:15AM +0530, Srikar Dronamraju wrote: > > A new sched_domain_topology_level was added just for Power9. However the > > same can be achieved by merging powerpc_topology with power9_topology > > and makes the

[PATCH v3] powerpc/pseries: Avoid using addr_to_pfn in realmode

2020-07-20 Thread Ganesh Goudar
When an UE or memory error exception is encountered the MCE handler tries to find the pfn using addr_to_pfn() which takes effective address as an argument, later pfn is used to poison the page where memory error occurred, recent rework in this area made addr_to_pfn to run in realmode, which can be

Re: [PATCH 04/11] powerpc/smp: Enable small core scheduling sooner

2020-07-20 Thread Jordan Niethe
On Tue, Jul 14, 2020 at 2:44 PM Srikar Dronamraju wrote: > > Enable small core scheduling as soon as we detect that we are in a > system that supports thread group. Doing so would avoid a redundant > check. > > Cc: linuxppc-dev > Cc: Michael Ellerman > Cc: Nick Piggin > Cc: Oliver OHalloran >

Re: [PATCH 04/11] powerpc/smp: Enable small core scheduling sooner

2020-07-20 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-07-17 11:18:21]: > On Tue, Jul 14, 2020 at 10:06:17AM +0530, Srikar Dronamraju wrote: > > Enable small core scheduling as soon as we detect that we are in a > > system that supports thread group. Doing so would avoid a redundant > > check. > > > > Cc: linuxppc-dev > >

Re: [PATCH v4 10/10] powerpc/watchpoint: Remove 512 byte boundary

2020-07-20 Thread Jordan Niethe
On Fri, Jul 17, 2020 at 2:11 PM Ravi Bangoria wrote: > > Power10 has removed 512 bytes boundary from match criteria. i.e. The watch > range can cross 512 bytes boundary. It looks like this change is not mentioned in ISA v3.1 Book III 9.4 Data Address Watchpoint. It could be useful to mention that

Re: [PATCH 05/11] powerpc/smp: Dont assume l2-cache to be superset of sibling

2020-07-20 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-07-17 11:30:11]: > Hi Srikar, > > On Tue, Jul 14, 2020 at 10:06:18AM +0530, Srikar Dronamraju wrote: > > Current code assumes that cpumask of cpus sharing a l2-cache mask will > > always be a superset of cpu_sibling_mask. > > > > Lets stop that assumption. > > > > Cc:

Re: [PATCH 5/5] cpuidle-pseries: Block Extended CEDE(1) which adds no additional value.

2020-07-20 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:39]: > From: "Gautham R. Shenoy" > > The Extended CEDE state with latency-hint = 1 is only different from > normal CEDE (with latency-hint = 0) in that a CPU in Extended CEDE(1) > does not wakeup on timer events. Both CEDE and Extended CEDE(1) map to > the

Re: [PATCH 4/5] cpuidle-pseries : Include extended CEDE states in cpuidle framework

2020-07-20 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:38]: > From: "Gautham R. Shenoy" > > This patch exposes those extended CEDE states to the cpuidle framework > which are responsive to external interrupts and do not need an H_PROD. > > Since as per the PAPR, all the extended CEDE states are non-responsive

Re: [PATCH 3/5] cpuidle-pseries : Fixup exit latency for CEDE(0)

2020-07-20 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:37]: > From: "Gautham R. Shenoy" > > We are currently assuming that CEDE(0) has exit latency 10us, since > there is no way for us to query from the platform. However, if the > wakeup latency of an Extended CEDE state is smaller than 10us, then we > can be

Re: [PATCH 3/5] dma-mapping: make support for dma ops optional

2020-07-20 Thread Christoph Hellwig
On Sat, Jul 18, 2020 at 10:17:14AM -0700, Guenter Roeck wrote: > On Wed, Jul 08, 2020 at 05:24:47PM +0200, Christoph Hellwig wrote: > > Avoid the overhead of the dma ops support for tiny builds that only > > use the direct mapping. > > > > Signed-off-by: Christoph Hellwig > > For

Re: [PATCH 06/11] powerpc/smp: Generalize 2nd sched domain

2020-07-20 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-07-17 12:07:55]: > On Tue, Jul 14, 2020 at 10:06:19AM +0530, Srikar Dronamraju wrote: > > Currently "CACHE" domain happens to be the 2nd sched domain as per > > powerpc_topology. This domain will collapse if cpumask of l2-cache is > > same as SMT domain. However we could

Re: [FIX PATCH] powerpc/prom: Enable Radix GTSE in cpu pa-features

2020-07-20 Thread Bharata B Rao
On Mon, Jul 20, 2020 at 03:38:29PM +1000, Nicholas Piggin wrote: > Excerpts from Bharata B Rao's message of July 20, 2020 2:42 pm: > > diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c > > index 9cc49f265c86..a9594bad572a 100644 > > --- a/arch/powerpc/kernel/prom.c > > +++

Re: [PATCH v6 03/23] powerpc/book3s64/pkeys: pkeys are supported only on hash on book3s.

2020-07-20 Thread Aneesh Kumar K.V
On 7/20/20 11:35 AM, Michael Ellerman wrote: "Aneesh Kumar K.V" writes: Move them to hash specific file and add BUG() for radix path. --- .../powerpc/include/asm/book3s/64/hash-pkey.h | 32 arch/powerpc/include/asm/book3s/64/pkeys.h| 25 +

Re: [PATCH 2/5] cpuidle-pseries: Add function to parse extended CEDE records

2020-07-20 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:36]: > From: "Gautham R. Shenoy" > > Currently we use CEDE with latency-hint 0 as the only other idle state > on a dedicated LPAR apart from the polling "snooze" state. > > The platform might support additional extended CEDE idle states, which > can be

Re: [PATCH v6 03/23] powerpc/book3s64/pkeys: pkeys are supported only on hash on book3s.

2020-07-20 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > Move them to hash specific file and add BUG() for radix path. > --- > .../powerpc/include/asm/book3s/64/hash-pkey.h | 32 > arch/powerpc/include/asm/book3s/64/pkeys.h| 25 + > arch/powerpc/include/asm/pkeys.h | 37

Re: [PATCH 09/11] Powerpc/smp: Create coregroup domain

2020-07-20 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-07-17 13:49:26]: > On Tue, Jul 14, 2020 at 10:06:22AM +0530, Srikar Dronamraju wrote: > > Add percpu coregroup maps and masks to create coregroup domain. > > If a coregroup doesn't exist, the coregroup domain will be degenerated > > in favour of SMT/CACHE domain. > > >