Re: [kvm-unit-tests PATCH 03/32] powerpc: Fix stack backtrace termination

2024-03-04 Thread Thomas Huth
On 05/03/2024 07.29, Nicholas Piggin wrote: On Tue Feb 27, 2024 at 6:50 PM AEST, Thomas Huth wrote: On 26/02/2024 11.11, Nicholas Piggin wrote: ... /* save DTB pointer */ - std r3, 56(r1) + SAVE_GPR(3,r1) Isn't SAVE_GPR rather meant for the interrupt frame, not for

Re: [kvm-unit-tests PATCH 7/7] common: add memory dirtying vs migration test

2024-03-04 Thread Thomas Huth
On 05/03/2024 03.50, Nicholas Piggin wrote: On Mon Mar 4, 2024 at 4:22 PM AEST, Thomas Huth wrote: On 26/02/2024 10.38, Nicholas Piggin wrote: This test stores to a bunch of pages and verifies previous stores, while being continually migrated. This can fail due to a QEMU TCG physical memory

Re: [kvm-unit-tests PATCH 6/7] gitlab-ci: Run migration selftest on s390x and powerpc

2024-03-04 Thread Thomas Huth
On 05/03/2024 03.38, Nicholas Piggin wrote: On Sat Mar 2, 2024 at 12:16 AM AEST, Thomas Huth wrote: On 26/02/2024 10.38, Nicholas Piggin wrote: The migration harness is complicated and easy to break so CI will be helpful. Signed-off-by: Nicholas Piggin --- .gitlab-ci.yml | 18

Re: [kvm-unit-tests PATCH 03/32] powerpc: Fix stack backtrace termination

2024-03-04 Thread Nicholas Piggin
On Tue Feb 27, 2024 at 6:50 PM AEST, Thomas Huth wrote: > On 26/02/2024 11.11, Nicholas Piggin wrote: > > The backtrace handler terminates when it sees a NULL caller address, > > but the powerpc stack setup does not keep such a NULL caller frame > > at the start of the stack. > > > > This happens

Re: [kvm-unit-tests PATCH 14/32] powerpc: general interrupt tests

2024-03-04 Thread Thomas Huth
On 05/03/2024 03.19, Nicholas Piggin wrote: On Fri Mar 1, 2024 at 10:41 PM AEST, Thomas Huth wrote: On 26/02/2024 11.12, Nicholas Piggin wrote: Add basic testing of various kinds of interrupts, machine check, page fault, illegal, decrementer, trace, syscall, etc. This has a known failure on

Re: [kvm-unit-tests PATCH 14/32] powerpc: general interrupt tests

2024-03-04 Thread Thomas Huth
On 05/03/2024 03.30, Nicholas Piggin wrote: On Fri Mar 1, 2024 at 11:45 PM AEST, Andrew Jones wrote: On Fri, Mar 01, 2024 at 01:41:22PM +0100, Thomas Huth wrote: On 26/02/2024 11.12, Nicholas Piggin wrote: Add basic testing of various kinds of interrupts, machine check, page fault, illegal,

[PATCH v3 10/10] mm/treewide: Align up pXd_leaf() retval across archs

2024-03-04 Thread peterx
From: Peter Xu Even if pXd_leaf() API is defined globally, it's not clear on the retval, and there are three types used (bool, int, unsigned log). Always return a boolean for pXd_leaf() APIs. Suggested-by: Jason Gunthorpe Signed-off-by: Peter Xu --- arch/riscv/include/asm/pgtable-64.h | 2

[PATCH v3 09/10] mm/treewide: Drop pXd_large()

2024-03-04 Thread peterx
From: Peter Xu They're not used anymore, drop all of them. Reviewed-by: Jason Gunthorpe Signed-off-by: Peter Xu --- arch/arm/include/asm/pgtable-2level.h| 1 - arch/arm/include/asm/pgtable-3level.h| 1 - arch/loongarch/kvm/mmu.c | 2 +-

[PATCH v3 08/10] mm/treewide: Replace pud_large() with pud_leaf()

2024-03-04 Thread peterx
From: Peter Xu pud_large() is always defined as pud_leaf(). Merge their usages. Chose pud_leaf() because pud_leaf() is a global API, while pud_large() is not. Reviewed-by: Jason Gunthorpe Signed-off-by: Peter Xu --- arch/powerpc/mm/book3s64/pgtable.c | 2 +- arch/s390/boot/vmem.c

[PATCH v3 07/10] mm/treewide: Replace pmd_large() with pmd_leaf()

2024-03-04 Thread peterx
From: Peter Xu pmd_large() is always defined as pmd_leaf(). Merge their usages. Chose pmd_leaf() because pmd_leaf() is a global API, while pmd_large() is not. Reviewed-by: Jason Gunthorpe Signed-off-by: Peter Xu --- arch/arm/mm/dump.c | 4 ++--

[PATCH v3 06/10] mm/kasan: Use pXd_leaf() in shadow_mapped()

2024-03-04 Thread peterx
From: Peter Xu There is an old trick in shadow_mapped() to use pXd_bad() to detect huge pages. After commit 93fab1b22ef7 ("mm: add generic p?d_leaf() macros") we have a global API for huge mappings. Use that to replace the trick. Cc: Andrey Ryabinin Cc: Alexander Potapenko Cc: Andrey

[PATCH v3 05/10] mm/x86: Drop two unnecessary pud_leaf() definitions

2024-03-04 Thread peterx
From: Peter Xu pud_leaf() has a fallback macro defined in include/linux/pgtable.h already. Drop the extra two for x86. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: x...@kernel.org Reviewed-by: Jason Gunthorpe Acked-by: Thomas Gleixner Signed-off-by: Peter Xu

[PATCH v3 04/10] mm/x86: Replace pgd_large() with pgd_leaf()

2024-03-04 Thread peterx
From: Peter Xu pgd_leaf() is a global API while pgd_large() is not. Always use the global pgd_leaf(), then drop pgd_large(). Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: x...@kernel.org Signed-off-by: Peter Xu --- arch/x86/include/asm/pgtable.h | 4 ++--

[PATCH v3 03/10] mm/x86: Replace p4d_large() with p4d_leaf()

2024-03-04 Thread peterx
From: Peter Xu p4d_large() is always defined as p4d_leaf(). Merge their usages. Chose p4d_leaf() because p4d_leaf() is a global API, while p4d_large() is not. Only x86 has p4d_leaf() defined as of now. So it also means after this patch we removed all p4d_large() usages. Cc: Thomas Gleixner

[PATCH v3 02/10] mm/ppc: Replace pXd_is_leaf() with pXd_leaf()

2024-03-04 Thread peterx
From: Peter Xu They're the same macros underneath. Drop pXd_is_leaf(), instead always use pXd_leaf(). At the meantime, instead of renames, drop the pXd_is_leaf() fallback definitions directly in arch/powerpc/include/asm/pgtable.h. because similar fallback macros for pXd_leaf() are already

[PATCH v3 01/10] mm/ppc: Define pXd_large() with pXd_leaf()

2024-03-04 Thread peterx
From: Peter Xu The two definitions are the same. The only difference is that pXd_large() is only defined with THP selected, and only on book3s 64bits. Instead of implementing it twice, make pXd_large() a macro to pXd_leaf(). Define it unconditionally just like pXd_leaf(). This helps to

[PATCH v3 00/10] mm/treewide: Replace pXd_large() with pXd_leaf()

2024-03-04 Thread peterx
From: Peter Xu [based on latest akpm/mm-unstable, commit b38c34939fe4] v3: - Added three patches - mm/treewide: Align up pXd_leaf() retval across archs Per request from Jason to further cleanup the retvals - mm/kasan: Use pXd_leaf() in shadow_mapped() Something I spot when saw a

Re: [PATCH v2 4/7] mm/x86: Drop two unnecessary pud_leaf() definitions

2024-03-04 Thread Peter Xu
On Mon, Mar 04, 2024 at 09:03:34AM -0400, Jason Gunthorpe wrote: > On Thu, Feb 29, 2024 at 04:42:55PM +0800, pet...@redhat.com wrote: > > From: Peter Xu > > > > pud_leaf() has a fallback macro defined in include/linux/pgtable.h already. > > Drop the extra two for x86. > > > > Cc: Thomas

Re: [kvm-unit-tests PATCH 5/7] arch-run: Add a "continuous" migration option for tests

2024-03-04 Thread Nicholas Piggin
On Mon Mar 4, 2024 at 7:19 PM AEST, Andrew Jones wrote: > On Mon, Mar 04, 2024 at 07:17:35AM +0100, Thomas Huth wrote: > > On 26/02/2024 10.38, Nicholas Piggin wrote: > > > The cooperative migration protocol is very good to control precise > > > pre and post conditions for a migration event.

Re: [kvm-unit-tests PATCH 7/7] common: add memory dirtying vs migration test

2024-03-04 Thread Nicholas Piggin
On Mon Mar 4, 2024 at 4:22 PM AEST, Thomas Huth wrote: > On 26/02/2024 10.38, Nicholas Piggin wrote: > > This test stores to a bunch of pages and verifies previous stores, > > while being continually migrated. This can fail due to a QEMU TCG > > physical memory dirty bitmap bug. > > Good idea, but

Re: [kvm-unit-tests PATCH 5/7] arch-run: Add a "continuous" migration option for tests

2024-03-04 Thread Nicholas Piggin
On Mon Mar 4, 2024 at 4:17 PM AEST, Thomas Huth wrote: > On 26/02/2024 10.38, Nicholas Piggin wrote: > > The cooperative migration protocol is very good to control precise > > pre and post conditions for a migration event. However in some cases > > its intrusiveness to the test program, can mask

Re: [kvm-unit-tests PATCH 6/7] gitlab-ci: Run migration selftest on s390x and powerpc

2024-03-04 Thread Nicholas Piggin
On Sat Mar 2, 2024 at 12:16 AM AEST, Thomas Huth wrote: > On 26/02/2024 10.38, Nicholas Piggin wrote: > > The migration harness is complicated and easy to break so CI will > > be helpful. > > > > Signed-off-by: Nicholas Piggin > > --- > > .gitlab-ci.yml | 18 +++--- > > 1 file

Re: [kvm-unit-tests PATCH 14/32] powerpc: general interrupt tests

2024-03-04 Thread Nicholas Piggin
On Sat Mar 2, 2024 at 12:14 AM AEST, Andrew Jones wrote: > On Fri, Mar 01, 2024 at 02:57:04PM +0100, Thomas Huth wrote: > > On 01/03/2024 14.45, Andrew Jones wrote: > > > On Fri, Mar 01, 2024 at 01:41:22PM +0100, Thomas Huth wrote: > > > > On 26/02/2024 11.12, Nicholas Piggin wrote: > > > > > Add

Re: [kvm-unit-tests PATCH 14/32] powerpc: general interrupt tests

2024-03-04 Thread Nicholas Piggin
On Fri Mar 1, 2024 at 11:45 PM AEST, Andrew Jones wrote: > On Fri, Mar 01, 2024 at 01:41:22PM +0100, Thomas Huth wrote: > > On 26/02/2024 11.12, Nicholas Piggin wrote: > > > Add basic testing of various kinds of interrupts, machine check, > > > page fault, illegal, decrementer, trace, syscall,

Re: [kvm-unit-tests PATCH 1/7] arch-run: Keep infifo open

2024-03-04 Thread Nicholas Piggin
On Fri Mar 1, 2024 at 11:32 PM AEST, Thomas Huth wrote: > On 26/02/2024 10.38, Nicholas Piggin wrote: > > The infifo fifo that is used to send characters to QEMU console is > > only able to receive one character before the cat process exits. > > Supporting interactions between test and harness

Re: [kvm-unit-tests PATCH 14/32] powerpc: general interrupt tests

2024-03-04 Thread Nicholas Piggin
On Fri Mar 1, 2024 at 10:41 PM AEST, Thomas Huth wrote: > On 26/02/2024 11.12, Nicholas Piggin wrote: > > Add basic testing of various kinds of interrupts, machine check, > > page fault, illegal, decrementer, trace, syscall, etc. > > > > This has a known failure on QEMU TCG pseries machines where

Re: [kvm-unit-tests PATCH 12/32] powerpc: Fix emulator illegal instruction test for powernv

2024-03-04 Thread Nicholas Piggin
On Fri Mar 1, 2024 at 9:50 PM AEST, Thomas Huth wrote: > On 26/02/2024 11.11, Nicholas Piggin wrote: > > Illegal instructions cause 0xe40 (HEAI) interrupts rather > > than program interrupts. > > > > Acked-by: Thomas Huth > > Signed-off-by: Nicholas Piggin > > --- > >

Re: [kvm-unit-tests PATCH 07/32] powerpc/sprs: Don't fail changed SPRs that are used by the test harness

2024-03-04 Thread Nicholas Piggin
On Fri Mar 1, 2024 at 9:15 PM AEST, Thomas Huth wrote: > On 26/02/2024 11.11, Nicholas Piggin wrote: > > SPRs annotated with SPR_HARNESS can change between consecutive reads > > because the test harness code has changed them. Avoid failing the > > test in this case. > > > > Signed-off-by:

Re: [kvm-unit-tests PATCH 04/32] powerpc: interrupt stack backtracing

2024-03-04 Thread Nicholas Piggin
On Fri Mar 1, 2024 at 7:53 PM AEST, Thomas Huth wrote: > On 26/02/2024 11.11, Nicholas Piggin wrote: > > Add support for backtracing across interrupt stacks, and > > add interrupt frame backtrace for unhandled interrupts. > > > > Signed-off-by: Nicholas Piggin > > --- > >

Re: [kvm-unit-tests PATCH 03/32] powerpc: Fix stack backtrace termination

2024-03-04 Thread Nicholas Piggin
On Fri Mar 1, 2024 at 7:45 PM AEST, Thomas Huth wrote: > On 27/02/2024 09.50, Thomas Huth wrote: > > On 26/02/2024 11.11, Nicholas Piggin wrote: > >> The backtrace handler terminates when it sees a NULL caller address, > >> but the powerpc stack setup does not keep such a NULL caller frame > >> at

Re: BUG: Bad page map in process init pte:c0ab684c pmd:01182000 (on a PowerMac G4 DP)

2024-03-04 Thread Erhard Furtner
On Thu, 29 Feb 2024 17:11:28 + Christophe Leroy wrote: > Interesting. > > I guess 0xe000 is where linear RAM starts to be mapped with pages ? > Can you confirm with a dump of > /sys/kernel/debug/powerpc/block_address_translation ? # cat

Re: [RFC v2.1 07/12] powerpc: Use initializer for struct vm_unmapped_area_info

2024-03-04 Thread Michael Ellerman
Rick Edgecombe writes: > Future changes will need to add a new member to struct > vm_unmapped_area_info. This would cause trouble for any call site that > doesn't initialize the struct. Currently every caller sets each field > manually, so if new fields are added they will be unitialized and the

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Michael Ellerman
Jani Nikula writes: > On Mon, 04 Mar 2024, Jani Nikula wrote: >> Removal of the backlight include from fb.h uncovered an implicit >> dependency in powerpc asm/backlight.h. Add the explicit include. >> >> Reported-by: Naresh Kamboju >> Closes: >>

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Michael Ellerman
Christophe Leroy writes: > Le 04/03/2024 à 11:32, Thomas Zimmermann a écrit : >> Hi >> >> Am 04.03.24 um 10:55 schrieb Jani Nikula: >>> Removal of the backlight include from fb.h uncovered an implicit >>> dependency in powerpc asm/backlight.h. Add the explicit include. >>> >>> Reported-by:

Re: [PATCH] powerpc/pseries: fix max polling time in plpks_confirm_object_flushed() function

2024-03-04 Thread Michael Ellerman
Nayna Jain writes: > usleep_range() function takes input time and range in usec. However, > currently it is assumed in msec in the function > plpks_confirm_object_flushed(). > > Fix the total polling time for the object flushing from 5msec to 5sec. > > Reported-by: Nageswara R Sastry > Fixes:

Re: [PATCH 00/11] misc: Convert to platform remove callback returning void

2024-03-04 Thread Greg Kroah-Hartman
On Mon, Mar 04, 2024 at 11:36:23PM +0100, Uwe Kleine-König wrote: > Hello Arnd, hello Greg, > > On Wed, Feb 21, 2024 at 02:52:29PM +0100, Arnd Bergmann wrote: > > On Wed, Feb 21, 2024, at 10:53, Uwe Kleine-König wrote: > > > Hello, > > > > > > this series converts all drivers below drivers/misc

Re: [PATCH v5 0/6] DCP as trusted keys backend

2024-03-04 Thread Jarkko Sakkinen
On Tue Dec 19, 2023 at 2:45 AM EET, Paul Moore wrote: > On Fri, Dec 15, 2023 at 6:07 AM David Gstir wrote: > > > > This is a revival of the previous patch set submitted by Richard Weinberger: > > https://lore.kernel.org/linux-integrity/20210614201620.30451-1-rich...@nod.at/ > > > > v4 is here: >

Re: [PATCH v5 4/6] MAINTAINERS: add entry for DCP-based trusted keys

2024-03-04 Thread Jarkko Sakkinen
On Fri Dec 15, 2023 at 1:06 PM EET, David Gstir wrote: > This covers trusted keys backed by NXP's DCP (Data Co-Processor) chip > found in smaller i.MX SoCs. > > Signed-off-by: David Gstir > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS

Re: [PATCH v5 3/6] KEYS: trusted: Introduce NXP DCP-backed trusted keys

2024-03-04 Thread Jarkko Sakkinen
On Fri Dec 15, 2023 at 1:06 PM EET, David Gstir wrote: > DCP (Data Co-Processor) is the little brother of NXP's CAAM IP. > Beside of accelerated crypto operations, it also offers support for Why acronym is not opened already in the first patch? Also, that does not mean it could not be opened also

Re: [PATCH 00/11] misc: Convert to platform remove callback returning void

2024-03-04 Thread Uwe Kleine-König
Hello Arnd, hello Greg, On Wed, Feb 21, 2024 at 02:52:29PM +0100, Arnd Bergmann wrote: > On Wed, Feb 21, 2024, at 10:53, Uwe Kleine-König wrote: > > Hello, > > > > this series converts all drivers below drivers/misc to struct > > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:

Re: [PATCH v5 2/6] KEYS: trusted: improve scalability of trust source config

2024-03-04 Thread Jarkko Sakkinen
On Fri Dec 15, 2023 at 1:06 PM EET, David Gstir wrote: > Checking if at least one valid trust source is selected does not scale > and becomes hard to read. This improves this in preparation for the DCP > trust source. This commit needs a complete rewrite and I do not have time and energy to

Re: [PATCH v5 1/6] crypto: mxs-dcp: Add support for hardware-bound keys

2024-03-04 Thread Jarkko Sakkinen
Further remarks. On Fri Dec 15, 2023 at 1:06 PM EET, David Gstir wrote: > DCP is capable of performing AES with two hardware-bound keys: > > - The one-time programmable (OTP) key which is burnt via on-chip fuses > - The unique key (UK) which is derived from the OTP key > > In addition to the two

Re: [PATCH v5 1/6] crypto: mxs-dcp: Add support for hardware-bound keys

2024-03-04 Thread Jarkko Sakkinen
On Fri Dec 15, 2023 at 1:06 PM EET, David Gstir wrote: > DCP is capable of performing AES with two hardware-bound keys: > > - The one-time programmable (OTP) key which is burnt via on-chip fuses > - The unique key (UK) which is derived from the OTP key This is somewhat cryptic explanation for the

Re: [PATCH] powerpc/pseries: fix max polling time in plpks_confirm_object_flushed() function

2024-03-04 Thread Christophe Leroy
Le 04/03/2024 à 07:53, Nayna Jain a écrit : > [Vous ne recevez pas souvent de courriers de na...@linux.ibm.com. Découvrez > pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > usleep_range() function takes input time and range in usec. However, > currently it is

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Christophe Leroy
Le 04/03/2024 à 11:32, Thomas Zimmermann a écrit : > Hi > > Am 04.03.24 um 10:55 schrieb Jani Nikula: >> Removal of the backlight include from fb.h uncovered an implicit >> dependency in powerpc asm/backlight.h. Add the explicit include. >> >> Reported-by: Naresh Kamboju >> Closes: >>

Re: [PATCH v2 5/9] mm: Initialize struct vm_unmapped_area_info

2024-03-04 Thread Edgecombe, Rick P
On Mon, 2024-03-04 at 18:00 +, Christophe Leroy wrote: > > Personally, I think a single patch that sets "= {}" for all of them > > and > > drop the all the "= 0" or "= NULL" assignments would be the > > cleanest way > > to go. > > I agree with Kees, set = {} and drop all the "something = 0;"

Re: [PATCH v2 5/9] mm: Initialize struct vm_unmapped_area_info

2024-03-04 Thread Christophe Leroy
Le 02/03/2024 à 02:51, Kees Cook a écrit : > On Sat, Mar 02, 2024 at 12:47:08AM +, Edgecombe, Rick P wrote: >> On Wed, 2024-02-28 at 09:21 -0800, Kees Cook wrote: >>> I totally understand. If the "uninitialized" warnings were actually >>> reliable, I would agree. I look at it this way: >>>

[PATCH v2] usb: gadget: fsl-udc: Replace custom log wrappers by dev_{err,warn,dbg,vdbg}

2024-03-04 Thread Uwe Kleine-König
The custom log wrappers ERR, WARNING, DBG and VDBG don't add anything useful that cannot easily be done with dev_err() and friends. Replace the custom stuff by the well known functions from printk.h. Also drop some dead code in a #if 0 block. Signed-off-by: Uwe Kleine-König --- Changes since

Re: [PATCH v8 03/10] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST#

2024-03-04 Thread Manivannan Sadhasivam
On Mon, Mar 04, 2024 at 11:51:04AM +0100, Niklas Cassel wrote: > On Mon, Mar 04, 2024 at 01:47:13PM +0530, Manivannan Sadhasivam wrote: > > On Thu, Feb 29, 2024 at 01:40:29PM +0100, Niklas Cassel wrote: > > > On Sat, Feb 24, 2024 at 12:24:09PM +0530, Manivannan Sadhasivam wrote: > > > > > > Since

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Naresh Kamboju
Hi Jani and Benjamin, On Mon, 4 Mar 2024 at 15:31, Jani Nikula wrote: > > On Mon, 04 Mar 2024, Jani Nikula wrote: > > Removal of the backlight include from fb.h uncovered an implicit > > dependency in powerpc asm/backlight.h. Add the explicit include. > > > > Reported-by: Naresh Kamboju > >

Re: [PATCHv11 2/4] genirq: Provide a snapshot mechanism for interrupt statistics

2024-03-04 Thread Thomas Gleixner
On Mon, Mar 04 2024 at 20:00, Bitao Hu wrote: >> +# Snapshot for interrupt statistics >> +config GENERIC_IRQ_STAT_SNAPSHOT >> +bool >> + >> # Support forced irq threading >> config IRQ_FORCED_THREADING >> bool > > I think we should follow Douglas's suggestion by making > "config

Re: [PATCH v2 4/7] mm/x86: Drop two unnecessary pud_leaf() definitions

2024-03-04 Thread Thomas Gleixner
On Thu, Feb 29 2024 at 16:42, pet...@redhat.com wrote: > From: Peter Xu > > pud_leaf() has a fallback macro defined in include/linux/pgtable.h already. > Drop the extra two for x86. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x...@kernel.org >

Re: [PATCH v2 7/7] mm/treewide: Drop pXd_large()

2024-03-04 Thread Jason Gunthorpe
On Thu, Feb 29, 2024 at 04:42:58PM +0800, pet...@redhat.com wrote: > From: Peter Xu > > They're not used anymore, drop all of them. > > Signed-off-by: Peter Xu > --- > arch/arm/include/asm/pgtable-2level.h| 1 - > arch/arm/include/asm/pgtable-3level.h| 1 - >

Re: [PATCH v2 6/7] mm/treewide: Replace pud_large() with pud_leaf()

2024-03-04 Thread Jason Gunthorpe
On Thu, Feb 29, 2024 at 04:42:57PM +0800, pet...@redhat.com wrote: > From: Peter Xu > > pud_large() is always defined as pud_leaf(). Merge their usages. Chose > pud_leaf() because pud_leaf() is a global API, while pud_large() is not. > > Signed-off-by: Peter Xu > --- >

Re: [PATCH v2 5/7] mm/treewide: Replace pmd_large() with pmd_leaf()

2024-03-04 Thread Jason Gunthorpe
On Thu, Feb 29, 2024 at 04:42:56PM +0800, pet...@redhat.com wrote: > From: Peter Xu > > pmd_large() is always defined as pmd_leaf(). Merge their usages. Chose > pmd_leaf() because pmd_leaf() is a global API, while pmd_large() is not. > > Signed-off-by: Peter Xu > --- > arch/arm/mm/dump.c

Re: [PATCH v2 4/7] mm/x86: Drop two unnecessary pud_leaf() definitions

2024-03-04 Thread Jason Gunthorpe
On Thu, Feb 29, 2024 at 04:42:55PM +0800, pet...@redhat.com wrote: > From: Peter Xu > > pud_leaf() has a fallback macro defined in include/linux/pgtable.h already. > Drop the extra two for x86. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc:

Re: [PATCH v2 3/7] mm/x86: Replace p4d_large() with p4d_leaf()

2024-03-04 Thread Jason Gunthorpe
On Thu, Feb 29, 2024 at 04:42:54PM +0800, pet...@redhat.com wrote: > From: Peter Xu > > p4d_large() is always defined as p4d_leaf(). Merge their usages. Chose > p4d_leaf() because p4d_leaf() is a global API, while p4d_large() is not. > > Only x86 has p4d_leaf() defined as of now. So it also

Re: [PATCH v2 2/7] mm/ppc: Replace pXd_is_leaf() with pXd_leaf()

2024-03-04 Thread Jason Gunthorpe
On Thu, Feb 29, 2024 at 04:42:53PM +0800, pet...@redhat.com wrote: > From: Peter Xu > > They're the same macros underneath. Drop pXd_is_leaf(), instead always use > pXd_leaf(). > > At the meantime, instead of renames, drop the pXd_is_leaf() fallback > definitions directly in

Re: [PATCH v2 1/7] mm/ppc: Define pXd_large() with pXd_leaf()

2024-03-04 Thread Jason Gunthorpe
On Thu, Feb 29, 2024 at 04:42:52PM +0800, pet...@redhat.com wrote: > From: Peter Xu > > The two definitions are the same. The only difference is that pXd_large() > is only defined with THP selected, and only on book3s 64bits. > > Instead of implementing it twice, make pXd_large() a macro to

Re: [PATCH] usb: gadget: fsl-udc: Replace custom log wrappers by pr_{err,warn,debug}

2024-03-04 Thread Greg Kroah-Hartman
On Mon, Mar 04, 2024 at 01:11:53PM +0100, Uwe Kleine-König wrote: > The custom log wrappers ERR, WARNING and DBG don't add anything useful > that cannot easily be done with pr_err() and friends. Replace the custom > stuff by the well known functions from printk.h. These really should be dev_*()

[PATCH] usb: gadget: fsl-udc: Replace custom log wrappers by pr_{err,warn,debug}

2024-03-04 Thread Uwe Kleine-König
The custom log wrappers ERR, WARNING and DBG don't add anything useful that cannot easily be done with pr_err() and friends. Replace the custom stuff by the well known functions from printk.h. Signed-off-by: Uwe Kleine-König --- Hello, I didn't replace VDBG by pr_vdebug because the latter

Re: [PATCHv11 2/4] genirq: Provide a snapshot mechanism for interrupt statistics

2024-03-04 Thread Bitao Hu
Hi, On 2024/3/2 03:22, Thomas Gleixner wrote: Doug! On Wed, Feb 28 2024 at 14:44, Doug Anderson wrote: I won't insist on it, but I continue to worry about memory implications with large numbers of CPUs. With a 4-byte int, 8192 max CPUs, and 100 IRQs the extra "ref" value takes up over 3MB of

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-03-04 Thread Tasmiya Nalatwad
Greetings, The build error is seen on linux-next and mainline also Mainline : 6.8.0-rc7 linux-next : 6.8.0-rc7-next-20240304 --- Traces --- net/core/dev.c: In function ‘netdev_dpll_pin_assign’: ./include/linux/rcupdate.h:462:36: error: dereferencing pointer to incomplete type ‘struct

Re: [PATCH v8 03/10] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST#

2024-03-04 Thread Niklas Cassel
On Mon, Mar 04, 2024 at 01:47:13PM +0530, Manivannan Sadhasivam wrote: > On Thu, Feb 29, 2024 at 01:40:29PM +0100, Niklas Cassel wrote: > > On Sat, Feb 24, 2024 at 12:24:09PM +0530, Manivannan Sadhasivam wrote: > > > > Since e.g. qcom-ep.c does a reset_control_assert() during perst > >

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Thomas Zimmermann
Am 04.03.24 um 11:32 schrieb Thomas Zimmermann: [...] ---   arch/powerpc/include/asm/backlight.h | 1 +   1 file changed, 1 insertion(+) diff --git a/arch/powerpc/include/asm/backlight.h b/arch/powerpc/include/asm/backlight.h index 1b5eab62ed04..275d5bb9aa04 100644 ---

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Thomas Zimmermann
Hi Am 04.03.24 um 10:55 schrieb Jani Nikula: Removal of the backlight include from fb.h uncovered an implicit dependency in powerpc asm/backlight.h. Add the explicit include. Reported-by: Naresh Kamboju Closes:

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Jani Nikula
On Mon, 04 Mar 2024, Jani Nikula wrote: > Removal of the backlight include from fb.h uncovered an implicit > dependency in powerpc asm/backlight.h. Add the explicit include. > > Reported-by: Naresh Kamboju > Closes: >

[PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Jani Nikula
Removal of the backlight include from fb.h uncovered an implicit dependency in powerpc asm/backlight.h. Add the explicit include. Reported-by: Naresh Kamboju Closes: https://lore.kernel.org/r/ca+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu75yi...@mail.gmail.com Fixes: 11b4eedfc87d ("fbdev: Do not

[PATCH v9 10/10] PCI: dwc: ep: Add Kernel-doc comments for APIs

2024-03-04 Thread Manivannan Sadhasivam
All of the APIs are missing the Kernel-doc comments. Hence, add them. Reviewed-by: Frank Li Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-designware-ep.c | 94 + 1 file changed, 94 insertions(+) diff --git

[PATCH v9 09/10] PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event

2024-03-04 Thread Manivannan Sadhasivam
Now that the API is available, let's make use of it. It also handles the reinitialization of DWC non-sticky registers in addition to sending the notification to EPF drivers. Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- 1 file changed, 1

[PATCH v9 08/10] PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event

2024-03-04 Thread Manivannan Sadhasivam
The PCIe link can go to LINK_DOWN state in one of the following scenarios: 1. Fundamental (PERST#)/hot/warm reset 2. Link transition from L2/L3 to L0 In those cases, LINK_DOWN causes some non-sticky DWC registers to loose the state (like REBAR, PTM_CAP etc...). So the drivers need to

[PATCH v9 07/10] PCI: dwc: ep: Remove "core_init_notifier" flag

2024-03-04 Thread Manivannan Sadhasivam
"core_init_notifier" flag is set by the glue drivers requiring refclk from the host to complete the DWC core initialization. Also, those drivers will send a notification to the EPF drivers once the initialization is fully completed using the pci_epc_init_notify() API. Only then, the EPF drivers

[PATCH v9 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers

2024-03-04 Thread Manivannan Sadhasivam
Currently, dw_pcie_ep_init_registers() API is directly called by the glue drivers requiring active refclk from host. But for the other drivers, it is getting called implicitly by dw_pcie_ep_init(). This is due to the fact that this API initializes DWC EP specific registers and that requires an

[PATCH v9 05/10] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers()

2024-03-04 Thread Manivannan Sadhasivam
The goal of the dw_pcie_ep_init_complete() API is to initialize the DWC specific registers post registering the controller with the EP framework. But the naming doesn't reflect its functionality and causes confusion. So, let's rename it to dw_pcie_ep_init_registers() to make it clear that it

[PATCH v9 04/10] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host

2024-03-04 Thread Manivannan Sadhasivam
The DWC glue drivers requiring an active reference clock from the PCIe host for initializing their PCIe EP core, set a flag called 'core_init_notifier' to let DWC driver know that these drivers need a special attention during initialization. In these drivers, access to the hw registers (like DBI)

[PATCH v9 03/10] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST#

2024-03-04 Thread Manivannan Sadhasivam
For DWC glue drivers supporting PERST# (currently Qcom and Tegra194), some of the DWC resources like eDMA should be cleaned up during the PERST# assert time. So let's introduce a dw_pcie_ep_cleanup() API that could be called by these drivers to cleanup the DWC specific resources. Currently, it

[PATCH v9 02/10] PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit()

2024-03-04 Thread Manivannan Sadhasivam
dw_pcie_ep_exit() API is undoing what the dw_pcie_ep_init() API has done already (at least partly). But the API name dw_pcie_ep_exit() is not quite reflecting that. So let's rename it to dw_pcie_ep_deinit() to make the purpose of this API clear. This also aligns with the DWC host driver.

[PATCH v9 01/10] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops

2024-03-04 Thread Manivannan Sadhasivam
deinit() callback was solely introduced for the pcie-rcar-gen4 driver where it is used to do platform specific resource deallocation. And this callback is called right at the end of the dw_pcie_ep_exit() API. So it doesn't matter whether it is called within or outside of dw_pcie_ep_exit() API. So

[PATCH v9 00/10] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host

2024-03-04 Thread Manivannan Sadhasivam
Hello, This series is the continuation of previous work by Vidya Sagar [1] to fix the issues related to accessing DBI register space before completing the core initialization in some EP platforms like Tegra194/234 and Qcom EP. Since Vidya is busy, I took over the series based on his consent

Re: [kvm-unit-tests PATCH 5/7] arch-run: Add a "continuous" migration option for tests

2024-03-04 Thread Andrew Jones
On Mon, Mar 04, 2024 at 07:17:35AM +0100, Thomas Huth wrote: > On 26/02/2024 10.38, Nicholas Piggin wrote: > > The cooperative migration protocol is very good to control precise > > pre and post conditions for a migration event. However in some cases > > its intrusiveness to the test program, can

Re: [PATCH v17 6/6] powerpc/crash: add crash memory hotplug support

2024-03-04 Thread Sourabh Jain
On 02/03/24 18:49, Hari Bathini wrote: On 26/02/24 2:11 pm, Sourabh Jain wrote: Extend the arch crash hotplug handler, as introduced by the patch title ("powerpc: add crash CPU hotplug support"), to also support memory add/remove events. Elfcorehdr describes the memory of the crash kernel

Re: [PATCH v8 10/10] PCI: dwc: ep: Add Kernel-doc comments for APIs

2024-03-04 Thread Manivannan Sadhasivam
On Thu, Feb 29, 2024 at 01:56:23PM +0100, Niklas Cassel wrote: > Hello Mani, > > On Sat, Feb 24, 2024 at 12:24:16PM +0530, Manivannan Sadhasivam wrote: > > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > >

Re: [PATCH v8 03/10] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST#

2024-03-04 Thread Manivannan Sadhasivam
On Thu, Feb 29, 2024 at 01:40:29PM +0100, Niklas Cassel wrote: > On Sat, Feb 24, 2024 at 12:24:09PM +0530, Manivannan Sadhasivam wrote: > > For DWC glue drivers supporting PERST# (currently Qcom and Tegra194), some > > of the DWC resources like eDMA should be cleaned up during the PERST# > >