[PATCH v2 08/10] powerpc: use for_each_sg()

2015-05-01 Thread Akinobu Mita
not properly initialize their sg tables when CONFIG_DEBUG_SG is enabled. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: Michael Ellerman m...@ellerman.id.au Cc: linuxppc-dev@lists.ozlabs.org Cc: linux

Re: [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds

2015-01-22 Thread Akinobu Mita
2015-01-23 5:41 GMT+09:00 Kim Phillips kim.phill...@freescale.com: On Thu, 22 Jan 2015 10:45:51 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jan 21, 2015 at 09:57:59PM +0900, Akinobu Mita wrote: 2015-01-21 9:07 GMT+09:00 Andrew Morton a...@linux-foundation.org: On Tue, 20 Jan

Re: [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds

2015-01-21 Thread Akinobu Mita
2015-01-21 9:07 GMT+09:00 Andrew Morton a...@linux-foundation.org: On Tue, 20 Jan 2015 15:01:50 -0800 j...@joshtriplett.org wrote: On Tue, Jan 20, 2015 at 02:02:00PM -0600, Kim Phillips wrote: It's possible to configure DEBUG_PAGEALLOC without PAGE_POISONING on ppc. Fix building the

[PATCH] powerpc: remove unused BITOP_LE_SWIZZLE macro

2013-03-02 Thread Akinobu Mita
The BITOP_LE_SWIZZLE macro was used in the little-endian bitops functions for powerpc. But these functions were converted to generic bitops and the BITOP_LE_SWIZZLE is not used anymore. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc

Re: [PATCH] powerpc+of: Rename and fix OF reconfig notifier error inject module

2012-12-13 Thread Akinobu Mita
and rename it along the way. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org Looks good. Acked-by: Akinobu Mita akinobu.m...@gmail.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc

[PATCH] powerpc: iommu: use bitmap library

2012-11-04 Thread Akinobu Mita
- Caluculate the bitmap size with BITS_TO_LONGS() - Use bitmap_empty() to verify that all bits are cleared This also includes a printk to pr_warn() conversion. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau

[PATCH] powerpc: remove BITOP_MASK and BITOP_WORD from asm/bitops.h

2012-11-04 Thread Akinobu Mita
Replace BITOP_MASK and BITOP_WORD with BIT_MASK and BIT_WORD defined in linux/bitops.h and remove BITOP_* which are not used anymore. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev

[PATCH] powerpc: use asm-generic/bitops/le.h

2012-11-04 Thread Akinobu Mita
convert to use asm-generic/bitops/le.h for powerpc. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/include/asm/bitops.h | 55

Re: [PATCH -v5 0/6] notifier error injection

2012-07-04 Thread Akinobu Mita
2012/7/4 Andrew Morton a...@linux-foundation.org: On Sat, 30 Jun 2012 14:59:24 +0900 Akinobu Mita akinobu.m...@gmail.com wrote: This provides kernel modules that can be used to test the error handling of notifier call chain failures by injecting artifical errors to the following notifier

[PATCH -v5 5/6] powerpc: pSeries reconfig notifier error injection module

2012-06-30 Thread Akinobu Mita
to actions/notifier event/error. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org --- No changes since v4 lib/Kconfig.debug| 17 + lib

[PATCH -v5 6/6] fault-injection: add selftests for cpu and memory hotplug

2012-06-30 Thread Akinobu Mita
error handling by injecting notifier errors 7. Online all hot-pluggable memory in preparation for testing 8. Test memory hot-remove error handling by injecting notifier errors Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Suggested-by: Andrew Morton a...@linux-foundation.org Cc: Pavel Machek pa

[PATCH -v5 0/6] notifier error injection

2012-06-30 Thread Akinobu Mita
default if PM_DEBUG is enabled Akinobu Mita (6): fault-injection: notifier error injection cpu: rewrite cpu-notifier-error-inject module PM: PM notifier error injection module memory: memory notifier error injection module powerpc: pSeries reconfig notifier error injection module fault

[PATCH -v5 1/6] fault-injection: notifier error injection

2012-06-30 Thread Akinobu Mita
interface to control what error code should be returned and which event should be failed. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Pavel Machek pa...@ucw.cz Cc: Rafael J. Wysocki r...@sisk.pl Cc: linux...@lists.linux-foundation.org Cc: Greg KH g...@kroah.com Cc: linux...@kvack.org Cc

Re: [PATCH -v4 6/6] fault-injection: add notifier error injection testing scripts

2012-06-27 Thread Akinobu Mita
2012/6/27 Andrew Morton a...@linux-foundation.org: On Sat, 23 Jun 2012 23:58:22 +0900 Akinobu Mita akinobu.m...@gmail.com wrote: This adds two testing scripts with notifier error injection Can we move these into tools/testing/selftests/, so that a make run_tests runs these tests? Also, I

[PATCH -v4 0/6] notifier error injection

2012-06-23 Thread Akinobu Mita
= errno = 0) - improve Kconfig help text - make CONFIG_PM_NOTIFIER_ERROR_INJECTION visible even if PM_DEBUG is disabled - make CONFIG_PM_NOTIFIER_ERROR_INJECTION default if PM_DEBUG is enabled Akinobu Mita (6): fault-injection: notifier error injection cpu: rewrite cpu-notifier-error-inject

[PATCH -v4 1/6] fault-injection: notifier error injection

2012-06-23 Thread Akinobu Mita
interface to control what error code should be returned and which event should be failed. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Pavel Machek pa...@ucw.cz Cc: Rafael J. Wysocki r...@sisk.pl Cc: linux...@lists.linux-foundation.org Cc: Greg KH g...@kroah.com Cc: linux...@kvack.org Cc

[PATCH -v4 5/6] powerpc: pSeries reconfig notifier error injection module

2012-06-23 Thread Akinobu Mita
to actions/notifier event/error. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org --- * v4 - update modules to follow new interface lib/Kconfig.debug

[PATCH -v4 6/6] fault-injection: add notifier error injection testing scripts

2012-06-23 Thread Akinobu Mita
in preparation for testing 2. Test memory hot-add error handling by injecting notifier errors 3. Online all hot-pluggable memory in preparation for testing 4. Test memory hot-remove error handling by injecting notifier errors Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Suggested-by: Andrew

[PATCH] powerpc: use string library

2012-01-27 Thread Akinobu Mita
- Use memchr_inv to check if the data contains all 0xFF bytes. It is faster than looping for each byte. - Use memcmp to compare memory areas Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: linuxppc-dev@lists.ozlabs.org --- arch

[PATCH v3 1/6] fault-injection: notifier error injection

2011-07-23 Thread Akinobu Mita
interface to control what error code should be returned and which event should be failed. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Pavel Machek pa...@ucw.cz Cc: Rafael J. Wysocki r...@sisk.pl Cc: linux...@lists.linux-foundation.org Cc: Greg KH g...@kroah.com Cc: linux...@kvack.org Cc

[PATCH v3 5/6] powerpc: pSeries reconfig notifier error injection module

2011-07-23 Thread Akinobu Mita
the error code. If the notifier call chain should be failed with some events notified, write the error code to the files. This module needs pSeries_reconfig_notifier_{,un}register symbols to be exported. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b

[PATCH v3 6/6] fault-injection: add notifier error injection testing scripts

2011-07-23 Thread Akinobu Mita
in preparation for testing 4. Test CPU hot-remove error handling by injecting notifier errors * tools/testing/fault-injection/memory-notifier.sh is doing the same thing for memory hotplug notifier. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Suggested-by: Andrew Morton a...@linux

[PATCH v2 1/5] fault-injection: notifier error injection

2011-07-17 Thread Akinobu Mita
interface to control what error code should be returned and which event should be failed. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Pavel Machek pa...@ucw.cz Cc: Rafael J. Wysocki r...@sisk.pl Cc: linux...@lists.linux-foundation.org Cc: Greg Kroah-Hartman gre...@suse.de Cc: linux

[PATCH v2 5/5] powerpc: pSeries reconfig notifier error injection

2011-07-17 Thread Akinobu Mita
the error code. If the notifier call chain should be failed with some events notified, write the error code to the files. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org

[PATCH 3/7] fault-injection: notifier error injection

2011-07-03 Thread Akinobu Mita
interface to control what error code should be returned and which event should be failed. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Pavel Machek pa...@ucw.cz Cc: Rafael J. Wysocki r...@sisk.pl Cc: Greg Kroah-Hartman gre...@suse.de Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc

[PATCH 7/7] powerpc: pSeries reconfig notifier error injection

2011-07-03 Thread Akinobu Mita
the error code. If the notifier call chain should be failed with some events notified, write the error code to the files. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org

Re: [PATCH 3/7] fault-injection: notifier error injection

2011-07-03 Thread Akinobu Mita
2011/7/4 Pavel Machek pa...@ucw.cz: +     for (action = enb-actions; action-name; action++) { +             struct dentry *file = debugfs_create_int(action-name, mode, +                                             enb-dir, action-error); + +             if (!file) { +                    

[PATCH 2/2] powerpc: improve error code on reconfiguration notifier failure

2011-06-21 Thread Akinobu Mita
with notifier_from_errno(). Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/kernel/prom.c |8 +++- arch/powerpc/platforms/pseries

Re: [PATCH -mm 2/6] powerpc: convert little-endian bitops macros to static inline functions

2011-02-06 Thread Akinobu Mita
2011/2/7 Benjamin Herrenschmidt b...@kernel.crashing.org: On Thu, 2011-01-27 at 22:56 +0900, Akinobu Mita wrote: (This patch is intended to be folded into the patch in -mm: powerpc-introduce-little-endian-bitops.patch) The little-endian bitops on powerpc are written as preprocessor macros

[PATCH -mm 2/6] powerpc: convert little-endian bitops macros to static inline functions

2011-01-27 Thread Akinobu Mita
, and that is a Very Bad Thing. This converts the little-endian bitops macros to static inline functions with proper prototypes. Suggested-by: H. Peter Anvin h...@zytor.com Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc

[PATCH v5 06/27] powerpc: introduce little-endian bitops

2011-01-22 Thread Akinobu Mita
Introduce little-endian bit operations by renaming existing powerpc native little-endian bit operations and changing them to take any pointer types. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc

[PATCH v4 03/24] powerpc: introduce little-endian bitops

2011-01-16 Thread Akinobu Mita
Introduce little-endian bit operations by renaming existing powerpc native little-endian bit operations. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org --- The whole

[PATCH] spufs: use simple_write_to_buffer

2010-12-24 Thread Akinobu Mita
Simplify several write fileoperations for spufs by using simple_write_to_buffer(). Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: Jeremy Kerr j...@ozlabs.org Cc: linuxppc-dev@lists.ozlabs.org Cc: cbe

[PATCH] powerpc: use simple_read_from_buffer

2010-12-24 Thread Akinobu Mita
Simplify read file operation for /proc/powerpc/rtas/* interface by using simple_read_from_buffer. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/kernel

[PATCH v3 02/22] bitops: rename generic little-endian bitops functions

2010-11-23 Thread Akinobu Mita
/test_and_set_le_bit/ s/generic_test_and_clear_le_bit/test_and_clear_le_bit/ Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Acked-by: Arnd Bergmann a...@arndb.de Acked-by: Hans-Christian Egtvedt hans-christian.egtv...@atmel.com Cc: Geert Uytterhoeven ge...@linux-m68k.org Cc: Roman Zippel zip...@linux

[PATCH v2 02/22] bitops: rename generic little-endian bitops functions

2010-10-21 Thread Akinobu Mita
/test_and_set_le_bit/ s/generic_test_and_clear_le_bit/test_and_clear_le_bit/ Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Hans-Christian Egtvedt hans-christian.egtv...@atmel.com Cc: Geert Uytterhoeven ge...@linux-m68k.org Cc: Roman Zippel zip...@linux-m68k.org Cc: Andreas Schwab sch...@linux

[PATCH] powerpc/512x: fix clk_get() return value

2010-08-31 Thread Akinobu Mita
clk_get() should return an ERR_PTR value on error, not NULL. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/platforms/512x/clock.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH] powerpc: use __ratelimit

2010-02-28 Thread Akinobu Mita
Replace open-coded rate limiting logic with __ratelimit(). Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-...@ozlabs.org --- arch/powerpc/platforms/iseries/pci.c | 10 +++--- 1 files

Re: [PATCH 1/7] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area

2009-10-29 Thread Akinobu Mita
2009/10/29 Andrew Morton a...@linux-foundation.org: Why were these patches resent?  What changed? Everybody who is going to review these patches has already reviewed them and now they need to review them all again? I resent the patches because the iommu-helper change was not correct and I

[PATCH 2/7] iommu-helper: Use bitmap library

2009-10-28 Thread Akinobu Mita
of the limit in bitmap 4. Remove iommu_area_free, iommu_area_reserve, and find_next_zero_area Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: David S. Miller da...@davemloft.net Cc: sparcli...@vger.kernel.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau

Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area

2009-10-17 Thread Akinobu Mita
2009/10/17 FUJITA Tomonori fujita.tomon...@lab.ntt.co.jp: On Tue, 13 Oct 2009 18:10:17 +0900 Akinobu Mita akinobu.m...@gmail.com wrote: My user space testing exposed off-by-one error find_next_zero_area in iommu-helper. Some zero area cannot be found by this bug. Subject: [PATCH] Fix off

Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area

2009-10-17 Thread Akinobu Mita
--- a/lib/iommu-helper.c +++ b/lib/iommu-helper.c @@ -19,7 +19,7 @@ again:       index = (index + align_mask) ~align_mask;       end = index + nr; -     if (end = size) +     if (end size) I think that this is intentional; the last byte of the limit doesn't work. It looks

[PATCH -mmotm -v2] Fix bitmap-introduce-bitmap_set-bitmap_clear-bitmap_find_next_zero_area. patch

2009-10-15 Thread Akinobu Mita
From: Akinobu Mita akinobu.m...@gmail.com Subject: Fix bitmap-introduce-bitmap_set-bitmap_clear-bitmap_find_next_zero_area.patch - Rewrite bitmap_set and bitmap_clear Instead of setting or clearing for each bit. - Fix off-by-one errors in bitmap_find_next_zero_area This bug was derived

Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area

2009-10-13 Thread Akinobu Mita
My user space testing exposed off-by-one error find_next_zero_area in iommu-helper. Some zero area cannot be found by this bug. Subject: [PATCH] Fix off-by-one error in find_next_zero_area Signed-off-by: Akinobu Mita akinobu.m...@gmail.com --- lib/iommu-helper.c |2 +- 1 files changed, 1

[PATCH -mmotm] Fix bitmap-introduce-bitmap_set-bitmap_clear-bitmap_find_next_zero_area. patch

2009-10-13 Thread Akinobu Mita
Update PATCH 2/8 based on review comments by Andrew and bugfix exposed by user space testing. I didn't change argument of align_mask at this time because it turned out that it needs more changes in iommu-helper users. From: Akinobu Mita akinobu.m...@gmail.com Subject: Fix bitmap-introduce

Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area

2009-10-13 Thread Akinobu Mita
On Wed, Oct 14, 2009 at 08:54:47AM +1100, Michael Ellerman wrote: On Tue, 2009-10-13 at 18:10 +0900, Akinobu Mita wrote: My user space testing exposed off-by-one error find_next_zero_area in iommu-helper. Why not merge those tests into the kernel as a configurable boot-time self-test? I

Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area

2009-10-12 Thread Akinobu Mita
On Fri, Oct 09, 2009 at 04:41:00PM -0700, Andrew Morton wrote: On Fri, 9 Oct 2009 17:29:15 +0900 Akinobu Mita akinobu.m...@gmail.com wrote: This introduces new bitmap functions: bitmap_set: Set specified bit area bitmap_clear: Clear specified bit area bitmap_find_next_zero_area

[PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area

2009-10-09 Thread Akinobu Mita
: Yevgeny Petrilin yevge...@mellanox.co.il Cc: net...@vger.kernel.org Cc: Tony Luck tony.l...@intel.com Cc: Fenghua Yu fenghua...@intel.com Cc: linux-i...@vger.kernel.org Cc: linux-al...@sgi.com Signed-off-by: Akinobu Mita akinobu.m...@gmail.com --- include/linux/bitmap.h | 11 +++ lib

[PATCH 3/8] iommu-helper: Use bitmap library

2009-10-09 Thread Akinobu Mita
: Ingo Molnar mi...@redhat.com Cc: H. Peter Anvin h...@zytor.com Cc: x...@kernel.org Cc: FUJITA Tomonori fujita.tomon...@lab.ntt.co.jp Signed-off-by: Akinobu Mita akinobu.m...@gmail.com --- arch/powerpc/kernel/iommu.c |4 +- arch/sparc/kernel/iommu.c|3 +- arch/x86/kernel

Re: [PATCH v2] Fix highmem build failure

2009-04-02 Thread Akinobu Mita
Looks good. I tested it on x86_32. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] Fix highmem build failure

2009-04-01 Thread Akinobu Mita
On Wed, Apr 01, 2009 at 04:33:31PM -0500, Kumar Gala wrote: The following commit breaks PPC builds with CONFIG_HIGHMEM=y commit f4112de6b679d84bd9b9681c7504be7bdfb7c7d5 Author: Akinobu Mita akinobu.m...@gmail.com Date: Tue Mar 31 15:23:25 2009 -0700 mm: introduce debug_kmap_atomic