Re: [PATCH 8/9] drivers/mmc: correct error-handling code

2009-07-28 Thread Anton Vorontsov
coccinelle.lip6.fr/) > > // > @match exists@ > expression x, E; > statement S1, S2; > @@ > > x = sdhci_alloc_host(...) > ... when != x = E > ( > * if (x == NULL || ...) S1 else S2 > | > * if (x == NULL && ...) S1 else S2 > ) > // > > Signed-off-by:

[PATCH] sdhci: Get rid of "frequency too high" flood when using eSDHC

2009-07-24 Thread Anton Vorontsov
nt, so we can divide clock by 256 * 16, not just 256. This patch introduces get_min_clock() callback for sdhci core and implements it for sdhci-of driver, and thus fixes the issue. Signed-off-by: Anton Vorontsov --- drivers/mmc/host/sdhci-of.c |8 drivers/mmc/host/sdhci.c|5 +++

[PATCH 2/2] powerpc/83xx: Add eSDHC support for MPC837xE-RDB/WLAN boards

2009-07-24 Thread Anton Vorontsov
, for RDB boards we can safely setup pinmux and manually fill-in clock-frequency, thus making eSDHC work even with older u-boots. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8377_rdb.dts |2 +- arch/powerpc/boot/dts/mpc8378_rdb.dts |2 +- arch/powerpc/boo

[PATCH 1/2] powerpc/83xx: Add support for MPC8377E-WLAN boards

2009-07-24 Thread Anton Vorontsov
PHY's ID pin grounded, thus USB port is host-only. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8377_wlan.dts| 464 + arch/powerpc/platforms/83xx/Kconfig |4 +- arch/powerpc/platforms/83xx/mpc837x_rdb.c |5 +- 3 files changed

[PATCH] powerpc/83xx: Fix PCI IO base address on MPC837xE-RDB boards

2009-07-20 Thread Anton Vorontsov
specifying the correct PCI IO base address. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8377_rdb.dts |2 +- arch/powerpc/boot/dts/mpc8378_rdb.dts |2 +- arch/powerpc/boot/dts/mpc8379_rdb.dts |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/boot

Re: [PATCH v2 0/4] net: Revive fixed link support

2009-07-18 Thread Anton Vorontsov
ardware to test this, so I rely on you > to tell be if I screwed it up. It has been compile tested. Works fine here, thanks! -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: Ang: Re: [PATCH 0/2] Setting GPIOs simultaneously

2009-07-14 Thread Anton Vorontsov
has regressed w.r.t earlier releases. Yes and no. Yes, it has "regressed" for out-of-tree code, and no, I don't feel sorry about that. :-) -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH RFC 1/2] Makefile: Never use -fno-omit-frame-pointer

2009-07-14 Thread Anton Vorontsov
On Wed, Jun 17, 2009 at 12:16:30AM +0400, Anton Vorontsov wrote: > According to Segher Boessenkool and GCC manual, -fomit-frame-pointer > is only the default when optimising on archs/ABIs where it doesn't > hinder debugging and -pg. So, we do not get it by default on x86, > not at

Re: [PATCH] powerpc/85xx: Fix ethernet link detection on MPC8569E-MDS boards

2009-07-14 Thread Anton Vorontsov
On Wed, Jun 24, 2009 at 08:30:28PM +0400, Anton Vorontsov wrote: > Linux isn't able to detect link changes on ethernet ports that were > used by U-Boot. This is because U-Boot wrongly clears interrupt > polarity bit (INTPOL, 0x400) in the extended status register (EXT_SR, > 0x1b

Re: [PATCH] powerpc/85xx: Don't scan for TBI PHY addresses on MPC8569E-MDS boards

2009-07-14 Thread Anton Vorontsov
On Wed, Jul 01, 2009 at 09:39:25PM +0400, Anton Vorontsov wrote: > Sometimes (e.g. when there are no UEMs attached to a board) > fsl_pq_mdio_find_free() fails to find a spare address for a TBI PHY, > this is because get_phy_id() returns bogus 0x values > (0x is ex

Re: [PATCH 0/2] Setting GPIOs simultaneously

2009-07-13 Thread Anton Vorontsov
ndependent, so thinking about it more, I believe we should now discuss "chip-select framework", not gpio controllers (it could be that using gpio controllers for this purpose wasn't that good idea). http://www.mail-archive.com/linuxp

Re: [PATCH 0/2] Setting GPIOs simultaneously

2009-07-13 Thread Anton Vorontsov
On Mon, Jul 13, 2009 at 06:01:02PM +0200, Joakim Tjernlund wrote: > > Anton Vorontsov wrote on 13/07/2009 17:19:11: > > > > Hi all, > > > > I've been sitting on these patches for some time, but now it appears > > that the set_sync() feature is need

[PATCH 2/2] powerpc/qe: Implement set_sync() callback for QE GPIOs

2009-07-13 Thread Anton Vorontsov
This is needed to set GPIO's values synchronously. Signed-off-by: Anton Vorontsov --- arch/powerpc/include/asm/gpio.h | 11 +++ arch/powerpc/sysdev/qe_lib/gpio.c | 27 +++ 2 files changed, 38 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/in

[PATCH 1/2] gpiolib: Implement gpio_set_values_sync()

2009-07-13 Thread Anton Vorontsov
ther all passed GPIOs belong to one particular gpio_chip. Someday we may want to implement chip-specific .can_set_sync() check, but currently this isn't needed. Signed-off-by: Anton Vorontsov --- drivers/gpio/gpiolib.c | 57 include/asm-g

[PATCH 0/2] Setting GPIOs simultaneously

2009-07-13 Thread Anton Vorontsov
Hi all, I've been sitting on these patches for some time, but now it appears that the set_sync() feature is needed elsewhere. So here are the patches. Joakim, I think this is what you need. Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.ne

[PATCH] powerpc/85xx: Add support for I2C EEPROMs on MPC8548CDS boards

2009-07-09 Thread Anton Vorontsov
This patch simply adds four eeprom nodes to MPC8548CDS' device tree. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8548cds.dts | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8548cds.dts b/arch/powerpc/boo

Re: [PATCH] ucc_geth: Add support for skb recycling

2009-07-07 Thread Anton Vorontsov
On Tue, Jul 07, 2009 at 11:47:38AM -0700, Rick Jones wrote: > Anton Vorontsov wrote: > >We can reclaim transmitted skbs to use in the receive path, so-called > >skb recycling support. > > > >Also reorder ucc_geth_poll() steps, so that we'll clean tx ring firstly,

[PATCH] ucc_geth: Add support for skb recycling

2009-07-07 Thread Anton Vorontsov
We can reclaim transmitted skbs to use in the receive path, so-called skb recycling support. Also reorder ucc_geth_poll() steps, so that we'll clean tx ring firstly, thus maybe reclaim some skbs for rx. Signed-off-by: Anton Vorontsov --- drivers/net/ucc_geth.c |

Re: [PATCH] net: fix OF fixed-link property handling on Freescale network device drivers

2009-07-07 Thread Anton Vorontsov
000 419e0020 7c0004ac 801e0004 0c00 4c00012c 6402 7c0004ac 901e0004 813d0110 <800900d0> 2f80 419e0024 7c0004ac ---[ end trace 1ae193a95823d5e4 ]--- And the same comment regarding link speed/duplex reporting for userspace: # ethtool eth1 Settings for eth1: Cannot get devi

Re: [PATCH] net: fix OF fixed-link property handling on Freescale network device drivers

2009-07-07 Thread Anton Vorontsov
mp: 80c901b8 70c1 41820058 8123004c 7cab2b78 3900 3800 38e90180 39200012 7d2903a6 5400103a 7c0004ac <7d27002e> 0c09 4c00012c 7d2a4b78 ---[ end trace 7b7ae7cbafe6f2ba ]--- Segmentation fault Also, now userspace has no chance to know link speed: # ifconfig eth1 up # ethtool eth1 Settings for eth1: Cannot get device settings: No such device Current message level: 0x003f (63) Link detected: yes # (You need to tech *_ethtool.c to report speed/duplex for fixed-link cases). Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

2009-07-01 Thread Anton Vorontsov
On Wed, Jul 01, 2009 at 04:25:22PM -0500, Kumar Gala wrote: > > On Jul 1, 2009, at 3:59 PM, Anton Vorontsov wrote: > > >qe_ic is in the same boat, just as every other PIC controller. Heh.. > >doing some 'grep alloc_bootmem', it seems that there are pretty &g

Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

2009-07-01 Thread Anton Vorontsov
On Wed, Jul 01, 2009 at 04:13:43PM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: > > > diff --git a/arch/powerpc/sysdev/qe_lib/qe_ic.c > > b/arch/powerpc/sysdev/qe_lib/qe_ic.c > > index 63cdf98..074905c 100644 > > --- a/arch/powerpc/sysdev/qe_lib/qe_ic.c > &

Re: [PATCH] [spi_mpc83xx] Always enable legacy support.

2009-07-01 Thread Anton Vorontsov
s is "legacy" platform driver, was used by the MPC8323E-RDB boards > @@ -941,10 +940,6 @@ static void __exit legacy_driver_unregister(void) > return; > platform_driver_unregister(&mpc83xx_spi_driver); > } > -#else > -static void __init legacy

[PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

2009-07-01 Thread Anton Vorontsov
werpc: Fix mpic alloc warning") missed some alloc_bootmem() instances, this is now fixed. Signed-off-by: Anton Vorontsov --- On Wed, Jul 01, 2009 at 12:48:19PM -0700, Ira Snyder wrote: [...] > > [0.00] [c0489e60] [c043db98] ___alloc_bootmem_nopanic+0x54/0x108 > > [

[PATCH] powerpc/85xx: Don't scan for TBI PHY addresses on MPC8569E-MDS boards

2009-07-01 Thread Anton Vorontsov
: probe of e0082120.mdio failed with error -16 And obviously ethernet doesn't work after this. This patch solves the problem by adding tbi-phy node into mdio node, so that we won't scan for spare addresses, we'll just use a fixed one. Signed-off-by: Anton Vorontsov --- arch/p

Re: [PATCH 1/4] of/mdio: Add fixed link support

2009-06-26 Thread Anton Vorontsov
On Fri, Jun 26, 2009 at 05:33:26PM -0600, Grant Likely wrote: > On Fri, Jun 26, 2009 at 4:29 PM, Anton > Vorontsov wrote: > > Currently the fixed link support is broken for all OF ethernet drivers, > > an "OF MDIO rework" removed most of the support. Instead of re-ad

[PATCH 4/4] fs_enet: Revive fixed link support

2009-06-26 Thread Anton Vorontsov
de appears to be NULL. Also set netdev parent device via SET_NETDEV_DEV() call, this is needed so that OF MDIO core could find a node pointer for a device. Plus, fix "if (IS_ERR(phydev))" check, in case of errors, of_phy_connect() returns NULL, not ERR_PTR as phy_connect(). Signed-off

[PATCH 3/4] ucc_geth: Revive fixed link support

2009-06-26 Thread Anton Vorontsov
appears to be NULL. Also, remove an old fixed-link code that we don't use any longer. Signed-off-by: Anton Vorontsov --- drivers/net/ucc_geth.c | 18 +++--- 1 files changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c inde

[PATCH 2/4] gianfar: Revive fixed link support

2009-06-26 Thread Anton Vorontsov
-link code that we don't use any longer. Signed-off-by: Anton Vorontsov --- drivers/net/gianfar.c | 21 + 1 files changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 4ae1d25..41b2107 100644 --- a/drivers/net/

[PATCH 1/4] of/mdio: Add fixed link support

2009-06-26 Thread Anton Vorontsov
r is NULL, then of_phy_connect() will try to find ethernet device's node, then will look for fixed-link property, and if specified, it connects PHY as usual, via bus_id (fixed link PHYs do not have any device tree nodes associated with them). Signed-off-by: Anton Vorontsov --- drivers

[PATCH 0/4 for 2.6.31] NET: Revive fixed link support

2009-06-26 Thread Anton Vorontsov
eep drivers' changes minimal. Patches 2 and 3 are for the drivers that I tested in run-time, with normal PHYs, and fixed links. Patch #4 was build-tested, but I believe it should work in run-time too. Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com i

[PATCH] sky2: Fix checksum endianness

2009-06-26 Thread Anton Vorontsov
[ef84ba20] [c02fb7fc] net_rx_action+0xc0/0x144 The NIC is Yukon-2 EC chip revision 1. Converting checksum field from le16 to CPU byte order fixes the issue. Signed-off-by: Anton Vorontsov --- drivers/net/sky2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sky2

Re: [PATCH] ucc_geth: Fix half-duplex operation for non-MII/RMII interfaces

2009-06-25 Thread Anton Vorontsov
On Thu, Jun 25, 2009 at 11:02:36AM +0400, Anton Vorontsov wrote: [...] > Of course, it could be that the root cause of the problems > I observe is weird NIC on my host. Well, then QA team should > have used the same broken NIC on their hosts. :-) > > I can easily test it by inte

Re: [PATCH v2 1/2] ucc_geth: Fix half-duplex operation for non-MII/RMII interfaces

2009-06-25 Thread Anton Vorontsov
On Thu, Jun 25, 2009 at 05:02:32AM +0400, Anton Vorontsov wrote: > Currently the half-duplex operation seems to not work reliably for > RGMII PHY interfaces. It takes about 10 minutes to boot NFS rootfs > using 10/half link, following symptoms were observed: David, please ignore thes

Re: [PATCH] ucc_geth: Fix half-duplex operation for non-MII/RMII interfaces

2009-06-25 Thread Anton Vorontsov
On Wed, Jun 24, 2009 at 10:11:14PM -0700, Mark Huth wrote: > Anton Vorontsov wrote: >> Currently the half-duplex operation seems to not work reliably for >> RGMII/GMII PHY interfaces. It takes about 10 minutes to boot NFS >> rootfs using 10/half link, following s

[PATCH v2 2/2] gianfar: Fix half-duplex operation for non-MII/RMII interfaces

2009-06-24 Thread Anton Vorontsov
it should be set for RGMII. It's no wonder though, QE Ethernet and TSEC are pretty similar. Signed-off-by: Anton Vorontsov --- drivers/net/gianfar.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 8741bb0..503

[PATCH v2 1/2] ucc_geth: Fix half-duplex operation for non-MII/RMII interfaces

2009-06-24 Thread Anton Vorontsov
t can be 0 for RGMII(10/100) modes, while MPC8568ERM (Rev. C 02/2007) spec says that cleared FDX bit is permitted for MII/RMII modes only. The symptoms above were seen on MPC8569E-MDS boards, so QEIWRM is clearly wrong, and this patch completely cures the problems above. Signed-off-by: Anton

Re: [PATCH] gianfar: Fix half-duplex operation for non-MII/RMII interfaces

2009-06-24 Thread Anton Vorontsov
On Thu, Jun 25, 2009 at 01:39:45AM +0400, Anton Vorontsov wrote: > On Wed, Jun 24, 2009 at 04:25:06PM -0500, Andy Fleming wrote: > [...] > >>> My concern is that you will be detecting the GMII interface, and > >>> disallowing half-duplex, despite the fact that the

Re: [PATCH] gianfar: Fix half-duplex operation for non-MII/RMII interfaces

2009-06-24 Thread Anton Vorontsov
n HW? I mean, if we connect 100 Mbs link to the GMII PHY, then gfar_get_interface() would return MII, correct? If so, then I think I'll also have to change phy_interface_t phyi = phydev->interface; to phy_interface_t phyi = gfar_get_interface(dev); since phydev->interface m

Re: [PATCH] gianfar: Fix half-duplex operation for non-MII/RMII interfaces

2009-06-24 Thread Anton Vorontsov
On Wed, Jun 24, 2009 at 03:18:59PM -0500, Andy Fleming wrote: > > On Jun 24, 2009, at 1:27 PM, Anton Vorontsov wrote: > >> It appears that gianfar driver has the same problem[1] that I >> just fixed for ucc_geth. >> >> NFS boot using 10/half link takes about 10 mi

[PATCH] gianfar: Fix half-duplex operation for non-MII/RMII interfaces

2009-06-24 Thread Anton Vorontsov
uld be set. It's no wonder though, QE Ethernet and TSEC are pretty similar. [1] http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-June/073631.html Signed-off-by: Anton Vorontsov --- drivers/net/gianfar.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH] ucc_geth: Fix half-duplex operation for non-MII/RMII interfaces

2009-06-24 Thread Anton Vorontsov
DX bit can be 0 for RGMII(10/100) modes, while MPC8568ERM (Rev. C 02/2007) spec says that cleared FDX bit is permitted for MII/RMII modes only. The symptoms above were seen on MPC8569E-MDS boards, so QEIWRM is clearly wrong, and this patch completely cures the problems above. Signed-off-by: Anton

[PATCH] powerpc/85xx: Fix ethernet link detection on MPC8569E-MDS boards

2009-06-24 Thread Anton Vorontsov
could extract it from the device tree and pass it to phydevs, but that'll be quite a lot of work), so for now just reset the PHYs to their default states. Signed-off-by: Anton Vorontsov --- arch/powerpc/platforms/85xx/mpc85xx_mds.c | 13 + 1 files changed, 13 insertions(+), 0

Re: [PATCH] powerpc/85xx: Make eSDHC 1-bit only transfer mode default for MPC8569E-MDS

2009-06-19 Thread Anton Vorontsov
On Thu, Jun 18, 2009 at 09:25:46PM -0500, Kumar Gala wrote: > > On Jun 18, 2009, at 6:37 PM, Anton Vorontsov wrote: > >> For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards, >> so make 1-bit mode default. When we resolve the issue, u-boot will >>

Re: [PATCH -mm v3][POWERPC] mpc8xxx : allow SPI without cs.

2009-06-19 Thread Anton Vorontsov
t;can't set output direction for" > + "gpio #%d: %d\n", > + i, ret); There is no space between 'for' and 'gpio' words. (also the whole dev_err() may fit into two line

Re: [PATCH -mm][POWERPC] mpc8xxx : allow SPI without cs.

2009-06-19 Thread Anton Vorontsov
On Fri, Jun 19, 2009 at 01:45:46PM +0200, Leon Woestenberg wrote: > Hello, > > On Thu, Jun 18, 2009 at 4:04 PM, Kumar Gala wrote: > > On Jun 18, 2009, at 8:09 AM, Anton Vorontsov wrote: > >> On Thu, Jun 18, 2009 at 08:19:44AM +0200, Rini van Zetten wrote: > &g

[PATCH] powerpc/85xx: Make eSDHC 1-bit only transfer mode default for MPC8569E-MDS

2009-06-18 Thread Anton Vorontsov
For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards, so make 1-bit mode default. When we resolve the issue, u-boot will remove sdhci,1-bit-only property from the device tree, while SDHCI will still work with older u-boots. Signed-off-by: Anton Vorontsov --- arch/powerpc

[PATCH] powerpc/85xx: Fix FSL RapidIO probing on MDS boards

2009-06-18 Thread Anton Vorontsov
From: Randy Vinson FSL RapidIO won't probe without a proper compatible entry. This patch fixes the issue by adding fsl,rapidio-delta compatible to mpc85xx_ids. Signed-off-by: Randy Vinson Signed-off-by: Anton Vorontsov --- arch/powerpc/platforms/85xx/mpc85xx_mds.c |1 + 1 files ch

Re: [PATCH -mm][POWERPC] mpc8xxx : allow SPI without cs.

2009-06-18 Thread Anton Vorontsov
w = pinfo->alow_flags[cs]; > + gpio_set_value(gpio, on ^ alow); Please put an empty line after variable declaration. Thanks! -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH v2] sdhci: Add support for hosts that are only capable of 1-bit transfers

2009-06-17 Thread Anton Vorontsov
, this patch modifies sdhci-of driver, so that now it looks for "sdhci,1-bit-only" property in the device-tree, and if specified we enable a proper quirk. Signed-off-by: Anton Vorontsov --- Pierre, As promised, here is a version with a quirk. Also incorporated suggestions by Gr

Re: [PATCH] sdhci: Add support for hosts that are only capable of 1-bit transfers

2009-06-17 Thread Anton Vorontsov
On Sat, Jun 13, 2009 at 09:40:02AM -0600, Grant Likely wrote: > On Thu, Jun 11, 2009 at 2:15 PM, Anton > Vorontsov wrote: > > Some hosts (hardware configurations, or particular SD/MMC slots) may > > not support 4-bit bus. For example, on MPC8569E-MDS boards we can > > swit

[PATCH RFC 2/2] powerpc: Remove -fno-omit-frame-pointer workarounds

2009-06-16 Thread Anton Vorontsov
The workarounds aren't needed any longer since the top level Makefile doesn't pass -fno-omit-frame-pointer cflag for PowerPC builds. Signed-off-by: Anton Vorontsov --- arch/powerpc/Makefile|5 - arch/powerpc/kernel/Makefile | 12 ++--

[PATCH RFC 1/2] Makefile: Never use -fno-omit-frame-pointer

2009-06-16 Thread Anton Vorontsov
cc to produce buggy code on PowerPC targets. If Segher and GCC manual are right, this patch should be a no-op for all arches except PowerPC, where the patch fixes gcc issues. Signed-off-by: Anton Vorontsov --- See this thread for more discussion: http://osdir.com/ml/linux-kernel/2009-05/msg01754

Re: PWM class? (was: Re: MPC52xx simple GPIO support)

2009-06-11 Thread Anton Vorontsov
On Thu, Jun 11, 2009 at 04:00:51PM -0600, Grant Likely wrote: > On Wed, Jun 3, 2009 at 7:22 AM, Anton Vorontsov > wrote: > > On Wed, Jun 03, 2009 at 02:42:26PM +0200, Stefan Strobl wrote: > > [...] > >> The led class provides support for setting the brightness, wh

[PATCH] sdhci: Add support for hosts that are only capable of 1-bit transfers

2009-06-11 Thread Anton Vorontsov
, this patch modifies sdhci-of driver, so that now it looks for "mode" property in the device-tree. Signed-off-by: Anton Vorontsov --- Pierre, I'm not sure if a quirk would be appropriate here. If so, I can redo the patch with FORCE_1_BIT_DATA quirk. Thanks, Documentation/power

[PATCH] powerpc/83xx: Update sdhci nodes per new bindings

2009-06-10 Thread Anton Vorontsov
As of commit 404614728f857d0ac63d29c3a29d0cf392a15598 ("Update FSL esdhc binding"), we use "fsl,esdhc" compatible entry as a base match. U-Boot will use the same compatible to fixup esdhc nodes. This patch updates 83xx dts files so that they conform to the new bindings.

PWM class? (was: Re: MPC52xx simple GPIO support)

2009-06-03 Thread Anton Vorontsov
b. And then we can reuse drivers/leds/leds-pwm.c driver (of course, after adding appropriate OF code into it). Sure, as you've said, it could be quite boringly to implement, could take quite some time to pass all review cycles etc. But someday someone will have to do this. :-) -- Anton Vo

Re: [PATCH] mmc: Fix the wrong accessor to HOSTVER register

2009-06-02 Thread Anton Vorontsov
not in_be16(0xFC). > > Signed-off-by: Dave Liu Sorry for the delay Dave. This patch is surely Acked-by: Anton Vorontsov > --- > drivers/mmc/host/sdhci-of.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of.c

Re: MPC52xx simple GPIO support

2009-06-02 Thread Anton Vorontsov
os = <>) drivers/mtd/nand/fsl_upm.c (of_get_gpio() then gpio_request()). For userland usage you need to enable CONFIG_GPIO_SYSFS, and then look into /sys/class/gpio/{gpiochip,export,gpioNNN}. -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___

Re: [PATCH 0/9] Some work for spi_mpc83xx driver, spi-mmc support for MPC8610HPCD

2009-05-04 Thread Anton Vorontsov
On Mon, May 04, 2009 at 01:55:04PM -0700, Andrew Morton wrote: > On Fri, 1 May 2009 03:47:39 +0400 > Anton Vorontsov wrote: > > > Here are few patches that are needed to support spi-mmc slot on > > MPC8610HPCD PowerPC boards: > > > > [1/9] spi_mpc83xx: Handles

Re: [PATCH 9/9] spi_mpc8xxx: s/83xx/8xxx/g

2009-05-04 Thread Anton Vorontsov
On Mon, May 04, 2009 at 01:53:27PM -0700, Andrew Morton wrote: > On Fri, 1 May 2009 03:48:33 +0400 > Anton Vorontsov wrote: > > > Since we renamed the file, we might want to rename the file > > internals too. > > > > Though we don't bother with changing

[PATCH 6/6] powerpc/85xx: Add STMicro M25P40 serial flash support for MPC8569E-MDS

2009-05-01 Thread Anton Vorontsov
For serial flash support we need to: - Add QE Par IO Bank E device tree node, a GPIO from this bank is used for SPI chip-select line; - Add serial-flash node; - Add proper module alias into of/base.c. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8569mds.dts | 26

[PATCH 5/6] powerpc/85xx: Enable Serial RapidIO for MPC85xx MDS boards

2009-05-01 Thread Anton Vorontsov
Select HAS_RAPIDIO symbol and add rio nodes for MPC8568E-MDS and MPC8569E-MDS boards. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8568mds.dts | 17 + arch/powerpc/boot/dts/mpc8569mds.dts | 17 + arch/powerpc/platforms/85xx/Kconfig |1 + 3

[PATCH 4/6] powerpc/85xx: Add eSDHC support for MPC8569E-MDS boards

2009-05-01 Thread Anton Vorontsov
Note that eSDHC and DUART0 are mutually exclusive on MPC8569E-MDS boards. Default option is DUART0, so eSDHC is disabled by default. U-Boot will fixup device tree if eSDHC should be used instead of DUART0. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8569mds.dts | 10

[PATCH 3/6] powerpc/85xx: Fix reg and interrupts for mpc8569emds' localbus, add NAND

2009-05-01 Thread Anton Vorontsov
This patch fixes bogus reg = <> property in the localbus node, and fixes interrupt property (should be "interrupts"). Also add node for NAND support. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8569mds.dts | 11 +-- 1 files changed, 9 insertions

[PATCH 2/6] powerpc/85xx: Fix mpc8569emds' crypto node to include SNOW unit

2009-05-01 Thread Anton Vorontsov
fsl,exec-units-mask should be 0xbfe to include SNOW unit in MPC8569E's security engine. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8569mds.dts |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boo

[PATCH 1/6] powerpc/85xx: Add PCI IDs for MPC8569 family processors

2009-05-01 Thread Anton Vorontsov
This patch adds PCI IDs for MPC8569 and MPC8569E processors, plus adds appropriate quirks for these IDs, and thus makes PCI-E actually work on MPC8569E-MDS boards. Signed-off-by: Anton Vorontsov --- arch/powerpc/sysdev/fsl_pci.c |2 ++ include/linux/pci_ids.h |2 ++ 2 files

[PATCH 0/6] Some fixes and enhancements for MPC8569E-MDS boards

2009-05-01 Thread Anton Vorontsov
Hi all, Here are few fixes and improvements for MPC8569E-MDS boards. Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo

Re: [PATCH 1/3] powerpc, Makefile: Make it possible to safely select CONFIG_FRAME_POINTER

2009-05-01 Thread Anton Vorontsov
On Sun, Apr 05, 2009 at 11:07:56PM +0200, Sam Ravnborg wrote: > On Fri, Mar 20, 2009 at 07:44:29PM +0300, Anton Vorontsov wrote: > > This patch introduces ARCH_HAS_NORMAL_FRAME_POINTERS Kconfig symbol. > > When defined, the top level Makefile won't add -fno-omit-frame-pointer

[PATCH 3/3] tracing: Tracers that use CALLER_ADDR macros should select FRAME_POINTER

2009-05-01 Thread Anton Vorontsov
Irqsoff, switch and preempt tracers use CALLER_ADDR macros, so they should select FRAME_POINTER. Otherwise traces are meaningless. Signed-off-by: Anton Vorontsov --- kernel/trace/Kconfig |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kernel/trace/Kconfig b/kernel

[PATCH 2/3] powerpc: Remove -fno-omit-frame-pointer workarounds

2009-05-01 Thread Anton Vorontsov
The workarounds aren't needed any longer since the top level Makefile doesn't pass -fno-omit-frame-pointer cflag for PowerPC builds. Signed-off-by: Anton Vorontsov --- arch/powerpc/Makefile|5 - arch/powerpc/kernel/Makefile | 12 ++--

[PATCH 1/3] powerpc, Makefile: Make it possible to safely select CONFIG_FRAME_POINTER

2009-05-01 Thread Anton Vorontsov
This patch introduces HAVE_NORMAL_FRAME_POINTER Kconfig symbol. When defined, the top level Makefile won't add -fno-omit-frame-pointer cflag (the flag is useless for PowerPC kernels, and also makes gcc generate wrong code). Also move ARCH_WANT_FRAME_POINTERS's help text. Signed-off

[PATCH v5 0/3] Tracers vs. CALLER_ADDR on PowerPC

2009-05-01 Thread Anton Vorontsov
ther code can rely on that. If not, I can just fill-in the asm/ftrace.h for PowerPC. -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 9/9] spi_mpc8xxx: s/83xx/8xxx/g

2009-04-30 Thread Anton Vorontsov
Since we renamed the file, we might want to rename the file internals too. Though we don't bother with changing platform driver name and platform module alias. The stuff is legacy and hopefully we'll remove it soon. Suggested-by: Kumar Gala Signed-off-by: Anton Vorontsov --- d

[PATCH 8/9] spi_mpc83xx: Rename spi_83xx.c to spi_8xxx.c

2009-04-30 Thread Anton Vorontsov
The driver handles MPC83xx, MPC85xx and MPC86xx SPI controllers, so rename the file for clarity. Suggested-by: Kumar Gala Signed-off-by: Anton Vorontsov --- drivers/spi/Makefile |2 +- drivers/spi/spi_mpc83xx.c | 958 - drivers/spi

[PATCH 7/9] spi_mpc83xx: Remove dead code

2009-04-30 Thread Anton Vorontsov
This patch removes #if 0'ed code, and spi_mpc83xx->busy variable that is used by that dead snippet only. Signed-off-by: Anton Vorontsov --- drivers/spi/spi_mpc83xx.c | 16 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/drivers/spi/spi_mpc83xx.c b/dri

[PATCH 6/9] spi_mpc83xx: Split mpc83xx_spi_work() into two routines

2009-04-30 Thread Anton Vorontsov
. Signed-off-by: Anton Vorontsov --- drivers/spi/spi_mpc83xx.c | 115 +++- 1 files changed, 60 insertions(+), 55 deletions(-) diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c index 40f7448..50112a5 100644 --- a/drivers/spi/spi_mpc83xx.c

[PATCH 5/9] spi_mpc83xx: Fix checkpatch issues

2009-04-30 Thread Anton Vorontsov
nsfer(spi, t); WARNING: line over 80 characters #1392: FILE: drivers/spi/spi_mpc8xxx.c:402: + mpc83xx_spi_chipselect(spi, BITBANG_CS_INACTIVE); Signed-off-by: Anton Vorontsov --- drivers/spi/spi_mpc83xx.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/sp

[PATCH 4/9] powerpc/86xx: Add MMC SPI support for MPC8610HPCD boards

2009-04-30 Thread Anton Vorontsov
This patch adds spi and mmc-spi-slot nodes, plus a gpio-controller for PIXIS' sdcsr bank that is used for managing SPI chip-select and for reading card's states. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8610_hpcd.dts | 32 ar

[PATCH 3/9] spi_mpc83xx: Add small delay after asserting chip-select line

2009-04-30 Thread Anton Vorontsov
This is needed for some underlaying GPIO controllers that may be a bit slow, or if chip-select signal need some time to stabilize. For what it's worth, we already have the similar delay for chip-select de-assertion case. Signed-off-by: Anton Vorontsov --- drivers/spi/spi_mpc83xx.c |

[PATCH 2/9] spi_mpc83xx: Quieten down the "Requested speed is too low" message

2009-04-30 Thread Anton Vorontsov
y. Signed-off-by: Anton Vorontsov --- drivers/spi/spi_mpc83xx.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c index f4573a9..08b49d2 100644 --- a/drivers/spi/spi_mpc83xx.c +++ b/drivers/spi/spi_mpc83xx.c @@ -

[PATCH 1/9] spi_mpc83xx: Handles other Freescale processors

2009-04-30 Thread Anton Vorontsov
ely not experimental anymore. Signed-off-by: Anton Vorontsov --- drivers/spi/Kconfig | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 83a185d..3c1845c 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfi

[PATCH 0/9] Some work for spi_mpc83xx driver, spi-mmc support for MPC8610HPCD

2009-04-30 Thread Anton Vorontsov
ssues [6/9] spi_mpc83xx: Split mpc83xx_spi_work() into two routines [7/9] spi_mpc83xx: Remove dead code [8/9] spi_mpc83xx: Rename spi_83xx.c to spi_8xxx.c [9/9] spi_mpc8xxx: s/83xx/8xxx/g Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freeno

[PATCH] mpc52xx_psc_spi: Convert to cs_control callback

2009-04-30 Thread Anton Vorontsov
mpc52xx_psc_spi driver is the last user of the legacy activate_cs and deactivate_cs callbacks, so convert the driver to the cs_control hook and remove the legacy callbacks from fsl_spi_platform_data struct. Signed-off-by: Anton Vorontsov --- drivers/spi/mpc52xx_psc_spi.c | 22

[PATCH] powerpc/fsl_soc: Remove mpc83xx_wdt_init, again

2009-04-30 Thread Anton Vorontsov
ove mpc83xx_wdt code"). Remove it once again. Signed-off-by: Anton Vorontsov --- arch/powerpc/sysdev/fsl_soc.c | 46 - 1 files changed, 0 insertions(+), 46 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c in

Re: [PATCH 3/3] powerpc/86xx: Add MMC SPI support for MPC8610HPCD boards

2009-04-30 Thread Anton Vorontsov
Sorry for the late response, On Sat, Apr 04, 2009 at 05:38:44PM -0700, H. Peter Anvin wrote: > Anton Vorontsov wrote: > > This patch adds spi and mmc-spi-slot nodes, plus a gpio-controller > > for PIXIS' sdcsr bank that is used for managing SPI chip-select and > >

Re: Next April 28: boot failure on PowerPC with SLQB

2009-04-30 Thread Anton Vorontsov
> ret = nextmem; > - nextmem = (void *)((unsigned long)ret + size); > - if ((unsigned long)ret >> PAGE_SHIFT != > - (unsigned long)nextmem >> PAGE_SHIFT) > - nextmem = NULL; > +

[PATCH] alim15x3: Remove historical hacks, re-enable init_hwif for PowerPC

2009-04-27 Thread Anton Vorontsov
harm, and today some PowerPC targets (Xilinx ML510, as reported by Roderick Colenbrander) need the init_hwif, so we have to re-enable it and remove the overwrite. Reported-by: Roderick Colenbrander Suggested-by: Bartlomiej Zolnierkiewicz Signed-off-by: Anton Vorontsov --- On Mon, Apr 27, 2009 at

Re: removing get_immrbase()??

2009-04-23 Thread Anton Vorontsov
On Thu, Apr 23, 2009 at 12:03:06PM -0500, Scott Wood wrote: > Anton Vorontsov wrote: >> On Thu, Apr 23, 2009 at 11:00:48AM -0500, Scott Wood wrote: >>> Even if the given change may not break the firmware, it could force an >>> update in which a prior change breaks the f

Re: removing get_immrbase()??

2009-04-23 Thread Anton Vorontsov
On Thu, Apr 23, 2009 at 11:00:48AM -0500, Scott Wood wrote: > On Thu, Apr 23, 2009 at 05:50:05PM +0400, Anton Vorontsov wrote: > > As for Freescale parts, all the reference board I've seen were > > very friendly wrt upgrading their device-trees, i.e. none of > > the

Re: removing get_immrbase()??

2009-04-23 Thread Anton Vorontsov
On Thu, Apr 23, 2009 at 09:02:49AM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: > > > And note that most developers are using up-to-date firmwares > > (U-Boots), device trees, and kernels. > > Developers? Yes. > End-users? No. If end-users upgraded the kernel on

Re: removing get_immrbase()??

2009-04-23 Thread Anton Vorontsov
ate your device tree > > (thus we have .dts in the kernel tree and not somewhere else). > > Not always possible. The device tree may be 'softer' than firmware, > and easier to update, but it is still firmer than the kernel. That is > why so much effort has been spent to no

Re: removing get_immrbase()??

2009-04-23 Thread Anton Vorontsov
definition. Sure, there is a completely different story wrt device-tree changes that might break firmwares. And that I believe we'd better avoid. For example device_type = "soc", if removed, most firmwares would not fix-up {clock,bus}-freq

[PATCH] fsl_rio: Pass the proper device to dma mapping routines

2009-04-18 Thread Anton Vorontsov
[ef82be40] [c0234f20] of_platform_device_probe+0x5c/0x84 [...] ---[ end trace 561bb236c800851f ]--- This patch fixes the issue. Signed-off-by: Anton Vorontsov --- arch/powerpc/sysdev/fsl_rio.c | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git a/arch

[PATCH] ucc_geth: Move freeing of TX packets to NAPI context

2009-04-17 Thread Anton Vorontsov
From: Joakim Tjernlund This will make the system alot more responsive while ping flooding the ucc_geth ethernet interface. Also set NAPI weight to 64 as this is a common value. Signed-off-by: Joakim Tjernlund Signed-off-by: Anton Vorontsov --- drivers/net/ucc_geth.c | 31

Re: RFC Patch: Use x86 init_hwif in the alim15x3 for x86-like PowerPC systems

2009-04-17 Thread Anton Vorontsov
; > how the chip is configured by reading said configuration and use > > either the legacy interrupts or the PCI one... > > > > > See this commit: > > > > > > commit 6d1cee44361b8d06ccd1812e80448d86ae60dfe3 > > > Author: Anton Voronts

Re: RFC Patch: Use x86 init_hwif in the alim15x3 for x86-like PowerPC systems

2009-04-17 Thread Anton Vorontsov
ine. But they don't. On MPC8610HPCD we have IDE interrupt directly connected to the MPIC line (through PCI sideband interrupt), and i8259 is _completely_ disabled in the bridge. See this commit: commit 6d1cee44361b8d06ccd1812e80448d86ae60dfe3 Author: Anton Vorontsov Date: Tue A

Re: [PATCH 6/6] powerpc/fsl_soc: Isolate legacy fsl_spi support to mpc832x_rdb boards

2009-04-17 Thread Anton Vorontsov
Hi Peter, Sorry for the late response (and don't hesitate to ping me if I don't answer, some things get lost in my inbox traffic, sorry). On Wed, Apr 08, 2009 at 11:18:43AM +0200, Peter Korsgaard wrote: > >>>>> "Anton" == Anton Vorontsov writes: >

Re: RFC Patch: Use x86 init_hwif in the alim15x3 for x86-like PowerPC systems

2009-04-16 Thread Anton Vorontsov
On Thu, Apr 16, 2009 at 11:27:34PM +0200, Roderick Colenbrander wrote: > On Thu, Apr 16, 2009 at 10:57 PM, Anton Vorontsov > wrote: > > On Thu, Apr 16, 2009 at 09:30:00PM +0200, Bartlomiej Zolnierkiewicz wrote: > >> > >> Hi, > >> > >> On Wednes

Re: RFC Patch: Use x86 init_hwif in the alim15x3 for x86-like PowerPC systems

2009-04-16 Thread Anton Vorontsov
+ * which use a Ali M15x3 south bridge like e.g. Xilinx ML310/410/510. > > */ > > > > static void __devinit init_hwif_ali15x3 (ide_hwif_t *hwif) > > @@ -455,7 +456,7 @@ static void __devinit init_hwif_ali15x3 (ide_hwif_t > > *hwif) > > } > > #else >

<    1   2   3   4   5   6   7   8   9   10   >