Re: [PATCH 1/3] tools/perf: Fix the nrcpus in perf bench futex to enable the run when all CPU's are not online

2024-06-10 Thread Disha Goel
sible cpus and not the number of online cpus. Signed-off-by: Athira Rajeev Thanks for the fix patches, Athira. I have tested all three patches on a power machine (both small and max config), and the perf bench futex and epoll tests run fine. For the series: Tested-by: Disha Goel --- tools/perf/b

Re: [PATCH] perf test record+probe_libc_inet_pton: Fix call chain match on powerpc

2023-11-28 Thread Disha Goel
o.6) 11ef03534 [unknown] (/usr/bin/ping) test child finished with 0 end probe libc's inet_pton & backtrace it with ping: Ok Signed-off-by: Likhitha Korrapati Reported-by: Disha Goel Thanks for the fix patch. I have tested on a Power10 machine, "probe libc's inet_pton & backtr

Re: [PATCH] perf vendor events: Update datasource event name to fix duplicate events

2023-11-27 Thread Disha Goel
s correctly without any segfault now. # ./perf list List of pre-defined events (to be used in -e or -M): branch-instructions OR branches[Hardware event] branch-misses [Hardware event] Tested-by: Dis

Re: [PATCH] tools/perf/arch/powerpc: Fix the CPU ID const char* value by adding 0x prefix

2023-10-10 Thread Disha Goel
er: --- start --- test child forked, pid 87922 Using CPUID 0x00800200 division by zero syntax error test child finished with 0 ---- end ---- Simple expression parser: Ok Tested-by: Disha Goel --- tools/perf/arch/powerpc/util/header.c | 2 +- tools/pe

Re: [V2 2/2] tools/perf/tests: Fix object code reading to skip address that falls out of text section

2023-09-14 Thread Disha Goel
is check. To address this issue in "perf report", exploring an option of having stubs range as part of the /proc/kallsyms, so that perf report can resolve addresses in stubs range However this patch uses text_end to skip the stub range for Object code reading testcase. Reported-by: Dish

Re: [PATCH] powerpc/perf/hv-24x7: Update domain value check

2023-08-25 Thread Disha Goel
core=1/ event is not supported by the kernel. failed to read counter hv_24x7/CPM_ADJUNCT_INST,domain=0,core=1/ Performance counter stats for 'system wide': hv_24x7/CPM_ADJUNCT_INST,domain=0,core=1/ 1.001352771 seconds time elapsed Tested-by: Disha Goel --- arch/powerpc/perf/

Re: [PATCH] perf test: Skip perf bench breakpoint run if no breakpoints available

2023-08-23 Thread Disha Goel
ch changes: [command]# ./perf bench breakpoint thread Skipping perf bench breakpoint thread: No hardware support Reported-by: Disha Goel Signed-off-by: Kajol Jain With this patch applied perf bench breakpoint test works correctly on Power9 and Power10. Result on Power9 system with patch chan

Re: [PATCH V2 2/2] tools/perf/tests: perf all metricgroups test fails when perf_event access is restricted

2023-08-07 Thread Disha Goel
ss or fail for the testcase. Signed-off-by: Athira Rajeev With this patch applied(on power) perf metricgroups test works correctly when perf_event access is restricted. # ./perf test "perf all metricgroups test" 96: perf all metricgroups test : Ok T

Re: [PATCH] tests/bpf: Fix the bpf test to check for libtraceevent support

2023-02-06 Thread Disha Goel
: Skip (not compiled in or missing libtraceevent support) Tested-by: Disha Goel --- tools/perf/tests/bpf.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c index 17c023823713..4af3

Re: [PATCH] tools/perf/tests: Add system wide check for perf bench workload in all metric test

2023-02-06 Thread Disha Goel
wide check for perf bench workload. Result with the patch changes in powerpc: 92: perf all metrics test : Ok Signed-off-by: Kajol Jain Tested the patch on powerpc machine, perf metrics test works fine.  91: perf all metrics test   : Ok Tested-by:

Re: [PATCH V3] tools/perf/tests: Fix string substitutions in build id test

2023-01-20 Thread Disha Goel
ests/shell/buildid.sh: Bad substitution test child finished with -2 end After applying the patch in same environment, error is not seen and test runs fine. Tested the same patch in bash as well. # readlink -f $(which sh) /usr/bin/bash The test works fine with the changes. Tested-by: Disha Goe

Re: [PATCH 1/2] tools/perf: Fix printing os->prefix in CSV metrics output

2022-11-04 Thread Disha Goel
,backend cycles idle S0,1,88766,,instructions,2030942,100.00,0.35,insn per cycle S0,1,,,1.27,stalled cycles per insn Fixes: 92a61f6412d3 ("perf stat: Implement CSV metrics output") Reported-by: Disha Goel Signed-off-by: Athira Rajeev perf stat csv test passed afte

Re: [PATCH 1/2] tools/perf/tests/shell: Update stat+csv_output.sh to include sanity check for topology

2022-10-17 Thread Disha Goel
56dbc9 ("perf test: Add checking for perf stat CSV output.") Reported-by: Disha Goel Signed-off-by: Athira Rajeev Suggested-by: James Clark Suggested-by: Ian Rogers For the patchset, Tested-by: Disha Goel --- tools/perf/tests/shell/stat+csv_output.sh | 43

Re: [PATCH 1/3] powerpc/perf: Fix branch_filter support for multiple filters in powerpc

2022-09-16 Thread Disha Goel
n't support sampling/overflow-interrupts. Try 'perf stat' Reported-by: Disha Goel Signed-off-by: Athira Rajeev Reviewed-by: Madhavan Srinivasan Tested-by: Disha Goel --- arch/powerpc/perf/core-book3s.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/powerpc/per

Re: [PATCH] tools/perf: Fix aggr_printout to display cpu field irrespective of core value

2022-09-16 Thread Disha Goel
59,418 instructions CPU-1 70,478 instructions CPU-1 65,201 instructions CPU-1 63,704 instructions <<>> This is caught while running "perf test" for "stat+json_output.sh" and "stat+csv_

Re: [PATCH V2] tools/perf/tests: Fix perf probe error log check in skip_if_no_debuginfo

2022-09-16 Thread Disha Goel
e above error, to skip the test in these scenarios too. Reported-by: Disha Goel Signed-off-by: Athira Rajeev Tested-by: Disha Goel --- changelog: v1 -> v2: Corrected formatting of spaces in error log. With spaces in v1 of the patch, the egrep search was considering spaces also

[PATCH v2 2/2] powerpc/kvm: Remove unused references for MMCR3/SIER2/SIER3 registers

2022-09-16 Thread Disha Goel
From: Kajol Jain" Commit 57dc0eed73ca ("KVM: PPC: Book3S HV P9: Implement PMU save/restore in C") removed the PMU save/restore functions from assembly code and implemented these functions in C, for power9 and later platforms. After the code refactoring, Performance Monitoring Unit (PMU)

[PATCH v2 1/2] powerpc/kvm: Remove unused macros from asm-offset

2022-09-16 Thread Disha Goel
and v3.1 support from P7/8 path") Commit 57dc0eed73ca ("KVM: PPC: Book3S HV P9: Implement PMU save/restore in C") Many of the asm-offset macro definitions were missed to remove. Patch fixes by removing the unused macros. Signed-off-by: Disha Goel --- arch/powerpc/kernel/asm-off

[PATCH v2 0/2] Remove unused macros from asm-offset

2022-09-16 Thread Disha Goel
xppc-dev/patch/20220913074025.132160-2-disg...@linux.vnet.ibm.com/ Link to the script used to get unused macro: https://github.com/maddy-kerneldev/scripts/blob/master/check_asm-offset.sh Link to linux-ci job result: https://github.com/disgoel/linux-ci/actions?query=branch%3Akvmmacro.v2 Disha Go

Re: [PATCH 0/4] Remove unused macros from asm-offset

2022-09-14 Thread Disha Goel
On 9/13/22 1:45 PM, Christophe Leroy wrote: Le 13/09/2022 à 09:40, Disha Goel a écrit : There were commits which did code refactoring and converting some of kvm assembly routines to C. When doing it, many of the asm-offset macro definitions were missed to remove. Patchset here removes those

[PATCH 4/4] powerpc/kvm: Remove unused references for MMCR3/SIER2/SIER3 registers

2022-09-13 Thread Disha Goel
From: Kajol Jain Commit 57dc0eed73ca ("KVM: PPC: Book3S HV P9: Implement PMU save/restore in C") removed the PMU save/restore functions from assembly code and implemented these functions in C, for power9 and later platforms. After the code refactoring, Performance Monitoring Unit (PMU)

[PATCH 3/4] powerpc/kvm: Remove unused macros from asm-offset

2022-09-13 Thread Disha Goel
re un-used. Patch fixes by removing those. Fixes: fae5c9f3664b ("KVM: PPC: Book3S HV: remove ISA v3.0 and v3.1 support from P7/8 path") Signed-off-by: Disha Goel --- arch/powerpc/kernel/asm-offsets.c | 20 1 file changed, 20 deletions(-) diff --git a/arch/powerpc/ker

[PATCH 2/4] powerpc/asm-offset: Remove unused KVM_RADIX macros

2022-09-13 Thread Disha Goel
it. Fixes: 9769a7fd79b6 ("KVM: PPC: Book3S HV: Remove radix guest support from P7/8 path") Signed-off-by: Disha Goel --- arch/powerpc/kernel/asm-offsets.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c index d5d9c1dcef1c.

[PATCH 1/4] powerpc/asm-offset: Remove unused KVM_TLB_SETS macros

2022-09-13 Thread Disha Goel
this is un-used. Patch fixes by removing this. Fixes: 2e1ae9cd56f8 ("KVM: PPC: Book3S HV: Implement radix prefetch workaround by disabling MMU") Signed-off-by: Disha Goel --- arch/powerpc/kernel/asm-offsets.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kernel/a

[PATCH 0/4] Remove unused macros from asm-offset

2022-09-13 Thread Disha Goel
Link to linux-ci job result: https://github.com/disgoel/linux-ci/actions Disha Goel (3): powerpc/asm-offset: Remove unused KVM_TLB_SETS macros powerpc/asm-offset: Remove unused KVM_RADIX macros powerpc/kvm: Remove unused macros from asm-offset Kajol Jain (1): powerpc/kvm: Remove unused

Re: [PATCH V2] tools/perf/tests: Fix session topology test to skip the test in guest environment

2022-05-13 Thread Disha Goel
rtions(+) Tested the patch on powerpc and powernv, session topology test works fine with the patch.Tested-by: Disha Goel diff --git a/tools/perf/tests/topology.c b/tools/perf/tests/topology.cindex ee1e3dcbc0bd..d23a9e322ff5 100644--- a/tools/perf/tests/topology.c+++ b/tools/perf/tests/topo

Re: [PATCH V2] tools/perf/tests: Skip perf BPF test if clang is not present

2022-05-13 Thread Disha Goel
1fae431e74 ("perf test: Add 'perf test BPF'")Signed-off-by: Athira Rajeev ---Changelog: Addressed review comments from Arnaldo by adding reason for skipping of testcase. tools/perf/tests/bpf.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) Tested the patch on powerpc and powernv

Re: [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries

2022-05-05 Thread Disha Goel
Kajol. Use "strim" to remove space from string. Also use "feof" to check for EOF instead of using new variable "ret". Tested the patches on powervm and powernv, verified perf test session topology test with the patch set.Tested-by: Disha Goel < disg...@linux.vnet.

Re: [PATCH 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries

2022-04-29 Thread Disha Goel
rf test session topology test with the patch set.Tested-by: Disha Goel < disg...@linux.vnet.ibm.com> tools/perf/tests/topology.c | 17 tools/perf/util/header.c| 54 + tools/perf/util/header.h| 1 + 3 files changed, 72 insertions(+)

Re: [PATCH V3 0/2] Fix perf bench numa to work with machines having #CPUs > 1K

2022-04-13 Thread Disha Goel
fixing the compilation issues observed in debian Tesed the patches on powerpc with CPU > 1K and other configurations as well, verified the perf bench numa with the patch set.Tested-by: Disha Goel tools/perf/bench/numa.c | 136 +-- tools/perf/util/header.c | 51

Re: [PATCH 0/4] tools/perf: Fix perf bench numa, futex and epoll to work with machines having #CPUs > 1K

2022-04-06 Thread Disha Goel
igurations as well, verified the perf benchmark numa, futex and epoll for whole series with the patch set.Tested-by: Disha Goel < disg...@linux.vnet.ibm.com> tools/perf/bench/epoll-ctl.c | 25 -- tools/perf/bench/epoll-wait.c | 25 -- tools/perf/bench/fute