[patch 0/3] PS3 patches for 2.6.29

2008-12-03 Thread Geoff Levand
Hi Paul, Here is a small set of patches for 2.6.29. Please consider them for your next branch. [patch 1/3] powerpc: Fix typo in pgtable-ppc64.h [patch 2/3] powerpc/ps3: Quiet dmesg output [patch 3/3] powerpc/ps3: Add sub-match id modalias support -Geoff --

[patch 1/3] powerpc: Fix typo in pgtable-ppc64.h

2008-12-03 Thread Geoff Levand
Fix a minor comment typo in pgtable-ppc64.h. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/include/asm/pgtable-ppc64.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/powerpc/include/asm/pgtable-ppc64.h +++ b/arch/powerpc/include/asm/pgtable-ppc64.h

[patch 2/3] powerpc/ps3: Quiet dmesg output

2008-12-03 Thread Geoff Levand
Change the debug message in dma_sb_region_create() from pr_info() to DBG() to quiet the dmesg output. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/mm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/powerpc/platforms/ps3/mm.c +++ b/arch

[patch 3/3] powerpc/ps3: Add sub-match id modalias support

2008-12-03 Thread Geoff Levand
-devices. - Rename PS3_MODULE_ALIAS_GRAPHICS to PS3_MODULE_ALIAS_GPU_FB, as ps3fb binds to the FB sub-device. Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/include/asm/ps3.h | 57

Re: RTC problem in PS3

2008-12-02 Thread Geoff Levand
driver, so when it is build as a loadable module udev can't figure out which driver to load. Here is some discussion Geert and I had: Original Message On Tue, 2 Dec 2008, Geert Uytterhoeven wrote: On Mon, 1 Dec 2008, Geoff Levand wrote: There is a similar problem when the new

Re: [PATCH] ps3: ps3-lpm.c compile fix

2008-11-03 Thread Geoff Levand
-by: Geoff Levand [EMAIL PROTECTED] --- a/drivers/ps3/ps3-lpm.c +++ b/drivers/ps3/ps3-lpm.c @@ -22,6 +22,7 @@ #include linux/module.h #include linux/interrupt.h #include linux/uaccess.h +#include asm/smp.h #include linux/smp.h? Nope, everybody else uses asm/smp.h

[patch] powerpc/ps3: Replace the flip_ctl logic in ps3av and ps3fb by a mutex

2008-10-30 Thread Geoff Levand
driver. Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- This was submitted to the linux-fbdev-devel and cbe-oss-dev MLs for review some time ago with no comments so far. Please consider for 2.6.29. -Geoff arch/powerpc/include/asm/ps3.h

[patch 0/4] PS3 patches for 2.6.27

2008-08-20 Thread Geoff Levand
Hi Paul, This is a set of PS3 fixup patches for 2.6.27. Patch 4/4, Fix ioremap of spu shadow regs, is a bit of a hack, but I can't think of a better way to get the needed protection bits. [patch 1/4] powerpc: Fix typo in pgtable-ppc64.h [patch 2/4] powerpc/ps3: Update ps3_defconfig [patch

[patch 1/4] powerpc: Fix typo in pgtable-ppc64.h

2008-08-20 Thread Geoff Levand
Fix a minor comment typo in pgtable-ppc64.h. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/include/asm/pgtable-ppc64.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/powerpc/include/asm/pgtable-ppc64.h +++ b/arch/powerpc/include/asm/pgtable-ppc64.h

[patch 2/4] powerpc/ps3: Update ps3_defconfig

2008-08-20 Thread Geoff Levand
Update ps3_defconfig. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/configs/ps3_defconfig | 153 - 1 file changed, 133 insertions(+), 20 deletions(-) --- a/arch/powerpc/configs/ps3_defconfig +++ b/arch/powerpc/configs/ps3_defconfig @@ -1,7

[patch 4/4] powerpc/ps3: Fix ioremap of spu shadow regs

2008-08-20 Thread Geoff Levand
Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/spu.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) --- a/arch/powerpc/platforms/ps3/spu.c +++ b/arch/powerpc/platforms/ps3/spu.c @@ -186,14 +186,24 @@ static void

[patch 3/4] powerpc/ps3: Rework htab to remove ioremap

2008-08-20 Thread Geoff Levand
a1f242ff460e4b50a045fa237c3c56cce9eabf83. Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED] CC: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/htab.c | 269 - arch/powerpc/platforms/ps3/setup.c |1 2

Re: PS3 early lock-up

2008-08-05 Thread Geoff Levand
Benjamin Herrenschmidt wrote: arch/powerpc/platfroms/ps3/htab.c:ps3_hpte_updatepp() uses `htab[slot].v'. Ok, that leaves us with 2 options: - Change ps3_hpte_updatepp() to not read from the hash table via that mapping (ie, do you have an LV1 call to read an HPTE ? Do you measure any

Re: PS3 early lock-up

2008-08-04 Thread Geoff Levand
Hi, Benjamin Herrenschmidt wrote: ps3_hpte_insert() seems to be called during system initialization with the following values of rflags: - first call: 0x190 - initial memory: 0x194 (455 times) - hotplug memory: o crash: 0x115 o OK: 0x117 Do you have an idea of

Re: going to OLS?

2008-07-18 Thread Geoff Levand
Kumar Gala wrote: So if your headed to OLS respond to this thread and maybe we'll have an inform PPC BoF @ a pub. I will go. -Geoff ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

PS3 patches for 2.6.27

2008-07-16 Thread Geoff Levand
Hi Ben, Here are two more PS3 patches for 2.6.27. Please apply. -Geoff ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[patch 1/2] powerpc/ps3: Add a sub-match id to ps3_system_bus

2008-07-16 Thread Geoff Levand
From: Masakazu Mokuno [EMAIL PROTECTED] Add sub match id for ps3 system bus so that two different system bus devices can be connected to a shared device. Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/device-init.c

Re: [patch 07/11] powerpc/dma: implement new dma_*map*_attrs() interfaces

2008-07-07 Thread Geoff Levand
in this patch are ok but I'd like you to double-check and send your ack if you think they are. I tested on PS3 with ps3_defconfig, and it works OK. Acked-by: Geoff Levand [EMAIL PROTECTED] Signed-off-by: Mark Nelson [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- arch

Re: [patch 05/11] powerpc/cell: add spu aware cpufreq governor

2008-07-07 Thread Geoff Levand
[EMAIL PROTECTED] wrote: This patch adds a cpufreq governor that takes the number of running spus into account. It's very similar to the ondemand governor, but not as complex. Instead of hacking spu load into the ondemand governor it might be easier to have cpufreq accepting multiple governors

[patch] PS3: Quiet system bus match output

2008-07-01 Thread Geoff Levand
Reduce the output verbosity of ps3_system_bus_match(). Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- Paul, Please queue for 2.6.27. -Geoff arch/powerpc/platforms/ps3/system-bus.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) --- a/arch/powerpc/platforms

Re: [Cbe-oss-dev] 2.6.26-rc6 kernel bug on PS3?

2008-06-25 Thread Geoff Levand
On 06/25/2008 06:01 AM, Stefan Wald wrote: Hi, I think we have a kernel bug here... running a multimedia app with about 20 spe contexts. Application hangs after a while defunct and dmesg output looks like d.txt. Is it repeatable? Nothing in your dump looks ps3 specific. Did you try with a

Re: [rtc-linux] state of GEN_RTC vs rtc subsystem

2008-06-02 Thread Geoff Levand
Geoff Levand wrote: Alessandro Zummo wrote: On Wed, 20 Feb 2008 10:11:23 -0600 Kumar Gala [EMAIL PROTECTED] wrote: Is the functionality provided by drivers/char/gen_rtc.c completely handled by the rtc subsystem in drivers/rtc? I ask for two reasons: 1. should we make it mutually

Re: [rtc-linux] state of GEN_RTC vs rtc subsystem

2008-05-30 Thread Geoff Levand
Alessandro Zummo wrote: On Wed, 20 Feb 2008 10:11:23 -0600 Kumar Gala [EMAIL PROTECTED] wrote: Is the functionality provided by drivers/char/gen_rtc.c completely handled by the rtc subsystem in drivers/rtc? I ask for two reasons: 1. should we make it mutually exclusive in Kconfig 2.

Debian kernel updates for Cell platforms

2008-05-24 Thread Geoff Levand
I made an updated debian config.powerpc64 to enable support for the PS3 and fix the QS20 and QS21 options. I put a kernel, initrd and modules archive here: http://cell.gotdns.org/pub/debian-cell-kernel-1/ Could people please test and report on various powerpc64 platforms. -Geoff

Re: [patch v2] PS3: Fix memory hotplug

2008-05-21 Thread Geoff Levand
Geoff Levand wrote: A change was made to walk_memory_resource() in commit 4b119e21d0c66c22e8ca03df05d9de623d0eb50f that added a check of find_lmb(). Add the coresponding lmb_add() call to ps3_mm_add_memory() so that that check will succeed. This fixes the condition where the PS3 boots up

Re: PS3: Fix memory hotplug

2008-05-21 Thread Geoff Levand
Paul Mackerras wrote: Benjamin Herrenschmidt writes: When you do an lmb_add you should probably also do an lmb_analyze to update the total memory count etc... That leads to some interesting issues such as the LMB stuff wasn't really meant to be dynamically modified after boot, and thus

[rfc] [patch] LMB: Add basic spin locking to lmb

2008-05-19 Thread Geoff Levand
Add a spinlock to struct lmb to enforce concurrency in lmb_add(), lmb_remove(), lmb_analyze(), and lmb_dump_all(). This locking is needed for SMP systems that access the lmb structure during hot memory add and remove operations after secondary cpus have been started. Signed-off-by: Geoff Levand

[patch v2] LMB: Add basic spin locking to lmb

2008-05-19 Thread Geoff Levand
-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Add locking to lmb_find(). include/linux/lmb.h |1 lib/lmb.c | 62 2 files changed, 49 insertions(+), 14 deletions(-) --- a/include/linux/lmb.h +++ b/include/linux/lmb.h @@ -30,6 +30,7

Re: Convert remaining dts-v0 files to v1

2008-05-15 Thread Geoff Levand
-2.6/arch/powerpc/boot/dts/ps3.dts 2008-05-15 16:32:08.0 +1000 I tested this on PS3 and it seems to work OK. Acked-by: Geoff Levand [EMAIL PROTECTED] ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo

[patch v2] PS3: Fix memory hotplug

2008-05-15 Thread Geoff Levand
of boot memory. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: Add call to lmb_analyze(). arch/powerpc/platforms/ps3/mm.c |3 +++ 1 file changed, 3 insertions(+) --- a/arch/powerpc/platforms/ps3/mm.c +++ b/arch/powerpc/platforms/ps3/mm.c @@ -317,6 +317,9 @@ static int __init

Re: [RFC] [PATCH] vmemmap fixes to use smaller pages

2008-05-15 Thread Geoff Levand
Benjamin Herrenschmidt wrote: This patch changes vmemmap to use a different region (region 0xf) of the address space whose page size can be dynamically configured at boot. This doesn't seem to cause any problems, and users successfully used it with the ubuntu hardy kernel, so I think it is OK

PS3: Fix memory hotplug

2008-05-13 Thread Geoff Levand
of boot memory. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- Paul, Please send this one upstream at your earliest convenience. -Geoff arch/powerpc/platforms/ps3/mm.c |2 ++ 1 file changed, 2 insertions(+) --- a/arch/powerpc/platforms/ps3/mm.c +++ b/arch/powerpc/platforms/ps3/mm.c

Re: [PATCH 5/5] [PPC] provide walk_memory_resource() for ppc

2008-05-12 Thread Geoff Levand
Hi, I've had some trouble with this change. Badari Pulavarty wrote: Provide walk_memory_resource() for ppc64. PPC maintains logic memory region mapping in lmb.memory structures. Walk through these structures and do the callbacks for the contiguous chunks. ... ---

Re: [patch 5/5] PS3: Update ps3_defconfig

2008-05-05 Thread Geoff Levand
Marvin wrote: what about adding these defaults: - CONFIG_SCHED_SMT - CONFIG_HUGETLBFS (needed by ibm cell sdk) not sure about: - CONFIG_SPU_FS_64K_LS Did you test these options? Please let me know your results. -Geoff

Re: [RFC] [PATCH] vmemmap fixes to use smaller pages

2008-05-02 Thread Geoff Levand
Benjamin Herrenschmidt wrote: On Thu, 2008-05-01 at 14:46 -0700, Geoff Levand wrote: It doesn't seem to cause problems on PS3, and I added it into ps3-linux.git as other/powerpc-vmemmap-variable-page-size.diff, but I couldn't get it to fail without the patch... Could you send me your

Re: powerpc boot regression

2008-05-01 Thread Geoff Levand
Badari Pulavarty wrote: On Thu, 2008-05-01 at 15:13 +1000, Tony Breeds wrote: On Tue, Apr 29, 2008 at 11:12:41PM -0700, David Miller wrote: This commit causes bootup failures on sparc64: commit 86f6dae1377523689bd8468fed2f2dd180fc0560 Author: Yasunori Goto [EMAIL PROTECTED] Date:

Re: [RFC] [PATCH] vmemmap fixes to use smaller pages

2008-05-01 Thread Geoff Levand
Benjamin Herrenschmidt wrote: This patch changes vmemmap to use a different region (region 0xf) of the address space whose page size can be dynamically configured at boot. The problem with the current approach of always using 16M pages is that it's not well suited to machines that have small

Re: [RFC] [PATCH] vmemmap fixes to use smaller pages

2008-04-30 Thread Geoff Levand
Benjamin Herrenschmidt wrote: This patch changes vmemmap to use a different region (region 0xf) of the address space whose page size can be dynamically configured at boot. The problem with the current approach of always using 16M pages is that it's not well suited to machines that have small

[patch 0/5] PS3 patches for 2.6.26

2008-04-30 Thread Geoff Levand
Paul, This is a small set of PS3 fixup patches for 2.6.26. [patch 1/5] POWERPC: Fix slb.c compile warnings [patch 2/5] PS3: Add time include to lpm [patch 3/5] PS3: Make ps3_virq_setup and ps3_virq_destroy static [patch 4/5] PS3: Remove unsupported wakeup sources [patch 5/5] PS3:

[patch 4/5] PS3: Remove unsupported wakeup sources

2008-04-30 Thread Geoff Levand
Other OS wakeup is not supported from the IR controller, the bluetooth controller nor the RTC. Remove references to these in the PS3 sys-manager source. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- drivers/ps3/ps3-sys-manager.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions

[patch 5/5] PS3: Update ps3_defconfig

2008-04-30 Thread Geoff Levand
Update ps3_defconfig. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/configs/ps3_defconfig | 132 +++-- 1 file changed, 84 insertions(+), 48 deletions(-) --- a/arch/powerpc/configs/ps3_defconfig +++ b/arch/powerpc/configs/ps3_defconfig @@ -1,7

[patch 3/5] PS3: Make ps3_virq_setup and ps3_virq_destroy static

2008-04-30 Thread Geoff Levand
From: Geert Uytterhoeven [EMAIL PROTECTED] The routines ps3_virq_setup() and ps3_virq_destroy() are used in only one file, so make them static. Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/interrupt.c |6

[patch] PS3: Fix gelic net module dependency

2008-04-09 Thread Geoff Levand
reference to `.ps3_sys_manager_set_wol' CC: Masakazu Mokuno [EMAIL PROTECTED] CC: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- Hi Paul, This fixes an error introduced in my 2.6.26 WOL patches now queued in your powerpc tree. Please apply. -Geoff drivers/net

[patch] PS3: Split device setup for static vs. dynamic devices

2008-03-28 Thread Geoff Levand
of storage devices that may appear later in the PS3 repository. This fixes a few section mismatch warnings. Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- Hi Paul, Here is another one for 2.6.26 that Geert just sent me. Please apply

[patch 3/6 v2] PS3: Bootwrapper improvements

2008-03-27 Thread Geoff Levand
if the overlay code is too big. o Remove some unused instructions. o Update the text describing the PS3 bootwrapper overlay. o Add a check for null pointer writes. o Change hcall return value from s64. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Cleanup null check code. arch/powerpc

[patch 0/6] PS3 patches for 2.6.26

2008-03-26 Thread Geoff Levand
Paul and Jeff, This is a small set of PS3 patches for 2.6.26. Patches 1-5 are ready to apply to the powerpc tree. Patch 6 for the network driver needs an ACK by Jeff. [1/6] PS3: Fix unlikely typo in ps3_get_irq [2/6] PS3: Add ps3_get_speid routine [3/6] PS3: Bootwrapper improvements

[patch 1/6] PS3: Fix unlikely typo in ps3_get_irq

2008-03-26 Thread Geoff Levand
From: Roel Kluin [EMAIL PROTECTED] Fix a typo bug 'unlikely(x) == y' and add an unlikely() call to an unlikely code path in the PS3 interrupt routine ps3_get_irq(). Signed-off-by: Roel Kluin [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3

[patch 2/6] PS3: Add ps3_get_speid routine

2008-03-26 Thread Geoff Levand
From: Takashi Yamamoto [EMAIL PROTECTED] Add a new routine ps3_get_speid() which returns the logical SPE ID. This ID is needed for profiling support. Signed-off-by: Takashi Yamamoto [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/spu.c |7

[patch 3/6] PS3: Bootwrapper improvements

2008-03-26 Thread Geoff Levand
if the overlay code is too big. o Remove some unused instructions. o Update the text describing the PS3 bootwrapper overlay. o Add a check for null pointer writes. o Change hcall return value from s64. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/boot/ps3-head.S | 25

[patch 4/6] PS3: Save power in busy loops on halt

2008-03-26 Thread Geoff Levand
-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/setup.c | 12 +++- drivers/ps3/ps3-sys-manager.c | 30 -- drivers/ps3/sys-manager-core.c | 16 ++-- include/asm-powerpc/ps3.h |5 +++-- 4 files changed, 44

[patch 5/6] PS3: Sys-manager Wake-on-LAN support

2008-03-26 Thread Geoff Levand
Add Wake-on-LAN support to the PS3 system-manager. Other OS WOL support was introduced in PS3 system firmware 2.20. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- drivers/ps3/ps3-sys-manager.c | 46 -- include/asm-powerpc/ps3.h |2 + 2 files

[patch 6/6] PS3: Gelic network driver Wake-on-LAN support

2008-03-26 Thread Geoff Levand
From: Masakazu Mokuno [EMAIL PROTECTED] Add Wake-on-LAN support to the PS3 Gelic network driver. Other OS WOL support was introduced in PS3 system firmware 2.20. Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- drivers/net/ps3_gelic_net.c | 81

Re: [patch 5/6] PS3: Sys-manager Wake-on-LAN support

2008-03-26 Thread Geoff Levand
Hi, Benjamin Herrenschmidt wrote: On Wed, 2008-03-26 at 17:39 -0700, Geoff Levand wrote: Add Wake-on-LAN support to the PS3 system-manager. Other OS WOL support was introduced in PS3 system firmware 2.20. There is no sleep in the first place tho :-) Or does this power it up / boot

Re: [PATCH] [POWERPC] bootwrapper: Allow specifying of image physical offset

2008-03-07 Thread Geoff Levand
On 03/07/2008 08:55 AM, Kumar Gala wrote: Normally we assume kernel images will be loaded at offset 0. However there are situations, like when the kernel itself is running at a non-zero physical address, that we don't want to load it at 0. Allow the wrapper to take an offset. We use this

[patch] PS3: Fix unlikely typo in ps3_get_irq

2008-02-28 Thread Geoff Levand
From: Roel Kluin [EMAIL PROTECTED] Fix a typo bug 'unlikely(x) == y' and add an unlikely() call to an unlikely code path in the PS3 interrupt routine ps3_get_irq(). Signed-off-by: Roel Kluin [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- Hi Paul, Please apply for 2.6.25

Re: [PATCH 0/3] hotplug memory remove updates

2008-02-28 Thread Geoff Levand
Hi. Nathan Lynch wrote: Badari Pulavarty wrote: Hi Paul, Here are the hotplug memory remove updates for 2.6.25-rc2-mm1. How have these been tested? Have you initiated a memory remove operation from the HMC? That's the only way to catch some bugs... I'm wondering how the memory hot

Re: [PATCH] ps3: Fix unlikely incorrect usage

2008-02-24 Thread Geoff Levand
On 02/24/2008 12:06 AM, Samuel Tardieu wrote: Fix unlikely(plug) == NO_IRQ into unlikely(plug == NO_IRQ). Signed-off-by: Samuel Tardieu [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/interrupt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks for the submission, but

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-16 Thread Geoff Levand
On 02/16/2008 08:08 AM, Roel Kluin wrote: The patch below was not yet tested. If it's correct as it is, please comment. - if (unlikely(plug) == NO_IRQ) { + if (unlikely(plug == NO_IRQ)) { A good catch! I'll put it in with some other 2.6.25 bug fixes. -Geoff

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-16 Thread Geoff Levand
On 02/16/2008 09:42 AM, Arjan van de Ven wrote: On Sat, 16 Feb 2008 18:33:16 +0100 Willy Tarreau [EMAIL PROTECTED] wrote: On Sat, Feb 16, 2008 at 09:25:52AM -0800, Arjan van de Ven wrote: On Sat, 16 Feb 2008 17:08:01 +0100 Roel Kluin [EMAIL PROTECTED] wrote: The patch below was not

[patch 0/6] PS3 fixups for 2.6.25

2008-02-08 Thread Geoff Levand
Paul, Here are a few PS3 fixups to apply for 2.6.25. [patch 1/6] PS3: Fix lpm set bookmark [patch 2/6] PS3: Fix lpm read pm interval [patch 3/6] PS3: Fix bootwrapper hang bug [patch 4/6] PS3: Use system reboot on restart [patch 5/6] PS3: Sys-manager code cleanup [patch 6/6] PS3:

[patch 1/6] PS3: Fix lpm set bookmark

2008-02-08 Thread Geoff Levand
of the db10cyc instruction did not work correctly. This change replaces the db10cyc instruction with 10 nop instructions. Signed-off-by: Takashi Yamamoto [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- drivers/ps3/ps3-lpm.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[patch 4/6] PS3: Use system reboot on restart

2008-02-08 Thread Geoff Levand
-by: Geoff Levand [EMAIL PROTECTED] --- drivers/ps3/ps3-sys-manager.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) --- a/drivers/ps3/ps3-sys-manager.c +++ b/drivers/ps3/ps3-sys-manager.c @@ -622,7 +622,7 @@ static void ps3_sys_manager_final_restar ps3_vuart_cancel_async(dev

[patch 5/6] PS3: Sys-manager code cleanup

2008-02-08 Thread Geoff Levand
General code cleanups for PS3 system-manager: o Move all MODULE_ macros to bottom. o Correct PS3_SM_WAKE_P_O_R value. o Enhance comment on wakeup source values. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- drivers/ps3/ps3-sys-manager.c | 13 +++-- 1 file changed, 7 insertions

[patch 2/6] PS3: Fix lpm read pm interval

2008-02-08 Thread Geoff Levand
From: Takashi Yamamoto [EMAIL PROTECTED] ps3_read_pm (pm_interval) should return an actual HW register value because the pm_interval register is a counter register. This patch removes the shadow pm_interval register. Signed-off-by: Takashi Yamamoto [EMAIL PROTECTED] Signed-off-by: Geoff Levand

[patch 3/6] PS3: Fix bootwrapper hang bug

2008-02-08 Thread Geoff Levand
, the system hangs with a blank screen. Earlier firmwares don't cause such a catastrophic failure, and so this bug went undetected. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/boot/ps3-hvcall.S |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/powerpc/boot/ps3

[patch 6/6] PS3: Update sys-manager button events

2008-02-08 Thread Geoff Levand
PS3 firmware 1.94 added the source of power and reset events to the payload of the system manager POWER_PRESSED and RESET_PRESSED events. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- drivers/ps3/ps3-sys-manager.c | 29 +++-- 1 file changed, 23 insertions(+), 6

Re: [PATCH v3] [POWERPC] bootwrapper: build multiple cuImages

2008-02-06 Thread Geoff Levand
Grant Likely wrote: diff --git a/arch/powerpc/boot/cuboot-hpc2.c b/arch/powerpc/boot/cuboot-mpc7448hpc2.c similarity index 100% rename from arch/powerpc/boot/cuboot-hpc2.c rename to arch/powerpc/boot/cuboot-mpc7448hpc2.c This is not a proper patch. No rule to make target

Re: [RFC] [POWERPC] bootwrapper: build multiple cuImages

2008-01-31 Thread Geoff Levand
On 01/30/2008 04:34 PM, Grant Likely wrote: --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile ... $(obj)/zImage.ps3: vmlinux $(wrapper) $(wrapperbits) $(srctree)/$(src)/dts/ps3.dts Seems like this could use $(dtstree). $(STRIP) -s -R .comment $ -o vmlinux.strip -

Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup

2008-01-30 Thread Geoff Levand
Ingo Molnar wrote: * Luck, Tony [EMAIL PROTECTED] wrote: Could you check the patch below? With this applied to latest -git, ia64 buils fine for me in a cross-compiling environment. (but i dont know whether it boots ...) Uni-processor build still fails with this patch (config is

Re: [powerpc changes] Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup

2008-01-30 Thread Geoff Levand
with ps3_defconfig and works OK. Acked-by: Geoff Levand [EMAIL PROTECTED] ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch 00/11] ps3av/3fb patches for 2.6.25

2008-01-27 Thread Geoff Levand
On 01/27/2008 03:15 AM, Geert Uytterhoeven wrote: On Sun, 27 Jan 2008, Andrew Morton wrote: On Sun, 27 Jan 2008 10:44:40 +0100 (CET) Geert Uytterhoeven [EMAIL PROTECTED] wrote: I posted these patches before, about 2 months ago. Unfortunately I didn't CC you at that time, so they

[patch 12/16] PS3: Add logical performance monitor device support

2008-01-18 Thread Geoff Levand
Add PS3 logical performance monitor device support to the PS3 system-bus and platform device registration routines. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Add enum ps3_lpm_tb_type. o Remove redundant enclosing structure and return proper error codes from

[patch 11/16] PS3: Add logical performance monitor repository routines

2008-01-18 Thread Geoff Levand
From: Takashi Yamamoto [EMAIL PROTECTED] Add repository routines for the PS3 Logical Performance Monitor. Signed-off-by: Takashi Yamamoto [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Correct Yamamoto-san's mail addr. v3: o Change num_pu and pu_id to type u64. o

[patch 16/16] PS3: Update ps3_defconfig

2008-01-18 Thread Geoff Levand
Update ps3_defconfig. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/configs/ps3_defconfig | 49 ++--- 1 file changed, 35 insertions(+), 14 deletions(-) --- a/arch/powerpc/configs/ps3_defconfig +++ b/arch/powerpc/configs/ps3_defconfig @@ -1,7

[patch 15/16] PS3: Revove use lpar address workaround

2008-01-18 Thread Geoff Levand
Remove the PS3 workaround needed to support sparsemem SPU mappings. The SPU mappings no longer use sparsemem, so this workaround is no longer needed. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/Kconfig | 11 --- arch/powerpc/platforms/ps3/mm.c| 16

[patch 13/16] PS3: Add logical performance monitor driver support

2008-01-18 Thread Geoff Levand
[EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Correct Yamamoto-san's mail addr. o Text cleanups. o Added more comments explaining lpm operation. o Split SRPN_BKMK into separate patch. o Use get_hard_smp_processor_id() in ps3_get_hw_thread_id(). o Split

[patch 02/16] PS3: Make bus_id and dev_id u64

2008-01-18 Thread Geoff Levand
From: Geert Uytterhoeven [EMAIL PROTECTED] Change the PS3 bus_id and dev_id from type unsigned int to u64. These IDs are 64-bit in the repository, and the special storage notification device has a device ID of ULONG_MAX. Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Geoff

[patch 04/16] PS3: Use the HVs storage device notification mechanism properly

2008-01-18 Thread Geoff Levand
device is closed using a reboot notifier. Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/device-init.c | 422 --- arch/powerpc/platforms/ps3/platform.h|2 arch/powerpc/platforms/ps3

[patch 06/16] PS3: Kill unused ps3_repository_bump_device()

2008-01-18 Thread Geoff Levand
From: Geert Uytterhoeven [EMAIL PROTECTED] PS3: Kill unused routine ps3_repository_bump_device(). Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/platform.h |6 -- 1 files changed, 6 deletions

[patch 4/4 v4] PS3: Add logical performance monitor driver support

2008-01-10 Thread Geoff Levand
[EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Correct Yamamoto-san's mail addr. o Text cleanups. o Added more comments explaining lpm operation. o Split SRPN_BKMK into separate patch. o Use get_hard_smp_processor_id() in ps3_get_hw_thread_id(). o

[patch 2/4 v3] PS3: Add logical performance monitor repository routines

2008-01-09 Thread Geoff Levand
From: Takashi Yamamoto [EMAIL PROTECTED] Add repository routines for the PS3 logical performance monitor. Signed-off-by: Takashi Yamamoto [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Correct Yamamoto-san's mail addr. v3: o Change num_pu and pu_id to type u64. o

[patch 3/4 v3] PS3: Add logical performance monitor device support

2008-01-09 Thread Geoff Levand
Add PS3 logical performance monitor device support to the PS3 system-bus and platform device registration routines. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Add enum ps3_lpm_tb_type. o Remove redundant enclosing structure and return proper error codes from

[patch 4/4 v3] PS3: Add logical performance monitor driver support

2008-01-09 Thread Geoff Levand
[EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Correct Yamamoto-san's mail addr. o Text cleanups. o Added more comments explaining lpm operation. o Split SRPN_BKMK into separate patch. o Use get_hard_smp_processor_id() in ps3_get_hw_thread_id(). o

[patch 1/4] POWERPC: Add Cell SPRN bookmark register

2008-01-08 Thread Geoff Levand
Add a definition for the Cell SPRN bookmark register to asm-powerpc/regs.h Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- Needed for PS3's lpm driver. include/asm-powerpc/reg.h |1 + 1 file changed, 1 insertion(+) --- a/include/asm-powerpc/reg.h +++ b/include/asm-powerpc/reg.h @@ -553,6

[patch 4/4 v2] PS3: Add logical performance monitor driver support

2008-01-08 Thread Geoff Levand
[EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Correct Yamamoto-san's mail addr. o Text cleanups. o Added more comments explaining lpm operation. o Split SRPN_BKMK into separate patch. o Use get_hard_smp_processor_id() in ps3_get_hw_thread_id(). o

[patch 3/4 v2] PS3: Add logical performance monitor device support

2008-01-08 Thread Geoff Levand
Add PS3 logical performance monitor device support to the PS3 system-bus and platform device registration routines. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o Add enum ps3_lpm_tb_type. o Remove redundant enclosing structure and return proper error codes from

[patch 2/4 v2] PS3: Add logical performance monitor repository routines

2008-01-08 Thread Geoff Levand
From: Takashi Yamamoto [EMAIL PROTECTED] Add repository routines for the PS3 Logical Performance Monitor (lpm). Signed-off-by: Takashi Yamamoto [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: correct Yamamoto-san's mail addr. arch/powerpc/platforms/ps3/platform.h

Re: [patch 2/3] PS3: Add logical performance monitor device support

2008-01-06 Thread Geoff Levand
On 01/05/2008 03:29 AM, Arnd Bergmann wrote: On Saturday 05 January 2008, Geoff Levand wrote: + struct layout { + struct ps3_system_bus_device dev; + } *p; What's the point of this data structure? You don't use the struct anywhere, and it only has one member, so

Re: [patch 3/3] PS3: Add logical performance monitor driver support

2008-01-06 Thread Geoff Levand
On 01/05/2008 03:56 AM, Arnd Bergmann wrote: On Saturday 05 January 2008, Geoff Levand wrote: From: Takashi Yamamoto [EMAIL PROTECTED] Add PS3 logical performance monitor (lpm) device driver. The PS3's LV1 hypervisor provides a Logical Performance Monitor that abstarcts the Cell

[patch 0/3] PS3 logical performance monitor patches for 2.6.25

2008-01-04 Thread Geoff Levand
Paul, This is a small set of patches that adds support for the PS3's logical performance monitor. The logical performance monitor is a hypervisor abstraction that provides access to the Cell processor's performance monitoring features needed by profilers such as oprofile and perfmon. Please

[patch 1/3] PS3: Add logical performance monitor repository routines

2008-01-04 Thread Geoff Levand
From: Takashi Yamamoto [EMAIL PROTECTED] Add repository routines for the PS3 Logical Performance Monitor (lpm). Signed-off-by: Takashi Yamamoto [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/platform.h |7 arch/powerpc/platforms/ps3

[patch 2/3] PS3: Add logical performance monitor device support

2008-01-04 Thread Geoff Levand
Add PS3 logical performance monitor (lpm) device support to the PS3 system-bus and platform device registration routines. Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/device-init.c | 95 ++- arch/powerpc/platforms/ps3/system-bus.c

[patch 3/3] PS3: Add logical performance monitor driver support

2008-01-04 Thread Geoff Levand
[EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- arch/powerpc/platforms/ps3/Kconfig | 14 drivers/ps3/Makefile |1 drivers/ps3/ps3-lpm.c | 1171 + include/asm-powerpc/ps3.h | 37 + 4 files changed

Re: Please pull powerpc.git merge branch

2007-12-28 Thread Geoff Levand
Paul Mackerras wrote: Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge This broke Cell builds. arch/powerpc/platforms/cell/spufs/sched.c:200: multiple definition of `.notify_spus_active' arch/powerpc/platforms/cell/spu_syscalls.c:149:

Re: [patch v3] PS3: Fix printing of os-area magic numbers

2007-12-23 Thread Geoff Levand
On 12/23/2007 01:51 AM, Geert Uytterhoeven wrote: On Sat, 22 Dec 2007, Geoff Levand wrote: +static void dump_field(char *s, const u8 *f, unsigned int size) +{ +#if defined(DEBUG) +unsigned int i; + +for (i = 0; i size; i++) +s[i] = isprint(f[i]) ? f[i] : '.'; +s[i

[patch v4] PS3: Fix printing of os-area magic numbers

2007-12-23 Thread Geoff Levand
contained random data that would be printed to the display. Also unify the handling of header and db magic numbers and make both of type array of u8. CC: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o handle unprintable chars. v3: o breakout string dump

Re: [patch v2] PS3: Fix printing of os-area magic numbers

2007-12-22 Thread Geoff Levand
On 12/20/2007 08:44 PM, Paul Mackerras wrote: Geoff Levand writes: Fix a bug in the printing of the os-area magic numbers which assumed that magic numbers were zero terminated strings. The magic numbers are represented in memory as integers. If the os-area sections are not initialized

[patch v3] PS3: Fix printing of os-area magic numbers

2007-12-22 Thread Geoff Levand
to the display. Also unify the handling of header and db magic numbers and make both of type array of u8. CC: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- v2: o handle unprintable chars. v3: o breakout string dump into helper dump_field() o unify handling

Re: Time for cell code reshuffle?

2007-12-21 Thread Geoff Levand
Arnd Bergmann wrote: We've been discussing in the past a few times where we should best put the spufs code, and when to do it. Since Jeremy and I now have all the current patches in powerpc.git, maybe we should do it now. To the question, where what it should go, I'd leave the decision to

Re: [PATCH 1/3] ps3: vuart: fix error path locking

2007-12-18 Thread Geoff Levand
On 12/18/2007 05:10 PM, Andrew Morton wrote: On Wed, 12 Dec 2007 18:00:12 -0800 Geoff Levand [EMAIL PROTECTED] wrote: This stray down would cause a permanent sleep which doesn't seem correct. The other uses of this semaphore appear fairly mutex like it's even initialized

<    1   2   3   4   5   6   >