Hi Jeff,
> In later patches, we're going to change how the ctime.tv_nsec field is
> utilized. Switch to using accessor functions instead of raw accesses
> of inode->i_ctime.
s/utilized/used/ :D
All looks good on the spufs change:
Acked-by: Jeremy Kerr
(also, thanks f
Hi Randy,
> Fix a typo of "or" which should be "of".
Nice, people are still reading the spufs docs! :D
Looks good to me, thanks for the patch.
Reviewed-by: Jeremy Kerr
Cheers,
Jeremy
struct mctp_i2c_dev *midev = NULL, *tmp = NULL;
> @@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client)
> mctp_i2c_free_client(mcli);
> mutex_unlock(_clients_lock);
> /* Callers ignore return code */
> - return 0;
> }
The comment there no longer makes much sense, I'd suggest removing that
too. Either way:
Reviewed-by: Jeremy Kerr
Cheers,
Jeremy
Hi Jason,
> The BUG_ON macro simplifies the if condition followed by BUG, so that
> we can use BUG_ON instead of if condition followed by BUG.
[...]
> - if (spu_acquire(ctx))
> - BUG(); /* a kernel thread never has signals pending */
> + /* a kernel thread never has
st robot
> Signed-off-by: Arnd Bergmann
Looks good to me, thanks.
Acked-by: Jeremy Kerr
Cheers,
Jeremy
Hi Julia,
> Other uses of >aff_list_head, eg in spufs_assert_affinity, indicate
> that the list elements have type spu_context, not spu as used here. Change
> the type of tmp accordingly.
Looks good to me; we could even use ctx there, rather than the separate
tmp variable.
Reviewe
Hi Christophe,
> > Just use the proper non __-prefixed get/put_user variants where
> > that is not done yet.
>
> But it means you are doing the access_ok() check everytime, which is
> what is to be avoided by doing the access_ok() once then using the
> __-prefixed variant.
5 out of 8 of these
Christoph Hellwig .
Fixes: bf1ab978be23 ("[POWERPC] coredump: Add SPU elf notes to coredump.")
Signed-off-by: Jeremy Kerr
Reviewed-by: Arnd Bergmann
Reviewed-by: Christoph Hellwig
---
arch/powerpc/platforms/cell/spufs/file.c | 113 +++
1 file changed, 75 inserti
From: Christoph Hellwig
Just use the proper non __-prefixed get/put_user variants where that is
not done yet.
Signed-off-by: Christoph Hellwig
Signed-off-by: Jeremy Kerr
---
arch/powerpc/platforms/cell/spufs/file.c | 42 +---
1 file changed, 8 insertions(+), 34 deletions
Hi Christoph,
> And another one that should go on top of this one to address Al's other
> compaint:
Yeah, I was pondering that one. The access_ok() is kinda redundant, but
it does avoid forcing a SPU context save on those errors.
However, it's not like we really need to optimise for the case of
Hi Christoph,
> FYI, these little hunks reduce the difference to my version, maybe
> you can fold them in?
Sure, no problem.
How do you want to coordinate these? I can submit mine through mpe, but
that may make it tricky to synchronise with your changes. Or, you can
include this change in your
Currently, we may perform a copy_to_user (through
simple_read_from_buffer()) while holding a context's register_lock,
while accessing the context save area.
This change uses a temporary buffers for the context save area data,
which we then pass to simple_read_from_buffer.
Signed-off-by: Jeremy
Hi Al & Christoph,
> Again, this really needs fixing. Preferably - as a separate commit
> preceding this series, so that it could be
> backported. simple_read_from_buffer() is a blocking operation.
I'll put together a patch that fixes this.
Christoph: I'll do it in a way that matches your
small on-stack buffer and avoid
> memory allocations as well.
That looks much better, thanks!
Reviewed-by: Jeremy Kerr
However, I no longer have access to hardware to test this on. Michael,
are the coredump tests in spufs-testsuite still alive?
Cheers,
Jeremy
Hi Vaidy,
The current topic is who owns setting up the ATT bits for that piece
of memory. It is the kernel today. Kernel decides to set this up as
normal memory or I/O memory and sets the bits in page table entry.
Or, what if there's a range of address-space that isn't backed by system
RAM
Hi Vasant,
> > OK. How about we just don't do that?
>
> Yes. Hostboot will fix that. It will make sure that HBRT is loaded
> into regular memory.
Super.
> > It sounds like we're just trying to work around an invalid
> > representation of the mappings.
>
> Its not workaround. Its additional
Hi Vasant,
> Correct. We will have `ibm,prd-label` property. That's not the issue.
It sure sounds like the issue - someone has represented a range that
should be mapped by HBRT, but isn't appropriate for mapping by HBRT.
> Here issueis HBRT is loaded into NVDIMM memory.
OK. How about we just
Hi Vasant,
> Add check to validate whether requested page is part of system RAM
> or not before mmap() and error out if its not part of system RAM.
opal_prd_range_is_valid() will return false if the reserved memory range
does not have an ibm,prd-label property. If this you're getting invalid
Hi Jon,
Signed-off-by: Colin Ian King
---
Documentation/filesystems/spufs.txt | 2 +-
Documentation/gpu/drm-uapi.rst | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
This is the first patch to spufs.txt since 2006...I wonder if that stuff
is being used by
Hi William,
Sometimes we have stale messages showing up in the recv queue that are
being processed by the pollers. We don't want to print out warnings for
these messages not having an outstanding request as they can be expected
when doing a kexec from the petitroot environment or from another
pec64 and printing a 64-bit number for
> consistency.
If we still have spufs in the tree in 2038 I'd be worried :) But good
to keep things consistent.
Acked-by: Jeremy Kerr <j...@ozlabs.org>
Michael: want to take this directly through your tree?
Cheers,
Jeremy
.
This change passes TLB_INVAL_SCOPE_GLOBAL instead.
Signed-off-by: Jeremy Kerr <j...@ozlabs.org>
CC: Nicholas Piggin <npig...@gmail.com>
---
arch/powerpc/kernel/dt_cpu_ftrs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/dt_cpu_ftrs.c
b/
Hi Michael,
> So fix it by setting rc = 0 before returning in the success case.
>
> Fixes: 7b1f4020d0d1 ("spufs: get rid of dump_emit() wrappers")
> Signed-off-by: Michael Ellerman <m...@ellerman.id.au>
Looks good to me, thanks.
Acked-by: Jeremy Kerr <j...@ozlabs.org>
Cheers,
Jeremy
no longer work.
This change adds _PAGE_PRIVILEGED to the hash fault handler for
kernel accesses.
Signed-off-by: Jeremy Kerr <j...@ozlabs.org>
Reported-by: Sombat Tragolgosol <sombat3...@gmail.com>
CC: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com>
---
arch/powerpc/platforms/c
Hi all,
> Looks like this also happens with the simple spu_run test:
>
>
> https://github.com/jk-ozlabs/spufs-testsuite/blob/master/tests/03-spu_run/01-spu_run.c
>
> ... might need some debugging here, I'll update if I find anything.
And it appears we're stuck in the POLL_WHILE_FALSE() loop
Hi all,
> I'd like to report that SPU not working for kernel > 4.9. The problem
> caused by spe_context_run function, when call , it never return back.
Looks like this also happens with the simple spu_run test:
Hi Mukesh,
>> Unless I'm mistaken, there are two things I can see happening with the
>> old code: if we hit the IRQ_NONE path enough, we'll report a "nobody
>> cared" error (see __report_bad_irq) and disable the interrupt, or for
>> the -1 case, we'll immediately log a "bogus return value" error
Hi Mukesh,
> The return value of an interrupt handler is the special type
> irqreturn_t. An interrupt handler can return two special values,
> IRQ_NONE or IRQ_HANDLED.
Yep, you can assume that the reader knows that level of the interrupt
handler API :) What we want to know is how that change in
Hi Mukesh,
> Converts all the return explicit number to a more proper IRQ_HANDLED,
> which looks proper incase of interrupt handler returning case.
This looks good to me, but can you describe the effects of those changes
to the interrupt handler's return code? ie, what happened in the
erroneous
Hi Mukesh,
> Moves the return value check of 'opal_dump_info' to a proper place which
> was previously unnecessarily filling all the dump info even on failure.
Acked-by: Jeremy Kerr <j...@ozlabs.org>
Thanks!
Jeremy
Hi Corey,
> In all, this looks good. I have two minor nits inline below, and
> two more major comments here:
>
> I would prefer if it always queried the data, even if the device id
> information is provided by the lower level driver.
OK, can do. I was concerned that the SMI driver may want to
r to use the dynamic IDs; the
behaviour of the other SMIs is not changed by this series. However,
if there's interest, I'm happy to alter the existing SMIs too, in a
follow-up series.
Questions & comments most welcome.
Cheers,
Jeremy
---
Jeremy Kerr (4):
ipmi: Add a reference from
We don't currently provide any device ID info in the SMI registration,
so use the dynamic ID infrastructure instead.
Signed-off-by: Jeremy Kerr <j...@ozlabs.org>
---
drivers/char/ipmi/ipmi_powernv.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/cha
version information when needed. We keep a
short-term cache of this information so we don't need to re-query
for every attribute access.
Signed-off-by: Jeremy Kerr <j...@ozlabs.org>
---
drivers/char/ipmi/ipmi_msghandler.c | 158 ++--
1 file changed, 153 insertions(+
netfn, cmd and data buffer, so it can be used with
non-sequential responses.
Signed-off-by: Jeremy Kerr <j...@ozlabs.org>
---
drivers/char/ipmi/ipmi_si_intf.c | 3 ++-
drivers/char/ipmi/ipmi_ssif.c| 3 ++-
include/linux/ipmi_smi.h | 16 +---
3 files changed, 13 inse
In an upcoming change, we'll want to grab a reference to the ipmi_smi_t
from a struct bmc_device. This change adds a pointer to allow this.
Signed-off-by: Jeremy Kerr <j...@ozlabs.org>
---
drivers/char/ipmi/ipmi_msghandler.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/cha
Hi Thiago,
> So even if not ideal, the solution above is desirable for powerpc. We would
> like to preserve the ability of allowing userspace to pass parameters to the
> OS via the DTB, even if secure boot is enabled.
>
> I would like to turn the above into a proposal:
>
> Extend the syscall
Hi Stephen,
>> Do you know why mailman would be re-writing From: there? It's confusing
>> patchwork, as multiple mails are now coming from that address.
>
> Yep, Anton posts from samba.org. They publish a DMARC policy that
> breaks mailing lists.
(╯°□°)╯︵ ┻━━┻
This also breaks git-am:
Hi Stephen,
From the mail that Anton has sent to linuxppc-dev:
> From: Anton Blanchard via Linuxppc-dev
> Reply-To: Anton Blanchard
Do you know why mailman would be re-writing From: there? It's confusing
patchwork, as multiple mails are now
There are a few firmware-provided interfaces for OpenPOWER platforms:
the PRD infrastructure, IPMI support, and MTD access to the PNOR flash.
This change adds these to powernv_defconfig
Signed-off-by: Jeremy Kerr <j...@ozlabs.org>
---
arch/powerpc/configs/powernv_defconfig | 6 ++
Most current OpenPOWER platforms have an AST BMC, so add graphics
support via the AST DRM driver.
Signed-off-by: Jeremy Kerr <j...@ozlabs.org>
---
arch/powerpc/configs/powernv_defconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/configs/powernv_def
This change adds a defconfig for the non-virtualised power platforms,
based on pseries_defconfig, but without pseries, and little-endian,
and no OF trampoline.
Signed-off-by: Jeremy Kerr <j...@ozlabs.org>
---
arch/powerpc/configs/powernv_defconfig | 307 +
to none.
Acked-by: Jeremy Kerr j...@ozlabs.org
Cheers,
Jeremy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Hi Anton,
[PATCH] Fix crash due to processing memory-controller nodes as memory
Looks good to me. If you apply this to your kexec-lite repo, I'll update
op-build to use the new version, and send the merge requests for op-build.
I'd expect we'd have those changes upstream in the next couple of
Srinivasan sva...@linux.vnet.ibm.com
Acked-by: Jeremy Kerr j...@ozlabs.org
Cheers,
Jeremy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
We'll want to build the opal-prd daemon with the prd headers, so include
this in the uapi headers list.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/include/uapi/asm/Kbuild |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/include/uapi/asm/Kbuild
b/arch/powerpc
the list_head.
We also clarify the memcpy of the message, as we're copying unnecessary
bytes at the end of the message data.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/platforms/powernv/opal-prd.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git
) Copyright IBM 2015
Usual syntax is: Copyright IBM Corporation 2015
OK, fixed.
+ *
+ * Author: Vaidyanathan Srinivasan svaidy at linux.vnet.ibm.com
+ * Author: Jeremy Kerr j...@ozlabs.org
I'd rather you dropped these, they'll just bit rot, but if you insist I don't
care that much.
Yep
This change adds a char device to access the PRD (processor runtime
diagnostics) channel to OPAL firmware.
Includes contributions from Vaidyanathan Srinivasan, Neelesh Gupta
Vishal Kulkarni.
Signed-off-by: Neelesh Gupta neele...@linux.vnet.ibm.com
Signed-off-by: Jeremy Kerr j...@ozlabs.org
This change adds a char device to access the PRD (processor runtime
diagnostics) channel to OPAL firmware.
Includes contributions from Vaidyanathan Srinivasan, Neelesh Gupta
Vishal Kulkarni.
Signed-off-by: Neelesh Gupta neele...@linux.vnet.ibm.com
Signed-off-by: Jeremy Kerr j...@ozlabs.org
Hi Brian,
While I have Jeremy's attention, let me plug a friendly reminder for
this unrelated comment:
http://patchwork.ozlabs.org/patch/413355/
Jeremy, you still haven't updated patchwork.git for your last round of
supposed merges.
Ah, thanks for the reminder - I've just done the push.
This change adds a char device to access the PRD (processor runtime
diagnostics) channel to OPAL firmware.
Includes contributions from Vaidyanathan Srinivasan, Neelesh Gupta
Vishal Kulkarni.
Signed-off-by: Neelesh Gupta neele...@linux.vnet.ibm.com
Signed-off-by: Jeremy Kerr j...@ozlabs.org
The (upcoming) opal-prd driver needs to access the message notifier and
xscom code, so add EXPORT_SYMBOL_GPL macros for these.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/platforms/powernv/opal.c |4
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/platforms
opal_ipmi_init and opal_flash_init are equivalent, except for the
compatbile string. Merge these two into a common opal_pdev_init
function.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/platforms/powernv/opal.c | 21 ++---
1 file changed, 6 insertions(+), 15
Hi Ben,
+static LIST_HEAD(opal_prd_msg_queue);
+static DEFINE_SPINLOCK(opal_prd_msg_queue_lock);
+static DECLARE_WAIT_QUEUE_HEAD(opal_prd_msg_wait);
+static atomic_t usage;
opal_prd_usage ... otherwise it's a mess in the symbols map
OK, I'll change this.
Also why limit the number of
Hi Michael,
Traffic on the cbe-oss-dev list is more or less non-existent, other than
CC's from linuxppc.
Plus all that spam that never makes it out of the moderation queue.
It's seems like we may as well just send everyone to linuxppc and
archive the list.
Acked-by: Jeremy Kerr j
Hi all,
If the mtd maintainers are happy with it this would be the easier approach in
this instance.
OK, sounds good to me.
MTD folks: any objections to this process? If not, is this patch good to
go in, or any changes we should make?
Cheers,
Jeremy
for
the FSP flash update functionality, so we rename that initcall to
opal_flash_update_init().
A future change will add an mtd driver that uses this interface.
Changes from Joel Stanley and Jeremy Kerr.
Signed-off-by: Cyril Bur cyril...@gmail.com
Signed-off-by: Jeremy Kerr j...@ozlabs.org
Signed-off
Hi all,
This series implements a simple mtd device to allow access to the PNOR
flash on OpenPower machines. The flash is accessed through firmware
calls.
Patch 1/2 adds the Linux interface to these calls. Patch 2/2 adds a mtd
driver that uses these calls.
Because there's two subsystems involved
for a minute of silence.
(Wistfully-)Acked-by: Jeremy Kerr j...@ozlabs.org
Cheers,
Jeremy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
This change adds a char device to access the PRD (processor runtime
diagnostics) channel to OPAL firmware.
Includes contributions from Vaidyanathan Srinivasan, Neelesh Gupta
Vishal Kulkarni.
Signed-off-by: Neelesh Gupta neele...@linux.vnet.ibm.com
Signed-off-by: Jeremy Kerr j...@ozlabs.org
From: Cyril Bur cyril...@gmail.com
Powerpc powernv platforms allow access to certain system flash devices
through a firmwarwe interface. This change adds an mtd driver for these
flash devices.
Minor updates from Jeremy Kerr and Joel Stanley.
Signed-off-by: Cyril Bur cyril...@gmail.com
Signed
on the list has shown any
interest in it over the years.
So remove it. If anyone has one and cares please speak up.
I've never had any spufs-related feedback from celleb platforms either.
Acked-by: Jeremy Kerr j...@ozlabs.org
Cheers,
Jeremy
Hi Ben,
You might want to also remove the use of r8 and r9 which are supposed
to contain the OPAL entry and base for debugging purposes. We would also
have to restore them before booting the kernel.
I'd prefer that to be a separate change, if that's okay - it'd require
us to change the kentry
Hi Ben,
We'll likely be entering the zImage.epapr as BE, so include the pseries
implementation of _zimage_start, which adds the endian fixup magic.
Wont that break embedded epapr stuff ?
How so? This will just give us the endian fixup trampoline (followed by
a branch to _zimage_start_lib)
We'll likely be entering the zImage.epapr as BE, so include the pseries
implementation of _zimage_start, which adds the endian fixup magic.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/boot/wrapper |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch
For epapr-style boot, we may be little-endian. This change implements
the proper conversion for fdt*_to_cpu and cpu_to_fdt*. We also need the
full cpu_to_* and *_to_cpu macros for this.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/boot/libfdt_env.h | 14 --
arch
allocates the minimum of 32 bytes for the base of the stack
instead.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/boot/crt0.S |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/crt0.S b/arch/powerpc/boot/crt0.S
index 14de4f8..bf8 100644
at least 32 bytes in the initial stack frame, to handle the
LR save area. We bump this to 112 bytes, as that'll be the max required
by ABIv1.
Thanks to Alistair Popple for debugging help.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/boot/crt0.S |2 +-
1 file changed, 1 insertion
Now that the wrapper supports 64-bit builds, we see warnings when
attempting to cast pointers to int. Use unsigned long instead.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/boot/libfdt-wrapper.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch
We use r6 and r7 for epapr boot, but the current pre-C init will clobber
both of these.
This change does a simple replacement, of r6 - r12 and r7 - r13, so
that we hit platform init with these registers intact.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/boot/crt0.S | 24
anything.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/boot/wrapper |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index ae0f88e..3f50c27 100755
--- a/arch/powerpc/boot/wrapper
+++ b/arch/powerpc/boot/wrapper
For epapr-style boot, we may be little-endian. This change implements
the proper conversion for fdt*_to_cpu and cpu_to_fdt*. We also need the
full cpu_to_* and *_to_cpu macros for this.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org
---
arch
We use r6 and r7 for epapr boot, but the current pre-C init will clobber
both of these.
This change does a simple replacement, of r6 - r12 and r7 - r13, so
that we hit platform init with these registers intact.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/boot/crt0.S | 24
Hi Anshuman,
This patch creates a new OPAL platform event character driver
which will give userspace clients the access to these events
and process them effectively. Following platforms events are
currently supported with this platform driver.
(1) Environmental and Power Warning
Hi Corey,
This looks good. Can this go into the IPMI tree now, or does it need
work done in the PowerPC tree first?
The 1/2 patch is already in the powerpc tree - but to ensure that we hit
Linus' tree in the right order, Michael has suggested that you merge his
topic branch (which only has
Hi Corey,
Alternatively, they could be merged by one maintainer, pending an ack
from the other.
I'm fine either way.
How about the third option? :)
I've put patch 1 in a topic branch:
https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/log/?h=topic/opal-ipmi
And will
This change adds an initial IPMI driver for powerpc OPAL firmware. The
interface is exposed entirely through firmware: we have two functions to
send and receive IPMI messages, and an interrupt notification from the
firmware to signify that a message is available.
Signed-off-by: Jeremy Kerr j
Hi Corey,
Thanks for the review.
IPMI folks: the IPMI driver could do with a little review, as it's
not a conventional BT/KCS/SMI SI, in that the low-level send/recv
interface will handle the entire message at once.
Handling the entire message at once should be fine, as that's what
this
Hi Ben,
Our OPAL interface can only do one at a time ? Because our underlying
FW driver already has a queue ..
The Linux driver needs to match responses to their requests, so the
driver needs to keep a reference to the requests that we've sent. The
current implementation is very simple: we
Recent OPAL firmare adds a couple of functions to send and receive IPMI
messages:
https://github.com/open-power/skiboot/commit/b2a374da
This change updates the token list and wrappers to suit, and adds the
platform devices for any IPMI interfaces.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
the structure function definitions. This'll
break the build if only 2/2 is in the tree, and CONFIG_IPMI_POWERNV is
set.
Alternatively, they could be merged by one maintainer, pending an ack
from the other.
Comments / queries / etc welcome.
Cheers,
Jeremy
---
Jeremy Kerr (2):
powerpc/powernv: Add
This change adds an initial IPMI driver for powerpc OPAL firmware. The
interface is exposed entirely through firmware: we have two functions to
send and receive IPMI messages, and an interrupt notification from the
firmware to signify that a message is available.
Signed-off-by: Jeremy Kerr j
Hi Michael,
Currently, we can't call opal wrappers from modules when using the LE
ABIv2, which requires a TOC init.
What happens if we try? Build failure or run time bug?
We'll get an arbitrary memory dereference (two, actually) in the opal
wrappers, when we try to load the opal entry point
Currently, we can't call opal wrappers from modules when using the LE
ABIv2, which requires a TOC init.
This change uses the _GLOBAL_TOC() macro (rather than _GLOBAL) for the
opal wrappers, so that we can do non-local calls to them.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc
Hi Mikey Ian,
Currently spu_handle_mm_fault() is in the cell platform.
This code is generically useful for other non-cell co-processors on powerpc.
This patch moves this function out of the cell platform into arch/powerpc/mm
so
that others may use it.
Makes sense.
Acked-by: Jeremy
Hi Mikey Ian,
__spu_trap_data_seg() currently contains code to determine the VSID and ESID
required for a particular EA and mm struct.
This code is generically useful for other co-processors. This moves the code
of the cell platform so it can be used by other powerpc code.
OK, nice.
+
Hi Dan,
The SPUFS_CNTL_MAP_SIZE define is cut and pasted twice so we can delete
the second instance.
Looks good to me.
Acked-by: Jeremy Kerr j...@ozlabs.org
Cheers,
Jeremy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https
own.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
Ingo: 6b6350f1 is currently in tip; this fixes a build breakage for spufs
---
arch/powerpc/platforms/cell/spufs/sched.c |1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/cell/spufs/sched.c
b/arch/powerpc/platforms
1169576 15355007 ea4c7f obj/vmlinux
Tested on pseries.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/kernel/paca.c | 32 +---
1 file changed, 25 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/kernel/paca.c b/arch/powerpc/kernel/paca.c
index
The only external user of slb_shadow is the pseries lpar code, and it
can access through the paca array instead.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/include/asm/lppaca.h |2 --
arch/powerpc/kernel/paca.c|2 +-
arch/powerpc/platforms/pseries/lpar.c
1169576 15355007 ea4c7f obj/vmlinux
Tested on pseries.
Signed-off-by: Jeremy Kerr j...@ozlabs.org
---
v2: don't drop the endian conversion, use SLB_NUM_BOLTED
---
arch/powerpc/kernel/paca.c | 32 +---
1 file changed, 25 insertions(+), 7 deletions(-)
diff --git
Hi Alexey,
This patch does 2 things:
1. removes the loop in which PCI devices were added to groups and
adds explicit iommu_add_device() calls to add devices as soon as they get
the iommu_table pointer assigned to them.
2. moves a bus notifier to powernv code in order to avoid conflict with
.
Acked-by: Jeremy Kerr j...@ozlabs.org
Cheers,
Jeremy
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Hi Linus,
Is Jeremy the patchwork maintainer?
Yep, that's me.
and it turns out that apparently 'patchwork' is just making up random
times, because when you download the email as an mbox, it will turn
this into that corrupt and incorrect
Date: Thu, 06 Jun 2013 19:42:54 -
thing
Hi Linus,
No. The date from the email was
Date: Fri, 7 Jun 2013 15:42:54 +1000
and we want *that* date.
Ah, gotchya.
So, we now use the original date header (if present) in the mbox views:
$ wget -qO - http://patchwork.ozlabs.org/patch/249598/mbox/ | grep ^Date
Date: Fri, 7 Jun 2013
-off-by: Jeremy Kerr j...@ozlabs.org
---
arch/powerpc/platforms/powernv/opal.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal.c
b/arch/powerpc/platforms/powernv/opal.c
index aaa0dba..ade4463 100644
--- a/arch/powerpc
Based on benh's proposal at
https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-September/101237.html,
this change provides support for reserving memory from the
reserved-ranges node at the root of the device tree.
We just call memblock_reserve on these ranges for now.
Signed-off-by: Jeremy
Based on benh's proposal at
https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-September/101237.html,
this change provides support for reserving memory from the
reserved-ranges node at the root of the device tree.
We just call memblock_reserve on these ranges for now.
Signed-off-by: Jeremy
Based on benh's proposal at
https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-September/101237.html,
this change provides support for reserving memory from the
reserved-ranges node at the root of the device tree.
We just call memblock_reserve on these ranges for now.
Signed-off-by: Jeremy
1 - 100 of 209 matches
Mail list logo