On Tue, Aug 28, 2018 at 10:44:28AM -0500, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
Please don't send new patches in reply to existing threads, it makes it
harder to follow what the
t-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1222121 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_esai.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl
txclk_df * 64
Addresses-Coverity-ID: 1222129 ("Unintentional integer overflow")
Signed-off-by: Gustavo A. R. Silva
Acked-by: Nicolin Chen
Signed-off-by: Mark Brown
---
sound/soc/fsl/fsl_spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_
On Tue, Jun 19, 2018 at 04:29:35PM +, York Sun wrote:
> Joakim,
>
> I am not the maintainer for this driver. Adding Mark Brown.
>
> York
>
> On 06/19/2018 09:23 AM, Joakim Tjernlund wrote:
> > espi does not look for a OF cell-index property which
> > mak
vam <fabio.este...@nxp.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_esai.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index da8fd98c7f51..d79e99ef31ad 100644
--- a/sound/soc/fsl/fsl_esai.c
+++
lue but merely the initial setting from
the set_dai_fmt().
Reported-by: Mika Penttilä <mika.pentt...@nextfour.com>
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Mika Penttilä <mika.pentt...@nextfour.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
s
gh to get the ratio.
So a simple fix could be just to set PM directly instead of going
into the loop-search.
Reported-by: Marek Vasut <ma...@denx.de>
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Marek Vasut <ma...@denx.de>
Reviewed-by: Fabio Estevam <fabio.este..
y: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Caleb Crome <ca...@crome.org>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fs
he register.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Caleb Crome <ca...@crome.org>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org
: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/
his issue by adding a variable to log the active
streams manually.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Caleb Crome <ca...@crome.org>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.n
;
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 55 +
1 file changed, 23 insertions(+),
ted-by: Caleb Crome <ca...@crome.org>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 256 +++---
@crome.org>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff
e>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
TX or RX at the same time.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Caleb Crome <ca...@crome.org>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <br
tion, use it to help readability.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Caleb Crome <ca...@crome.org>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brow
: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Caleb Crome <ca...@crome.org>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.or
..@gmail.com>
Tested-by: Caleb Crome <ca...@crome.org>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 219 +
-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index ed9102d91cf5..b58fabe77c6f 100644
--
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 5bc67ad8000f..0823b08923b5 1006
Roeck <li...@roeck-us.net>
Acked-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c
in
structure to save some wrapped lines.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Acked-by: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brown &l
: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 64 -
1 file changed, 31 insertions(+), 33 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 84d2f
igned-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Acked-by: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brown <broo...@kernel.org>
t;
Acked-by: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 374 +--
sound/soc/fsl/fsl_ssi.h | 376 ++--
sound/soc/fsl/fsl_ssi_dbg.c | 44
y unifies the coding style.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Acked-by: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brown <broo...@kern
Acked-by: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index ed9ac758e35d..eb9ac847bda3 100644
ave space, useful for dev_err outputs.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Acked-by: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brow
character line.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Acked-by: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brown <broo...@kern
igiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Acked-by: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 79 +++--
sound/soc/fsl/fsl_ssi.h | 3 ++
2 files c
abi <ti...@tabi.org>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 24
sound/soc/fsl/fsl_ssi.h | 1 +
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index aef014c46d
ode looks redudant. So simplify it.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Tested-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Acked-by: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brown <br
On Mon, Dec 04, 2017 at 12:46:34PM -0800, Nicolin Chen wrote:
> struct device is defined in system level header files any way.
> As long as fsl_ssi.h is included after those header files, it
> should be safe to remove this line.
It's better practice to either directly include those headers or
On Wed, Nov 29, 2017 at 10:23:23PM +0100, Takashi Iwai wrote:
> Mark, I already took this into my tree, as it's a change in ALSA core
> stuff. As mentioned in another mail, the branch was exposed to
> topic/pcm-20bit branch, so that you can pull cleanly.
That's what this is reporting - the
The patch
ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to
widths in playback and capture
in AC'97 mode so allow this, too.
Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/soun
extra channel slots enabled
mean ruined playback let's play safe here and make sure that no extra
slots are enabled in SACCST every time a playback is started.
Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Acked-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by:
values.
Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Acked-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound
iej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 26 ++
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index c3a83ed0297e..424bafaf
n <nicoleots...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
Cc: sta...@vger.kernel.org
---
sound/soc/fsl/fsl_ssi.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index f2f51e06e22c..c3
Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Acked-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ss
Hi all,
Today's linux-next merge of the powerpc tree got a conflict in:
arch/powerpc/kvm/powerpc.c
between commit:
ac64115a66c1 ("KVM: PPC: Fix oops when checking KVM_CAP_PPC_HTM")
from Linus' tree and commit:
2a3d6553cbd7 ("KVM: PPC: Tie KVM_CAP_PPC_HTM to the user-visible TM
kasprintf() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
Acked-by: Peter Ujfalusi <peter.ujfal...@ti.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/davinci/davinci-mcasp.c | 12
1 file chan
kasprintf
devm_kasprintf() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/omap/omap-hdmi-audio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/omap/omap-hdmi-aud
kasprintf() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl-asoc-card.c | 4
1 file changed, 4 insertions(+)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/s
On Thu, Sep 21, 2017 at 10:50:03AM +0530, Arvind Yadav wrote:
> devm_kasprintf() can fail here and we must check its return value.
This is patch 2/3 but you've only sent me this one patch. This is
missing the point of numbering a series, the only reason for the
numbering is to provide ordering
override the bit clock rate, this
patch changes the driver to calculate the bit clock rate using the
slot number and the slot width from the via set_tdm_slot().
The patch also removes an obsolete comment of the dir parameter.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: M
et_sysclk() and snd_soc_dai_set_tdm_slot()
in the soc-core.c will return -ENOTSUPP if there is no function
implementation for them in the dai and component drivers.
So this patch tries to ignore this errno.
Signed-off-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: Mark Brown <
On Tue, Sep 05, 2017 at 10:45:29AM -0700, Nicolin Chen wrote:
> The ipg clock is merely used to access registers, and has nothing
> (directly) to do with external clock outputs. The driver shall not
> change the ipg clock as the system ipg clock (its parent clock)
> might be messed and even
On Tue, Sep 05, 2017 at 10:19:05AM +0200, Łukasz Majewski wrote:
> On 09/05/2017 09:52 AM, Nicolin Chen wrote:
> > Can you elaborate why you set ipg clock as bclk? I don't remember SSI could
> > derive bitclock from ipg clock.
> Just to be clear:
> What clock shall be set with:
> struct
98515 sound/soc/fsl/fsl_spdif.o
Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_spdif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/
t to work with DT
full_name changes, just remove it.
Signed-off-by: Rob Herring <r...@kernel.org>
Cc: Timur Tabi <ti...@tabi.org>
Cc: Nicolin Chen <nicoleots...@gmail.com>
Cc: Xiubo Li <xiubo@gmail.com>
Cc: Fabio Estevam <fabio.este...@nxp.com>
Cc: Liam Girdwo
argument
to the function snd_soc_set_runtime_hwparams, which is const or used
in a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 ins
argument to the
function snd_soc_set_runtime_hwparams, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/sh/dma-sh7760.c | 2 +-
sound/soc/sh/fsi.c| 2 +-
sound/soc/sh/rcar/core.c
ly passed as the 2nd argument to the
function snd_soc_set_runtime_hwparams, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/intel/skylake/skl-pcm.c | 2 +-
1 file changed, 1 insertion(+)
in a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/intel/atom/sst-mfld-platform-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst-m
s the 2nd argument
to the function snd_soc_set_runtime_hwparams, which is const or used in
a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/kirkwood/kirkwood-dma.c | 2 +-
1 file chang
argument to the
function snd_soc_set_runtime_hwparams, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_asrc_dma.c | 2 +-
sound/soc/fsl/imx-pcm-fiq.c | 2 +-
2 files change
tf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.
Signed-off-by: Rob Herring <r...@kernel.org>
Acked-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel
s structure is only stored in the ops field of a snd_soc_dai_driver
structure. That field is declared const, so snd_soc_dai_ops structures
that have this property can be declared as const also.
Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
Signed-off-by: Mark Brown <broo...@ke
s structure is only stored in the ops field of a snd_soc_dai_driver
structure. That field is declared const, so snd_soc_dai_ops structures
that have this property can be declared as const also.
Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
Signed-off-by: Mark Brown <broo...@ke
s structure is only stored in the ops field of a snd_soc_dai_driver
structure. That field is declared const, so snd_soc_dai_ops structures
that have this property can be declared as const also.
Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
Signed-off-by: Mark Brown <broo...@ke
On Fri, Jul 14, 2017 at 04:08:21AM -0700, Joe Perches wrote:
> On Fri, 2017-07-14 at 12:02 +0100, Mark Brown wrote:
> > On Thu, Jul 13, 2017 at 11:18:11AM -0700, Joe Perches wrote:
> > > I don't it's better.
> > > It's not that confusing if the 0/n patch cover
On Thu, Jul 13, 2017 at 11:18:11AM -0700, Joe Perches wrote:
> I don't it's better.
> It's not that confusing if the 0/n patch cover letter is cc'd
> to all the appropriate mailing lists and all the [1..n]/n
> patches are sent with in-reply-to of the cover letter and
> send to the maintainers
On Thu, Jul 13, 2017 at 09:32:41AM +0200, Takashi Iwai wrote:
> please stop posting in this style. It's really annoying to see
> spontaneously popping-up almost same patch for more than two hours
> long.
> If you have a series of the same fix patches, send them as a patch
> set in a shot with a
value
Check return value from call to platform_get_irq(),
so in case of failure print error message and propagate
the return value.
Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
Acked-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel
; Done using Coccinelle:
Acked-by: Mark Brown <broo...@kernel.org>
signature.asc
Description: PGP signature
type enum dma_transfer_direction, and
not enum dma_data_direction. The enumeration values are the same
so this did not had an effect in practise.
Signed-off-by: Stefan Agner <ste...@agner.ch>
Acked-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel
needs its MCLK when powerup in wm8962_resume(). Thus it's better
to control the MCLK in codec driver. Thus remove the clock enable in
machine driver accordingly.
While at it, get rid of imx_wm8962_remove function since it is now
empty.
Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com>
Sign
latform's device dev.
Reported-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/imx-wm8962.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/s
On Wed, Mar 29, 2017 at 02:38:23PM +0300, Daniel Baluta wrote:
> If I read the code correctly, both machine and codec driver are doing:
> * codec_clk = clk_get(...)
> I guess that the codec driver is the first to be loaded and it will call:
> * __clk_create_clk
> which will do the allocation.
On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote:
> On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote:
> > >> - codec_clk = devm_clk_get(_dev->dev, NULL);
> > >> + codec_clk = clk_get(_dev->dev, NULL);
> > is different from _dev->dev.
> I get that they are
al <bhumi...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/eukrea-tlv320.c | 2 +-
sound/soc/fsl/imx-mc13783.c | 2 +-
sound/soc/fsl/mpc8610_hpcd.c| 2 +-
sound/soc/fsl/mx27vis-aic32x4.c | 2 +-
sound/soc/fsl/p1022_ds.c| 2 +-
sound/soc/fsl/
kpatch.pl
Signed-off-by: Alin Grigorean <alin.gri...@gmail.com>
Acked-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/imx-pcm-fiq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/imx-pc
On Fri, Feb 17, 2017 at 04:20:47PM -0800, Joe Perches wrote:
> If or when you apply it, you should
> fix it up to suit.
To repeat, I don't have this patch so someone will need to send it to
me.
> $ git log -1000 --pretty=oneline --no-merges sound/soc | \
> cut -f2- -d" " | cut -f1 -d":" |sort
On Fri, Feb 17, 2017 at 12:28:44PM -0800, Nicolin Chen wrote:
> On Thu, Feb 16, 2017 at 11:11:48PM -0800, Joe Perches wrote:
> > To enable eventual removal of pr_warning
> >
> > This makes pr_warn use consistent for sound/soc
> >
> > Prior to this patch, there were 5 uses of pr_warning and
> >
On Tue, Jan 03, 2017 at 10:22:57AM -0800, Caleb Crome wrote:
> From: Caleb Crome
>
> The fsl_ssi fifo watermark is by default set to 2 free spaces (i.e.
> activate DMA on FIFO when only 2 spaces are left.) This means the
Please submit patches using subject lines reflecting the
a 15-deep fifo get the new behavior. I
suspect a new fifo depth setting could be optimized on the older
chips too, but I have not tested.
Signed-off-by: Caleb Crome <ca...@crome.org>
Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
-
On Wed, Jan 04, 2017 at 10:31:42AM -0800, ccrome wrote:
> The subject should be
>
> [PATCH] ASoC: fsl_ssi: set fifo watermark to more reliable value
>
> Correct?
Yes.
> Should I re-submit?
No, it's fine - if I'm sending one of those mails it'll be fine as I've
actually seen the mail to reply
0 844371155 sound/soc/fsl/imx-wm8962.o
Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl-asoc-card.c | 2 +-
sound/soc/fsl/imx-wm8962.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --gi
upt-names/
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Acked-by: Rob Herring <r...@kernel.org>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
Documentation/devicetree/bindings/sound/davinci-mcbsp.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
t;receivce" ->
"receive"
trivial fix to spelling mistake in dev_err message
Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On Tue, Jun 28, 2016 at 01:47:59PM +0100, Colin King wrote:
> From: Colin Ian King
Please fix things so that your mail configuration matches your git
configuration, it makes things harder to review since it looks like
you've got a non-author signoff with a missing
Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>
Acked-by: Nicolin Chen <nicoleots...@gmail.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
ind
On Mon, Apr 25, 2016 at 10:50:24AM -0700, Caleb Crome wrote:
> Due to caching, SOR wasn't written when it should have been. This
> patch simply adds SOR to the volatile list.
Could you expand on when it wasn't written and why it needed to be
please?
signature.asc
Description: PGP signature
On Mon, Feb 01, 2016 at 05:58:06PM +0100, Maciej S. Szmigiero wrote:
> Looks like a possible solution would be to change
> regmap_raw_read() to do read using _regmap_read in
> case the cache is bypassed and there is no ->read
> callback defined for regmap implementation.
No, that's completely
On Mon, Feb 01, 2016 at 10:30:53PM +0100, Maciej S. Szmigiero wrote:
> On 01.02.2016 22:10, Mark Brown wrote:
> > No, that's completely broken. We can't do a raw read from a regmap that
> > doesn't offer raw access and we shouldn't pretend to do so. If the
> > caller is ca
On Tue, Jan 12, 2016 at 07:13:30PM +0100, Lothar Waßmann wrote:
> i.MX6UL does not have the audio multiplexer (AUDMUX) like e.g. i.MX6Q,
> but apart from that can use the same audio driver. Make audmux
> optional for the imx-sgtl5000 driver, so it can be used on i.MX6UL
> too. Also i.MX6UL
On Mon, Jan 11, 2016 at 07:23:54PM -0600, Timur Tabi wrote:
> Mark Brown wrote:
> >regcache handles this fine, it's perfectly happy to just go and allocate
> >the cache as registers get used (this is why the code that's doing the
> >allocation exists...). What is
On Mon, Jan 11, 2016 at 09:45:37AM -0600, Timur Tabi wrote:
> Ok, I'm confused. Granted, all of this regcache stuff was added after I
> stopped working on this driver, so I'm out of the loop. But it appears that
> the regcache cannot properly handle an uninitialized cache. I would expect
> it
On Mon, Jan 11, 2016 at 10:10:56AM -0200, Fabio Estevam wrote:
> On Mon, Jan 11, 2016 at 10:04 AM, Fabio Estevam wrote:
> > [2.526984] [ cut here ]
> > [2.531632] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:2755
> >
On Mon, Jan 11, 2016 at 03:10:20PM +0100, Maciej S. Szmigiero wrote:
> On 11.01.2016 15:00, Mark Brown wrote:
> > I suspect not, it looks like the driver is using the cache for
> > suspend/resume handling. I've dropped the patch for now. Either the
> > driver sh
On Tue, Nov 17, 2015 at 07:15:59AM -0200, Mauro Carvalho Chehab wrote:
> Now that media has its own subdirectory inside platform_data,
> let's move the headers that are already there to such subdir.
Acked-by: Mark Brown <broo...@kernel.org>
signature.asc
Description: P
On Tue, Aug 04, 2015 at 12:42:48AM +0200, Maciej S. Szmigiero wrote:
In cases like this where only one patch of six patch series is updated
should other ones be resubmitted as well to keep the full patch series
together?
Yes, any unapplied patches should be resubmitted.
signature.asc
On Mon, Aug 03, 2015 at 12:44:11AM +0200, Maciej S. Szmigiero wrote:
Adjust set DAI format function in fsl_ssi driver
so it doesn't fail and clears RXDIR in AC'97 mode.
Changes from v1: fix indentation to be consistent with rest
of the driver.
Inter version changelogs go after the --- as
On Wed, Jul 15, 2015 at 09:40:19AM +0200, Uwe Kleine-König wrote:
On Tue, Jul 14, 2015 at 10:54:42AM +0100, Mark Brown wrote:
static const struct of_device_id mpc512x_psc_spi_of_match[] = {
- { .compatible = fsl,mpc5121-psc-spi, },
+ { .compatible = fsl,mpc5121-psc-spi, .data = (void
On Tue, Jul 14, 2015 at 11:19:56AM +0200, Uwe Kleine-König wrote:
static const struct of_device_id mpc512x_psc_spi_of_match[] = {
- { .compatible = fsl,mpc5121-psc-spi, },
+ { .compatible = fsl,mpc5121-psc-spi, .data = (void *)TYPE_MPC5121 },
+ { .compatible =
On Wed, Jun 10, 2015 at 04:26:27PM +0800, Zidan Wang wrote:
+ - hp-det : ADCLRC/GPIO1, LINPUT3/JD2 and RINPUT3/JD3 pins can
+ be selected as headphone jack detect inputs to
+ automatically disable the speaker output and enable
+
On Wed, Jun 10, 2015 at 06:37:23PM +0300, Dan Carpenter wrote:
My static checker complains that:
sound/soc/fsl/imx-wm8962.c:196 imx_wm8962_probe() warn:
we tested 'ret' before and it was 'false'
Applied, thanks.
signature.asc
Description: Digital signature
501 - 600 of 913 matches
Mail list logo