[PATCH] macintosh: adb: make adb_dev_class constant

2024-03-05 Thread Ricardo B. Marliere
ynamically allocated at boot time. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- drivers/macintosh/adb.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c index 05

[PATCH next] bus: fsl-mc: constify the struct device_type usage

2024-02-19 Thread Ricardo B. Marliere
Cc: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- drivers/bus/fsl-mc/fsl-mc-bus.c | 32 include/linux/fsl/mc.h | 30 +++--- 2 files changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c

[PATCH 2/2] ALSA: seq: make snd_seq_bus_type const

2024-02-14 Thread Ricardo B. Marliere
Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- sound/core/seq_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/seq_device.c b/sound/core/seq_device.c index 7f3fd8eb016f..654d620d0199 100644 --- a/

[PATCH 1/2] ALSA: aoa: make soundbus_bus_type const

2024-02-14 Thread Ricardo B. Marliere
ntime. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- sound/aoa/soundbus/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/aoa/soundbus/core.c b/sound/aoa/soundbus/core.c index 8f24a3eea16b..2a295f610594 100644 --- a

[PATCH 0/2] ALSA: struct bus_type cleanup

2024-02-14 Thread Ricardo B. Marliere
To: Jaroslav Kysela To: Takashi Iwai Cc: Cc: Cc: Cc: Cc: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- Ricardo B. Marliere (2): ALSA: aoa: make soundbus_bus_type const ALSA: seq: make snd_seq_bus_type const sound/aoa/soundbus/core.c | 2 +- sound/core/seq_device.c | 2

Re: [PATCH v2 0/5] powerpc: struct bus_type cleanup

2024-02-13 Thread Ricardo B. Marliere
Hi Christophe, On 13 Feb 08:05, Christophe Leroy wrote: > Hi > > Le 12/02/2024 à 21:04, Ricardo B. Marliere a écrit : > > This series is part of an effort to cleanup the users of the driver > > core, as can be seen in many recent patches authored by Greg across the > >

[PATCH v2 5/5] powerpc: ibmebus: make ibmebus_bus_type const

2024-02-12 Thread Ricardo B. Marliere
Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- arch/powerpc/include/asm/ibmebus.h | 2 +- arch/powerpc/platforms/pseries/ibmebus.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/ibmebus

[PATCH v2 4/5] powerpc: pmac: make macio_bus_type const

2024-02-12 Thread Ricardo B. Marliere
Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- arch/powerpc/include/asm/macio.h | 2 +- drivers/macintosh/macio_asic.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/include/asm/macio.h b/arch/powerpc/i

[PATCH v2 3/5] powerpc: mpic: make mpic_subsys const

2024-02-12 Thread Ricardo B. Marliere
Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- arch/powerpc/include/asm/mpic.h | 2 +- arch/powerpc/sysdev/mpic.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/include/asm/mpic.h b/arch/powerpc/include/asm/mp

[PATCH v2 2/5] powerpc: vio: make vio_bus_type const

2024-02-12 Thread Ricardo B. Marliere
Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- arch/powerpc/include/asm/vio.h | 2 +- arch/powerpc/platforms/pseries/vio.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/vio.h b/arch/powerpc/i

[PATCH v2 1/5] powerpc: vio: move device attributes into a new ifdef

2024-02-12 Thread Ricardo B. Marliere
the vio_cmo_sysfs_init function. Cc: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- arch/powerpc/platforms/pseries/vio.c | 59 +--- 1 file changed, 34 insertions(+), 25 deletions(-) diff --git a/arch/powerpc/platforms/pseries/vio.c b/arch/powerpc/platforms

[PATCH v2 0/5] powerpc: struct bus_type cleanup

2024-02-12 Thread Ricardo B. Marliere
-power8--glibc--stable-2023.11-1 toolchain. --- [1]: https://lore.kernel.org/lkml/?q=f%3Agregkh%40linuxfoundation.org+s%3A%22make%22+and+s%3A%22const%22 Cc: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- Changes in v2: - Added a new patch to make macio_bus_type const. - Improved

Re: [PATCH 0/4] powerpc: struct bus_type cleanup

2024-02-12 Thread Ricardo B. Marliere
Please disregard this series, I will send a v2. Thank you, - Ricardo.

[PATCH 4/4] powerpc: ibmebus: make ibmebus_bus_type const

2024-02-09 Thread Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type, move the ibmebus_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B

[PATCH 3/4] powerpc: mpic: make mpic_subsys const

2024-02-09 Thread Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type, move the mpic_subsys variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B

[PATCH 2/4] powerpc: vio: make vio_bus_type const

2024-02-09 Thread Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type, move the vio_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B

[PATCH 1/4] powerpc: vio: move device attributes into a new ifdef

2024-02-09 Thread Ricardo B. Marliere
the vio_cmo_sysfs_init function. Cc: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- arch/powerpc/platforms/pseries/vio.c | 59 +--- 1 file changed, 34 insertions(+), 25 deletions(-) diff --git a/arch/powerpc/platforms/pseries/vio.c b/arch/powerpc/platforms

[PATCH 0/4] powerpc: struct bus_type cleanup

2024-02-09 Thread Ricardo B. Marliere
-power8--glibc--stable-2023.11-1 toolchain. --- [1]: https://lore.kernel.org/lkml/?q=f%3Agregkh%40linuxfoundation.org+s%3A%22make%22+and+s%3A%22const%22 Cc: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- Ricardo B. Marliere (4): powerpc: vio: move device attributes into a new

Re: [PATCH v4 5/5] sched: rename SD_SHARE_PKG_RESOURCES to SD_SHARE_LLC

2024-02-08 Thread Ricardo Neri
some confusing. > > Suggested-by: Valentin Schneider > Signed-off-by: Alex Shi FWIW, Reviewed-by: Ricardo Neri

[PATCH 4/4] powerpc: pseries: make suspend_subsys const

2024-02-04 Thread Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type, move the suspend_subsys variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B

[PATCH 3/4] powerpc: pseries: make cmm_subsys const

2024-02-04 Thread Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type, move the cmm_subsys variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B

[PATCH 2/4] powerpc: ps3: make ps3_system_bus_type const

2024-02-04 Thread Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type, move the ps3_system_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo

[PATCH 0/4] powerpc: struct bus_type cleanup

2024-02-04 Thread Ricardo B. Marliere
%40linuxfoundation.org+s%3A%22make%22+and+s%3A%22const%22 [2]: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=bus_cleanup=26105f537f0c60eacfeb430abd2e05d7ddcdd8aa Cc: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- Ricardo B. Marliere (4): powerpc

[PATCH 1/4] powerpc: cell: make spu_subsys const

2024-02-04 Thread Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type, move the spu_subsys variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B

Re: [PATCH v7 0/4] kexec: Fix kexec_file_load for llvm16 with PGO

2023-09-08 Thread Ricardo Ribalda
Hi Song On Fri, 8 Sept 2023 at 23:48, Song Liu wrote: > > Hi Ricardo, > > Thanks for your kind reply. > > On Fri, Sep 8, 2023 at 2:18 PM Ricardo Ribalda wrote: > > > > Hi Song > > > > On Fri, 8 Sept 2023 at 01:08, Song Liu wrote: > > > >

Re: [PATCH v7 0/4] kexec: Fix kexec_file_load for llvm16 with PGO

2023-09-08 Thread Ricardo Ribalda
Hi Song On Fri, 8 Sept 2023 at 01:08, Song Liu wrote: > > Hi Ricardo and folks, > > On Fri, May 19, 2023 at 7:48 AM Ricardo Ribalda wrote: > > > > When upreving llvm I realised that kexec stopped working on my test > > platform. > > > > The reason seem

[PATCH v7 4/4] riscv/purgatory: Remove PGO flags

2023-05-19 Thread Ricardo Ribalda
Signed-off-by: Ricardo Ribalda --- arch/riscv/purgatory/Makefile | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/riscv/purgatory/Makefile b/arch/riscv/purgatory/Makefile index 5730797a6b40..bd2e27f82532 100644 --- a/arch/riscv/purgatory/Makefile +++ b/arch/riscv/purgatory/Makefile @@ -3

[PATCH v7 3/4] powerpc/purgatory: Remove PGO flags

2023-05-19 Thread Ricardo Ribalda
If profile-guided optimization is enabled, the purgatory ends up with multiple .text sections. This is not supported by kexec and crashes the system. Cc: sta...@vger.kernel.org Fixes: 930457057abe ("kernel/kexec_file.c: split up __kexec_load_puragory") Signed-off-by: Ricardo Ribalda

[PATCH v7 2/4] x86/purgatory: Remove PGO flags

2023-05-19 Thread Ricardo Ribalda
If profile-guided optimization is enabled, the purgatory ends up with multiple .text sections. This is not supported by kexec and crashes the system. Cc: sta...@vger.kernel.org Fixes: 930457057abe ("kernel/kexec_file.c: split up __kexec_load_puragory") Signed-off-by: Ricardo Ribalda

[PATCH v7 1/4] kexec: Support purgatories with .text.hot sections

2023-05-19 Thread Ricardo Ribalda
ecause of this, the system crashes immediately after: kexec_core: Starting new kernel Cc: sta...@vger.kernel.org Fixes: 930457057abe ("kernel/kexec_file.c: split up __kexec_load_puragory") Reviewed-by: Ross Zwisler Reviewed-by: Steven Rostedt (Google) Reviewed-by: Philipp Rudo Signed-off-by:

[PATCH v7 0/4] kexec: Fix kexec_file_load for llvm16 with PGO

2023-05-19 Thread Ricardo Ribalda
When upreving llvm I realised that kexec stopped working on my test platform. The reason seems to be that due to PGO there are multiple .text sections on the purgatory, and kexec does not supports that. Signed-off-by: Ricardo Ribalda --- Changes in v7: - Fix $SUBJECT of riscv patch - Rename PGO

Re: [PATCH v6 4/4] risc/purgatory: Add linker script

2023-05-01 Thread Ricardo Ribalda
Hi Conor On Mon, 1 May 2023 at 19:41, Conor Dooley wrote: > > Hey Ricardo, > > On Mon, May 01, 2023 at 02:38:22PM +0200, Ricardo Ribalda wrote: > > If PGO is enabled, the purgatory ends up with multiple .text sections. > > This is not supported by kexec and crashes the

Re: [PATCH v6 4/4] risc/purgatory: Add linker script

2023-05-01 Thread Ricardo Ribalda
at 07:18:12PM +0200, Ricardo Ribalda wrote: > > On Mon, 1 May 2023 at 18:19, Nick Desaulniers > > wrote: > > > > > > On Mon, May 1, 2023 at 5:39 AM Ricardo Ribalda > > > wrote: > > > > > > > > If PGO is enabled, the purgator

Re: [PATCH v6 4/4] risc/purgatory: Add linker script

2023-05-01 Thread Ricardo Ribalda
: > > On Mon, May 1, 2023 at 5:39 AM Ricardo Ribalda wrote: > > > > If PGO is enabled, the purgatory ends up with multiple .text sections. > > This is not supported by kexec and crashes the system. > > > > Cc: sta...@vger.kernel.org > > Fixes: 93

[PATCH v6 4/4] risc/purgatory: Add linker script

2023-05-01 Thread Ricardo Ribalda
If PGO is enabled, the purgatory ends up with multiple .text sections. This is not supported by kexec and crashes the system. Cc: sta...@vger.kernel.org Fixes: 930457057abe ("kernel/kexec_file.c: split up __kexec_load_puragory") Signed-off-by: Ricardo Ribalda --- arch/riscv/purgator

[PATCH v6 3/4] powerpc/purgatory: Remove profile optimization flags

2023-05-01 Thread Ricardo Ribalda
If PGO is enabled, the purgatory ends up with multiple .text sections. This is not supported by kexec and crashes the system. Cc: sta...@vger.kernel.org Fixes: 930457057abe ("kernel/kexec_file.c: split up __kexec_load_puragory") Signed-off-by: Ricardo Ribalda --- arch/powerpc/purgator

[PATCH v6 2/4] x86/purgatory: Remove profile optimization flags

2023-05-01 Thread Ricardo Ribalda
If PGO is enabled, the purgatory ends up with multiple .text sections. This is not supported by kexec and crashes the system. Cc: sta...@vger.kernel.org Fixes: 930457057abe ("kernel/kexec_file.c: split up __kexec_load_puragory") Signed-off-by: Ricardo Ribalda --- arch/x86/purgatory/Ma

[PATCH v6 0/4] kexec: Fix kexec_file_load for llvm16 with PGO

2023-05-01 Thread Ricardo Ribalda
When upreving llvm I realised that kexec stopped working on my test platform. The reason seems to be that due to PGO there are multiple .text sections on the purgatory, and kexec does not supports that. Signed-off-by: Ricardo Ribalda --- Changes in v6: - Replace linker script with Makefile rule

[PATCH v6 1/4] kexec: Support purgatories with .text.hot sections

2023-05-01 Thread Ricardo Ribalda
ecause of this, the system crashes immediately after: kexec_core: Starting new kernel Cc: sta...@vger.kernel.org Fixes: 930457057abe ("kernel/kexec_file.c: split up __kexec_load_puragory") Reviewed-by: Ross Zwisler Reviewed-by: Steven Rostedt (Google) Reviewed-by: Philipp Rudo Signed-off-by:

Re: [PATCH v7 00/24] x86: Implement an HPET-based hardlockup detector

2023-04-12 Thread Ricardo Neri
On Wed, Mar 01, 2023 at 03:47:29PM -0800, Ricardo Neri wrote: > Hi x86 trusted reviewers, > > This is the seventh version of this patchset. I acknowledge that it took me > a long time to post a new version. Sorry! I will commit time to continue > working on this series with high

[PATCH v7 24/24] x86/tsc: Stop the HPET hardlockup detector if TSC become unstable

2023-03-01 Thread Ricardo Neri
hardlockup detector. Cc: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * Do not switch to the perf

[PATCH v7 22/24] x86/watchdog: Add a shim hardlockup detector

2023-03-01 Thread Ricardo Neri
nuxppc-dev@lists.ozlabs.org Suggested-by: Nicholas Piggin Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Added watchdog_nmi_start() to be used when the watchdog is reconfigured. * Always build the x86-specific hardlockup detector shim

[PATCH v7 20/24] x86/watchdog/hardlockup/hpet: Determine if HPET timer caused NMI

2023-03-01 Thread Ricardo Neri
)) 0.01550 155.020.00158 157.56 0.00020 117.74 Cc: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Andi Kleen Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- NOTE:

[PATCH v7 23/24] watchdog: Introduce hardlockup_detector_mark_unavailable()

2023-03-01 Thread Ricardo Neri
the state of /proc/sys/kernel/ nmi_watchdog to keep it consistent. Cc: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v6: * Introduced this patch Changes sinc

[PATCH v7 21/24] watchdog/hardlockup/hpet: Only enable the HPET watchdog via a boot parameter

2023-03-01 Thread Ricardo Neri
: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri -- Changes since v6: * Do not reuse the nmi_watchdog command line option. Instead, use a separate command line option. (Nicho

[PATCH v7 18/24] init/main: Delay initialization of the lockup detector after smp_init()

2023-03-01 Thread Ricardo Neri
g Reviewed-by: Tony Luck Acked-by: Nicholas Piggin Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Introduced this patch Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- init/main.c | 4 +++- 1 file

[PATCH v7 19/24] x86/watchdog/hardlockup: Add an HPET-based hardlockup detector

2023-03-01 Thread Ricardo Neri
...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * Added missing header asm/nmi.h. linux/nmi.h #includes it only if CONFIG_HAVE_NMI_WATCHDOG selected. Such option is not selected for ARCH=x86. * Removed

[PATCH v7 17/24] watchdog/hardlockup: Decouple the hardlockup detector from perf

2023-03-01 Thread Ricardo Neri
t; Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * None Changes since v4: * None Changes since v3: * Squashed into this patch a previous patch to make arch_touch_nm

[PATCH v7 16/24] watchdog/hardlockup: Define a generic function to detect hardlockups

2023-03-01 Thread Ricardo Neri
Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * None Changes since v4: * None Changes since v3: * None Changes since v2: * None Changes since v1: * None --- include/linux/nmi.h | 1 + kernel/watchdog_hld.c | 18 +++--- 2 files c

[PATCH v7 15/24] x86/hpet: Reserve an HPET channel for the hardlockup detector

2023-03-01 Thread Ricardo Neri
Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * Reworded the commit message for clarity. * Removed pointless global variable hld_data

[PATCH v7 14/24] x86/hpet: Prepare IRQ assignments to use the X86_ALLOC_AS_NMI flag

2023-03-01 Thread Ricardo Neri
" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Introduced this patch. Changes since v4: * N/A Changes sinc

[PATCH v7 12/24] x86/hpet: Expose hpet_writel() in header

2023-03-01 Thread Ricardo Neri
Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * None Changes since v4: * Dropped exposing hpet_readq() as it is not needed. Changes since v3: * None Changes since v2: * None Changes since v1: * None --- arch/x86/include/asm/hpet.h | 1 + arch/

[PATCH v7 10/24] iommu/amd: Enable NMIPass when allocating an NMI

2023-03-01 Thread Ricardo Neri
Roedel Cc: Suravee Suthikulpanit Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v6: * Removed check for nr_irqs in irq_remapping_alloc(). Allocation had been rejected already in the root domain. (Thomas) Cha

[PATCH v7 13/24] x86/hpet: Add helper function hpet_set_comparator_periodic()

2023-03-01 Thread Ricardo Neri
: Tony Luck Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Originally-by: Suravee Suthikulpanit Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- When programming the HPET channel in periodic mode, a udelay(

[PATCH v7 11/24] iommu/amd: Compose MSI messages for NMIs in non-IR format

2023-03-01 Thread Ricardo Neri
format. Let descendant irqchips write the composed message. Cc: Andi Kleen Cc: "Ravi V. Shankar" Cc: Joerg Roedel Cc: Suravee Suthikulpanit Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v6:

[PATCH v7 09/24] iommu/amd: Expose [set|get]_dev_entry_bit()

2023-03-01 Thread Ricardo Neri
ists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Introduced this patch Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- drivers/iommu/amd/amd_iommu.h | 3 ++

[PATCH v7 07/24] iommu/vt-d: Rework prepare_irte() to support per-interrupt delivery mode

2023-03-01 Thread Ricardo Neri
Kleen Cc: David Woodhouse Cc: "Ravi V. Shankar" Cc: Lu Baolu Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Ashok Raj Reviewed-by: Tony Luck Reviewed-by: Lu Baolu Signed-off-by: Ricardo Neri --- Change

[PATCH v7 08/24] iommu/vt-d: Set the IRTE delivery mode individually for each interrupt

2023-03-01 Thread Ricardo Neri
. Cc: Andi Kleen Cc: David Woodhouse Cc: "Ravi V. Shankar" Cc: Lu Baolu Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Reviewed-by: Lu Baolu Signed-off-by: Ricardo Neri --- Changes since v6: * None Change

[PATCH v7 06/24] iommu/vt-d: Clear the redirection hint when the destination mode is physical

2023-03-01 Thread Ricardo Neri
ion.org Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Ashok Raj Reviewed-by: Lu Baolu Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Introduced this patch. Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --

[PATCH v7 04/24] x86/apic/vector: Implement a local APIC NMI controller

2023-03-01 Thread Ricardo Neri
nuxppc-dev@lists.ozlabs.org Suggested-by: Thomas Gleixner Signed-off-by: Ricardo Neri --- Changes since v6: * Reworked patch "x86/apic/vector: Implement support for NMI delivery mode" into a separate local APIC NMI controller. (Thomas) Changes since v5: * Introduced this patch. Ch

[PATCH v7 05/24] x86/apic/vector: Skip cleanup for the NMI vector

2023-03-01 Thread Ricardo Neri
The NMI vector is fixed. No cleanup is needed after updating affinity. Cc: Andi Kleen Cc: "Ravi V. Shankar" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v6: * Introduced this patch. Cha

[PATCH v7 00/24] x86: Implement an HPET-based hardlockup detector

2023-03-01 Thread Ricardo Neri
watchdog: 23 and 24. Previous version of the patches can be found in [1], [2], [3], [4], [5], and [6]. Thanks and BR, Ricardo == Problem statement In x86, the NMI watchdog is driven using a counter (one per CPU) of the Performance Monitoring Unit (PMU). PMU counters, however, are scarce

[PATCH v7 03/24] x86/apic: Add the X86_IRQ_ALLOC_AS_NMI interrupt allocation flag

2023-03-01 Thread Ricardo Neri
ozlabs.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Introduced this patch. Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- arch/x86/include/asm/irqdo

[PATCH v7 01/24] x86/apic: Add irq_cfg::delivery_mode

2023-03-01 Thread Ricardo Neri
Ashok Raj Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * Reworded the commit message to accurately state that the root domain allocates a vector for an interrupt, not an interrupt. (Thomas) * Removed stray newline. (Thomas) * Replaced 'irq' with 'interrupt' in the

[PATCH v7 02/24] x86/apic/msi: Use the delivery mode from irq_cfg for message composition

2023-03-01 Thread Ricardo Neri
to APIC_DELIVERY_MODE_FIXED. Cc: Andi Kleen Cc: "Ravi V. Shankar" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * Reworded changelog as per suggestion from Thomas. Change

Re: [PATCH v8 2/3] freezer: refactor pm_freezing into a function.

2022-12-05 Thread Ricardo Ribalda
Hi Rafael On Fri, 2 Dec 2022 at 18:48, Rafael J. Wysocki wrote: > > On Thu, Dec 1, 2022 at 12:08 PM Ricardo Ribalda wrote: > > > > Add a way to let the drivers know if the processes are frozen. > > > > This is needed by drivers that are waiting for processes to

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Ricardo Ribalda
Hi Oliver On Thu, 1 Dec 2022 at 14:22, 'Oliver Neukum' via Chromeos Kdump wrote: > > On 01.12.22 14:03, Ricardo Ribalda wrote: > > Hi, > > > This patchset does not modify this behaviour. It simply fixes the > > stall for kexec(). > > > > The patch that

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Ricardo Ribalda
Hi Oliver Thanks for your review On Thu, 1 Dec 2022 at 13:29, Oliver Neukum wrote: > > On 01.12.22 12:08, Ricardo Ribalda wrote: > > If we are shutting down due to kexec and the userspace is frozen, the > > system will stall forever waiting for userspace to complete. &

[PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Ricardo Ribalda
: 83bfc7e793b5 ("ASoC: SOF: core: unregister clients and machine drivers in .shutdown") Signed-off-by: Ricardo Ribalda --- sound/soc/sof/core.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sound/soc/sof/core.c b/sound/soc/sof/core.c index 3e6141d03770..9587b6a85

[PATCH v8 2/3] freezer: refactor pm_freezing into a function.

2022-12-01 Thread Ricardo Ribalda
Fixes: 83bfc7e793b5 ("ASoC: SOF: core: unregister clients and machine drivers in .shutdown") Signed-off-by: Ricardo Ribalda sdad --- include/linux/freezer.h | 3 ++- kernel/freezer.c| 3 +-- kernel/power/process.c | 24 3 files changed, 23 insert

[PATCH v8 1/3] kexec: Refactor kexec_in_progress into a function

2022-12-01 Thread Ricardo Ribalda
chine drivers in .shutdown") Signed-off-by: Ricardo Ribalda --- arch/powerpc/platforms/pseries/vio.c | 2 +- arch/x86/kernel/cpu/mshyperv.c | 6 +++--- arch/x86/xen/enlighten_hvm.c | 2 +- drivers/firmware/efi/efi.c | 2 +- drivers/pci/pci-driver.c

[PATCH v8 0/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-01 Thread Ricardo Ribalda
...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-hyp...@vger.kernel.org Cc: xen-de...@lists.xenproject.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux...@vger.kernel.org Signed-off-by: Ricardo Ribalda --- Changes in v8: - Wrap pm_freezing and kex

Re: [PATCH v6 15/29] x86/hpet: Add helper function hpet_set_comparator_periodic()

2022-05-17 Thread Ricardo Neri
On Sat, May 14, 2022 at 10:17:38AM +0200, Thomas Gleixner wrote: > On Fri, May 13 2022 at 14:19, Ricardo Neri wrote: > > On Fri, May 06, 2022 at 11:41:13PM +0200, Thomas Gleixner wrote: > >> The argument about not bloating the code > >> with an "obvious??

Re: [PATCH v6 28/29] x86/tsc: Restart NMI watchdog after refining tsc_khz

2022-05-17 Thread Ricardo Neri
On Tue, May 10, 2022 at 01:44:05PM +0200, Thomas Gleixner wrote: > On Tue, May 10 2022 at 21:16, Nicholas Piggin wrote: > > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > >> + /* > >> + * If in use, the HPET hardlockup detector relies on tsc_

Re: [PATCH v6 28/29] x86/tsc: Restart NMI watchdog after refining tsc_khz

2022-05-17 Thread Ricardo Neri
On Tue, May 10, 2022 at 09:16:21PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > > The HPET hardlockup detector relies on tsc_khz to estimate the value of > > that the TSC will have when its HPET channel fires. A refined ts

Re: [PATCH v6 21/29] x86/nmi: Add an NMI_WATCHDOG NMI handler category

2022-05-17 Thread Ricardo Neri
On Mon, May 09, 2022 at 03:59:40PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 17:00, Ricardo Neri wrote: > > Add a NMI_WATCHDOG as a new category of NMI handler. This new category > > is to be used with the HPET-based hardlockup detector. This detector > > does

Re: [PATCH v6 29/29] x86/tsc: Switch to perf-based hardlockup detector if TSC become unstable

2022-05-16 Thread Ricardo Neri
On Tue, May 10, 2022 at 10:14:00PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > > The HPET-based hardlockup detector relies on the TSC to determine if an > > observed NMI interrupt was originated by HPET timer. Hence, this d

Re: [PATCH v6 05/29] x86/apic/vector: Do not allocate vectors for NMIs

2022-05-13 Thread Ricardo Neri
On Fri, May 13, 2022 at 10:50:09PM +0200, Thomas Gleixner wrote: > On Fri, May 13 2022 at 11:03, Ricardo Neri wrote: > > On Fri, May 06, 2022 at 11:12:20PM +0200, Thomas Gleixner wrote: > >> Why would a NMI ever end up in this code? There is no vector management > >>

Re: [PATCH v6 24/29] watchdog/hardlockup: Use parse_option_str() to handle "nmi_watchdog"

2022-05-13 Thread Ricardo Neri
On Tue, May 10, 2022 at 08:46:41PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > > Prepare hardlockup_panic_setup() to handle a comma-separated list of > > options. Thus, it can continue parsing its own command-line options whi

Re: [PATCH v6 20/29] init/main: Delay initialization of the lockup detector after smp_init()

2022-05-13 Thread Ricardo Neri
On Tue, May 10, 2022 at 08:38:22PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 9:59 am: > > Certain implementations of the hardlockup detector require support for > > Inter-Processor Interrupt shorthands. On x86, support for these can only &g

Re: [PATCH v6 22/29] x86/watchdog/hardlockup: Add an HPET-based hardlockup detector

2022-05-13 Thread Ricardo Neri
On Mon, May 09, 2022 at 04:03:39PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 17:00, Ricardo Neri wrote: > > + if (is_hpet_hld_interrupt(hdata)) { > > + /* > > +* Kick the timer first. If the HPET channel is periodic, it > > +

Re: [PATCH v6 15/29] x86/hpet: Add helper function hpet_set_comparator_periodic()

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:51:52PM +0200, Thomas Gleixner wrote: > On Fri, May 06 2022 at 23:41, Thomas Gleixner wrote: > > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > >> Programming an HPET channel as periodic requires setting the > >> HPET_TN_SETVAL bit in the

Re: [PATCH v6 15/29] x86/hpet: Add helper function hpet_set_comparator_periodic()

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:41:13PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > Programming an HPET channel as periodic requires setting the > > HPET_TN_SETVAL bit in the channel configuration. Plus, the comparator > > register must b

Re: [PATCH v6 13/29] iommu/amd: Compose MSI messages for NMI irqs in non-IR format

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:31:56PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > +* > > +* Also, NMIs do not have an associated vector. No need for cleanup. > > They have a vector and what the heck is this cle

Re: [PATCH v6 12/29] iommu/amd: Enable NMIPass when allocating an NMI irq

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:26:22PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > > > + if (info->flags & X86_IRQ_ALLOC_AS_NMI) { > > + /* Only one IRQ per NMI */ > > + if (nr_irqs != 1) > > +

Re: [PATCH v6 10/29] iommu/vt-d: Implement minor tweaks for NMI irqs

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:23:23PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > The Intel IOMMU interrupt remapping driver already programs correctly the > > delivery mode of individual irqs as per their irq_data. Improve handling > >

Re: [PATCH v6 05/29] x86/apic/vector: Do not allocate vectors for NMIs

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:12:20PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > Vectors are meaningless when allocating IRQs with NMI as the delivery > > mode. > > Vectors are not meaningless. NMI has a fixed vector. > > Th

Re: [PATCH v6 03/29] x86/apic/msi: Set the delivery mode individually for each IRQ

2022-05-11 Thread Ricardo Neri
On Fri, May 06, 2022 at 10:05:34PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > There are no restrictions in hardware to set MSI messages with its > > own delivery mode. > > "messages with its own" ? Plural/singular confu

Re: [PATCH v6 02/29] x86/apic: Add irq_cfg::delivery_mode

2022-05-11 Thread Ricardo Neri
On Fri, May 06, 2022 at 09:53:54PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > Currently, the delivery mode of all interrupts is set to the mode of the > > APIC driver in use. There are no restrictions in hardware to configure the > >

Re: [PATCH v6 01/29] irq/matrix: Expose functions to allocate the best CPU for new vectors

2022-05-11 Thread Ricardo Neri
On Fri, May 06, 2022 at 09:48:28PM +0200, Thomas Gleixner wrote: > Ricardo, Thank you very much for your feedback Thomas! I am sorry for my late reply, I had been out of office. > > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > Certain types of interrupts, such as N

[PATCH v6 29/29] x86/tsc: Switch to perf-based hardlockup detector if TSC become unstable

2022-05-05 Thread Ricardo Neri
: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Relocated the d

[PATCH v6 28/29] x86/tsc: Restart NMI watchdog after refining tsc_khz

2022-05-05 Thread Ricardo Neri
nuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch Changes since v4 * N/A Changes since v3 * N/A Changes since v2: * N/A Changes since v1: * N/A --- arch/x86/kernel/tsc.c | 6 ++ 1 file changed, 6 insertions(+) diff --

[PATCH v6 27/29] watchdog: Expose lockup_detector_reconfigure()

2022-05-05 Thread Ricardo Neri
: Nicholas Piggin Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * None Changes since v4: * Switching to the perf-based lockup dete

[PATCH v6 26/29] x86/watchdog: Add a shim hardlockup detector

2022-05-05 Thread Ricardo Neri
las Piggin Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Added watchdog_nmi_start() to be used when tsc_khz is recalibrated. * Always build the x86-specific hardlockup detector shim; not only when the HPET-based detector is selected. * Corrected a typo

[PATCH v6 25/29] watchdog/hardlockup/hpet: Only enable the HPET watchdog via a boot parameter

2022-05-05 Thread Ricardo Neri
-line parsing using an early_param, as __setup("nmi_watchdog=") only parses generic options. Cc: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-

[PATCH v6 24/29] watchdog/hardlockup: Use parse_option_str() to handle "nmi_watchdog"

2022-05-05 Thread Ricardo Neri
their own options. Cc: Andi Kleen Cc: Nicholas Piggin Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Corrected typo in comm

[PATCH v6 23/29] x86/watchdog/hardlockup/hpet: Determine if HPET timer caused NMI

2022-05-05 Thread Ricardo Neri
avi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Suggested-by: Andi Kleen Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- NOTE: The error characterization data is repetead here from the cover letter. --- Changes since v5:

[PATCH v6 22/29] x86/watchdog/hardlockup: Add an HPET-based hardlockup detector

2022-05-05 Thread Ricardo Neri
: Andi Kleen Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Squashed a previously separate patch to support interrupt remapping into this patch

[PATCH v6 21/29] x86/nmi: Add an NMI_WATCHDOG NMI handler category

2022-05-05 Thread Ricardo Neri
: "Ravi V. Shankar" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Updated to call instrumentation_end() as per f051f6979550 ("x86/nmi: Pr

[PATCH v6 20/29] init/main: Delay initialization of the lockup detector after smp_init()

2022-05-05 Thread Ricardo Neri
.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- init/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

  1   2   3   >