On 22.01.2016 09:15, Shaohui Xie wrote:
___
From: Andrew Lunn <and...@lunn.ch>
Sent: Friday, January 22, 2016 5:12 AM
To: Shaohui Xie
Cc: Sebastian Hesselbarth; Florian Fainelli; shh@gmail.com;
devicet...@vger.kernel.org; net...@vger.kernel.org;
li
On 18.01.2016 08:23, Shaohui Xie wrote:
If you look at the list of possible values for "phy-mode" you'd see
that none of it describes a PHY-to-PHY connection but all are for
MAC-to-PHY connections. Also, names above suggest it already: MII is
short for media _independent_ interface.
I copy
On 15.01.2016 05:01, Shaohui Xie wrote:
>> -Original Message-
>> From: Andrew Lunn [mailto:and...@lunn.ch]
>> Sent: Friday, January 15, 2016 12:44 AM
>> To: shh@gmail.com
>> Cc: devicet...@vger.kernel.org; net...@vger.kernel.org; linuxppc-
>> d...@lists.ozlabs.org;
On 02/12/2014 01:21 AM, Stephen N Chivers wrote:
Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote on
02/12/2014 10:46:36 AM:
From: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
To: Scott Wood scottw...@freescale.com
Cc: Kumar Gala ga...@kernel.crashing.org, Stephen N Chivers
On 02/12/2014 06:28 AM, Kevin Hao wrote:
On Wed, Feb 12, 2014 at 10:21:58AM +1000, Stephen N Chivers wrote:
But, the Interrupt Controller (MPIC)
goes AWOL and it is down hill from there.
The MPIC is specified in the DTS as:
mpic: pic@4 {
On 02/12/14 11:31, Kevin Hao wrote:
On Wed, Feb 12, 2014 at 09:30:00AM +0100, Sebastian Hesselbarth wrote:
On 02/12/2014 06:28 AM, Kevin Hao wrote:
On Wed, Feb 12, 2014 at 10:21:58AM +1000, Stephen N Chivers wrote:
But, the Interrupt Controller (MPIC)
goes AWOL and it is down hill from
105353145eafb3ea919f5cdeb652a9d8f270228e
Author: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
Date: Tue Dec 3 14:52:00 2013 +0100
OF: base: match each node compatible against all given matches first
[adding Arnd on Cc]
Could be. I checked tty/serial/of_serial.c and it does not provide a
compatible for fsl,ns16550
On 02/12/2014 12:38 AM, Stephen N Chivers wrote:
Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote on
On 02/11/2014 11:33 PM, Kumar Gala wrote:
On Feb 11, 2014, at 2:57 PM, Stephen N Chivers schiv...@csc.com.au wrote:
I have been trial booting a 3.14-rc2 kernel for a 85xx platform
On 02/12/2014 12:41 AM, Scott Wood wrote:
On Tue, 2014-02-11 at 23:51 +0100, Sebastian Hesselbarth wrote:
On 02/11/2014 11:33 PM, Kumar Gala wrote:
Hmm,
Wondering if this caused the issue:
commit 105353145eafb3ea919f5cdeb652a9d8f270228e
Author: Sebastian Hesselbarth sebastian.hesselba
on Dockstar,
which has PHY addr 0x0 - also the reset default, which may be
why it slipped through.
Acked-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
drivers/net/ethernet/marvell/mv643xx_eth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell
On 11/05/2013 11:12 PM, Arnaud Ebalard wrote:
Hi Jason,
Jason Gunthorpe jguntho...@obsidianresearch.com writes:
Commit cc9d4598 'net: mv643xx_eth: use of_phy_connect if phy_node
present' made the call to phy_scan optional, if the DT has a link to
the phy node.
However phy_scan has the side
On 05/31/2013 02:55 AM, David Miller wrote:
From: Sebastian Hesselbarthsebastian.hesselba...@gmail.com
Date: Wed, 29 May 2013 21:32:42 +0200
For the patches above I suggest to take Patches 1-6 through David
Miller's branch, and Patches 7-12 through Jason Cooper's when the
former have appeared
On 05/30/13 11:06, Arnaud Ebalard wrote:
Sebastian Hesselbarth sebastian.hesselba...@gmail.com writes:
With DT support for mv643xx_eth board specific init for some boards now
is unneccessary. Remove those board files, Kconfig entries, and
corresponding entries in kirkwood_defconfig.
Signed-off
of
the network device.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Note: I observed this behavior when removing a modular mv643xx_eth driver
after attaching it to a phy handled by (also modular) mvmdio. The mvmdio
conversion has been done in
commit
This adds a struct device_node pointer for a phy passed by phandle
to mv643xx_eth node.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Jason Cooper ja...@lakedaemon.net
Cc: Andrew Lunn
Make use of managed devm_ioremap and remove corresponding iounmap.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Jason Cooper ja...@lakedaemon.net
Cc: Andrew Lunn and...@lunn.ch
Cc
This connects to a phy node passed to the port device instead of probing
the phy by phy_addr.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Jason Cooper ja...@lakedaemon.net
Cc: Andrew
easily. Instead the current workaround by not gating ge clocks
is kept. The OF property workaround is postponed until some
easy to use of_set_property is available.
Sebastian Hesselbarth (13):
net: mv643xx_eth: use phy_disconnect instead of phy_detach
net: mv643xx_eth: use managed
using this driver should also be
protected from clearing that bit.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Note: In contrast to the reset value of 0 for CLK125_BYPASS_EN bit as
stated in Kirkwood datasheet, we confirmed that reset value is 1 instead.
Either datasheet
platform_data.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Note: Although different, device tree bindings are compatible with PPC
bindings. As I do not have access to any PPC platform using mv643xx_eth,
I leave conversion (phy vs phy-handle) and compatible string name
up to PPC
This patch adds orion-eth and mvmdio device tree nodes for DT enabled
Dove boards. As there is only one ethernet controller on Dove, a default
phy node is also added with a note to set its reg property on a per-board
basis.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
This patch adds mv643xx_eth and mvmdio device tree nodes for DT enabled
Kirkwood boards. Phy nodes are also added with reg property set on a
per-board basis.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Changelog:
v4-v5:
- use Kirkwood specific compatible string
Cc
This patch adds mv643xx_eth and mvmdio device tree nodes for DT enabled
Orion5x boards. Phy nodes are also added with reg property set on a
per-board basis.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Changelog:
v3-v4:
- convert to new device tree binding
Cc: David
With DT support for mv643xx_eth we do not need legacy platform_data
based setup for DT enabled boards anymore.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Jason Cooper ja
With DT support for mv643xx_eth we do not need legacy platform_data
based setup for DT enabled boards. This patch removes eth setup
for all orion5x DT board files.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek
With all boards converted to DT enabled mv643xx_eth we can now
remove the clock alias for gbe clocks.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Jason Cooper ja...@lakedaemon.net
Cc
With DT support for mv643xx_eth board specific init for some boards now
is unneccessary. Remove those board files, Kconfig entries, and
corresponding entries in kirkwood_defconfig.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Note: board-km_kirkwood.c is also removed
On 05/27/13 11:39, Benjamin Herrenschmidt wrote:
On Mon, 2013-05-27 at 02:23 -0700, David Miller wrote:
Sparc has an of_set_property(), it needs to become generic.
There is an of_update_property(), we could change the name though, yours
is nicer :-)
Ben, David,
I had a quick look at
On 05/27/2013 11:50 PM, Benjamin Herrenschmidt wrote:
On Mon, 2013-05-27 at 14:47 +0200, Arnd Bergmann wrote:
On Monday 27 May 2013 21:50:04 Benjamin Herrenschmidt wrote:
However, that wouldn't help much with the allocation/leak problem,
though at least it would be easier to use. It could also
On 05/26/2013 06:04 AM, David Miller wrote:
From: Sebastian Hesselbarthsebastian.hesselba...@gmail.com
Date: Wed, 22 May 2013 22:04:01 +0200
+ memcpy((void *)p-value, reg, 6);
This cast is completely unnecessary, non-void to void pointer casts
are automatic.
If it is
On 05/24/2013 07:13 PM, Russell King - ARM Linux wrote:
Do you really want that on ARM? Given the fiasco with the location of
the registers, are you sure you want to place more trust in that
direction? Does it give you a warm fuzzy feeling to know that you
might have to work out some way to
On 05/23/2013 08:40 PM, Jason Cooper wrote:
On Thu, May 23, 2013 at 11:53:57AM -0600, Jason Gunthorpe wrote:
On Thu, May 23, 2013 at 01:23:39PM -0400, Jason Cooper wrote:
Shouldn't it rather be
compatible = marvell,kirkwood-eth, marvell,orion-eth;
Not sure about orion-eth?
Jason,
On 05/21/2013 07:48 PM, Andrew Lunn wrote:
On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote:
This patch adds orion-eth and mvmdio device tree nodes for DT enabled
Dove boards. As there is only one ethernet controller on Dove, a default
phy node is also added with a note
On 05/22/2013 12:04 PM, tiejun.chen wrote:
On 05/22/2013 05:43 PM, Sebastian Hesselbarth wrote:
On 05/21/2013 07:48 PM, Andrew Lunn wrote:
On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote:
This patch adds orion-eth and mvmdio device tree nodes for DT enabled
Dove boards
On 05/22/2013 06:59 PM, Jason Gunthorpe wrote:
On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote:
iirc, our solution to this was to parse the ATAGs for the mac addr and
update the appended dtb. This way, module load and unload would work
without loosing the mac address. I believe
On 05/22/2013 07:35 PM, Jason Cooper wrote:
On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote:
On 05/22/2013 06:59 PM, Jason Gunthorpe wrote:
On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote:
iirc, our solution to this was to parse the ATAGs for the mac addr
On 05/22/2013 07:48 PM, Jason Cooper wrote:
On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote:
Hmm, maybe a little bit too early. While restoring the MAC address now
works, another bug arises which I guess is related with phy setup
and aneg.
Will investigate and update
On 05/22/2013 08:24 PM, Jason Gunthorpe wrote:
On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote:
Not neccessary anyway, after talking Jason C in a Kirkwood-only
workaround I prepared a patch that reads mac address registers early
and stores it in the local-mac-address
On 05/22/2013 08:49 PM, Jason Cooper wrote:
On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote:
On 05/22/2013 07:48 PM, Jason Cooper wrote:
On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote:
Hmm, maybe a little bit too early. While restoring the MAC
will find the stored MAC
in the corresponding MAC address property.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Jason Cooper ja...@lakedaemon.net
Cc: Andrew Lunn and...@lunn.ch
Cc: Benjamin
using this driver should also be
protected from clearing that bit.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Note: In contrast to the reset value of 0 for CLK125_BYPASS_EN bit as
stated in Kirkwood datasheet, we confirmed that reset value is 1 instead.
Either
On 05/22/2013 10:36 PM, Simon Baatz wrote:
Hi Sebastian,
On Tue, May 21, 2013 at 06:41:49PM +0200, Sebastian Hesselbarth wrote:
With DT support for mv643xx_eth, board specific init for some boards now
is unneccessary. Remove those board files, Kconfig entries, and
corresponding entries
On 05/22/2013 10:16 PM, Jason Gunthorpe wrote:
On Wed, May 22, 2013 at 10:04:02PM +0200, Sebastian Hesselbarth wrote:
Ethernet controllers found on Kirkwood SoCs not only suffer from loosing
MAC address register contents on clock gating but also some important
registers are reset to values
On 05/22/2013 11:02 PM, Jason Cooper wrote:
On Wed, May 22, 2013 at 10:55:43PM +0200, Sebastian Hesselbarth wrote:
On 05/22/2013 10:36 PM, Simon Baatz wrote:
Hi Sebastian,
On Tue, May 21, 2013 at 06:41:49PM +0200, Sebastian Hesselbarth wrote:
With DT support for mv643xx_eth, board specific
of
the network device.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Note: I observed this behavior when removing a modular mv643xx_eth driver
after attaching it to a phy handled by (also modular) mvmdio. The mvmdio
conversion has been done in
commit
Make use of managed devm_ioremap and remove corresponding iounmap.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Jason Cooper ja...@lakedaemon.net
Cc: Andrew Lunn and...@lunn.ch
Cc
This adds a struct device_node pointer for a phy passed by phandle
to mv643xx_eth node.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Jason Cooper ja...@lakedaemon.net
Cc: Andrew Lunn
it.
Sebastian Hesselbarth (12):
net: mv643xx_eth: use phy_disconnect instead of phy_detach
net: mv643xx_eth: use managed devm_ioremap for port registers
net: mv643xx_eth: add phy_node to platform_data struct
net: mv643xx_eth: use of_phy_connect if phy_node present
net: mv643xx_eth: add DT
This connects to a phy node passed to the port device instead of probing
the phy by phy_addr.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Jason Cooper ja...@lakedaemon.net
Cc: Andrew
This patch adds orion-eth and mvmdio device tree nodes for DT enabled
Dove boards. As there is only one ethernet controller on Dove, a default
phy node is also added with a note to set its reg property on a per-board
basis.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
platform_data.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Note: Although different, device tree bindings are compatible with PPC
bindings. As I do not have access to any PPC platform using mv643xx_eth,
I leave conversion (phy vs phy-handle) and compatible string name
up to PPC
This patch adds mv643xx_eth and mvmdio device tree nodes for DT enabled
Kirkwood boards. Phy nodes are also added with reg property set on a
per-board basis.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Changelog:
v3-v4:
- convert to new device tree binding
- fix phy
This patch adds mv643xx_eth and mvmdio device tree nodes for DT enabled
Orion5x boards. Phy nodes are also added with reg property set on a
per-board basis.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Changelog:
v3-v4:
- convert to new device tree binding
Cc: David
With DT support for mv643xx_eth we do not need legacy platform_data
based setup for DT enabled boards anymore.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Jason Cooper ja
With all boards converted to DT enabled mv643xx_eth we can now
remove the clock alias for gbe clocks. The workaround for ge0/ge1 clock
gates is not removed, as Kirkwood ethernet controllers loose MAC address
stored in internal registers on gated ge0/ge1 clocks.
Signed-off-by: Sebastian
With DT support for mv643xx_eth, board specific init for some boards now
is unneccessary. Remove those board files, Kconfig entries, and
corresponding entries in kirkwood_defconfig.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Note: board-km_kirkwood.c is also removed
With DT support for mv643xx_eth we do not need legacy platform_data
based setup for DT enabled boards. This patch removes eth setup
for all orion5x DT board files.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David Miller da...@davemloft.net
Cc: Lennert Buytenhek
With recent support for GRO, there is no need to keep both LRO and
GRO. This patch therefore removes the deprecated inet_lro support
from mv643xx_eth. This is work is based on an experimental patch
provided by Eric Dumazet and Willy Tarreau.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba
,
this patch set combines both patches into one set.
Sebastian Hesselbarth (2):
net: mv643xx_eth: add shared clk and cleanup existing clk handling
net: mv643xx_eth: use managed devm_kzalloc
Documentation/devicetree/bindings/marvell.txt |3 ++
drivers/net/ethernet/marvell/mv643xx_eth.c
Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: Grant Likely grant.lik...@secretlab.ca
Cc: Rob Herring rob.herr...@calxeda.com
Cc: Rob Landley r...@landley.net
Cc: Lennert Buytenhek buyt...@wantstofly.org
Cc: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
Cc: Andrew Lunn and...@lunn.ch
Cc: Jason
This patch moves shared private data kzalloc to managed devm_kzalloc and
cleans now unneccessary kfree and error handling.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Changes from v1:
- replaced EADDRNOTAVAIL with ENOMEM on failing ioremap (Reported by
Sergei
This patch adds GRO support to mv643xx_eth by making it invoke
napi_gro_receive instead of netif_receive_skb.
Signed-off-by: Soeren Moch sm...@web.de
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: David S. Miller da...@davemloft.net
Cc: Lennert Buytenhek buyt
On Thu, Apr 11, 2013 at 3:13 PM, Willy Tarreau w...@1wt.eu wrote:
On Thu, Apr 11, 2013 at 02:40:23PM +0200, Sebastian Hesselbarth wrote:
This patch adds GRO support to mv643xx_eth by making it invoke
napi_gro_receive instead of netif_receive_skb.
Signed-off-by: Soeren Moch sm...@web.de
On Thu, Apr 11, 2013 at 5:03 PM, Willy Tarreau w...@1wt.eu wrote:
On Thu, Apr 11, 2013 at 04:47:49PM +0200, Sebastian Hesselbarth wrote:
I tried todays net-next on top of 3.9-rc6 without any gro patch, with
the initial
patch (Soeren) and your proposed patch (Willy). The results show that
both
On Thu, Apr 11, 2013 at 5:32 PM, Willy Tarreau w...@1wt.eu wrote:
On Thu, Apr 11, 2013 at 05:27:03PM +0200, Sebastian Hesselbarth wrote:
I don't have a strong opinion on whether Soeren's or your proposal should
be submitted. But I insist on having one of them in, as GRO significantly
improves
On 04/11/2013 07:55 PM, Ben Hutchings wrote:
On Thu, 2013-04-11 at 14:40 +0200, Sebastian Hesselbarth wrote:
This patch adds GRO support to mv643xx_eth by making it invoke
napi_gro_receive instead of netif_receive_skb.
The inet_lro support should be removed at the same time; inet_lro is now
With recent support for GRO, there is no need to keep both LRO and
GRO. This patch therefore removes the deprecated inet_lro support
from mv643xx_eth. This is work is based on an experimental patch
provided by Eric Dumazet and Willy Tarreau.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba
On 04/11/2013 09:46 PM, Eric Dumazet wrote:
On Thu, 2013-04-11 at 21:11 +0200, Sebastian Hesselbarth wrote:
With recent support for GRO, there is no need to keep both LRO and
GRO. This patch therefore removes the deprecated inet_lro support
from mv643xx_eth. This is work is based
68 matches
Mail list logo
