[PATCH net-next 1/8] ibmvnic: Mark NAPI flag as disabled when released

2018-05-23 Thread Thomas Falcon
Set adapter NAPI state as disabled if they are removed. This will allow them to be enabled again if reallocated in case of a hard reset. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH net-next 0/8] ibmvnic: Failover hardening

2018-05-23 Thread Thomas Falcon
to an operational state. Thomas Falcon (8): ibmvnic: Mark NAPI flag as disabled when released ibmvnic: Introduce active CRQ state ibmvnic: Check CRQ command return codes ibmvnic: Return error code if init interrupted by transport event ibmvnic: Handle error case when setting link state

Re: [RFC v5 6/6] migration/memory: Update memory for assoc changes

2018-05-22 Thread Thomas Falcon
On 05/21/2018 12:52 PM, Michael Bringmann wrote: > migration/memory: This patch adds more recognition for changes to > the associativity of memory blocks described by the device-tree > properties and updates local and general kernel data structures to > reflect those changes. These differences

Re: [RFC v5 3/6] migration/dlpar: Add device readd queuing function

2018-05-22 Thread Thomas Falcon
On 05/21/2018 12:52 PM, Michael Bringmann wrote: > migration/dlpar: This patch adds function dlpar_readd_action() > which will queue a worker function to 'readd' a device in the > system. Such devices must be identified by a 'resource' type > and a drc_index to be readded. The function in the

[PATCH net] ibmvnic: Clean actual number of RX or TX pools

2018-04-20 Thread Thomas Falcon
Avoid using value stored in the login response buffer when cleaning TX and RX buffer pools since these could be inconsistent depending on the device state. Instead use the field in the driver's private data that tracks the number of active pools. Signed-off-by: Thomas Falcon <tl

Re: [PATCH] ibmvnic: Clear pending interrupt after device reset

2018-04-15 Thread Thomas Falcon
On 04/15/2018 07:55 PM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Sun, 15 Apr 2018 18:53:36 -0500 > >> Due to a firmware bug, the hypervisor can send an interrupt to a >> transmit or receive queue just prior to a partition migration,

[PATCH] ibmvnic: Clear pending interrupt after device reset

2018-04-15 Thread Thomas Falcon
o continue operation. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index f84a920.

Re: [PATCH] ibmvnic: Clear pending interrupt after device reset

2018-04-15 Thread Thomas Falcon
On 04/15/2018 06:27 PM, Thomas Falcon wrote: > Due to a firmware bug, the hypervisor can send an interrupt to a > transmit or receive queue just prior to a partition migration, not > allowing the device enough time to handle it and send an EOI. When > the partition migrates, the inter

Re: [PATCH net-next] ibmvnic: Potential NULL dereference in clean_one_tx_pool()

2018-03-23 Thread Thomas Falcon
On 03/23/2018 06:36 AM, Dan Carpenter wrote: > There is an && vs || typo here, which potentially leads to a NULL > dereference. Thanks for catching that! > > Fixes: e9e1e97884b7 ("ibmvnic: Update TX pool cleaning routine") > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH FEAT] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-01 Thread Thomas Falcon
information from the ibmvnic card. > > Co-Authored-By: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > --- Hi, you should include a Signed-off-by tag in the commit message. You should also include the branch the patch is meant for in the PATCH field. In this case, it would be n

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

2017-01-26 Thread Thomas Falcon
On 01/26/2017 12:28 PM, Stephen Hemminger wrote: > On Wed, 25 Jan 2017 15:02:19 -0600 > Thomas Falcon <tlfal...@linux.vnet.ibm.com> wrote: > >> static irqreturn_t ibmvnic_interrupt(int irq, void *instance) >> { >> struct ibmvnic_adapter *adapter = inst

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

2017-01-26 Thread Thomas Falcon
On 01/26/2017 11:56 AM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Thu, 26 Jan 2017 10:44:22 -0600 > >> On 01/25/2017 10:04 PM, David Miller wrote: >>> From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> >>> Date:

Re: [PATCH net 2/5] ibmvnic: Fix MTU settings

2017-01-26 Thread Thomas Falcon
On 01/25/2017 10:05 PM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Wed, 25 Jan 2017 15:02:20 -0600 > >> In the current driver, the MTU is set to the maximum value >> capable for the backing device. This patch sets the MTU to the >&

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

2017-01-26 Thread Thomas Falcon
On 01/25/2017 10:04 PM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Wed, 25 Jan 2017 15:02:19 -0600 > >> Move most interrupt handler processing into a tasklet, and >> introduce a delay after re-enabling interrupts to fix timing >&g

[PATCH net 5/5] ibmvnic: init completion struct before requesting long term mapped buffers

2017-01-25 Thread Thomas Falcon
t.ibm.com> Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index ec6c5fe..d1ffc61 100644 --- a/driver

[PATCH net 4/5] ibmvnic: Fix endian errors in error reporting output

2017-01-25 Thread Thomas Falcon
Error reports received from firmware were not being converted from big endian values, leading to bogus error codes reported on little endian systems. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 8 1 file changed, 4 insertions

[PATCH net 2/5] ibmvnic: Fix MTU settings

2017-01-25 Thread Thomas Falcon
values. Finally, it removes redundant min/max MTU assignments after device initialization. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethern

[PATCH net 3/5] ibmvnic: Fix endian error when requesting device capabilites

2017-01-25 Thread Thomas Falcon
-by: John Allen <jal...@linux.vnet.ibm.com> Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c i

[PATCH net 1/5] ibmvnic: harden interrupt handler

2017-01-25 Thread Thomas Falcon
Move most interrupt handler processing into a tasklet, and introduce a delay after re-enabling interrupts to fix timing issues encountered in hardware testing. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 21 +++-- d

Re: [PATCH] ibmveth: Add a proper check for the availability of the checksum features

2017-01-24 Thread Thomas Falcon
On 01/24/2017 12:28 AM, Thomas Huth wrote: > When using the ibmveth driver in a KVM/QEMU based VM, it currently > always prints out a scary error message like this when it is started: > > ibmveth 7103 (unregistered net_device): unable to change > checksum offload settings. 1 rc=-2

Re: [bug report] Driver for IBM System i/p VNIC protocol

2016-11-16 Thread Thomas Falcon
On 11/16/2016 06:25 AM, Dan Carpenter wrote: > Hello Thomas Falcon, > > The patch 032c5e82847a: "Driver for IBM System i/p VNIC protocol" > from Dec 21, 2015, leads to the following static checker warning: > > drivers/net/ethernet/ibm/ibmvnic.c:2957 error_le

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

2016-10-27 Thread Thomas Falcon
On 10/27/2016 10:26 AM, Eric Dumazet wrote: > On Wed, 2016-10-26 at 11:09 +1100, Jon Maxwell wrote: >> We recently encountered a bug where a few customers using ibmveth on the >> same LPAR hit an issue where a TCP session hung when large receive was >> enabled. Closer analysis revealed that the

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

2016-10-27 Thread Thomas Falcon
stomers tests. > > Signed-off-by: Jon Maxwell <jmaxwel...@gmail.com> Thanks, Jon. Acked-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > --- > drivers/net/ethernet/ibm/ibmveth.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/driv

[PATCH] ibmvnic: Handle backing device failover and reinitialization

2016-08-18 Thread Thomas Falcon
from the backing device before establishing a new connection. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 34 -- drivers/net/ethernet/ibm/ibmvnic.h | 2 ++ 2 files changed, 34 insertions(+), 2 del

Re: [PATCH v2 1/2] powerpc/pseries: Implemented indexed-count hotplug memory add

2016-07-19 Thread Thomas Falcon
On 07/18/2016 10:07 AM, Sahil Mehta wrote: > Indexed-count add for memory hotplug guarantees that a contiguous block > of lmbs beginning at a specified will be assigned (NOT > that lmbs will be added). Because of Qemu's per-DIMM memory > management, the addition of a contiguous block of memory

Re: [PATCH] ibmvnic: fix to use list_for_each_safe() when delete items

2016-06-21 Thread Thomas Falcon
On 06/20/2016 10:50 AM, Thomas Falcon wrote: > On 06/17/2016 09:53 PM, weiyj...@163.com wrote: >> From: Wei Yongjun <yongjun_...@trendmicro.com.cn> >> >> Since we will remove items off the list using list_del() we need >> to use a safe version of the

Re: [PATCH] ibmvnic: fix to use list_for_each_safe() when delete items

2016-06-20 Thread Thomas Falcon
>errors, list) { > dma_unmap_single(dev, error_buff->dma, >error_buff->len, >DMA_FROM_DEVICE); > Thanks! Acked-by: Thomas Falcon &l

[net-next PATCH 2/2 v4] ibmvnic: enable RX checksum offload

2016-04-01 Thread Thomas Falcon
Enable RX Checksum offload feature in the ibmvnic driver. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> Cc: John Allen <jal...@linux.vnet.ibm.com> --- v4: this patch included since it is enabled by the previous patch --- drivers/net/ethernet/ibm/ibmvnic.c | 4 1 fil

[net-next PATCH 1/2 v4] ibmvnic: map L2/L3/L4 header descriptors to firmware

2016-04-01 Thread Thomas Falcon
-mapped array of SCRQ descriptor elements to be sent to the VNIC server. These additions will help fully enable checksum offloading as well as other features as they are included later. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> Cc: John Allen <jal...@linux.vnet.ibm.com> -

[net-next PATCH v3] ibmvnic: map L2/L3/L4 header descriptors to firmware

2016-02-24 Thread Thomas Falcon
Allow the VNIC driver to provide descriptors containing L2/L3/L4 headers to firmware. This feature is needed for greater hardware compatibility and enablement of offloading technologies for some backing hardware. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- v2: Fixed typo

[net-next PATCH v2] ibmvnic: map L2/L3/L4 header descriptors to firmware

2016-02-24 Thread Thomas Falcon
From: root <r...@ltcalpine2-lp23.aus.stglabs.ibm.com> Allow the VNIC driver to provide descriptors containing L2/L3/L4 headers to firmware. This feature is needed for greater hardware compatibility and enablement of offloading technologies for some backing hardware. Signed-off-by: Thomas

[net-next PATCH] ibmvnic: map L2/L3/L4 header descriptors to firmware

2016-02-24 Thread Thomas Falcon
Allow the VNIC driver to provide descriptors containing L2/L3/L4 headers to firmware. This feature is needed for greater hardware compatibility and enablement of offloading technologies for some backing hardware. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drive

Re: [PATCH net-next v2] Driver for IBM System i/p VNIC protocol

2015-12-14 Thread Thomas Falcon
On 12/11/2015 06:53 PM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Tue, 8 Dec 2015 11:52:19 -0600 > >> +static long h_reg_sub_crq(unsigned long unit_address, unsigned long token, >> + unsigned long le

Re: [PATCH net-next] Driver for IBM System i/p VNIC protocol

2015-12-07 Thread Thomas Falcon
On 12/05/2015 09:25 PM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Fri, 4 Dec 2015 11:49:46 -0600 > >> +static int ibmvnic_buffs_per_pool = IBMVNIC_BUFFS_PER_POOL; >> +module_param(ibmvnic_buffs_per_pool, int, S_I

[PATCH net-next] ibmveth: add support for TSO6

2015-07-14 Thread Thomas Falcon
This patch adds support for a new method of signalling the firmware that TSO packets are being sent. The new method removes the need to alter the ip and tcp checksums and allows TSO6 support. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 145

[PATCH net-next v3 4/4] ibmveth: Add support for Large Receive Offload

2015-04-29 Thread Thomas Falcon
Enables receiving large packets from other LPARs. These packets have a -1 IP header checksum, so we must recalculate to have a valid checksum. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v3: -Removed code setting network

[PATCH net-next v3 1/4] ibmveth: change rx buffer default allocation for CMO

2015-04-29 Thread Thomas Falcon
This patch enables 64k rx buffer pools by default. If Cooperative Memory Overcommitment (CMO) is enabled, the number of 64k buffers is reduced to save memory. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c

[PATCH net-next v3 3/4] ibmveth: Add GRO support

2015-04-29 Thread Thomas Falcon
Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 25cfc26

[PATCH net-next v2 1/4] ibmveth: change rx buffer default allocation for CMO

2015-04-27 Thread Thomas Falcon
This patch enables 64k rx buffer pools by default. If Cooperative Memory Overcommitment (CMO) is enabled, the number of 64k buffers is reduced to save memory. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c

[PATCH net-next v2 2/4] ibmveth: Add support for TSO

2015-04-27 Thread Thomas Falcon
Add support for TSO. TSO is turned off by default and must be enabled and configured by the user. The driver version number is increased so that users can be sure that they are using ibmveth with TSO support. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal

[PATCH net-next v2 4/4] ibmveth: Add support for Large Receive Offload

2015-04-27 Thread Thomas Falcon
Enables receiving large packets from other LPARs. These packets have a -1 IP header checksum, so we must recalculate to have a valid checksum. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v2: -Included statistics that were

[PATCH net-next v2 3/4] ibmveth: Add GRO support

2015-04-27 Thread Thomas Falcon
Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 25cfc26

Re: [PATCHv2] ibmveth: Fix off-by-one error in ibmveth_change_mtu()

2015-04-22 Thread Thomas Falcon
. This is because there is a instead of an = in ibmveth_change_mtu(), which only permits an MTU which is strictly smaller than the buffer size, rather than allowing the buffer to be completely filled. This patch fixes the buglet. Thanks! Acked-by: Thomas Falcon tlfal...@linux.vnet.ibm.com

Re: [PATCH 4/5] ibmveth: Add support for Large Receive Offload

2015-04-21 Thread Thomas Falcon
On 04/14/2015 05:00 PM, Eric Dumazet wrote: On Tue, 2015-04-14 at 15:35 -0500, Thomas Falcon wrote: Enables receiving large packets from other LPARs. These packets have a -1 IP header checksum, so we must recalculate to have a valid checksum. Signed-off-by: Brian King brk

[PATCH 4/5] ibmveth: Add support for Large Receive Offload

2015-04-14 Thread Thomas Falcon
Enables receiving large packets from other LPARs. These packets have a -1 IP header checksum, so we must recalculate to have a valid checksum. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 15

[PATCH 2/5] ibmveth: Add support for TSO

2015-04-14 Thread Thomas Falcon
Add support for TSO. TSO is turned off by default and must be enabled and configured by the user. The driver version number is increased so that users can be sure that they are using ibmveth with TSO support. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal

[PATCH 3/5] ibmveth: Add GRO support

2015-04-14 Thread Thomas Falcon
Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 2911a57

[PATCH 1/5] ibmveth: change rx buffer default allocation for CMO

2015-04-14 Thread Thomas Falcon
This patch enables 64k rx buffer pools by default. If Cooperative Memory Overcommitment (CMO) is enabled, the number of 64k buffers is reduced to save memory. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c

[PATCH 5/5] ibmveth: Add ethtool statistics for tx and rx large packets

2015-04-14 Thread Thomas Falcon
This patch includes counters for transmitted and received large packets. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 4 drivers/net/ethernet/ibm/ibmveth.h | 2 ++ 2 files changed, 6 insertions

Re: [PATCHi v2] ibmveth: Add function to enable live MAC address changes

2015-03-02 Thread Thomas Falcon
On 02/28/2015 02:59 AM, Jiri Pirko wrote: Sat, Feb 28, 2015 at 06:56:04AM CET, tlfal...@linux.vnet.ibm.com wrote: Add a function that will enable changing the MAC address of an ibmveth interface while it is still running. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v2

[PATCH v3] ibmveth: Add function to enable live MAC address changes

2015-03-02 Thread Thomas Falcon
Add a function that will enable changing the MAC address of an ibmveth interface while it is still running. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v3: removed text wrapping in error message v2: If h_change_logical_lan_mac fails, dev-dev_addr will not be changed

[PATCHi v2] ibmveth: Add function to enable live MAC address changes

2015-02-27 Thread Thomas Falcon
Add a function that will enable changing the MAC address of an ibmveth interface while it is still running. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v2: If h_change_logical_lan_mac fails, dev-dev_addr will not be changed. drivers/net/ethernet/ibm/ibmveth.c | 25

[PATCH] ibmveth: Add function to enable live MAC address changes

2015-02-25 Thread Thomas Falcon
Add a function that will enable changing the MAC address of an ibmveth interface while it is still running. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git

[PATCH 0/3] pseries: Make CPU hotplug and hotremove endian safe

2014-09-16 Thread Thomas Falcon
This patchset ensures that cpu hotplugging and hotremoval are compatible with both big and little endian architectures. Bharata B Rao (1): pseries: Make CPU hotplug path endian safe Thomas Falcon (2): pseries: Fix endian issues in onlining cpu threads pseries: Fix endian issues in cpu

[PATCH v2 2/3] pseries: Fix endian issues in onlining cpu threads

2014-09-16 Thread Thomas Falcon
The ibm,ppc-interrupt-server#s property is in big endian format. These values need to be converted when used by little endian architectures. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- Changes in v2: Followed suggestions from Michael Ellerman conversion of intserv values

[PATCH v2 1/3] pseries: Make CPU hotplug path endian safe

2014-09-16 Thread Thomas Falcon
From: Bharata B Rao bhar...@linux.vnet.ibm.com - ibm,rtas-configure-connector should treat the RTAS data as big endian. - Treat ibm,ppc-interrupt-server#s as big-endian when setting smp_processor_id during hotplug. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com Signed-off-by: Thomas

[PATCH v3 3/3] pseries: Fix endian issues in cpu hot-removal

2014-09-16 Thread Thomas Falcon
When removing a cpu, this patch makes sure that values gotten from or passed to firmware are in the correct endian format. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- Changes in v3: drc_index in dlpar_cpu_release is no longer const to fix compilation error found by Bharata Rao

Re: [PATCH 2/2] pseries: Fix endian issues in cpu hot-removal

2014-09-12 Thread Thomas Falcon
On 09/12/2014 03:53 AM, Michael Ellerman wrote: On Wed, 2014-09-10 at 17:41 -0500, Thomas Falcon wrote: When removing a cpu, this patch makes sure that values gotten from or passed to firmware are in the correct endian format. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch

[PATCH v2 1/2] pseries: Fix endian issues in onlining cpu threads

2014-09-12 Thread Thomas Falcon
The ibm,ppc-interrupt-server#s property is in big endian format. These values need to be converted when used by little endian architectures. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- Changes in v2: Followed suggestions from Michael Ellerman conversion of intserv values

[PATCH v2 2/2] pseries: Fix endian issues in cpu hot-removal

2014-09-12 Thread Thomas Falcon
When removing a cpu, this patch makes sure that values gotten from or passed to firmware are in the correct endian format. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- Changes in v2: Followed suggestions from Michael Ellerman: Conversion of intserv to cpu endian occurs once

[PATCH 2/2] pseries: Fix endian issues in cpu hot-removal

2014-09-10 Thread Thomas Falcon
When removing a cpu, this patch makes sure that values gotten from or passed to firmware are in the correct endian format. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 14 +++--- arch/powerpc/platforms/pseries/hotplug-cpu.c

[PATCH 1/2] pseries: Fix endian issues in onlining cpu threads

2014-09-10 Thread Thomas Falcon
The ibm,ppc-interrupt-server#s property is in big endian format. These values need to be converted when used by little endian architectures. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH] pseries: Fix endianness in cpu hotplug and hotremove

2014-09-08 Thread Thomas Falcon
02:09 PM, Thomas Falcon wrote: This patch attempts to ensure that all values are in the proper endianness format when both hotadding and hotremoving cpus. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 56

[PATCH] pseries: Fix endianness in cpu hotplug and hotremove

2014-09-05 Thread Thomas Falcon
This patch attempts to ensure that all values are in the proper endianness format when both hotadding and hotremoving cpus. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 56 ++-- arch/powerpc/platforms/pseries

[PATCH] powerpc/pseries: Fix endian issues in memory hotplug

2014-08-19 Thread Thomas Falcon
Values acquired from Open Firmware are in 32-bit big endian format and need to be handled on little endian architectures. This patch ensures values are in cpu endian when hotplugging memory. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/hotplug

[PATCH] powerpc/pseries/hvcserver: Fix endian issue in hvcs_get_partner_info

2014-08-05 Thread Thomas Falcon
A buffer returned by H_VTERM_PARTNER_INFO contains device information in big endian format, causing problems for little endian architectures. This patch ensures that they are in cpu endian. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/hvcserver.c

Re: [PATCH] powerpc: fixing endianness of flash_block_list in rtas_flash

2014-08-01 Thread Thomas Falcon
On 08/01/2014 04:32 AM, Vasant Hegde wrote: On 07/25/2014 11:17 PM, Thomas Falcon wrote: The function rtas_flash_firmware passes the address of a data structure, flash_block_list, when making the update-flash-64-and-reboot rtas call. While the endianness of the address is handled correctly

[PATCH] powerpc: fixing endianness of flash_block_list in rtas_flash

2014-07-25 Thread Thomas Falcon
endian when passed to rtas on little endian hosts. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/kernel/rtas_flash.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c index

<    1   2