Re: tqm5200s phy link toggles between up and down

2012-12-18 Thread Wolfgang Grandegger
On 12/18/2012 10:57 AM, Wolfgang Grandegger wrote: On 12/18/2012 10:44 AM, Johannes Braun wrote: Hello, I hope someone could help me with my problem. Currently I am porting a new kernel (3.3.8) for a tqm5200s based board. This is not really a new kernel. The previous kernel was 2.6.23

Re: tqm5200s phy link toggles between up and down

2012-12-18 Thread Wolfgang Grandegger
On 12/18/2012 10:44 AM, Johannes Braun wrote: Hello, I hope someone could help me with my problem. Currently I am porting a new kernel (3.3.8) for a tqm5200s based board. This is not really a new kernel. The previous kernel was 2.6.23. The new kernel version is needed because of support

Re: [PATCH net-next v6 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-12-07 Thread Wolfgang Grandegger
On 12/07/2011 08:34 AM, Benjamin Herrenschmidt wrote: On Thu, 2011-12-01 at 10:41 +0100, Wolfgang Grandegger wrote: This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. I'm a bit confused by the net-next prefix here. Those patches

[PATCH net-next v6 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-12-01 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala ga...@kernel.crashing.org Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- arch/powerpc

[PATCH net-next v6 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-12-01 Thread Wolfgang Grandegger
/cc770/cc770_platform.c new file mode 100644 index 000..53115ee --- /dev/null +++ b/drivers/net/can/cc770/cc770_platform.c @@ -0,0 +1,272 @@ +/* + * Driver for CC770 and AN82527 CAN controllers on the platform bus + * + * Copyright (C) 2009, 2011 Wolfgang Grandegger w...@grandegger.com

[PATCH net-next v5 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-30 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala ga...@kernel.crashing.org Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- arch/powerpc

[PATCH net-next v5 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-30 Thread Wolfgang Grandegger
/can/cc770/cc770_platform.c new file mode 100644 index 000..fb87b22 --- /dev/null +++ b/drivers/net/can/cc770/cc770_platform.c @@ -0,0 +1,273 @@ +/* + * Driver for CC770 and AN82527 CAN controllers on the platform bus + * + * Copyright (C) 2009, 2011 Wolfgang Grandegger w...@grandegger.com

[PATCH net-next v5 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-30 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala ga...@kernel.crashing.org Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- arch/powerpc

[PATCH net-next v5 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-30 Thread Wolfgang Grandegger
/can/cc770/cc770_platform.c new file mode 100644 index 000..fb87b22 --- /dev/null +++ b/drivers/net/can/cc770/cc770_platform.c @@ -0,0 +1,273 @@ +/* + * Driver for CC770 and AN82527 CAN controllers on the platform bus + * + * Copyright (C) 2009, 2011 Wolfgang Grandegger w...@grandegger.com

[PATCH net-next v4 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-29 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala ga...@kernel.crashing.org Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- arch/powerpc

[PATCH net-next v4 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-29 Thread Wolfgang Grandegger
/can/cc770/cc770_platform.c new file mode 100644 index 000..fb87b22 --- /dev/null +++ b/drivers/net/can/cc770/cc770_platform.c @@ -0,0 +1,273 @@ +/* + * Driver for CC770 and AN82527 CAN controllers on the platform bus + * + * Copyright (C) 2009, 2011 Wolfgang Grandegger w...@grandegger.com

[PATCH net-next v3 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-28 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala ga...@kernel.crashing.org Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- arch/powerpc

[PATCH net-next v3 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-28 Thread Wolfgang Grandegger
index 000..65e177e --- /dev/null +++ b/drivers/net/can/cc770/cc770_platform.c @@ -0,0 +1,280 @@ +/* + * Driver for CC770 and AN82527 CAN controllers on the platform bus + * + * Copyright (C) 2009, 2011 Wolfgang Grandegger w...@grandegger.com + * + * This program is free software; you can

[PATCH net-next v2 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-25 Thread Wolfgang Grandegger
index 000..a33f91d --- /dev/null +++ b/drivers/net/can/cc770/cc770_platform.c @@ -0,0 +1,289 @@ +/* + * Driver for CC770 and AN82527 CAN controllers on the platform bus + * + * Copyright (C) 2009, 2011 Wolfgang Grandegger w...@grandegger.com + * + * This program is free software; you can

[PATCH net-next v2 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-25 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala ga...@kernel.crashing.org Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- arch/powerpc

[PATCH net-next] ibm/emac: fix improper cleanup when device is removed to allow re-bind

2011-11-17 Thread Wolfgang Grandegger
The re-binding (unbind..bind) of an EMAC device fails because the static variable busy_phy_map is not updated when the device is removed. Signed-off-by: Wolfgang Grandegger w...@denx.de --- drivers/net/ethernet/ibm/emac/core.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff

Re: [PATCH v13 0/6] flexcan: Add support for powerpc flexcan (freescale p1010)

2011-10-18 Thread Wolfgang Grandegger
Hi Kumar, On 10/18/2011 07:44 AM, Kumar Gala wrote: On Aug 16, 2011, at 10:32 PM, Robin Holt wrote: David, The following set of patches have been reviewed by the above parties and all comments have been integrated. Although the patches stray from the drivers/net/can directory, the

Re: [PATCH v12 5/6] flexcan: Prefer device tree clock frequency if available.

2011-08-12 Thread Wolfgang Grandegger
-by: Robin Holt h...@sgi.com To: Kumar Gala ga...@kernel.crashing.org To: Wolfgang Grandegger w...@grandegger.com, To: Marc Kleine-Budde m...@pengutronix.de, To: U Bhaskar-B22300 b22...@freescale.com To: Scott Wood scottw...@freescale.com To: Grant Likely grant.lik...@secretlab.ca Cc

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-11 Thread Wolfgang Grandegger
On 08/11/2011 06:46 AM, Kumar Gala wrote: On Aug 10, 2011, at 1:16 PM, Wolfgang Grandegger wrote: On 08/10/2011 07:01 PM, Kumar Gala wrote: On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: I added a simple clock source for the p1010rdb so the flexcan driver could determine a clock

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-11 Thread Wolfgang Grandegger
On 08/11/2011 05:56 AM, Robin Holt wrote: On Wed, Aug 10, 2011 at 08:16:33PM +0200, Wolfgang Grandegger wrote: On 08/10/2011 07:01 PM, Kumar Gala wrote: On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: I added a simple clock source for the p1010rdb so the flexcan driver could determine

Re: [PATCH v11 6/6] powerpc: Add flexcan device support for p1010rdb.

2011-08-11 Thread Wolfgang Grandegger
On 08/11/2011 06:07 PM, Robin Holt wrote: Allow the p1010 processor to select the flexcan network driver. Signed-off-by: Robin Holt h...@sgi.com Acked-by: Marc Kleine-Budde m...@pengutronix.de, Acked-by: Wolfgang Grandegger w...@grandegger.com, Cc: U Bhaskar-B22300 b22...@freescale.com Cc

Re: [PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available.

2011-08-11 Thread Wolfgang Grandegger
-by: Robin Holt h...@sgi.com To: Kumar Gala ga...@kernel.crashing.org To: Wolfgang Grandegger w...@grandegger.com, To: Marc Kleine-Budde m...@pengutronix.de, To: U Bhaskar-B22300 b22...@freescale.com To: Scott Wood scottw...@freescale.com To: Grant Likely grant.lik...@secretlab.ca Cc

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Wolfgang Grandegger
on. than the required properties so we are removing the file. Additionally, the p1010*dts* files are not following the standard for node naming in that they have a trailing -v1.0. Signed-off-by: Robin Holt h...@sgi.com To: Marc Kleine-Budde m...@pengutronix.de, To: Wolfgang Grandegger w

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Wolfgang Grandegger
On 08/10/2011 04:15 PM, Robin Holt wrote: On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: ... Done, except the compatible = fsl,p1010-flexcan, fsl,flexcan; line is compatible = fsl,flexcan, fsl,flexcan-p1010; IIRC, there order is more to less specific

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-10 Thread Wolfgang Grandegger
-off-by: Robin Holt h...@sgi.com Acked-by: Marc Kleine-Budde m...@pengutronix.de, Acked-by: Wolfgang Grandegger w...@grandegger.com, Cc: U Bhaskar-B22300 b22...@freescale.com Cc: socketcan-c...@lists.berlios.de, Cc: net...@vger.kernel.org, Cc: PPC list linuxppc-dev@lists.ozlabs.org Cc: Kumar

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Wolfgang Grandegger
On 08/10/2011 06:00 PM, Robin Holt wrote: On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: ... It looks like the way to do that is to assign a label to those devices and then associate the label with an alias. I have no idea how that works under the hood, but it is the way

Re: [RFC 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Wolfgang Grandegger
nfsl_get_sys_freq() et-next-2.6 v2] would be perfect. I added a clock source for the p1010rdb so the flexcan driver could find its clock frequency. Signed-off-by: Robin Holt h...@sgi.com To: Marc Kleine-Budde m...@pengutronix.de, To: Wolfgang Grandegger w...@grandegger.com, To: U Bhaskar-B22300 b22

Re: [PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Wolfgang Grandegger
Kleine-Budde m...@pengutronix.de, To: Wolfgang Grandegger w...@grandegger.com, To: U Bhaskar-B22300 b22...@freescale.com Cc: socketcan-c...@lists.berlios.de, Cc: net...@vger.kernel.org, Cc: PPC list linuxppc-dev@lists.ozlabs.org --- arch/powerpc/platforms/85xx/Kconfig|2 + arch/powerpc

Re: [PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Wolfgang Grandegger
On 08/09/2011 04:55 PM, Robin Holt wrote: On Tue, Aug 09, 2011 at 02:45:58PM +, U Bhaskar-B22300 wrote: Hi Robin, Where are you doing the irq handling ie request_irq() for the powerpc based P1010. Or the existing code of ARM based FlexCAN will work for P1010 ?? It appears

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-09 Thread Wolfgang Grandegger
On 08/09/2011 08:17 PM, Scott Wood wrote: On 08/09/2011 09:43 AM, Robin Holt wrote: In working with the socketcan developers, we have come to the conclusion the fsl-flexcan device tree bindings need to be cleaned up. The driver does not depend upon any properties other than the required

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-09 Thread Wolfgang Grandegger
standard for node naming? There's nothing wrong with putting a For the answer to that, you will need to ask Wolfgang Grandegger. I was working from his feedback. Looking at the plethora of other node names, the vast majority do not have any -v#.#, and the ones that do also tend to have multiple

Re: [RFC 4/4] [powerpc] Implement a p1010rdb clock source.

2011-08-08 Thread Wolfgang Grandegger
, clk_get_rate, etc functions to work. This patch provides the minimum functionality. This patch has to go via the powerpc git tree. Added linuxppc-dev@lists.ozlabs.org on CC. Signed-off-by: Robin Holt h...@sgi.com To: Marc Kleine-Budde m...@pengutronix.de To: Wolfgang Grandegger w...@grandegger.com

Re: GPIO IRQ on P1022

2011-07-31 Thread Wolfgang Grandegger
On 07/31/2011 12:38 PM, Felix Radensky wrote: Hi, I'm running kernel 3.0 on a custom board based on Freescale P1022. The interrupt line of on-board FPGA is connected to GPIO2_9. FPGA IRQ is level, active low. The GPIOs are mapped like this: GPIOs 160-191,

Re: GPIO IRQ on P1022

2011-07-31 Thread Wolfgang Grandegger
Hi Felix, On 07/31/2011 05:51 PM, Felix Radensky wrote: Hi Wolfgang, On 07/31/2011 06:19 PM, Wolfgang Grandegger wrote: On 07/31/2011 12:38 PM, Felix Radensky wrote: Hi, I'm running kernel 3.0 on a custom board based on Freescale P1022. The interrupt line of on-board FPGA is connected

Re: [PATCH][upstream] powerpc: Adding bindings for flexcan controller

2011-06-26 Thread Wolfgang Grandegger
On 04/19/2011 03:58 PM, Bhaskar Upadhaya wrote: From: Bhaskar Upadhaya bhaskar.upadh...@freescale.com Signed-off-by: Bhaskar Upadhaya bhaskar.upadh...@freescale.com Acked-By: Scott Wood scottw...@freescale.com --- Based upon

High process latencies due to MPC5200 FEC hard- soft-irq processing

2010-07-13 Thread Wolfgang Grandegger
Hello, we realized, that multiple ping floods (ping -f) can cause very large high-priority process latencies (up to a many seconds) on a MPC5200 PowerPC system with FEC NAPI support. The latencies are measured with # cyclictest -p 80 -n The problem is that processing of the ICMP pakets in the

Re: CAN Subsystem and MPC52xx onboard controller

2010-06-10 Thread Wolfgang Grandegger
On 06/10/2010 10:41 AM, Roman Fietze wrote: Hello List Members, I have tried multiple versions/branches and git repos (torvalds, benh/{next,master}, denx, pengutronix, ...) to get a 2.6.34 or HEAD version of that repos that compiles w/o errors when the CAN subsystem is enabled and the

Re: CAN Subsystem and MPC52xx onboard controller

2010-06-10 Thread Wolfgang Grandegger
On 06/10/2010 11:29 AM, Roman Fietze wrote: Hello Wolfram, On Thursday 10 June 2010 10:59:23 Wolfram Sang wrote: The mainline kernel works fine here with Phytec based MPC5xxx-boards. Reading your answer made me hope again, and I just pulled the newest HEAD from the mainline kernel and

Re: [PATCH v3 1/3] ptp: Added a brand new class driver for ptp clocks.

2010-05-17 Thread Wolfgang Grandegger
device with ioctls that allow tuning of the PTP clock. Signed-off-by: Richard Cochran richard.coch...@omicron.at Tested-by: Wolfgang Grandegger w...@denx.de on my Freescale MPC8313 setup with ptpd and ptpv2d. Wolfgang. ___ Linuxppc-dev mailing list

Re: [PATCH v3 3/3] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2010-05-17 Thread Wolfgang Grandegger
-by: Wolfgang Grandegger w...@denx.de on my Freescale MPC8313 setup with ptpd and ptpv2d. FYI: checkplatch.pl reports various errors for this patch series. Wolfgang. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo

Re: MPC5200B, many FEC_IEVENT_RFIFO_ERRORs until link down

2010-04-05 Thread Wolfgang Grandegger
Hallo Roman, Roman Fietze wrote: Hallo Wolfgang, On Wednesday 31 March 2010 12:15:47 Wolfgang Grandegger wrote: I just sent out the patch. Thanks a lot. Would be nice if you, or somebody else, could do some testing and provide some feedback. I tested the patches

[RFC-PATCH] fec_mpc52xx: add NAPI support

2010-03-31 Thread Wolfgang Grandegger
the packets can not be digested (processed) by the system at that rate anyhow. NAPI can be enabled via Kconfig parameter CONFIG_FEC_MPC52xx_NAPI. Throughput measurements with netperf showed almost the same results with and without NAPI. Signed-off-by: Wolfgang Grandegger w...@denx.de --- drivers/net

Re: MPC5200B, many FEC_IEVENT_RFIFO_ERRORs until link down

2010-03-31 Thread Wolfgang Grandegger
Hi Roman, Wolfgang Grandegger wrote: Roman Fietze wrote: Hello, I think this is a never ending story. This error still happens under higher load every few seconds, until I get a PHY: f0003000:00 - Link is Down, on my box easiliy reproducable after maybe 15 to 30 seconds. I can recover

Re: MPC5200B, many FEC_IEVENT_RFIFO_ERRORs until link down

2010-03-30 Thread Wolfgang Grandegger
Roman Fietze wrote: Hello, I think this is a never ending story. This error still happens under higher load every few seconds, until I get a PHY: f0003000:00 - Link is Down, on my box easiliy reproducable after maybe 15 to 30 seconds. I can recover using ip link set down/up dev eth0. I

Re: Linux patches for XIP on MPC8xx?

2010-03-23 Thread Wolfgang Grandegger
Németh Márton wrote: Hi Wolfgang, I found your homepage at http://www.denx.de/wiki/bin/view/DULG/ConfigureLinuxForXIP back from 2003. Was there any follow up of your patch for kernel 2.4.4? Not that I remember. Wolfgang. ___ Linuxppc-dev mailing

[PATCH v8 0/4] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-02-17 Thread Wolfgang Grandegger
as suggested by Stephen Rothwell. Changes since v7: - fix non-bisectable patch 1 as pointed out by Grant Likely. Wolfgang Wolfgang Grandegger (4): i2c-mpc: use __devinit[data] for initialization functions and data i2c-mpc: rename setclock initialization functions to setup i2c-mpc: add

[PATCH v8 1/4] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-17 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger w...@denx.de Tested

[PATCH v8 2/4] i2c-mpc: rename setclock initialization functions to setup

2010-02-17 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de To prepare support for the MPC512x processors from Freescale the setclock initialization functions have been renamed to setup because I2C interrupts must be enabled for the MPC512x by this function as well. Signed-off-by: Wolfgang Grandegger w...@denx.de

[PATCH v8 4/4] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-02-17 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds the MPC5121 to the list of supported devices, enhances the doc of the clock-frequency property and removes the obsolete cell-index, device_type and fsl-i2c property. Furthermore an example for the MPC5121 has been added. Signed-off

[PATCH v8 3/4] i2c-mpc: add support for the MPC512x processors from Freescale

2010-02-17 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de As I2C interrupts must be enabled for the MPC512x by the setup function as well, fsl,preserve-clocking is handled in a slighly different way. Also, the old settings are now reported calling dev_dbg(). For the MPC512x the clock setup function of the MPC52xx

Re: [PATCH v7 1/4] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-16 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, Feb 10, 2010 at 7:55 AM, Wolfgang Grandegger w...@grandegger.com wrote: From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-02-10 Thread Wolfgang Grandegger
Hi David, David Miller wrote: From: Anatolij Gustschin ag...@denx.de Date: Tue, 9 Feb 2010 15:23:17 +0100 In my understanding, in the ESP scsi driver the set of defines for the register offsets is common for all chip drivers. The chip driver methods for register access translate the

[PATCH v6 4/4] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds the MPC5121 to the list of supported devices, enhances the doc of the clock-frequency property and removes the obsolete cell-index, device_type and fsl-i2c property. Furthermore an example for the MPC5121 has been added. Signed-off

[PATCH v6 2/4] i2c-mpc: rename setclock initialization functions to setup

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de To prepare support for the MPC512x processors from Freescale the setclock initialization functions have been renamed to setup because I2C interrupts must be enabled for the MPC512x by this function as well. Signed-off-by: Wolfgang Grandegger w...@denx.de

[PATCH v6 1/4] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger w...@denx.de Tested

[PATCH v6 3/4] i2c-mpc: add support for the MPC512x processors from Freescale

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de As I2C interrupts must be enabled for the MPC512x by the setup function as well, fsl,preserve-clocking is handled in a slighly different way. Also, the old settings are now reported calling dev_dbg(). For the MPC512x the clock setup function of the MPC52xx

[PATCH v6 0/4] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
Grant Likely wrote: On Thu, Jan 28, 2010 at 6:25 AM, Wolfgang Grandegger w...@grandegger.com wrote: From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-02-10 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: Hi David, David Miller wrote: From: Anatolij Gustschin ag...@denx.de Date: Tue, 9 Feb 2010 15:23:17 +0100 In my understanding, in the ESP scsi driver the set of defines for the register offsets is common for all chip drivers. The chip driver methods

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
Stephen Rothwell wrote: Hi Wolfgang, On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger w...@grandegger.com wrote: __devinitdata goes at the end, immediately before the '='. Ditto throughout the file. This made a difference and revealed section mismatches. const seems

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, Feb 10, 2010 at 3:53 AM, Wolfgang Grandegger w...@grandegger.com wrote: Stephen Rothwell wrote: Hi Wolfgang, On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger w...@grandegger.com wrote: __devinitdata goes at the end, immediately before the '='. Ditto

[PATCH v7 2/4] i2c-mpc: rename setclock initialization functions to setup

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de To prepare support for the MPC512x processors from Freescale the setclock initialization functions have been renamed to setup because I2C interrupts must be enabled for the MPC512x by this function as well. Signed-off-by: Wolfgang Grandegger w...@denx.de

[PATCH v7 0/4] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board

[PATCH v7 3/4] i2c-mpc: add support for the MPC512x processors from Freescale

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de As I2C interrupts must be enabled for the MPC512x by the setup function as well, fsl,preserve-clocking is handled in a slighly different way. Also, the old settings are now reported calling dev_dbg(). For the MPC512x the clock setup function of the MPC52xx

[PATCH v7 1/4] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger w...@denx.de Tested

[PATCH v7 4/4] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds the MPC5121 to the list of supported devices, enhances the doc of the clock-frequency property and removes the obsolete cell-index, device_type and fsl-i2c property. Furthermore an example for the MPC5121 has been added. Signed-off

Re: [PATCH v4 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-02-09 Thread Wolfgang Grandegger
Hi Grant, Grant Likely wrote: On Thu, Jan 28, 2010 at 6:25 AM, Wolfgang Grandegger w...@grandegger.com wrote: From: Wolfgang Grandegger w...@denx.de This patch adds the MPC5121 to the list of supported devices, enhances the doc of the clock-frequency property and removes the obsolete cell

Re: [PATCH v4 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-02-09 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: Hi Grant, Grant Likely wrote: On Thu, Jan 28, 2010 at 6:25 AM, Wolfgang Grandegger w...@grandegger.com wrote: From: Wolfgang Grandegger w...@denx.de This patch adds the MPC5121 to the list of supported devices, enhances the doc of the clock-frequency property

[PATCH v5 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-31 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger w...@denx.de Tested

[PATCH v5 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-31 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The setclock initialization functions have been renamed to setup because I2C interrupts must be enabled for the MPC512x. This requires to handle fsl,preserve-clocking in a slighly different way. Also, the old settings are now reported calling dev_dbg

[PATCH v4 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-28 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds the MPC5121 to the list of supported devices, enhances the doc of the clock-frequency property and removes the obsolete cell-index property from the example nodes. Furthermore and example for the MPC5121 has been added. Signed-off

[PATCH v4 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-28 Thread Wolfgang Grandegger
: - switch back to __devinit[data] as pointed out by Ben. Wolfgang Wolfgang Grandegger (3): i2c-mpc: use __devinit[data] for initialization functions and data i2c-mpc: add support for the MPC512x processors from Freescale powerpc: doc/dts-bindings: update doc of FSL I2C bindings Documentation

[PATCH v4 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-28 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The setclock initialization functions have been renamed to setup because I2C interrupts must be enabled for the MPC512x. This requires to handle fsl,preserve-clocking in a slighly different way. Also, the old settings are now reported calling dev_dbg

[PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-28 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger w...@denx.de

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-27 Thread Wolfgang Grandegger
Arnd Bergmann wrote: On Sunday 24 January 2010, Wolfgang Denk wrote: In message 4b5c5bdf.6020...@grandegger.com you wrote: You are probably right and your proposal would likely result in more transparent (less ugly) code. There has been some discussion about unifying FEC drivers when the

Re: [PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-26 Thread Wolfgang Grandegger
Ben Dooks wrote: On Mon, Jan 25, 2010 at 09:55:04PM +0100, Wolfgang Grandegger wrote: From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-26 Thread Wolfgang Grandegger
Ben Dooks wrote: On Mon, Jan 25, 2010 at 04:15:09PM +0100, Wolfram Sang wrote: -static void __devinit mpc_i2c_setclock_52xx(struct device_node *node, - struct mpc_i2c *i2c, - u32 clock, u32 prescaler) +static void

[PATCH v3 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-26 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board

[PATCH v3 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-26 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds the MPC5121 to the list of supported devices, enhances the doc of the clock-frequency property and removes the obsolete cell-index property from the example nodes. Furthermore and example for the MPC5121 has been added. Signed-off

[PATCH v3 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-26 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The setclock initialization functions have been renamed to setup because I2C interrupts must be enabled for the MPC512x. This requires to handle fsl,preserve-clocking in a slighly different way. Also, the old settings are now reported calling dev_dbg

[PATCH v3 1/3] i2c-mpc: use __init[data] for initialization functions and data

2010-01-26 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de __devinit[data] has been renamed to __init[data] as this is not a hotplugable device. Futhermore, all initialization functions and data are now marked properly. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which

[PATCH 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-25 Thread Wolfgang Grandegger
This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board Wolfgang Wolfgang Grandegger (3

[PATCH 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger w...@denx.de

[PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The setclock initialization functions have been renamed to setup because I2C interrupts must be enabled for the MPC512x. This requires to handle fsl,preserve-clocking in a slighly different way. Also, the old settings are now reported calling dev_dbg

[PATCH 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds the MPC5121 to the list of supported devices, enhances the doc of the clock-frequency property and removes the obsolete cell-index property from the example nodes. Signed-off-by: Wolfgang Grandegger w...@denx.de --- Documentation/powerpc

Re: [PATCH 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-25 Thread Wolfgang Grandegger
Wolfram Sang wrote: On Mon, Jan 25, 2010 at 09:27:09AM +0100, Wolfgang Grandegger wrote: From: Wolfgang Grandegger w...@denx.de This patch adds the MPC5121 to the list of supported devices, enhances the doc of the clock-frequency property and removes the obsolete cell-index property from

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
Hi Wolfram, Wolfram Sang wrote: Hi Wolfgang, On Mon, Jan 25, 2010 at 09:27:08AM +0100, Wolfgang Grandegger wrote: From: Wolfgang Grandegger w...@denx.de The setclock initialization functions have been renamed to setup because I2C interrupts must be enabled for the MPC512x. This requires

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
Wolfram Sang wrote: -static void __devinit mpc_i2c_setclock_52xx(struct device_node *node, - struct mpc_i2c *i2c, - u32 clock, u32 prescaler) +static void __devinit mpc_i2c_setup_52xx(struct device_node *node, +

[PATCH v2 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board

[PATCH v2 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds the MPC5121 to the list of supported devices, enhances the doc of the clock-frequency property and removes the obsolete cell-index property from the example nodes. Furthermore and example for the MPC5121 has been added. Signed-off

[PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger w...@denx.de

[PATCH v2 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The setclock initialization functions have been renamed to setup because I2C interrupts must be enabled for the MPC512x. This requires to handle fsl,preserve-clocking in a slighly different way. Also, the old settings are now reported calling dev_dbg

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
Wolfram Sang wrote: overkill to me. I will have a closer look, though. At a minimum I will replace -1 with MPC_I2C_PRESERVE_CLOCK. Might be also an idea to define it with ~0 (clock is still unsigned). If possible, the code checking for those two cases (0 and -1) should be close together.

Re: [PATCH/RFC 2/2] 5200: improve i2c bus error recovery

2010-01-25 Thread Wolfgang Grandegger
Albrecht Dreß wrote: Am 25.01.10 08:55 schrieb(en) Wolfgang Grandegger: Albrecht Dreß wrote: Make the I2C adapter timeout configurable through a Device Tree property which gives the timeout in microseconds. My understanding is that software properties should not be defined via the device

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-24 Thread Wolfgang Grandegger
Arnd Bergmann wrote: On Thursday 21 January 2010, Wolfgang Grandegger wrote: The major problem that Anatolij tries to solve are the different register layouts of the supported SOCs, MPC52xx and MPC8xx. They use the same registers but at different offsets. Therefore we cannot handle

Re: [PATCH/RFC 2/2] 5200: improve i2c bus error recovery

2010-01-24 Thread Wolfgang Grandegger
Albrecht Dreß wrote: Make the I2C adapter timeout configurable through a Device Tree property which gives the timeout in microseconds. My understanding is that software properties should not be defined via the device tree. I think a sysfs entry is more appropriate. Wolfgang.

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-22 Thread Wolfgang Grandegger
David Miller wrote: From: Wolfgang Grandegger w...@grandegger.com Date: Thu, 21 Jan 2010 16:25:38 +0100 Do you see a more clever solution to this problem? See how we handle this in the ESP scsi driver. We have a set of defines for the register offsets, and a set of methods a chip driver

Re: [PATCH 04/11] i2c-mpc: Add MPC5121 I2C bus support

2010-01-22 Thread Wolfgang Grandegger
Grant Likely wrote: On Tue, Jan 19, 2010 at 1:24 PM, Anatolij Gustschin ag...@denx.de wrote: From: Piotr Ziecik ko...@semihalf.com - Update Kconfig for i2c-mpc driver. - Enable I2C interrupts on MPC5121. diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-21 Thread Wolfgang Grandegger
David Miller wrote: From: Anatolij Gustschin ag...@denx.de Date: Thu, 21 Jan 2010 03:13:18 +0100 struct fec_info { -fec_t __iomem *fecp; +void __iomem *fecp; To avoid confusion, the name base_addr seems more appropriate as it's just used to calculate register offsets and for

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-21 Thread Wolfgang Grandegger
Hi Anatolij, I had a close look... Anatolij Gustschin wrote: drivers/net/fs_enet/* Enable fs_enet driver to work 5121 FEC Enable it with CONFIG_FS_ENET_MPC5121_FEC Signed-off-by: John Rigby jcri...@gmail.com Signed-off-by: Piotr Ziecik ko...@semihalf.com

  1   2   3   4   >