> Every idea or tip is apreciated.
Please post your dts.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signat
On Sat, Mar 12, 2011 at 05:44:10PM +0100, Wolfram Sang wrote:
> dtc was moved and .gitignores have been added to the new location. So, we can
> delete the old, forgotten ones.
>
> Signed-off-by: Wolfram Sang
> Cc: Benjamin Herrenschmidt
Ping. Is this one more for Ben or
> As this board is tqm5200 based, added necessary changes
> to the tqm5200_defconfig. In previous patchserie I added
> the changes to mpc5200_defconfig, as Wolfram Sang mentioned,
> but as tqm5200_defconfig is in mainline, and the board is
> tqm5200 based, I t
On Tue, Mar 22, 2011 at 09:27:27AM +0100, Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher
> Acked-by: Benjamin Herrenschmidt
> cc: Wolfram Sang
> cc: Grant Likely
> cc: Benjamin Herrenschmidt
> cc: linux-fb...@vger.kernel.org
> cc: devicetree-disc...@ozlabs.org
On Fri, Mar 18, 2011 at 01:56:41PM +0100, Wolfram Sang wrote:
> On Thu, Mar 17, 2011 at 02:33:47AM +0300, Vladimir Ermakov wrote:
> > Adds PSC UART support for MPC5125 SoC.
>
> Please resend the patches and make use of scripts/get_maintainer.pl
I guess you noticed by now, just to
lso read
Documentation/SubmittingPatches.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital s
USB1_CLK,
> + IOCTL_USB1_NEXT, IOCTL_USB1_DIR
> + };
> + u8 mode;
> +
> + mode = (isusb) ? IOCTL_DEFAULT_MODE : IOCTL_FEC2_MODE;
> + for (i = 0; i < ARRAY_SIZE(offset); i++)
> + out_8(ioctl + offset[i], mode);
> +}
Same question here an
c";
else if of_find_compatible_node(startpoint, NULL, "fsl,mpc5125-psc")
psc_compat = "fsl,mpc5125-psc";
else if
/* Problem handling */
Dunno, might be worth to put it into a function as it could be used
dtc was moved and .gitignores have been added to the new location. So, we can
delete the old, forgotten ones.
Signed-off-by: Wolfram Sang
Cc: Benjamin Herrenschmidt
---
arch/powerpc/boot/.gitignore |1 -
arch/powerpc/boot/dtc-src/.gitignore |3 ---
2 files changed, 0 insertions
ustified. This
is why it is important to understand the differences of the chip as a
first step. (I have the feeling, that modifying is the way to go here,
though).
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solut
On Tue, Mar 08, 2011 at 04:55:31PM -0800, Andrew Morton wrote:
> On Thu, 3 Mar 2011 10:22:39 +0100
> Wolfram Sang wrote:
>
> > Hi,
> >
> > > +/*
> > > + * This file provides Date & Time support (no alarms) for PT7C4338 chip.
> > > + *
>
r-set looks
identical to me?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
described this behaviour nicely here:
http://www.spinics.net/lists/linux-serial/msg02136.html
From that point of view, FTDI is not to blame.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
tion as needed since
9a7780c9acb821fe1c2b6fc53f74cc2556ff5364 (libata-sff: make BMDMA optional)
Signed-off-by: Wolfram Sang
---
This is a build-failure, so fixing it before 2.6.37 would be great.
drivers/ata/Kconfig | 20 ++--
drivers/ata/Makefile |2 +-
2 files changed, 11 inserti
: 1 errors in 1 logs
src/arch/powerpc/platforms/52xx/mpc52xx_gpt.c:658: error: unknown field 'owner'
specified in initializer: 1 errors in 1 logs
...
Reported-by: Geert Uytterhoeven
Signed-off-by: Wolfram Sang
Cc: Grant Likely
Cc: Benjamin Herrenschmidt
Cc: Andrew Morton
---
rc7
Found by this build-error:
drivers/ata/pata_mpc52xx.c: In function 'mpc52xx_ata_init_one':
drivers/ata/pata_mpc52xx.c:662: error: 'ata_bmdma_interrupt' undeclared (first
use in this function)
So, move the Kconfig entry to the proper location.
Signed-off-by: Wolfram Sa
werpc/platforms/52xx/mpc52xx_gpt.c:658: error: unknown field 'owner'
specified in initializer: 1 errors in 1 logs
...
Reported-by: Geert Uytterhoeven
Signed-off-by: Wolfram Sang
Cc: Grant Likely
Cc: Benjamin Herrenschmidt
---
As this is a build-fix, would be nice to have for 2.6.37.
A si
ind regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
Linuxppc-dev mailing list
Linuxppc-
On Sat, Dec 11, 2010 at 07:13:00AM +0100, Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher
I'd say the two patches can be merged. Dunno what Grant prefers whom you should
CC as he is the maintainer.
> cc: Wolfram Sang
> cc: linuxppc-dev@lists.ozlabs.org
> ---
> - base
> Is it possible to add to the mpc5200_defconfig, what is needed for
> this board to compile a kernel which contains all features it needs?
Just add it as modules.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Sol
On Tue, Dec 07, 2010 at 07:58:55AM +0100, Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher
Reviewed-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.
> Wolfram Sang wrote:
> > On Mon, Dec 06, 2010 at 10:13:00AM +0100, Heiko Schocher wrote:
> >> If such a file is accepted in mainline, I make a v2 post.
> >
> > ===
> >
> > commit 0a0a5af30b9831e4f049610b5a2d9d5108ff027a
> > Author: Grant Li
ram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
ht
On Mon, Dec 06, 2010 at 07:29:23AM +0100, Heiko Schocher wrote:
> Thanks for the review,
You're welcome. Oh, just to make sure: It is really a MPC5200 and not a
MPC5200B?
Kind regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industri
On Sat, Dec 04, 2010 at 09:21:54AM +0100, Heiko Schocher wrote:
There shall be only one mpc5200-defconfig. Does the genric one work with your
board?
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http
= <1>;
> + #size-cells = <2>;
> + #address-cells = <3>;
> + device_type = "pci";
> + compatible = "fsl,mpc5200-pci";
> + reg = <0xf
kernel (PCMCIA being the third user I am aware of). I
wondered if it was feasible to make the "new-id"-code generic and make
those subsystems just use it. I haven't started working on it, though.
Kind regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sa
werpc/platforms/52xx/mpc52xx_gpt.c:658: error: unknown field 'owner'
specified in initializer: 1 errors in 1 logs
...
Reported-by: Geert Uytterhoeven
Signed-off-by: Wolfram Sang
Cc: Grant Likely
---
arch/powerpc/platforms/52xx/mpc52xx_gpt.c |1 +
1 files changed, 1 insertions(+), 0 d
upport multiple
> devices, but where probing is difficult (e.g. lm90 driver).
>
> I'm in the process of getting employer approval to get these patches
> upstream.
I hope you will get it approved, it is a lot easier to talk about code :)
Best regards,
Wolfram
--
Pengut
Signed-off-by: Wolfram Sang
---
arch/powerpc/boot/dts/pcm030.dts |1 +
arch/powerpc/boot/dts/pcm032.dts |3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
index 8a4ec30..e7c36bc 100644
--- a/arch
Side-effects happen when passing 0 to either io_limit or page_size. Give
an error in case of this misconfiguration.
Signed-off-by: Wolfram Sang
---
drivers/misc/eeprom/at24.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers
: Wolfram Sang
---
Changes since last version:
- use __be32 instead of u32
Documentation/powerpc/dts-bindings/eeprom.txt | 28 +
drivers/misc/eeprom/at24.c| 33
2 files changed, 55 insertions(+), 6 deletions(-)
create mode 100644
Here is the second round of this series:
* 1/3 now uses __be32 instead of u32.
* 2/3 is new and adds some more sanity checks
* 3/3 is unchanged
Grant, I hope you can pick 2/3 as well. Should make things easier and it is
just a misc-driver (which I maintain) :)
Wolfram Sang (3):
misc: at24
long ago, so I can't proof it right now. Will try to dig
> up some datasheets when in the office tomorrow.
Had a look, couldn't find anything :( And now?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
at everything
else is possible :) Thus, this approach. Thus, this approach.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital s
Signed-off-by: Wolfram Sang
---
arch/powerpc/boot/dts/pcm030.dts |1 +
arch/powerpc/boot/dts/pcm032.dts |3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
index 8a4ec30..e7c36bc 100644
--- a/arch
: Wolfram Sang
---
Grant: As mentioned at ELCE10, I could pretty much respin this old approach I
tried roughly a year ago (just with archdata then). If the approach and docs
are good, I am fine with the patches entering via one of your trees.
Documentation/powerpc/dts-bindings/eeprom.txt | 28
The printout for the type should be just "5xxx", so 512x users won't
wonder why they have a mpc52xx-type UART.
Signed-off-by: Wolfram Sang
Cc: Grant Likely
Cc: Greg Kroah-Hartman
---
At least I got confused and thought the wrong type was detected.
drivers/serial/mpc52x
nt_main("call",p1)
> cocci.print_secs("free",p2)
> //
>
> Signed-off-by: Julia Lawall
Acked-by: Wolfram Sang
>
> ---
> drivers/net/fs_enet/fs_enet-main.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drive
y
> I can change it to ndelay.
That might be a valid reason, dunno the details here. I'll leave the
final decision for Grant. If the use of __delay is acceptable, the
calculation that led to 7 should be explained, I think.
--
Pengutronix e.K. | Wolfra
elay(x) ndelay(x)
> #endif
Yes, but it is way more readable. Does the extra delay hurt? The value
of 7 looks a bit magic to me. Are you sure it will do for various clock
frequencies?
--
Pengutronix e.K. | Wolfram Sang
n error, please
> immediately notify the sender and destroy the original message.
>
> Thank you.
>
> Please consider the environment before printing this email.
> _______
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozl
node
> )(...);
> ...
> if (x == NULL) S
> <... when != x = E
> *if (...) {
> ... when != of_node_put(x)
> when != if (...) { ... of_node_put(x); ... }
> (
> return <+...x...+>;
> |
> * return ...;
> )
> }
> ...>
> of_node_put
node
> )(...);
> ...
> if (x == NULL) S
> <... when != x = E
> *if (...) {
> ... when != of_node_put(x)
> when != if (...) { ... of_node_put(x); ... }
> (
> return <+...x...+>;
> |
> * return ...;
> )
> }
> ...>
> of_node_p
> Can you email me, perhaps in one tarball, all of the patches I need?
Or push a git tree :)
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signat
Maybe just the lite-support is
slightly bit-rotten? What kind of build-errors do you get with the
mainline-kernel?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
sig
no need anymore to clear the clientdata-pointer, remove all current
occurrences in the drivers to simplify the code and prevent confusion.
Signed-off-by: Wolfram Sang
Cc: Jean Delvare
---
Some more notes:
I waited for rc1 as I knew there were some drivers/patches coming along which
needed to be
> Wolfram Sang (4):
> powerpc/pmac: Fix dangling pointers
> i2c/mpc: Drop NO_IRQ
> i2c/cpm: Drop NO_IRQ
> i2c/ibm-iic: Drop NO_IRQ
Sorry for the confusion, but the other Ben (Dooks) has pushed those
NO_IRQ-thigies meanwhile.
--
- don't free bus->irq (obsoleted by ca816d98170942371535b3e862813b0aba9b7d90)
- don't dispose irqs (should be done in of_mdiobus_register())
- use fec-pointer consistently in transfer()
- use resource_size()
- cosmetic fixes
Signed-off-by: Wolfram Sang
Cc: Grant Likely
---
My phy
Most things mentioned are either obsolete (platform-support) or wrong (device
numbering, DCD spport) these days. The remaining rest is obvious.
Signed-off-by: Wolfram Sang
Cc: Grant Likely
---
drivers/serial/mpc52xx_uart.c | 33 -
1 files changed, 0 insertions
On Tue, Apr 27, 2010 at 05:06:14PM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2010-04-02 at 02:17 +0200, Wolfram Sang wrote:
> > Drop NO_IRQ as 0 is the preferred way to describe 'no irq'
> > (http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is
2c_init())
> I have 2 devices on this bus, one device gets it's initcall
> before fsl_i2c_init, the second one does not :-( This means
> that the second device is never probed.
Can you try this patch?
From: Wolfram Sang
Date: Sat, 24 Apr 2010 03:18:16 +0200
Subject: [PATCH] i2c/m
On Mon, Apr 05, 2010 at 12:28:31AM +0200, ST wrote:
> Hi
> > (BTW your full name in the mail header would be appreciated)
> If the internet would be forgetting more...
Kernel development is intentionally public.
--
Pengutronix e.K. |
->A.attr);
if (device_create_file(E, &name->A))
S
|
+ sysfs_attr_init(&name->A.attr);
err = device_create_file(E, &name->A);
)
While reviewing, I put the initialization to apropriate places.
Signed-off-by: Wolfram Sang
Cc: Eric W. Biederman
Drop NO_IRQ as 0 is the preferred way to describe 'no irq'
(http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is
only used on powerpc, where NO_IRQ is 0 anyhow.
Signed-off-by: Wolfram Sang
Acked-by: Grant Likely
Cc: Sean MacLennan
Cc: Ben Dooks
---
drivers/
Drop NO_IRQ as 0 is the preferred way to describe 'no irq'
(http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is
only used on powerpc, where NO_IRQ is 0 anyhow.
Signed-off-by: Wolfram Sang
Acked-by: Grant Likely
Cc: Jochen Friedrich
Cc: Ben Dooks
---
drivers/
Drop NO_IRQ as 0 is the preferred way to describe 'no irq'
(http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is
only used on powerpc, where NO_IRQ is 0 anyhow.
Signed-off-by: Wolfram Sang
Acked-by: Grant Likely
Cc: Ben Dooks
---
drivers/i2c/busses/i2c-mp
This is a resend of my patch series from October (rebased). Only Grant's acks
have been added. Further explanation in the patches itself. Ben, can you pick
them up or tell Grant to do so?
Kind regards,
Wolfram
___
Linuxppc-dev mailing list
Linuxppc-
On Tue, Feb 02, 2010 at 12:06:12PM -0700, Grant Likely wrote:
> On Tue, Feb 2, 2010 at 11:58 AM, Wolfram Sang wrote:
> > On Fri, Jan 08, 2010 at 10:19:29PM +0100, Wolfram Sang wrote:
> >> Most things mentioned are either obsolete (platform-support) or wrong
> >>
virtex2p";
> xlnx,gpo-width = <0x1>;
> xlnx,iic-freq = <0x186a0>;
> xlnx,scl-inertial-delay = <0x0>;
> xlnx,sda-inertial-delay = <0x0>;
> xlnx,ten-bit-adr = <0x0>;
Have you
may be useful.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
Linuxppc-dev mailing list
Linuxp
he reason? With the latter, I have never seen this, they always told
the truth, so far. Although we mostly used MWDMA, no UDMA to avoid the
hardware problems.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
at task for
those having the proper setup. Regarding thermal_sys.c, which has two bug
reports already, it needs to be dynamic as the attribute name depends on the
device.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linu
t;A);
)
While reviewing, I put the initialization to apropriate places.
Signed-off-by: Wolfram Sang
Cc: Eric W. Biederman
Cc: Greg KH
Cc: Benjamin Herrenschmidt
Cc: Mike Isely
Cc: Mauro Carvalho Chehab
Cc: Sujith Thomas
Cc: Matthew Garrett
---
The thermal-sys.c-part should fix bugs #15
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.
Signed-off-by: Wolfram Sang
Cc: Colin Leroy
Cc: Benjamin Herrenschmidt
---
Found using coccinelle, then reviewed. Full
urrent mainline kernel and check the newly
merged MPC5121-patches :)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Di
s,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
Linuxppc-dev mailing list
Linuxppc-dev@li
of the driver would not change by missing your
driver improvement, so there is also no regression.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital sign
e sense.
Leave those two function pointers empty and fill them during probe (probe has
access to the compatible-property it was matched against, see its arguments).
So it should be a matter of:
if (matched_property == 5200b)
ops->func = this_one;
else
ops->func = th
quot;fsl,mpc5200b-immr");
This should be handled using a new compatible-entry "fsl,mpc5200b-psc-uart".
> + if (np) {
> + is_mpc5200b = 1;
> + dev_dbg(&op->dev, "mpc5200b: using /4 prescaler\n");
Does this message respe
On Thu, Feb 18, 2010 at 09:34:28PM -0800, Ryan wrote:
> On Thu, Feb 18, 2010 at 5:15 AM, Wolfram Sang wrote:
> >
> > > I'm soliciting comments from the community. Thanks in advance for
> > > sharing your thoughts.
> >
> > Mainline your driver and you a
> I'm soliciting comments from the community. Thanks in advance for
> sharing your thoughts.
Mainline your driver and you are free from such problems :)
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
nt Likely
> Cc: John Rigby
> ---
Reviewed-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_
must be enabled for the MPC512x by this
> function as well.
>
> Signed-off-by: Wolfgang Grandegger
Acked-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
gt; + }
> + for (;;)
> + ;
> +}
> +
> void __init mpc512x_init_IRQ(void)
> {
> struct device_node *np;
> @@ -62,4 +95,5 @@ void __init mpc512x_init(void)
> {
> mpc512x_declare_of_platform_devices();
> mpc5121_clk_init();
> +
ft[%d] cpu[%d]\n",
> +dec->name, dec->mult, dec->shift, cpu);
> + }
What about printk_once from kernel.h?
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.d
On Fri, Jan 08, 2010 at 10:19:29PM +0100, Wolfram Sang wrote:
> Most things mentioned are either obsolete (platform-support) or wrong (device
> numbering, DCD spport) these days. The remaining rest is obvious.
>
> Signed-off-by: Wolfram Sang
> Cc: Grant Likely
Ping. Anyone int
werpc/platforms/pseries/eeh_event.c
> @@ -80,7 +80,7 @@ static int eeh_event_handler(void * dummy)
> eeh_mark_slot(event->dn, EEH_MODE_RECOVERING);
>
> printk(KERN_INFO "EEH: Detected PCI bus error on device %s\n&quo
(u32 *)*p);
> pp->name = pname;
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au| minimalist, thank you. NOT _the_
> _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dg
ot; property from the example nodes.
> Furthermore and example for the MPC5121 has been added.
>
> Signed-off-by: Wolfgang Grandegger
Reviewed-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | h
Grandegger
One minor thing and you can add my
Reviewed-by: Wolfram Sang
> ---
> drivers/i2c/busses/Kconfig |7 +-
> drivers/i2c/busses/i2c-mpc.c | 127
> ++
> 2 files changed, 94 insertions(+), 40 deletions(-)
>
> diff --git a
ed to "mpc_i2c_data", which is even the better name.
>
> Signed-off-by: Wolfgang Grandegger
Tested-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de
a. Though, I
have to admit that in the last weeks I haven't followed of-related things due
to other commitments.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature
will be
rebased!)
This tree includes all MPC5121-patches and the two USB-patches from Anton. I
haven't actually tested them yet, but they all applied cleanly, at least.
Testing will come soon...
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Ind
> I just sent v2. Hope it's OK now.
Thanks, will check tomorrow.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital s
d be close
together. That could be a compromise until more quirks are needed ;)
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_i2c_setup_52xx())
'clock == 0' means 'safe divider' (and is checked in mpc_i2c_get_fdr_52xx())
This is not a beauty ;)
What about adding a flags variable to the setup-functions?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang
tested on a MPC5121ADS, TQM5200 and TQM8560 board
Nice :) BTW, is there a git-tree meanwhile for your or Anatolij's
MPC5121-development?
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/
-index = <1>;
> compatible = "fsl,mpc8544-i2c", "fsl-i2c";
> reg = <0x3100 0x100>;
> interrupts = <43 2>;
> --
> 1.6.2.5
>
> --
> To unsubscribe from this lis
= {
> - .setclock = mpc_i2c_setclock_8xxx,
> + .setup = mpc_i2c_setup_8xxx,
> .prescaler = 3,
> };
>
> @@ -606,6 +659,7 @@ static const struct of_device_id mpc_i2c_of_match[] = {
> {.compatible = "mpc5200-i2c", .data = &mpc_i2c_dat
software reset "RSTE" */
> + out_be32(&rm->rpr, 0x52535445);
> + /* Set software hard reset */
> + out_be32(&rm->rcr, 0x2);
> + } else {
> + printk(KERN_ERR ": Restart module not mapped.\n
> The patches are based on v2.6.33-rc4 and cover the following
> items:
The USB-patch needs two patches from linux-next. For convenience, don't you
have a git-tree somewhere? :)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Indus
ude that it is not possible on a 5200 to use the tricks to keep
the RTC persistent across resets. Thus, I think the patch is okay with not
supporting the 5200. Its rtc seems pretty useless.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
I
;select_chip = ads5121_select_chip;
> + }
> + of_node_put(rootnode);
If we have to live with the platform-stuff being in the driver, maybe a table
having the compatible-string and an init-function pointer per entry will make
it scale better with the number of boards?
Regards
dev->name);
I understand this type of printk fits to the rest of the code, I just wonder if
new (and patched) printouts shouldn't be converted to dev_*? Might be one line
then, and more consistent to what other drivers produce.
--
Pengutronix e.K.
Most things mentioned are either obsolete (platform-support) or wrong (device
numbering, DCD spport) these days. The remaining rest is obvious.
Signed-off-by: Wolfram Sang
Cc: Grant Likely
---
drivers/serial/mpc52xx_uart.c | 33 -
1 files changed, 0 insertions
y MPC5121 Rev. 2 and later is supported.
>
> Signed-off-by: Wolfgang Grandegger
Reviewed-by: Wolfram Sang
It still works with our board and I didn't find anything else to comment on.
Thanks, Wolfgang!
--
Pengutronix e.K. | Wolfram Sang
m was in the
discussion of being removed, this might complicate things, too.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Desc
> > It still works here and, as I see it, all issues were resolved as discussed.
>
> OK, fine if I add your acked-by then?
I wanted to add a 'Reviewed-by' after I checked V3.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang
> Wolfram, is it OK from your point of view now? I will roll out v3 after
> some more thorough testing tomorrow.
It still works here and, as I see it, all issues were resolved as discussed.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfra
301 - 400 of 635 matches
Mail list logo
