-Original Message-
From: Chen Guangyu-B42378
Sent: Tuesday, October 29, 2013 12:02 PM
To: Xiubo Li-B47053
Cc: Mark Brown; Guo Shawn-R65073; ti...@tabi.org; lgirdw...@gmail.com;
Jin Zhengxiong-R64188; rob.herr...@calxeda.com; pawel.m...@arm.com;
mark.rutl...@arm.com; swar
@@ -883,14 +883,19 @@ static int ldo_regulator_register(struct
snd_soc_codec *codec,
struct regulator_init_data *init_data,
int voltage)
{
+#ifdef CONFIG_SND_SOC_FSL_SGTL5000
+ return 0;
+#else
dev_err(codec-dev, this
+static struct snd_pcm_hardware snd_fsl_hardware = {
+ .info = SNDRV_PCM_INFO_INTERLEAVED |
+ SNDRV_PCM_INFO_BLOCK_TRANSFER |
+ SNDRV_PCM_INFO_MMAP |
+ SNDRV_PCM_INFO_MMAP_VALID |
+ SNDRV_PCM_INFO_PAUSE |
+ SNDRV_PCM_INFO_RESUME,
+static struct snd_pcm_hardware snd_fsl_hardware = {
+ .info = SNDRV_PCM_INFO_INTERLEAVED |
+ SNDRV_PCM_INFO_BLOCK_TRANSFER |
+ SNDRV_PCM_INFO_MMAP |
+ SNDRV_PCM_INFO_MMAP_VALID |
+ SNDRV_PCM_INFO_PAUSE |
+ SNDRV_PCM_INFO_RESUME,
Hi Dan, Vinod,
+static int fsl_sai_probe(struct platform_device *pdev) {
[...]
+
+ sai-dma_params_rx.addr = res-start + SAI_RDR;
+ sai-dma_params_rx.maxburst = 6;
+ index = of_property_match_string(np, dma-names, rx);
+ ret = of_parse_phandle_with_args(np, dmas, #dma-cells,
+static int fsl_sai_hw_params(struct snd_pcm_substream *substream,
+ struct snd_pcm_hw_params *params,
+ struct snd_soc_dai *cpu_dai)
+{
+ int ret;
+
+ ret = fsl_sai_hw_params_tr(substream, params, cpu_dai,
+ FSL_FMT_TRANSMITTER);
+ -- Power supplies:
+ * Mic Bias
+
+ -- SGTL5000 pins:
+ * MIC_IN
+ * LINE_IN
+ * HP_OUT
+ * LINE_OUT
Things that are part of the CODEC should be part of the CODEC binding and
this binding should reference that - this way the information doesn't
have to
+ ret = snd_soc_register_card(fsl_sgt1500_card);
+ if (ret) {
+ dev_err(pdev-dev, register soc sound card failed :%d\n,
+ ret);
+ return ret;
+ }
Use the newly added devm_snd_soc_register_card() (in -next).
Okey, Please see the
+static int fsl_sai_probe(struct platform_device *pdev) {
[...]
+
+ sai-dma_params_rx.addr = res-start + SAI_RDR;
+ sai-dma_params_rx.maxburst = 6;
+ index = of_property_match_string(np, dma-names, rx);
+ ret = of_parse_phandle_with_args(np, dmas, #dma-cells, index,
+
When the CONFIG_REGULATOR is disabled there will be some warnings
printed out.
A little confused by the title. But after looking at the comments, is the
patch just gonna add some debug info for the case when the
CONFIG_REGULATOR's been un-selected?
Well first, I think at least the
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 1f4093f..4e2e4c9 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -883,14 +883,19 @@ static int ldo_regulator_register(struct
snd_soc_codec *codec,
Hi,
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ sai-base = devm_ioremap_resource(pdev-dev, res);
+ if (IS_ERR(sai-base)) {
+ ret = PTR_ERR(sai-base);
+ return ret;
could be:
return PTR_ERR(sai-base);
Yes，This looks better.
Hi,
Documentation/devicetree/bindings/sound/fsl-sgtl5000.txt
diff --git a/Documentation/devicetree/bindings/sound/fsl-sgtl5000.txt
b/Documentation/devicetree/bindings/sound/fsl-sgtl5000.txt
new file mode 100644
index 000..43e350f
--- /dev/null
+++
I understand that, but I'm trying to figure out why of_iomap() is
okay for hundreds of other drivers, but not this one. I've used it
dozens of times myself, without ever worrying about overlapping
regions.
The driver would work fine with just of_iomap(). But the resource
range
14 matches
Mail list logo
