Re: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc

2023-06-29 Thread gre...@linuxfoundation.org
On Thu, Jun 29, 2023 at 05:56:30AM +, Christophe Leroy wrote: > > > Le 28/06/2023 à 23:10, Leo Li a écrit : > > > > > >> -Original Message- > >> From: Christophe Leroy > >> Sent: Wednesday, June 28, 2023 2:40 PM > >> To: L

Re: bug: usb: gadget: FSL_UDC_CORE Corrupted request list leads to unrecoverable loop.

2022-02-18 Thread gre...@linuxfoundation.org
On Fri, Feb 18, 2022 at 11:17:59AM +, Joakim Tjernlund wrote: > I was happy with commit msgs and I don't know what the criticism was. I have no context anymore, sorry. Can someone resubmit the change again and we can take it from there? thanks, greg k-h

Re: bug: usb: gadget: FSL_UDC_CORE Corrupted request list leads to unrecoverable loop.

2022-02-18 Thread gre...@linuxfoundation.org
On Fri, Feb 18, 2022 at 10:21:12AM +, Joakim Tjernlund wrote: > I think you could apply them as is, only criticism was the commit msgs. That is always a good reason to reject a change. Please resubmit them with the commit message cleaned up and I will be glad to review it again. thanks,

Re: [PATCH] [Rebased for 4.19 and 4.14] powerpc/32: Fix boot failure with GCC latent entropy plugin

2022-01-30 Thread gre...@linuxfoundation.org
On Sun, Jan 30, 2022 at 09:45:10AM +, Christophe Leroy wrote: > This is backport for 4.19 and 4.14 > > (cherry picked from commit bba496656a73fc1d1330b49c7f82843836e9feb1) > > Boot fails with GCC latent entropy plugin enabled. All now queued up, thanks, greg k-h

Re: [PATCH] [Modified for 5.16 and 5.15] powerpc/32s: Fix kasan_init_region() for KASAN

2022-01-30 Thread gre...@linuxfoundation.org
On Sat, Jan 29, 2022 at 05:26:10PM +, Christophe Leroy wrote: > This is a backport for 5.16 and 5.15. > > To apply, it also requires commit 37eb7ca91b69 ("powerpc/32s: Allocate > one 256k IBAT instead of two consecutives 128k IBATs") Thanks for these, now queued up. greg k-h

Re: [PATCH 1/3] powerpc/powernv: remove the unused pnv_pci_set_p2p function

2019-07-09 Thread 'gre...@linuxfoundation.org'
On Tue, Jul 09, 2019 at 06:06:54PM +0300, Max Gurtovoy wrote: > > On 7/9/2019 5:40 PM, Christoph Hellwig wrote: > > On Tue, Jul 09, 2019 at 05:37:18PM +0300, Max Gurtovoy wrote: > > > On 7/9/2019 5:32 PM, Christoph Hellwig wrote: > > > > On Tue, Jul 09, 2019 at 05:31:37PM +0300, Max Gurtovoy

Re: [PATCH 5/5] Lib: sort.h: replace int size with size_t size in the swap function

2019-03-30 Thread gre...@linuxfoundation.org
On Sat, Mar 30, 2019 at 07:43:53PM +0300, Andrey Abramov wrote: > Replace int type with size_t type of the size argument > in the swap function, also affect all its dependencies. This says _what_ the patch does, but it gives no clue as to _why_ you are doing this. Neither did your 0/5 patch :(

Re: SV: MPC8321 boot failure

2018-10-18 Thread gre...@linuxfoundation.org
On Thu, Oct 18, 2018 at 08:51:46AM +, David Gounaris wrote: > Hi, I can also confirm that it works after cherry-picking the proposed commit. > > Reported-and-tested-by: David Gounaris > mailto:david.gouna...@infinera.com>> > Now queued up, thanks. greg k-h

Re: [PATCH 2/9] Move dma_ops from archdata into struct device

2017-01-11 Thread gre...@linuxfoundation.org
On Wed, Jan 11, 2017 at 10:28:05PM +, Bart Van Assche wrote: > On Wed, 2017-01-11 at 21:31 +0100, gre...@linuxfoundation.org wrote: > > That's a big sign that your patch series needs work. Break it up into > > smaller pieces, it should be possible, which will make merges e

Re: [PATCH 2/9] Move dma_ops from archdata into struct device

2017-01-11 Thread gre...@linuxfoundation.org
On Wed, Jan 11, 2017 at 06:17:03PM +, Bart Van Assche wrote: > On Wed, 2017-01-11 at 07:48 +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 10, 2017 at 04:56:41PM -0800, Bart Van Assche wrote: > > > Several RDMA drivers, e.g. drivers/infiniband/hw/qib, use the CPU to > > > transfer data

Re: [PATCH 2/9] Move dma_ops from archdata into struct device

2017-01-11 Thread gre...@linuxfoundation.org
On Wed, Jan 11, 2017 at 06:03:15PM +, Bart Van Assche wrote: > On Wed, 2017-01-11 at 07:46 +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 10, 2017 at 04:56:41PM -0800, Bart Van Assche wrote: > > > Several RDMA drivers, e.g. drivers/infiniband/hw/qib, use the CPU to > > > transfer data

Re: [v12, 0/8] Fix eSDHC host version register bug

2016-10-19 Thread gre...@linuxfoundation.org
On Wed, Oct 19, 2016 at 02:47:07AM +, Y.B. Lu wrote: > + Greg > > Hi Greg, > > I submitted this patchset for a MMC bug fix, and introduce the below patch > which needs your ACK. > > > Arnd Bergmann (1): > > > base: soc: introduce soc_device_match() interface >

Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-24 Thread gre...@linuxfoundation.org
On Mon, Feb 20, 2012 at 01:24:22PM +, Tabi Timur-B04825 wrote: Stephen Rothwell wrote: console_initcall() is not defined for modules. Hmmm... the patch you posted is a good short-term fix, but I wonder if makes sense for the driver to support modules at all. I have this in the

Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-24 Thread gre...@linuxfoundation.org
On Fri, Feb 24, 2012 at 04:00:12PM -0600, Timur Tabi wrote: gre...@linuxfoundation.org wrote: Sure, something like that is fine, but if the code really can't be a module, why not just fix the Kconfig file to enforce this properly instead? That's the simplest approach, for use. The TTY

Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-24 Thread gre...@linuxfoundation.org
On Fri, Feb 24, 2012 at 04:15:04PM -0600, Timur Tabi wrote: gre...@linuxfoundation.org wrote: That's the simplest approach, for use. The TTY portion of the driver can be used as a module. Is there any real value in loading a TTY driver as a module? Depends on the hardware