Re: [PATCH net-next v2 9/9] ibmvnic: Do not replenish RX buffers after every polling loop

2020-11-19 Thread ljp
On 2020-11-19 14:26, Thomas Falcon wrote: On 11/19/20 3:43 AM, ljp wrote: On 2020-11-18 19:12, Thomas Falcon wrote: From: "Dwip N. Banerjee" Reduce the amount of time spent replenishing RX buffers by only doing so once available buffers has fallen under a certain threshold, in

Re: [PATCH net-next v2 8/9] ibmvnic: Use netdev_alloc_skb instead of alloc_skb to replenish RX buffers

2020-11-19 Thread ljp
On 2020-11-18 19:12, Thomas Falcon wrote: From: "Dwip N. Banerjee" Take advantage of the additional optimizations in netdev_alloc_skb when allocating socket buffers to be used for packet reception. Signed-off-by: Dwip N. Banerjee Acked-by: Lijun Pan

Re: [PATCH net-next v2 9/9] ibmvnic: Do not replenish RX buffers after every polling loop

2020-11-19 Thread ljp
On 2020-11-18 19:12, Thomas Falcon wrote: From: "Dwip N. Banerjee" Reduce the amount of time spent replenishing RX buffers by only doing so once available buffers has fallen under a certain threshold, in this case half of the total number of buffers, or if the polling loop exits before the

Re: [PATCH net-next v2 5/9] ibmvnic: Remove send_subcrq function

2020-11-19 Thread ljp
On 2020-11-18 19:12, Thomas Falcon wrote: It is not longer used, so remove it. Signed-off-by: Thomas Falcon Acked-by: Lijun Pan

Re: [PATCH net-next v2 1/9] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

2020-11-19 Thread ljp
On 2020-11-18 19:12, Thomas Falcon wrote: This patch introduces the infrastructure to send batched subordinate Command Response Queue descriptors, which are used by the ibmvnic driver to send TX frame and RX buffer descriptors. Signed-off-by: Thomas Falcon Acked-by: Lijun Pan

Re: [PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

2020-11-06 Thread ljp
On 2020-11-06 13:42, Jakub Kicinski wrote: On Fri, 06 Nov 2020 13:30:25 -0600 ljp wrote: On 2020-11-06 13:17, Dany Madden wrote: > This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf > where it restructures do_reset. There are patches being tested that > would require maj

Re: [PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

2020-11-06 Thread ljp
On 2020-11-06 13:42, Jakub Kicinski wrote: On Fri, 06 Nov 2020 13:30:25 -0600 ljp wrote: On 2020-11-06 13:17, Dany Madden wrote: > This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf > where it restructures do_reset. There are patches being tested that > would require maj

Re: [PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

2020-11-06 Thread ljp
On 2020-11-06 13:17, Dany Madden wrote: This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf where it restructures do_reset. There are patches being tested that would require major rework if this is committed first. We will resend this after the other patches have been applied. I