Re: [PATCH 1/2 v4] fs_enet/mii-fec.c: fix MII speed calculation

2009-07-17 Thread Wolfgang Denk
Dear Wolfram Sang, In message <20090717093307.gb3...@pengutronix.de> you wrote: > ... > > @@ -188,6 +209,12 @@ static struct of_device_id fs_enet_mdio_fec_match[] = { > > { > > .compatible = "fsl,pq1-fec-mdio", > > }, > > +#if defined(CONFIG_PPC_MPC512x) > > + { > > +

Re: [PATCH 1/2 v4] fs_enet/mii-fec.c: fix MII speed calculation

2009-07-17 Thread Wolfgang Denk
Dear Grant Likely, In message you wrote: > > I assume this is tested. I have not tested this on my board, and I've It was tested, but as it turns out not quite well :-( > got one question below, but otherwise I think I can say ... > The calculation has changed here for non mpc5121 users.

Re: [PATCH 1/2 v4] fs_enet/mii-fec.c: fix MII speed calculation

2009-07-17 Thread Wolfram Sang
Hi, On Thu, Jul 16, 2009 at 11:42:25PM +0200, Wolfgang Denk wrote: > The MII speed calculation was based on the CPU clock (ppc_proc_freq), > but for MPC512x we must use the bus clock instead. > > This patch makes it use the correct clock and makes sure we don't > clobber reserved bits in the MII_

Re: [PATCH 1/2 v4] fs_enet/mii-fec.c: fix MII speed calculation

2009-07-16 Thread Grant Likely
On Thu, Jul 16, 2009 at 3:42 PM, Wolfgang Denk wrote: > The MII speed calculation was based on the CPU clock (ppc_proc_freq), > but for MPC512x we must use the bus clock instead. > > This patch makes it use the correct clock and makes sure we don't > clobber reserved bits in the MII_SPEED register.

[PATCH 1/2 v4] fs_enet/mii-fec.c: fix MII speed calculation

2009-07-16 Thread Wolfgang Denk
The MII speed calculation was based on the CPU clock (ppc_proc_freq), but for MPC512x we must use the bus clock instead. This patch makes it use the correct clock and makes sure we don't clobber reserved bits in the MII_SPEED register. Signed-off-by: Wolfgang Denk Cc: Grant Likely Cc: Kumar Gal