Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Wolfgang Grandegger
Kumar Gala wrote: On Jun 4, 2008, at 4:43 AM, Wolfgang Grandegger wrote: David Gibson wrote: On Tue, Jun 03, 2008 at 09:33:12AM -0500, Kumar Gala wrote: On Jun 3, 2008, at 5:08 AM, Wolfgang Grandegger wrote: Kumar Gala wrote: On Jun 1, 2008, at 9:03 PM, David Gibson wrote: On Fri, May

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Kumar Gala
I'm puzzled. Could someone point me to some real code where cell- index is used as a pointer into some global data. Sorry for my ignorance. http://ozlabs.org/pipermail/linuxppc-dev/2008-June/057254.html Yep, I saw that it's used for I2C (and SPI). But cell-index is also defined for

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Wolfgang Grandegger
Kumar Gala wrote: I'm puzzled. Could someone point me to some real code where cell-index is used as a pointer into some global data. Sorry for my ignorance. http://ozlabs.org/pipermail/linuxppc-dev/2008-June/057254.html Yep, I saw that it's used for I2C (and SPI). But cell-index is also

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread David Gibson
On Thu, Jun 05, 2008 at 02:43:59AM -0500, Kumar Gala wrote: I'm puzzled. Could someone point me to some real code where cell- index is used as a pointer into some global data. Sorry for my ignorance. http://ozlabs.org/pipermail/linuxppc-dev/2008-June/057254.html Yep, I saw that it's used

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-04 Thread Wolfgang Grandegger
David Gibson wrote: On Tue, Jun 03, 2008 at 09:33:12AM -0500, Kumar Gala wrote: On Jun 3, 2008, at 5:08 AM, Wolfgang Grandegger wrote: Kumar Gala wrote: On Jun 1, 2008, at 9:03 PM, David Gibson wrote: On Fri, May 30, 2008 at 08:49:45AM +0200, Wolfgang Grandegger wrote: [snip] You have a

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-04 Thread Kumar Gala
On Jun 4, 2008, at 4:43 AM, Wolfgang Grandegger wrote: David Gibson wrote: On Tue, Jun 03, 2008 at 09:33:12AM -0500, Kumar Gala wrote: On Jun 3, 2008, at 5:08 AM, Wolfgang Grandegger wrote: Kumar Gala wrote: On Jun 1, 2008, at 9:03 PM, David Gibson wrote: On Fri, May 30, 2008 at 08:49:45AM

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-03 Thread Wolfgang Grandegger
Kumar Gala wrote: On Jun 1, 2008, at 9:03 PM, David Gibson wrote: On Fri, May 30, 2008 at 08:49:45AM +0200, Wolfgang Grandegger wrote: This patch adds support for the TQM8548 modules from TQ-Components GmbH (http://www.tqc.de). [snip] index 000..d09250a --- /dev/null +++

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-03 Thread Kumar Gala
On Jun 3, 2008, at 5:08 AM, Wolfgang Grandegger wrote: Kumar Gala wrote: On Jun 1, 2008, at 9:03 PM, David Gibson wrote: On Fri, May 30, 2008 at 08:49:45AM +0200, Wolfgang Grandegger wrote: This patch adds support for the TQM8548 modules from TQ-Components GmbH (http://www.tqc.de).

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-03 Thread David Gibson
On Tue, Jun 03, 2008 at 09:33:12AM -0500, Kumar Gala wrote: On Jun 3, 2008, at 5:08 AM, Wolfgang Grandegger wrote: Kumar Gala wrote: On Jun 1, 2008, at 9:03 PM, David Gibson wrote: On Fri, May 30, 2008 at 08:49:45AM +0200, Wolfgang Grandegger wrote: [snip] You have a whole lot of 'cell-index'

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-02 Thread Wolfgang Grandegger
David Gibson wrote: On Fri, May 30, 2008 at 08:49:45AM +0200, Wolfgang Grandegger wrote: This patch adds support for the TQM8548 modules from TQ-Components GmbH (http://www.tqc.de). [snip] index 000..d09250a --- /dev/null +++ b/arch/powerpc/boot/dts/tqm8548.dts @@ -0,0 +1,370 @@ +/*

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-02 Thread Kumar Gala
On Jun 1, 2008, at 9:03 PM, David Gibson wrote: On Fri, May 30, 2008 at 08:49:45AM +0200, Wolfgang Grandegger wrote: This patch adds support for the TQM8548 modules from TQ-Components GmbH (http://www.tqc.de). [snip] index 000..d09250a --- /dev/null +++

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-01 Thread David Gibson
On Fri, May 30, 2008 at 08:49:45AM +0200, Wolfgang Grandegger wrote: This patch adds support for the TQM8548 modules from TQ-Components GmbH (http://www.tqc.de). [snip] index 000..d09250a --- /dev/null +++ b/arch/powerpc/boot/dts/tqm8548.dts @@ -0,0 +1,370 @@ +/* + * TQM8548 Device

[PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-05-30 Thread Wolfgang Grandegger
This patch adds support for the TQM8548 modules from TQ-Components GmbH (http://www.tqc.de). Signed-off-by: Wolfgang Grandegger [EMAIL PROTECTED] --- arch/powerpc/boot/Makefile |1 + arch/powerpc/boot/dts/tqm8548.dts | 370 + arch/powerpc/boot/wrapper

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-05-30 Thread Stephen Rothwell
Hi Wolfgang, On Fri, 30 May 2008 08:49:45 +0200 Wolfgang Grandegger [EMAIL PROTECTED] wrote: +++ b/arch/powerpc/platforms/85xx/tqm85xx.c @@ -120,8 +120,17 @@ static void __init tqm85xx_setup_arch(void) #endif #ifdef CONFIG_PCI - for_each_compatible_node(np, pci, fsl,mpc8540-pci)

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-05-30 Thread Wolfgang Grandegger
Stephen Rothwell wrote: Hi Wolfgang, On Fri, 30 May 2008 08:49:45 +0200 Wolfgang Grandegger [EMAIL PROTECTED] wrote: +++ b/arch/powerpc/platforms/85xx/tqm85xx.c @@ -120,8 +120,17 @@ static void __init tqm85xx_setup_arch(void) #endif #ifdef CONFIG_PCI -

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-05-30 Thread Arnd Bergmann
On Friday 30 May 2008, Wolfgang Grandegger wrote:  #ifdef CONFIG_PCI -   for_each_compatible_node(np, pci, fsl,mpc8540-pci) -   fsl_add_bridge(np, 1); +   for_each_node_by_type(np, pci) { +   if (of_device_is_compatible(np, fsl,mpc8540-pci) || +