Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-20 Thread Arnd Bergmann
On Tuesday 19 August 2008, Josh Boyer wrote: This adds a common board file for almost all of the simple PowerPC 44x boards that exist today. This is intended to be a single place to add support for boards that do not differ in platform support from most of the evaluation boards that are used

Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-20 Thread Josh Boyer
On Wed, 20 Aug 2008 15:33:21 +0200 Arnd Bergmann [EMAIL PROTECTED] wrote: On Tuesday 19 August 2008, Josh Boyer wrote: This adds a common board file for almost all of the simple PowerPC 44x boards that exist today. This is intended to be a single place to add support for boards that do

Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-20 Thread Grant Likely
On Wed, Aug 20, 2008 at 7:33 AM, Arnd Bergmann [EMAIL PROTECTED] wrote: On Tuesday 19 August 2008, Josh Boyer wrote: This adds a common board file for almost all of the simple PowerPC 44x boards that exist today. This is intended to be a single place to add support for boards that do not

Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-20 Thread Josh Boyer
On Wed, 2008-08-20 at 08:15 -0600, Grant Likely wrote: On Wed, Aug 20, 2008 at 7:33 AM, Arnd Bergmann [EMAIL PROTECTED] wrote: On Tuesday 19 August 2008, Josh Boyer wrote: This adds a common board file for almost all of the simple PowerPC 44x boards that exist today. This is intended to be

Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-20 Thread Josh Boyer
On Wed, 20 Aug 2008 10:45:47 -0400 Josh Boyer [EMAIL PROTECTED] wrote: On Wed, 2008-08-20 at 08:15 -0600, Grant Likely wrote: On Wed, Aug 20, 2008 at 7:33 AM, Arnd Bergmann [EMAIL PROTECTED] wrote: On Tuesday 19 August 2008, Josh Boyer wrote: This adds a common board file for almost all

Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-20 Thread Roland Dreier
You should fix 52xx with the same for loop change then, since I blatantly most of this file from you ;) Heh, then factor out mpc5200_simple_probe() into a helper and use it instead of copying it as ppc44x_probe? ;) If you stick to the NULL-terminated array version, then it becomes easy to

Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-20 Thread Josh Boyer
On Wed, 20 Aug 2008 09:33:06 -0700 Roland Dreier [EMAIL PROTECTED] wrote: You should fix 52xx with the same for loop change then, since I blatantly most of this file from you ;) Heh, then factor out mpc5200_simple_probe() into a helper and use it instead of copying it as ppc44x_probe?

Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-20 Thread Roland Dreier
Except that logically doesn't make much sense. Why would you have a list of mpc52xx and 44x boards together? They require completely different kernels because the MMU and drive set is entirely different. Or am I totally missing what you are saying? Yeah, I wasn't clear -- I meant to

Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-20 Thread Josh Boyer
On Wed, 20 Aug 2008 10:19:02 -0700 Roland Dreier [EMAIL PROTECTED] wrote: Except that logically doesn't make much sense. Why would you have a list of mpc52xx and 44x boards together? They require completely different kernels because the MMU and drive set is entirely different.

Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-20 Thread Roland Dreier
Yeah, I wasn't clear -- I meant to add a new helper like of_flat_dt_is_compatible_list() (not sure of the name) that takes a node and a NULL-terminated array of strings, and then mpc5200_simple_probe() can become a one-liner, along with mpc5121_generic_probe(), tqm85xx_probe(),

[PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

2008-08-19 Thread Josh Boyer
This adds a common board file for almost all of the simple PowerPC 44x boards that exist today. This is intended to be a single place to add support for boards that do not differ in platform support from most of the evaluation boards that are used as reference platforms. Boards that have