Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Scott Wood
: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code On 08/05/2012 09:39 PM, Jia Hongtao-B38951 wrote: -Original Message- From: Wood Scott-B07421 Sent: Saturday, August 04, 2012 12:04 AM To: Jia Hongtao-B38951 Cc: Kumar Gala; linuxppc-dev@lists.ozlabs.org; Wood

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Jia Hongtao-B38951
-Original Message- From: Wood Scott-B07421 Sent: Wednesday, August 08, 2012 11:54 PM To: Jia Hongtao-B38951 Cc: Wood Scott-B07421; Kumar Gala; linuxppc-dev@lists.ozlabs.org; Li Yang-R58472 Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code On 08/07

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Jia Hongtao-B38951
-Original Message- From: Wood Scott-B07421 Sent: Monday, August 06, 2012 11:16 PM To: Jia Hongtao-B38951 Cc: Wood Scott-B07421; Kumar Gala; linuxppc-dev@lists.ozlabs.org; Li Yang-R58472 Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code On 08/05/2012

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Scott Wood
: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code On 08/02/2012 10:39 PM, Jia Hongtao-B38951 wrote: -Original Message- From: Kumar Gala [mailto:ga...@kernel.crashing.org] Sent: Thursday, August 02, 2012 8:24 PM To: Jia Hongtao-B38951 Cc: linuxppc-dev

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Jia Hongtao-B38951
-Original Message- From: Wood Scott-B07421 Sent: Tuesday, August 07, 2012 11:20 PM To: Jia Hongtao-B38951 Cc: Wood Scott-B07421; Kumar Gala; linuxppc-dev@lists.ozlabs.org; Li Yang-R58472 Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code On 08/07

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Scott Wood
On 08/05/2012 11:11 PM, Tabi Timur-B04825 wrote: On Fri, Aug 3, 2012 at 11:09 AM, Scott Wood scottw...@freescale.com wrote: p1022ds OTOH is weird enough that it deserves its own board file. What's so weird about the P1022DS? The localbus muxing. Also, why do we need a default PCI bus if

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Scott Wood
Yang-R58472 Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code You need to convert all boards to use fsl_pci_init before this patch. Otherwise we'll end up with PCI getting initialized twice on boards. - k If we covert all boards with platform driver in this patch

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-05 Thread Jia Hongtao-B38951
-Original Message- From: Wood Scott-B07421 Sent: Saturday, August 04, 2012 12:04 AM To: Jia Hongtao-B38951 Cc: Kumar Gala; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code On 08/02

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-05 Thread Tabi Timur-B04825
On Fri, Aug 3, 2012 at 11:09 AM, Scott Wood scottw...@freescale.com wrote: p1022ds OTOH is weird enough that it deserves its own board file. What's so weird about the P1022DS? Also, why do we need a default PCI bus if one isn't specified in the device tree? -- Timur Tabi Linux kernel

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-03 Thread Scott Wood
] powerpc/fsl-pci: Unify pci/pcie initialization code You need to convert all boards to use fsl_pci_init before this patch. Otherwise we'll end up with PCI getting initialized twice on boards. - k If we covert all boards with platform driver in this patch PCI will be initialized only once

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-03 Thread Scott Wood
] powerpc/fsl-pci: Unify pci/pcie initialization code Why are you eliminating the uli lookup? We don't want to call uli_exclude_device on boards that don't have a uli. -Scott I found out that all 85xx_ds boards (mpc8572ds, mpc8544ds, p2020ds) have ULI. Perhaps all boards currently handled

[PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Kumar Gala
On Aug 2, 2012, at 6:42 AM, Jia Hongtao wrote: We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Scott Wood
On 08/02/2012 07:23 AM, Kumar Gala wrote: You need to convert all boards to use fsl_pci_init before this patch. Otherwise we'll end up with PCI getting initialized twice on boards. Alternatively, don't make fsl_pci_init an initcall until all boards have been converted. -Scott

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Scott Wood
On 08/02/2012 06:42 AM, Jia Hongtao wrote: We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Jia Hongtao-B38951
-Original Message- From: Wood Scott-B07421 Sent: Friday, August 03, 2012 4:19 AM To: Jia Hongtao-B38951 Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Wood Scott- B07421; Li Yang-R58472 Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Jia Hongtao-B38951
-Original Message- From: Kumar Gala [mailto:ga...@kernel.crashing.org] Sent: Thursday, August 02, 2012 8:24 PM To: Jia Hongtao-B38951 Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization