Re: [PATCH v2 04/14] PCI/MSI: Use sysfs_emit() and sysfs_emit_at() in "show" functions

2021-05-15 Thread Krzysztof Wilczyński
Hi Joe, [...] > >   if (entry) > > - return sprintf(buf, "%s\n", > > - entry->msi_attrib.is_msix ? "msix" : "msi"); > > + return sysfs_emit(buf, "%s\n", > > + entry->msi_attrib.is_msix ? "msix" : "msi"); > >   > > > >  

Re: [PATCH v2 04/14] PCI/MSI: Use sysfs_emit() and sysfs_emit_at() in "show" functions

2021-05-14 Thread Joe Perches
On Sat, 2021-05-15 at 05:24 +, Krzysztof Wilczyński wrote: > The sysfs_emit() and sysfs_emit_at() functions were introduced to make > it less ambiguous which function is preferred when writing to the output > buffer in a device attribute's "show" callback [1]. > > Convert the PCI sysfs object

[PATCH v2 04/14] PCI/MSI: Use sysfs_emit() and sysfs_emit_at() in "show" functions

2021-05-14 Thread Krzysztof Wilczyński
The sysfs_emit() and sysfs_emit_at() functions were introduced to make it less ambiguous which function is preferred when writing to the output buffer in a device attribute's "show" callback [1]. Convert the PCI sysfs object "show" functions from sprintf(), snprintf() and scnprintf() to