Re: [PATCH v2 15/16] powerpc/powernv/sriov: Make single PE mode a per-BAR setting

2020-08-03 Thread Segher Boessenkool
On Mon, Aug 03, 2020 at 03:57:11PM +1000, Michael Ellerman wrote: > > I would assume the function should still be generated since those checks > > are relevant, just the return value is bogus. > > Yeah, just sometimes missing warnings boil down to the compiler eliding > whole sections of code, if

Re: [PATCH v2 15/16] powerpc/powernv/sriov: Make single PE mode a per-BAR setting

2020-08-02 Thread Michael Ellerman
Nathan Chancellor writes: > On Sun, Aug 02, 2020 at 11:12:23PM +1000, Michael Ellerman wrote: >> Nathan Chancellor writes: >> > On Wed, Jul 22, 2020 at 04:57:14PM +1000, Oliver O'Halloran wrote: >> >> Using single PE BARs to map an SR-IOV BAR is really a choice about what >> >> strategy to use

Re: [PATCH v2 15/16] powerpc/powernv/sriov: Make single PE mode a per-BAR setting

2020-08-02 Thread Nathan Chancellor
On Sun, Aug 02, 2020 at 11:12:23PM +1000, Michael Ellerman wrote: > Nathan Chancellor writes: > > On Wed, Jul 22, 2020 at 04:57:14PM +1000, Oliver O'Halloran wrote: > >> Using single PE BARs to map an SR-IOV BAR is really a choice about what > >> strategy to use when mapping a BAR. It doesn't

Re: [PATCH v2 15/16] powerpc/powernv/sriov: Make single PE mode a per-BAR setting

2020-08-02 Thread Michael Ellerman
Nathan Chancellor writes: > On Wed, Jul 22, 2020 at 04:57:14PM +1000, Oliver O'Halloran wrote: >> Using single PE BARs to map an SR-IOV BAR is really a choice about what >> strategy to use when mapping a BAR. It doesn't make much sense for this to >> be a global setting since a device might have

Re: [PATCH v2 15/16] powerpc/powernv/sriov: Make single PE mode a per-BAR setting

2020-08-01 Thread Nathan Chancellor
On Wed, Jul 22, 2020 at 04:57:14PM +1000, Oliver O'Halloran wrote: > Using single PE BARs to map an SR-IOV BAR is really a choice about what > strategy to use when mapping a BAR. It doesn't make much sense for this to > be a global setting since a device might have one large BAR which needs to >

[PATCH v2 15/16] powerpc/powernv/sriov: Make single PE mode a per-BAR setting

2020-07-22 Thread Oliver O'Halloran
Using single PE BARs to map an SR-IOV BAR is really a choice about what strategy to use when mapping a BAR. It doesn't make much sense for this to be a global setting since a device might have one large BAR which needs to be mapped with single PE windows and another smaller BAR that can be mapped