Re: Calling wait_event_interruptible_timeout() in I2C wait functions

2009-02-05 Thread Mark Brown
On Wed, Feb 04, 2009 at 12:00:52PM -0800, Mike Ditto wrote: Timur Tabi wrote: However, it appears that this is not common behavior for I2C driver. In fact, only these six drivers ever call wait_event_interruptible_timeout(): i2c-cpm.c I don't know about the others, but in i2c-cpm.c the

Re: Calling wait_event_interruptible_timeout() in I2C wait functions

2009-02-05 Thread Timur Tabi
On Thu, Feb 5, 2009 at 5:51 AM, Mark Brown broo...@sirena.org.uk wrote: This is exactly the problem for users that caused Timur to run into this - further up the stack we're trying to do cleanup that involves writing via I2C but the I2C writes error out due to the signal. Well, there's not

Calling wait_event_interruptible_timeout() in I2C wait functions

2009-02-03 Thread Timur Tabi
In i2c-mpc.c, the i2c_wait() function has this: } else { /* Interrupt mode */ result = wait_event_interruptible_timeout(i2c-queue, (i2c-interrupt CSR_MIF), timeout * HZ); if (unlikely(result 0)) {