Re: [PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver

2014-03-07 Thread David Miller
From: Alistair Popple alist...@popple.id.au Date: Thu, 6 Mar 2014 14:52:25 +1100 + out_be32(dev-reg, in_be32(dev-reg) | WKUP_ETH_RGMIIEN + | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE); When an expression spans multiple lines, the lines should end with operators rather than begin with

rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Joe Perches
(added some cc's) On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: From: Alistair Popple alist...@popple.id.au Date: Thu, 6 Mar 2014 14:52:25 +1100 + out_be32(dev-reg, in_be32(dev-reg) | WKUP_ETH_RGMIIEN +| WKUP_ETH_TX_OE | WKUP_ETH_RX_IE); When an expression spans

[git pull] Please pull powerpc.git merge branch

2014-03-07 Thread Benjamin Herrenschmidt
Hi Linus ! Here are a couple of powerpc fixes for 3.14. One is (another !) nasty TM problem, we can crash the kernel by forking inside a transaction. The other one is a simple fix for an alignment issue which can hurt in LE mode. Cheers, Ben. The following changes since commit

Re: rfc: checkpatch logical line continuations

2014-03-07 Thread David Miller
From: Joe Perches j...@perches.com Date: Fri, 07 Mar 2014 13:02:44 -0800 Right now, checkpatch emits a --strict only warning on or || at the beginning of line but that could be changed to any $Operators our $Arithmetic = qr{\+|-|\*|\/|%}; our $Operators= qr{

Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Joe Perches
On Fri, 2014-03-07 at 13:30 -0800, j...@joshtriplett.org wrote: On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: From: Alistair Popple alist...@popple.id.au Date: Thu, 6 Mar 2014 14:52:25 +1100 +

Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread josh
On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: From: Alistair Popple alist...@popple.id.au Date: Thu, 6 Mar 2014 14:52:25 +1100 + out_be32(dev-reg, in_be32(dev-reg) | WKUP_ETH_RGMIIEN + | WKUP_ETH_TX_OE |

Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Dan Carpenter
On Fri, Mar 07, 2014 at 01:30:17PM -0800, j...@joshtriplett.org wrote: On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: From: Alistair Popple alist...@popple.id.au Date: Thu, 6 Mar 2014 14:52:25 +1100 +

Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Joe Perches
On Sat, 2014-03-08 at 02:04 +0300, Dan Carpenter wrote: On Fri, Mar 07, 2014 at 01:30:17PM -0800, j...@joshtriplett.org wrote: On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: From: Alistair Popple alist...@popple.id.au

[PATCH] eeh_pseries: Missing break?

2014-03-07 Thread Joe Perches
Looks like this is unintentional as the result = EEH_STATE_UNAVAILABLE is being overwritten by EEH_STATE_NOT_SUPPORT in the fallthrough to the default case. --- diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c index 8a8f047..83da53f 100644