Re: PowerPC agpmode issues

2016-09-20 Thread Michel Dänzer
On 20/09/16 12:43 PM, Herminio Hernandez, Jr. wrote: > > Yes to both, however when I set radeon.agpmode=1 most of the time the > kernel freezes when booting. When I do get past that I get these errors: [...] > *[ 11.415769] [drm:.radeon_agp_init [radeon]] *ERROR* Illegal AGP > Mode: 1 (valid

Re: [2/2] Detect instruction fetch denied and report

2016-09-20 Thread Michael Ellerman
On Mon, 2016-22-08 at 01:56:57 UTC, Balbir Singh wrote: > diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c > index a4db22f..f162e77 100644 > --- a/arch/powerpc/mm/fault.c > +++ b/arch/powerpc/mm/fault.c > @@ -404,6 +404,10 @@ good_area: >

Re: [v2] Fix __tlbiel in hash_native_64

2016-09-20 Thread Michael Ellerman
On Tue, 2016-13-09 at 06:40:07 UTC, Balbir Singh wrote: > __tlbie and __tlbiel are out of sync. __tlbie does the right thing > it calls tlbie with "tlbie rb, L" if CPU_FTR_ARCH_206 (cpu feature) is clear > and with "tlbie rb" otherwise. During the cleanup of __tlbiel I noticed > that __tlbiel was

Re: [2/2] Detect instruction fetch denied and report

2016-09-20 Thread Balbir Singh
On 20/09/16 16:35, Michael Ellerman wrote: > On Mon, 2016-22-08 at 01:56:57 UTC, Balbir Singh wrote: >> diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c >> index a4db22f..f162e77 100644 >> --- a/arch/powerpc/mm/fault.c >> +++ b/arch/powerpc/mm/fault.c >> @@ -404,6 +404,10 @@

Re: [PATCH 2/2] powernv:idle:Implement lite variant of power_enter_stop

2016-09-20 Thread Gautham R Shenoy
Hi Balbir, On Tue, Sep 20, 2016 at 03:54:43PM +1000, Balbir Singh wrote: > > diff --git a/arch/powerpc/platforms/powernv/idle.c > > b/arch/powerpc/platforms/powernv/idle.c > > index 479c256..c3d3fed 100644 > > --- a/arch/powerpc/platforms/powernv/idle.c > > +++

Re: [PATCH][RFC] Implement arch primitives for busywait loops

2016-09-20 Thread Christian Borntraeger
On 09/16/2016 10:57 AM, Nicholas Piggin wrote: > Implementing busy wait loops with cpu_relax() in callers poses > some difficulties for powerpc. > > First, we want to put our SMT thread into a low priority mode for the > duration of the loop, but then return to normal priority after exiting > the

Re: [PATCH][RFC] Implement arch primitives for busywait loops

2016-09-20 Thread Nicholas Piggin
On Tue, 20 Sep 2016 13:19:30 +0200 Christian Borntraeger wrote: > On 09/16/2016 10:57 AM, Nicholas Piggin wrote: > > Implementing busy wait loops with cpu_relax() in callers poses > > some difficulties for powerpc. > > > > First, we want to put our SMT thread into a low

Re: [PATCH][RFC] Implement arch primitives for busywait loops

2016-09-20 Thread Nicholas Piggin
On Tue, 20 Sep 2016 14:35:45 +0200 Christian Borntraeger wrote: > On 09/20/2016 02:27 PM, Nicholas Piggin wrote: > > On Tue, 20 Sep 2016 13:19:30 +0200 > > Christian Borntraeger wrote: > > > >> On 09/16/2016 10:57 AM, Nicholas Piggin wrote: >

Re: [PATCH][RFC] Implement arch primitives for busywait loops

2016-09-20 Thread Christian Borntraeger
On 09/20/2016 02:27 PM, Nicholas Piggin wrote: > On Tue, 20 Sep 2016 13:19:30 +0200 > Christian Borntraeger wrote: > >> On 09/16/2016 10:57 AM, Nicholas Piggin wrote: >>> Implementing busy wait loops with cpu_relax() in callers poses >>> some difficulties for powerpc. >>>

Re: [PATHC v2 0/9] ima: carry the measurement list across kexec

2016-09-20 Thread Eric W. Biederman
Thiago Jung Bauermann writes: > Am Samstag, 17 September 2016, 00:17:37 schrieb Eric W. Biederman: >> Thiago Jung Bauermann writes: >> > Hello Eric, >> > >> > Am Freitag, 16 September 2016, 14:47:13 schrieb Eric W. Biederman: >> >> I

[powerpc:test 45/76] undefined reference to `.elf64_apply_relocate_add'

2016-09-20 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git test head: f616ddd0503c863e05be4a9d16b3c3ef8f85213f commit: 90cf23bbbc9ef5d9da798c1b0caceb0ebc583b5f [45/76] powerpc: Factor out relocation code from module_64.c to elf_util_64.c. config: powerpc-ppc64e_defconfig

RE: [PATCH v5 2/2] QE: remove PPCisms for QE

2016-09-20 Thread Qiang Zhao
On Mon, Sep 20, 2016 at 4:13 AM, Leo Li wrote: > -Original Message- > From: Leo Li [mailto:pku@gmail.com] > Sent: Tuesday, September 20, 2016 4:13 AM > To: Qiang Zhao > Cc: Scott Wood ; linuxppc-dev d...@lists.ozlabs.org>; lkml

linux-next: manual merge of the powerpc tree with the kbuild tree

2016-09-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the powerpc tree got conflicts in: arch/powerpc/kernel/misc_32.S arch/powerpc/kernel/misc_64.S between commit: 9445aa1a3062 ("ppc: move exports to definitions") from the kbuild tree and commit: 6f698df10cb2 ("powerpc/kernel: Use kprobe blacklist

Re: [1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get

2016-09-20 Thread Russell Currey
On Wed, 2016-09-21 at 14:02 +1000, Michael Ellerman wrote: > On Mon, 2016-12-09 at 04:17:22 UTC, Russell Currey wrote: > > > > eeh_pe_bus_get() can return NULL if a PCI bus isn't found for a given PE. > > Some callers don't check this, and can cause a null pointer dereference > > under certain

[PATCH] powerpc/64: abstract EE/RI handling between E/S cases

2016-09-20 Thread Nicholas Piggin
Signed-off-by: Nicholas Piggin --- This moves some of the ifdefs out of line and hopefully makes things slightly more readable. Should be no generated code changes. arch/powerpc/kernel/entry_64.S | 111 +++-- 1 file changed, 62

Re: [1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get

2016-09-20 Thread Michael Ellerman
On Mon, 2016-12-09 at 04:17:22 UTC, Russell Currey wrote: > eeh_pe_bus_get() can return NULL if a PCI bus isn't found for a given PE. > Some callers don't check this, and can cause a null pointer dereference > under certain circumstances. > > Fix this by checking NULL everywhere eeh_pe_bus_get()

Re: [PATCH 4/4] drivers/pci/hotplug: Support surprise hotplug

2016-09-20 Thread Michael Ellerman
Gavin Shan writes: > This supports PCI surprise hotplug. The design is highlighted as > below: > >* The PCI slot's surprise hotplug capability is exposed through > device node property "ibm,slot-surprise-pluggable", meaning > PCI surprise hotplug will be

Re: powerpc/nvram: Fix a memory leak in err path

2016-09-20 Thread Michael Ellerman
On Wed, 2015-09-12 at 10:00:53 UTC, xinhui wrote: > If kmemdup fails, We need kfree *buff* first then return -ENOMEM. > Otherwise there is a memory leak. > > Signed-off-by: Pan Xinhui > Reviewed-by: Nathan Fontenot Applied to powerpc

Re: powerpc/nvram: Fix an incorrect partition merge

2016-09-20 Thread Michael Ellerman
On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: > From: Pan Xinhui > > When we merge two contiguous partitions whose signatures are marked > NVRAM_SIG_FREE, We need update prev's length and checksum, then write it > to nvram, not cur's. So lets fix this mistake

Re: powerpc: Don't change the section in _GLOBAL()

2016-09-20 Thread Michael Ellerman
On Thu, 2016-15-09 at 00:40:20 UTC, Michael Ellerman wrote: > Currently the _GLOBAL() macro unilaterally sets the assembler section to > ".text" at the start of the macro. This is rude as the caller may be > using a different section. > > So let the caller decide which section to emit the code

Re: powerpc/64: replay hypervisor maintenance priority

2016-09-20 Thread Michael Ellerman
On Wed, 2016-14-09 at 03:01:21 UTC, Nicholas Piggin wrote: > The hmi is defined to be higher priority than other maskable > interrupts, so replay it first, as a best-effort to replay according > to hardware priorities. > > Signed-off-by: Nicholas Piggin Applied to powerpc

Re: powerpc/64s: exception optimise MSR handling

2016-09-20 Thread Michael Ellerman
On Thu, 2016-15-09 at 09:04:46 UTC, Nicholas Piggin wrote: > mtmsrd with L=1 only affects MSR_EE and MSR_RI bits, and we always > know what state those bits are, so the kernel MSR does not need to be > loaded when modifying them. > > mtmsrd is often in the critical execution path, so avoiding

Re: powerpc/pseries: fix memory leak in queue_hotplug_event() error path

2016-09-20 Thread Michael Ellerman
On Mon, 2016-19-09 at 06:41:32 UTC, Andrew Donnellan wrote: > If we fail to allocate work, we don't end up using hp_errlog_copy. Free it > in the error path. > > Signed-off-by: Andrew Donnellan > Reviewed-by: Nathan Fontenot Applied to

Re: powerpc/64s: optimise syscall entry for virtual, relocatable case

2016-09-20 Thread Michael Ellerman
On Thu, 2016-15-09 at 09:03:21 UTC, Nicholas Piggin wrote: > The mflr r10 instruction was left over saving of lr when the code used > lr to branch to system_call_entry from the exception handler. That was > changed by 6a404806d to use the count register. The value is never used > now, so mflr can

Re: powerpc: do not use kprobe section to exempt exception handlers

2016-09-20 Thread Michael Ellerman
On Thu, 2016-15-09 at 14:29:44 UTC, Nicholas Piggin wrote: > Use the blacklist macros instead. This allows the linker to move > exception handler functions close to callers and avoids trampolines in > larger kernels. > > Signed-off-by: Nicholas Piggin Applied to powerpc next,

Re: powerpc: Ensure .mem(init|exit).text are within _stext/_etext

2016-09-20 Thread Michael Ellerman
On Thu, 2016-15-09 at 05:11:59 UTC, Michael Ellerman wrote: > In our linker script we open code the list of text sections, because we > need to include the __ftr_alt sections, which are arch-specific. > > This means we can't use TEXT_TEXT as defined in vmlinux.lds.h, and so we > don't have the

Re: powerpc/64: syscall ABI

2016-09-20 Thread Michael Ellerman
On Wed, 2016-14-09 at 03:21:47 UTC, Nicholas Piggin wrote: > Add some documentation for the 64-bit syscall ABI, which doesn't seem > to be documented elsewhere. > > This attempts to documented existing practice. The only small > discrepancy is glibc clobbers not quite matching the kernel (e.g., >

Re: MAINTAINERS: Update cxl maintainers

2016-09-20 Thread Michael Ellerman
On Fri, 2016-16-09 at 04:28:44 UTC, Michael Neuling wrote: > Fred has taken over the cxl maintenance I was doing. This updates the > MAINTAINERS file to reflect this. > > It also removes a duplicate entry in the files covered. > > Signed-off-by: Michael Neuling >

Re: powerpc/mm: Update the FORCE_MAX_ZONEORDER range to enable hugetlb

2016-09-20 Thread Michael Ellerman
On Mon, 2016-19-09 at 17:31:33 UTC, "Aneesh Kumar K.V" wrote: > For hugetlb to work with 4K page size, we need the MAX_ORDER to be more > than 13. When switching from a 64K page size to 4K linux page size using > make nconfig, we endup with a CONFIG_FORCE_MAX_ZONEORDER value of 9. > This results

Re: [PATCH v6 4/7] perf annotate: Do not ignore call instruction with indirect target

2016-09-20 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 20, 2016 at 08:05:03PM +0530, Ravi Bangoria escreveu: > On Monday 19 September 2016 09:14 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Aug 19, 2016 at 06:29:35PM +0530, Ravi Bangoria escreveu: > >> Do not ignore call instruction with indirect target when its already > >> identified

Re: [PATCH v6 4/7] perf annotate: Do not ignore call instruction with indirect target

2016-09-20 Thread Ravi Bangoria
Hi Arnaldo, On Monday 19 September 2016 09:14 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 19, 2016 at 06:29:35PM +0530, Ravi Bangoria escreveu: >> Do not ignore call instruction with indirect target when its already >> identified as a call. This is an extension of commit e8ea1561952b >>

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-20 Thread Reza Arbab
On Mon, Sep 19, 2016 at 11:59:35AM +0530, Aneesh Kumar K.V wrote: Movable node also does. memblock_set_bottom_up(true); What is the impact of that. Do we need changes equivalent to that ? Also where are we marking the nodes which can be hotplugged, ie where do we do

Re: [PATCH v2 2/3] powerpc/mm: allow memory hotplug into a memoryless node

2016-09-20 Thread Reza Arbab
On Mon, Sep 19, 2016 at 09:53:49PM +1000, Balbir Singh wrote: I presume you've tested with CONFIG_NODES_SHIFT of 8 (255 nodes?) Oh yes, definitely. The large number of possible nodes does not come into play here. -- Reza Arbab