Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2018-12-05 Thread Leon Romanovsky
On Thu, Dec 06, 2018 at 03:19:51PM +1100, David Gibson wrote: > Mellanox ConnectX-5 IB cards (MT27800) seem to cause a call trace when > unbound from their regular driver and attached to vfio-pci in order to pass > them through to a guest. > > This goes away if the disable_idle_d3 option is used,

Re: [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address

2018-12-05 Thread Mike Rapoport
On Wed, Dec 05, 2018 at 04:29:40PM +0100, Michal Simek wrote: > On 03. 12. 18 16:47, Mike Rapoport wrote: > > Rather than use the memblock_alloc_base that returns a physical address and > > then convert this address to the virtual one, use appropriate memblock > > function that returns a virtual

Re: [PATCH] powerpc/ipic: Fix a bounds check in ipic_set_priority()

2018-12-05 Thread Christophe LEROY
Le 05/12/2018 à 04:26, Michael Ellerman a écrit : Hi Dan, Thanks for the patch. Dan Carpenter writes: The ipic_info[] array only has 95 elements so I have made the bounds check smaller to prevent a read overflow. It was Smatch that found this issue: arch/powerpc/sysdev/ipic.c:784

Re: [PATCH] powerpc/ipic: Remove unused ipic_set_priority()

2018-12-05 Thread Michael Ellerman
Thiago Jung Bauermann writes: > Michael Ellerman writes: > >> ipic_set_priority() has been unused since 2006 when the last usage was >> removed in commit b9f0f1bb2bca ("[POWERPC] Adapt ipic driver to new >> host_ops interface, add set_irq_type to set IRQ sense"). >> >> Reported-by: Dan

[PATCH v2] powerpc/ipic: Remove unused ipic_set_priority()

2018-12-05 Thread Michael Ellerman
ipic_set_priority() has been unused since 2006 when the last usage was removed in commit b9f0f1bb2bca ("[POWERPC] Adapt ipic driver to new host_ops interface, add set_irq_type to set IRQ sense"). Reported-by: Dan Carpenter Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/ipic.h |

Re: Patch "powerpc/function_graph: Simplify with function_graph_enter()" has been added to the 4.19-stable tree

2018-12-05 Thread kbuild test robot
Hi gregkh, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [cannot apply to v4.20-rc5 next-20181205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/gregkh

linux-next: manual merge of the akpm-current tree with the powerpc tree

2018-12-05 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm-current tree got conflicts in: arch/powerpc/include/asm/book3s/32/pgalloc.h arch/powerpc/include/asm/nohash/32/pgalloc.h arch/powerpc/mm/pgtable-book3s64.c between commits: a95d133c8643 ("powerpc/mm: Move pte_fragment_alloc() to a common

Re: [RFC PATCH] soc: fsl: guts: handle devm_kstrdup() failure

2018-12-05 Thread Nicholas Mc Guire
On Wed, Dec 05, 2018 at 02:42:55PM -0600, Li Yang wrote: > On Sun, Dec 2, 2018 at 3:07 AM Nicholas Mc Guire wrote: > > > > devm_kstrdup() may return NULL if internal allocation failed. > > soc_dev_attr.machine should be checked (although its only use > > in pr_info() would be safe even with a

[PATCH] powerpc/boot: Fix build failures with -j 1

2018-12-05 Thread Michael Ellerman
In commit 5e9dcb6188a4 ("powerpc/boot: Expose Kconfig symbols to wrapper") we added a dependency to serial.c on autoconf.h: $(obj)/serial.c: $(obj)/autoconf.h This works when building in-tree (ie. with KBUILD_OUTPUT unset) because the obj tree is the src tree. But when building with eg.

[PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2018-12-05 Thread David Gibson
Mellanox ConnectX-5 IB cards (MT27800) seem to cause a call trace when unbound from their regular driver and attached to vfio-pci in order to pass them through to a guest. This goes away if the disable_idle_d3 option is used, so it looks like a problem with the hardware handling D3 state. To fix

Re: [PATCH] tty: Use of_node_name_{eq, prefix} for node name comparisons

2018-12-05 Thread Michael Ellerman
Rob Herring writes: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For hvc, the code can also be simplified by using of_stdout pointer > instead of searching again for the stdout node. > > Cc: Benjamin

Re: [alsa-devel] [PATCH] ASoC: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Kuninori Morimoto
Hi Rob > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For the FSL ASoC card, the full node names appear to be "ssi", "esai", > and "sai", so there's not any reason to use strstr and of_node_name_eq >

Re: [PATCH v2 34/34] dt-bindings: arm: Convert ZTE board/soc bindings to json-schema

2018-12-05 Thread Shawn Guo
On Mon, Dec 03, 2018 at 03:32:23PM -0600, Rob Herring wrote: > Convert ZTE SoC bindings to DT schema format using json-schema. > > Cc: Jun Nie > Cc: Mark Rutland > Cc: linux-arm-ker...@lists.infradead.org > Cc: devicet...@vger.kernel.org > Acked-by: Shawn Guo > Signed-off-by: Rob Herring >

Re: [PATCH v2 18/34] dt-bindings: arm: Convert FSL board/soc bindings to json-schema

2018-12-05 Thread Shawn Guo
On Mon, Dec 03, 2018 at 03:32:07PM -0600, Rob Herring wrote: > Convert Freescale SoC bindings to DT schema format using json-schema. > > Cc: Shawn Guo > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/arm/armadeus.txt | 6 -

Re: [PATCH] ASoC: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Nicolin Chen
Hi Rob, On Thu, Dec 6, 2018 at 3:51 AM Rob Herring wrote: > > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For the FSL ASoC card, the full node names appear to be "ssi", "esai", > and "sai", so there's

Re: [v11 6/7] arm64: dts: ls1046a: add qdma device tree nodes

2018-12-05 Thread Shawn Guo
On Tue, Oct 30, 2018 at 10:36:03AM +0800, Peng Ma wrote: > add the qDMA device tree nodes for LS1046A devices. > > Signed-off-by: Wen He > Signed-off-by: Peng Ma > --- > change in v11: > - no > > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 21 + > 1 files

Re: [v11 5/7] arm64: dts: ls1043a: add qdma device tree nodes

2018-12-05 Thread Shawn Guo
On Tue, Oct 30, 2018 at 10:36:02AM +0800, Peng Ma wrote: > add the qDMA device tree nodes for LS1043A devices. > > Signed-off-by: Wen He > Signed-off-by: Peng Ma > --- > change in v11: > - no > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 22 ++ > 1 files

Re: [v11 4/7] arm: dts: ls1021a: add qdma device tree nodes

2018-12-05 Thread Shawn Guo
On Tue, Oct 30, 2018 at 10:36:01AM +0800, Peng Ma wrote: > add the qDMA device tree nodes for LS1021A devices. > > Signed-off-by: Wen He > Signed-off-by: Peng Ma Applied, thanks.

Re: [PATCH 2/2] fsl: add i2c controlled qixis driver

2018-12-05 Thread Li Yang
On Thu, Oct 4, 2018 at 11:03 PM Pankaj Bansal wrote: > > FPGA on LX2160AQDS/LX2160ARDB connected on I2C bus, so add qixis > driver which is basically an i2c client driver to control FPGA. Is this driver just used to print out the QIXIS version and create platform devices for all the subnodes?

Re: [PATCH kernel v4 04/19] powerpc/powernv: Move npu struct from pnv_phb to pci_controller

2018-12-05 Thread David Gibson
On Wed, Dec 05, 2018 at 05:17:57PM +1100, Alexey Kardashevskiy wrote: > > > On 05/12/2018 16:47, Alexey Kardashevskiy wrote: > > > > > > On 05/12/2018 16:14, David Gibson wrote: > >> On Fri, Nov 23, 2018 at 04:52:49PM +1100, Alexey Kardashevskiy wrote: > >>> The powernv PCI code stores NPU

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-12-05 Thread Florian Fainelli
On 12/4/18 9:47 PM, Michael Ellerman wrote: > Hi Florian, > > Florian Fainelli writes: >> +PPC folks >> >> On 11/23/18 10:20 AM, Guenter Roeck wrote: >>> On Mon, Nov 19, 2018 at 12:50:50PM -0800, Guenter Roeck wrote: On Mon, Nov 19, 2018 at 10:44:30AM -0800, Florian Fainelli wrote: > On

Re: [PATCH v2 1/6] powerpc: prefer memblock APIs returning virtual address

2018-12-05 Thread Mike Rapoport
On Wed, Dec 05, 2018 at 11:37:44PM +1100, Michael Ellerman wrote: > Mike Rapoport writes: > > On Tue, Dec 04, 2018 at 08:59:41PM +1100, Michael Ellerman wrote: > >> Hi Mike, > >> > >> Thanks for trying to clean these up. > >> > >> I think a few could be improved though ... > >> > >> Mike

Re: [PATCH v2 12/34] dt-bindings: arm: Convert Altera board/soc bindings to json-schema

2018-12-05 Thread Dinh Nguyen
On 12/3/18 3:32 PM, Rob Herring wrote: > Convert Altera SoC bindings to DT schema format using json-schema. > > Cc: Mark Rutland > Cc: Dinh Nguyen > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/arm/altera.txt| 14 - >

Re: [PATCH v2 04/34] dt-bindings: altera: Convert clkmgr binding to json-schema

2018-12-05 Thread Dinh Nguyen
On 12/3/18 3:31 PM, Rob Herring wrote: > Convert Altera clkmgr to DT schema format using json-schema. > > Cc: Mark Rutland > Cc: Dinh Nguyen > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../arm/altera/socfpga-clk-manager.txt| 11 --- >

Re: [PATCH 3/3] arch: remove redundant generic-y defines

2018-12-05 Thread Christoph Hellwig
On Wed, Dec 05, 2018 at 06:44:38AM -0800, Christoph Hellwig wrote: > On Wed, Dec 05, 2018 at 08:28:06PM +0900, Masahiro Yamada wrote: > > Now that Kbuild automatically creates asm-generic wrappers for missing > > mandatory headers, it is redundant to list the same headers in > > generic-y and

Re: [PATCH 3/3] arch: remove redundant generic-y defines

2018-12-05 Thread Christoph Hellwig
On Wed, Dec 05, 2018 at 08:28:06PM +0900, Masahiro Yamada wrote: > Now that Kbuild automatically creates asm-generic wrappers for missing > mandatory headers, it is redundant to list the same headers in > generic-y and mandatory-y. > > Suggested-by: Sam Ravnborg > Signed-off-by: Masahiro Yamada

[PATCH 3/3] arch: remove redundant generic-y defines

2018-12-05 Thread Masahiro Yamada
Now that Kbuild automatically creates asm-generic wrappers for missing mandatory headers, it is redundant to list the same headers in generic-y and mandatory-y. Suggested-by: Sam Ravnborg Signed-off-by: Masahiro Yamada --- arch/alpha/include/uapi/asm/Kbuild | 5 -

Re: [RFC PATCH] soc: fsl: guts: handle devm_kstrdup() failure

2018-12-05 Thread Li Yang
On Sun, Dec 2, 2018 at 3:07 AM Nicholas Mc Guire wrote: > > devm_kstrdup() may return NULL if internal allocation failed. > soc_dev_attr.machine should be checked (although its only use > in pr_info() would be safe even with a NULL). Therefor > in the unlikely case of allocation failure,

Re: pkeys: Reserve PKEY_DISABLE_READ

2018-12-05 Thread Ram Pai
On Wed, Dec 05, 2018 at 08:21:02AM -0800, Andy Lutomirski wrote: > > On Dec 2, 2018, at 8:02 PM, Ram Pai wrote: > > > >> On Thu, Nov 29, 2018 at 12:37:15PM +0100, Florian Weimer wrote: > >> * Dave Hansen: > >> > On 11/27/18 3:57 AM, Florian Weimer wrote: > I would have expected

Re: pkeys: Reserve PKEY_DISABLE_READ

2018-12-05 Thread Ram Pai
On Wed, Dec 05, 2018 at 02:00:59PM +0100, Florian Weimer wrote: > * Ram Pai: > > > Ok. here is a patch, compiled but not tested. See if this meets the > > specifications. > > > > --- > > > > commit

Re: [PATCH] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2018-12-05 Thread Li Yang
On Thu, Nov 22, 2018 at 2:42 PM Yi Wang wrote: > > From: Wen Yang > > Currently there are 2 problems with the ucc_of_parse_tdm function: > 1,a possible null pointer dereference in ucc_of_parse_tdm, > detected by the semantic patch deref_null.cocci, > with the following warning: >

Re: [PATCH] tty: Use of_node_name_{eq,prefix} for node name comparisons

2018-12-05 Thread David Miller
From: Rob Herring Date: Wed, 5 Dec 2018 13:50:43 -0600 > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For hvc, the code can also be simplified by using of_stdout pointer > instead of searching again

[PATCH] ASoC: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. For the FSL ASoC card, the full node names appear to be "ssi", "esai", and "sai", so there's not any reason to use strstr and of_node_name_eq can be used instead.

[PATCH] ALSA: soundbus: Remove direct OF name and type accesses

2018-12-05 Thread Rob Herring
Convert soundbus uevent and sysfs OF node name and device type usage to use printf specifier and helper functions instead of directly accessing the name and type pointers. This will allow the eventual removal of the pointers. Cc: Johannes Berg Cc: Jaroslav Kysela Cc: Takashi Iwai Cc:

[PATCH] ALSA: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. A couple of open coded iterating thru the child node names are converted to use for_each_child_of_node() instead. Cc: Johannes Berg Cc: Jaroslav Kysela Cc:

[PATCH] tty: Use of_node_name_{eq,prefix} for node name comparisons

2018-12-05 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. For hvc, the code can also be simplified by using of_stdout pointer instead of searching again for the stdout node. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras

[PATCH] PCI: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Bjorn Helgaas Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-...@vger.kernel.org

[PATCH] macintosh: Use of_node_name_{eq, prefix} for node name comparisons

2018-12-05 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_{eq,prefix} helpers instead. This removes direct access to the node name pointer. This changes a single case insensitive node name comparison to case sensitive for "ata4". This is the only instance of a case insensitive comparison for

[PATCH] ide: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. Cc: "David S. Miller" Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linux-...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org

[PATCH] i2c: powermac: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linux-...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Rob Herring

[PATCH] powerpc: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. A couple of open coded iterating thru the child node names are converted to use for_each_child_of_node() instead. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras

[PATCH] powerpc: pseries: pmem: Convert to using %pOFn instead of device_node.name

2018-12-05 Thread Rob Herring
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. pmem.c was recently added and missed the initial conversion. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org

Re: [PATCH v2 26/34] dt-bindings: arm: Convert Renesas board/soc bindings to json-schema

2018-12-05 Thread Simon Horman
On Tue, Dec 04, 2018 at 09:08:57AM -0600, Rob Herring wrote: > On Tue, Dec 4, 2018 at 8:57 AM Geert Uytterhoeven > wrote: > > > > Hi Simon, > > > > On Tue, Dec 4, 2018 at 3:48 PM Simon Horman wrote: > > > On Mon, Dec 03, 2018 at 03:32:15PM -0600, Rob Herring wrote: > > > > Convert Renesas SoC

[PATCH v2] misc: cxl: Use device_type helpers to access the node type

2018-12-05 Thread Rob Herring
Remove directly accessing device_type property and use the of_node_is_type accessor instead. While not using it here, this is part of eventually removing the struct device_node.type pointer. Cc: Frederic Barrat Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: linuxppc-dev@lists.ozlabs.org

Re: [PATCH] powerpc/ipic: Remove unused ipic_set_priority()

2018-12-05 Thread Thiago Jung Bauermann
Michael Ellerman writes: > ipic_set_priority() has been unused since 2006 when the last usage was > removed in commit b9f0f1bb2bca ("[POWERPC] Adapt ipic driver to new > host_ops interface, add set_irq_type to set IRQ sense"). > > Reported-by: Dan Carpenter > Signed-off-by: Michael Ellerman

Re: [PATCH v2 22/34] dt-bindings: arm: Convert QCom board/soc bindings to json-schema

2018-12-05 Thread Andy Gross
On Mon, Dec 03, 2018 at 03:32:11PM -0600, Rob Herring wrote: > Convert QCom SoC bindings to DT schema format using json-schema. > > Cc: Andy Gross > Cc: David Brown > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Andy Gross

Re: [PATCH RFC 7/7] mm: better document PG_reserved

2018-12-05 Thread David Hildenbrand
On 05.12.18 18:32, Matthew Wilcox wrote: > On Wed, Dec 05, 2018 at 04:05:12PM +0100, David Hildenbrand wrote: >> On 05.12.18 15:35, Matthew Wilcox wrote: >>> On Wed, Dec 05, 2018 at 01:28:51PM +0100, David Hildenbrand wrote: I don't see a reason why we have to document "Some of them might not

[PATCH v2] powerpc/32: Move the old 6xx -mcpu logic before the TARGET_CPU logic

2018-12-05 Thread Mathieu Malaterre
The code: ifdef CONFIG_6xx KBUILD_CFLAGS += -mcpu=powerpc endif was added in 2006 in commit f48b8296b315 ("[PATCH] powerpc32: Set cpu explicitly in kernel compiles"). This change was acceptable since the TARGET_CPU logic was 64-bit only. Since commit 0e00a8c9fd92 ("powerpc: Allow

Re: [v11 1/7] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT

2018-12-05 Thread Vinod Koul
On 30-10-18, 10:35, Peng Ma wrote: > From: Wen He > > This patch implement a standard macro call functions is > used to NXP dma drivers. Applied all except DTS patches, thanks -- ~Vinod

Re: [PATCH RFC 7/7] mm: better document PG_reserved

2018-12-05 Thread Matthew Wilcox
On Wed, Dec 05, 2018 at 04:05:12PM +0100, David Hildenbrand wrote: > On 05.12.18 15:35, Matthew Wilcox wrote: > > On Wed, Dec 05, 2018 at 01:28:51PM +0100, David Hildenbrand wrote: > >> I don't see a reason why we have to document "Some of them might not even > >> exist". If there is a user, we

Re: pkeys: Reserve PKEY_DISABLE_READ

2018-12-05 Thread Andy Lutomirski
> On Dec 2, 2018, at 8:02 PM, Ram Pai wrote: > >> On Thu, Nov 29, 2018 at 12:37:15PM +0100, Florian Weimer wrote: >> * Dave Hansen: >> On 11/27/18 3:57 AM, Florian Weimer wrote: I would have expected something that translates PKEY_DISABLE_WRITE | PKEY_DISABLE_READ into

Re: [PATCH v2 08/34] dt-bindings: arm: Convert PMU binding to json-schema

2018-12-05 Thread Rob Herring
On Wed, Dec 5, 2018 at 4:08 AM Will Deacon wrote: > > Hi Rob, > > On Mon, Dec 03, 2018 at 03:31:57PM -0600, Rob Herring wrote: > > Convert ARM PMU binding to DT schema format using json-schema. > > Just a couple of things below. > > > diff --git a/Documentation/devicetree/bindings/arm/pmu.yaml >

Re: [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address

2018-12-05 Thread Michal Simek
On 03. 12. 18 16:47, Mike Rapoport wrote: > Rather than use the memblock_alloc_base that returns a physical address and > then convert this address to the virtual one, use appropriate memblock > function that returns a virtual address. > > Signed-off-by: Mike Rapoport > --- >

Re: [PATCH RFC 7/7] mm: better document PG_reserved

2018-12-05 Thread David Hildenbrand
On 05.12.18 15:35, Matthew Wilcox wrote: > On Wed, Dec 05, 2018 at 01:28:51PM +0100, David Hildenbrand wrote: >> I don't see a reason why we have to document "Some of them might not even >> exist". If there is a user, we should document it. E.g. for balloon >> drivers we now use PG_offline to

Re: [PATCH RFC 7/7] mm: better document PG_reserved

2018-12-05 Thread Matthew Wilcox
On Wed, Dec 05, 2018 at 01:28:51PM +0100, David Hildenbrand wrote: > I don't see a reason why we have to document "Some of them might not even > exist". If there is a user, we should document it. E.g. for balloon > drivers we now use PG_offline to indicate that a page might currently > not be

Re: use generic DMA mapping code in powerpc V4

2018-12-05 Thread Christoph Hellwig
On Wed, Dec 05, 2018 at 10:44:05AM +0100, Christian Zigotzky wrote: > Thanks for your reply. I undid all dma mapping commits with the following > command: > > git checkout 721c01ba8b46ddb5355bd6e6b3bbfdabfdf01e97 > > After that I compiled the kernels with this code for my P5020 board (Cyrus) >

Re: [PATCH RFC 6/7] arm64: kexec: no need to ClearPageReserved()

2018-12-05 Thread James Morse
Hi David, (CC: +Akashi) On 05/12/2018 12:28, David Hildenbrand wrote: > This will already be done by free_reserved_page(). (will already be -> will be ?) So it does! > diff --git a/arch/arm64/kernel/machine_kexec.c > b/arch/arm64/kernel/machine_kexec.c > index 922add8adb74..0ef4ea73aa54

Re: [PATCH 0/2] sriov enablement on s390

2018-12-05 Thread Sebastian Ott
Hello Bjorn, On Wed, 10 Oct 2018, Bjorn Helgaas wrote: > On Wed, Oct 10, 2018 at 02:55:07PM +0200, Sebastian Ott wrote: > > On Wed, 12 Sep 2018, Bjorn Helgaas wrote: > > > On Wed, Sep 12, 2018 at 02:34:09PM +0200, Sebastian Ott wrote: > > > > On s390 we currently handle SRIOV within firmware.

Re: [PATCH RFC 0/7] mm: PG_reserved cleanups and documentation

2018-12-05 Thread David Hildenbrand
On 05.12.18 13:56, Michal Hocko wrote: > On Wed 05-12-18 13:28:44, David Hildenbrand wrote: > [...] >> Most notably, for device memory we can hopefully soon stop setting >> it PG_reserved > > I am busy as hell so I am not likely to look at specific patche this > week. But could you be more

Re: pkeys: Reserve PKEY_DISABLE_READ

2018-12-05 Thread Florian Weimer
* Ram Pai: > Ok. here is a patch, compiled but not tested. See if this meets the > specifications. > > --- > > commit 3dc06e73f3795921265d5d1d935e428deab01616 > Author: Ram Pai > Date: Tue Dec 4 00:04:11 2018 -0500

Re: [PATCH RFC 7/7] mm: better document PG_reserved

2018-12-05 Thread Michal Hocko
On Wed 05-12-18 13:28:51, David Hildenbrand wrote: > The usage of PG_reserved and how PG_reserved pages are to be treated is > burried deep down in different parts of the kernel. Let's shine some light > onto these details by documenting (most?) current users and expected > behavior. > > I don't

Re: [PATCH RFC 0/7] mm: PG_reserved cleanups and documentation

2018-12-05 Thread Michal Hocko
On Wed 05-12-18 13:28:44, David Hildenbrand wrote: [...] > Most notably, for device memory we can hopefully soon stop setting > it PG_reserved I am busy as hell so I am not likely to look at specific patche this week. But could you be more specific why we need to get rid of other PG_reserved

Re: [PATCH v2 1/6] powerpc: prefer memblock APIs returning virtual address

2018-12-05 Thread Michael Ellerman
Mike Rapoport writes: > On Tue, Dec 04, 2018 at 08:59:41PM +1100, Michael Ellerman wrote: >> Hi Mike, >> >> Thanks for trying to clean these up. >> >> I think a few could be improved though ... >> >> Mike Rapoport writes: >> > diff --git a/arch/powerpc/kernel/paca.c

[PATCH RFC 7/7] mm: better document PG_reserved

2018-12-05 Thread David Hildenbrand
The usage of PG_reserved and how PG_reserved pages are to be treated is burried deep down in different parts of the kernel. Let's shine some light onto these details by documenting (most?) current users and expected behavior. I don't see a reason why we have to document "Some of them might not

[PATCH RFC 6/7] arm64: kexec: no need to ClearPageReserved()

2018-12-05 Thread David Hildenbrand
This will already be done by free_reserved_page(). Cc: Catalin Marinas Cc: Will Deacon Cc: Bhupesh Sharma Cc: James Morse Cc: Marc Zyngier Cc: Dave Kleikamp Cc: Mark Rutland Cc: Andrew Morton Cc: Michal Hocko Cc: Matthew Wilcox Signed-off-by: David Hildenbrand ---

[PATCH RFC 5/7] m68k/mm: use __ClearPageReserved()

2018-12-05 Thread David Hildenbrand
The PG_reserved flag is cleared from memory that is part of the kernel image (and therefore marked as PG_reserved). Avoid using PG_reserved directly. Cc: Geert Uytterhoeven Cc: Andrew Morton Cc: Michal Hocko Cc: Matthew Wilcox Signed-off-by: David Hildenbrand --- arch/m68k/mm/memory.c | 2

[PATCH RFC 4/7] riscv/vdso: don't clear PG_reserved

2018-12-05 Thread David Hildenbrand
The VDSO is part of the kernel image and therefore the struct pages are marked as reserved during boot. As we install a special mapping, the actual struct pages will never be exposed to MM via the page tables. We can therefore leave the pages marked as reserved. Cc: Palmer Dabbelt Cc: Albert Ou

[PATCH RFC 3/7] powerpc/vdso: don't clear PG_reserved

2018-12-05 Thread David Hildenbrand
The VDSO is part of the kernel image and therefore the struct pages are marked as reserved during boot. As we install a special mapping, the actual struct pages will never be exposed to MM via the page tables. We can therefore leave the pages marked as reserved. Cc: Benjamin Herrenschmidt Cc:

[PATCH RFC 2/7] s390/vdso: don't clear PG_reserved

2018-12-05 Thread David Hildenbrand
The VDSO is part of the kernel image and therefore the struct pages are marked as reserved during boot. As we install a special mapping, the actual struct pages will never be exposed to MM via the page tables. We can therefore leave the pages marked as reserved. Suggested-by: Martin Schwidefsky

[PATCH RFC 1/7] agp: efficeon: no need to set PG_reserved on GATT tables

2018-12-05 Thread David Hildenbrand
The l1 GATT page table is kept in a special on-chip page with 64 entries. We allocate the l2 page table pages via get_zeroed_page() and enter them into the table. These l2 pages are modified accordingly when inserting/removing memory via efficeon_insert_memory and efficeon_remove_memory. Apart

[PATCH RFC 0/7] mm: PG_reserved cleanups and documentation

2018-12-05 Thread David Hildenbrand
I was recently going over all users of PG_reserved. Short story: it is difficult and sometimes not really clear if setting/checking for PG_reserved is only a relict from the past. Easy to break things. I had way more cleanups in this series inititally, but some architectures take PG_reserved as a

[PATCH] powerpc/ipic: Remove unused ipic_set_priority()

2018-12-05 Thread Michael Ellerman
ipic_set_priority() has been unused since 2006 when the last usage was removed in commit b9f0f1bb2bca ("[POWERPC] Adapt ipic driver to new host_ops interface, add set_irq_type to set IRQ sense"). Reported-by: Dan Carpenter Signed-off-by: Michael Ellerman --- arch/powerpc/sysdev/ipic.c | 28

Re: [PATCH] powerpc: split compat syscall table out from native table

2018-12-05 Thread Michael Ellerman
Arnd Bergmann writes: > PowerPC uses a syscall table with native and compat calls interleaved, > which is a slightly simpler way to define two matching tables. > > As we move to having the tables generated, that advantage is no longer > important, but the interleaved table gets in the way of

Re: [PATCH] powerpc/ipic: Fix a bounds check in ipic_set_priority()

2018-12-05 Thread Julia Lawall
On Wed, 5 Dec 2018, Michael Ellerman wrote: > Julia Lawall writes: > > On Wed, 5 Dec 2018, Michael Ellerman wrote: > > > >> Hi Dan, > >> > >> Thanks for the patch. > >> > >> Dan Carpenter writes: > >> > The ipic_info[] array only has 95 elements so I have made the bounds > >> > check smaller

Re: [PATCH] powerpc/ipic: Fix a bounds check in ipic_set_priority()

2018-12-05 Thread Michael Ellerman
Julia Lawall writes: > On Wed, 5 Dec 2018, Michael Ellerman wrote: > >> Hi Dan, >> >> Thanks for the patch. >> >> Dan Carpenter writes: >> > The ipic_info[] array only has 95 elements so I have made the bounds >> > check smaller to prevent a read overflow. It was Smatch that found >> > this

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-12-05 Thread Lubomir Rintel
On Wed, 2018-12-05 at 17:01 +0530, Anshuman Khandual wrote: > > On 12/05/2018 02:56 AM, Lubomir Rintel wrote: > > On Mon, 2018-11-26 at 17:56 +0530, Anshuman Khandual wrote: > > > At present there are multiple places where invalid node number is encoded > > > as -1. Even though implicitly

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-12-05 Thread Anshuman Khandual
On 12/05/2018 02:56 AM, Lubomir Rintel wrote: > On Mon, 2018-11-26 at 17:56 +0530, Anshuman Khandual wrote: >> At present there are multiple places where invalid node number is encoded >> as -1. Even though implicitly understood it is always better to have macros >> in there. Replace these open

Re: [LKP] [mm] 19717e78a0: stderr.if(target_node==NUMA_NO_NODE){

2018-12-05 Thread Anshuman Khandual
On 12/05/2018 10:30 AM, kernel test robot wrote: > FYI, we noticed the following commit (built with gcc-7): > > commit: 19717e78a04d51512cf0e7b9b09c61f06b2af071 ("[PATCH V2] mm: Replace all > open encodings for NUMA_NO_NODE") > url: >

Re: [PATCH v2 08/34] dt-bindings: arm: Convert PMU binding to json-schema

2018-12-05 Thread Will Deacon
Hi Rob, On Mon, Dec 03, 2018 at 03:31:57PM -0600, Rob Herring wrote: > Convert ARM PMU binding to DT schema format using json-schema. Just a couple of things below. > diff --git a/Documentation/devicetree/bindings/arm/pmu.yaml > b/Documentation/devicetree/bindings/arm/pmu.yaml > new file mode

Re: use generic DMA mapping code in powerpc V4

2018-12-05 Thread Christian Zigotzky
On 04 December 2018 at 3:24PM, Christoph Hellwig wrote: On Tue, Dec 04, 2018 at 10:53:39AM +0100, Christian Zigotzky wrote: I don't know why this kernel doesn't recognize the hard disks connected to my physical P5020 board and why the onboard ethernet on my PASEMI board doesn't work.

Re: [PATCH] powerpc/ipic: Fix a bounds check in ipic_set_priority()

2018-12-05 Thread Julia Lawall
On Wed, 5 Dec 2018, Michael Ellerman wrote: > Hi Dan, > > Thanks for the patch. > > Dan Carpenter writes: > > The ipic_info[] array only has 95 elements so I have made the bounds > > check smaller to prevent a read overflow. It was Smatch that found > > this issue: > > > >