[PATCH] powerpc/perf: Fix reading of MSR[HV PR] bits in trace-imc

2020-08-25 Thread Athira Rajeev
IMC trace-mode uses MSR[HV PR] bits to set the cpumode for the instruction pointer captured in each sample. The bits are fetched from third DW of the trace record. Reading third DW from IMC trace record should use be64_to_cpu along with READ_ONCE inorder to fetch correct MSR[HV PR] bits. Patch addr

Re: fsl_espi errors on v5.7.15

2020-08-25 Thread Heiner Kallweit
On 26.08.2020 08:07, Chris Packham wrote: > > On 26/08/20 1:48 pm, Chris Packham wrote: >> >> On 26/08/20 10:22 am, Chris Packham wrote: >>> On 25/08/20 7:22 pm, Heiner Kallweit wrote: >>> >>> I've been staring at spi-fsl-espi.c for while now and I think I've > identified a couple of def

Re: fsl_espi errors on v5.7.15

2020-08-25 Thread Chris Packham
On 26/08/20 1:48 pm, Chris Packham wrote: > > On 26/08/20 10:22 am, Chris Packham wrote: >> On 25/08/20 7:22 pm, Heiner Kallweit wrote: >> >> >>> I've been staring at spi-fsl-espi.c for while now and I think I've identified a couple of deficiencies that may or may not be related to my

Re: fsl_espi errors on v5.7.15

2020-08-25 Thread Chris Packham
On 26/08/20 10:22 am, Chris Packham wrote: > On 25/08/20 7:22 pm, Heiner Kallweit wrote: > > >> I've been staring at spi-fsl-espi.c for while now and I think I've >>> identified a couple of deficiencies that may or may not be related >>> to my >>> issue. >>> >>> First I think the 'Transfer done

Re: [PATCH net v3] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread Mingming Cao
> On Aug 25, 2020, at 5:31 PM, David Miller wrote: > > From: Dany Madden > Date: Tue, 25 Aug 2020 13:26:41 -0400 > >> From: Mingming Cao >> >> At the time of do_rest, ibmvnic tries to re-initalize the tx_pools >> and rx_pools to avoid re-allocating the long term buffer. However >> there is

Re: [PATCH net v3] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread David Miller
From: Dany Madden Date: Tue, 25 Aug 2020 13:26:41 -0400 > From: Mingming Cao > > At the time of do_rest, ibmvnic tries to re-initalize the tx_pools > and rx_pools to avoid re-allocating the long term buffer. However > there is a window inside do_reset that the tx_pools and > rx_pools were freed

Re: [RFT][PATCH 0/7] Avoid overflow at boundary_size

2020-08-25 Thread Nicolin Chen
Hi Niklas, On Tue, Aug 25, 2020 at 12:16:27PM +0200, Niklas Schnelle wrote: > On 8/21/20 1:19 AM, Nicolin Chen wrote: > > We are expending the default DMA segmentation boundary to its > > possible maximum value (ULONG_MAX) to indicate that a device > > doesn't specify a boundary limit. So all dma_

Please apply commit 0828137e8f16 ("powerpc/64s: Don't init FSCR_DSCR in __init_FSCR()") to v4.14.y, v4.19.y, v5.4.y, v5.7.y

2020-08-25 Thread Thadeu Lima de Souza Cascardo
After commit 912c0a7f2b5daa3cbb2bc10f303981e493de73bd ("powerpc/64s: Save FSCR to init_task.thread.fscr after feature init"), which has been applied to the referred branches, when userspace sets the user DSCR MSR, it won't be inherited or restored during context switch, because the facility unavail

Re: fsl_espi errors on v5.7.15

2020-08-25 Thread Chris Packham
On 25/08/20 7:22 pm, Heiner Kallweit wrote: > I've been staring at spi-fsl-espi.c for while now and I think I've >> identified a couple of deficiencies that may or may not be related to my >> issue. >> >> First I think the 'Transfer done but SPIE_DON isn't set' message can be >> generated spuriou

Re: [PATCH net v2] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread Mingming Cao
On Aug 25, 2020, at 10:08 AM, David Miller wrote:From: Dany Madden Date: Tue, 25 Aug 2020 12:56:06 -0400@@ -2011,7 +2017,10 @@ static int do_reset(struct ibmvnic_adapter *adapter,    adapter->req_rx_add_entries_per_subcrq !=    old_num_rx_slots ||    adapter->req_tx_entries_per_subcrq !=-

[PATCH net v3] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread Dany Madden
From: Mingming Cao At the time of do_rest, ibmvnic tries to re-initalize the tx_pools and rx_pools to avoid re-allocating the long term buffer. However there is a window inside do_reset that the tx_pools and rx_pools were freed before re-initialized making it possible to deference null pointers.

Re: [PATCH net v2] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread David Miller
From: Dany Madden Date: Tue, 25 Aug 2020 12:56:06 -0400 > @@ -2011,7 +2017,10 @@ static int do_reset(struct ibmvnic_adapter *adapter, > adapter->req_rx_add_entries_per_subcrq != > old_num_rx_slots || > adapter->req_tx_entries_per_subcrq != > -

[PATCH net v2] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread Dany Madden
From: Mingming Cao At the time of do_rest, ibmvnic tries to re-initalize the tx_pools and rx_pools to avoid re-allocating the long term buffer. However there is a window inside do_reset that the tx_pools and rx_pools were freed before re-initialized making it possible to deference null pointers.

[PATCH v7 12/12] powerpc/64s/radix: Enable huge vmalloc mappings

2020-08-25 Thread Nicholas Piggin
Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Nicholas Piggin --- Documentation/admin-guide/kernel-parameters.txt | 2 ++ arch/powerpc/Kconfig| 1 + 2 files changed, 3 insertions(+) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin

[PATCH v7 11/12] mm/vmalloc: Hugepage vmalloc mappings

2020-08-25 Thread Nicholas Piggin
Support huge page vmalloc mappings. Config option HAVE_ARCH_HUGE_VMALLOC enables support on architectures that define HAVE_ARCH_HUGE_VMAP and supports PMD sized vmap mappings. vmalloc will attempt to allocate PMD-sized pages if allocating PMD size or larger, and fall back to small pages if that wa

[PATCH v7 10/12] mm/vmalloc: add vmap_range_noflush variant

2020-08-25 Thread Nicholas Piggin
As a side-effect, the order of flush_cache_vmap() and arch_sync_kernel_mappings() calls are switched, but that now matches the other callers in this file. Signed-off-by: Nicholas Piggin --- mm/vmalloc.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/mm/vmal

[PATCH v7 09/12] mm: Move vmap_range from mm/ioremap.c to mm/vmalloc.c

2020-08-25 Thread Nicholas Piggin
This is a generic kernel virtual memory mapper, not specific to ioremap. Signed-off-by: Nicholas Piggin --- include/linux/vmalloc.h | 3 + mm/ioremap.c| 197 mm/vmalloc.c| 196 +++ 3 files chan

[PATCH v7 08/12] x86: inline huge vmap supported functions

2020-08-25 Thread Nicholas Piggin
This allows unsupported levels to be constant folded away, and so p4d_free_pud_page can be removed because it's no longer linked to. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x...@kernel.org Cc: "H. Peter Anvin" Signed-off-by: Nicholas Piggin --- Ack or objection if this go

[PATCH v7 07/12] arm64: inline huge vmap supported functions

2020-08-25 Thread Nicholas Piggin
This allows unsupported levels to be constant folded away, and so p4d_free_pud_page can be removed because it's no longer linked to. Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Nicholas Piggin --- Ack or objection if this goes via the -mm tree?

[PATCH v7 06/12] powerpc: inline huge vmap supported functions

2020-08-25 Thread Nicholas Piggin
This allows unsupported levels to be constant folded away, and so p4d_free_pud_page can be removed because it's no longer linked to. Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Nicholas Piggin --- Ack or objection if this goes via the -mm tree? arch/powerpc/include/asm/vmalloc.h |

[PATCH v7 05/12] mm: HUGE_VMAP arch support cleanup

2020-08-25 Thread Nicholas Piggin
This changes the awkward approach where architectures provide init functions to determine which levels they can provide large mappings for, to one where the arch is queried for each call. This removes code and indirection, and allows constant-folding of dead code for unsupported levels. This also

[PATCH v7 04/12] mm/ioremap: rename ioremap_*_range to vmap_*_range

2020-08-25 Thread Nicholas Piggin
This will be used as a generic kernel virtual mapping function, so re-name it in preparation. Signed-off-by: Nicholas Piggin --- mm/ioremap.c | 64 +++- 1 file changed, 33 insertions(+), 31 deletions(-) diff --git a/mm/ioremap.c b/mm/ioremap.c ind

[PATCH v7 03/12] mm/vmalloc: rename vmap_*_range vmap_pages_*_range

2020-08-25 Thread Nicholas Piggin
The vmalloc mapper operates on a struct page * array rather than a linear physical address, re-name it to make this distinction clear. Signed-off-by: Nicholas Piggin --- mm/vmalloc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c

[PATCH v7 02/12] mm: apply_to_pte_range warn and fail if a large pte is encountered

2020-08-25 Thread Nicholas Piggin
apply_to_pte_range might mistake a large pte for bad, or treat it as a page table, resulting in a crash or corruption. Add a test to warn and return error if large entries are found. Signed-off-by: Nicholas Piggin --- mm/memory.c | 60 +++-- 1 file

[PATCH v7 01/12] mm/vmalloc: fix vmalloc_to_page for huge vmap mappings

2020-08-25 Thread Nicholas Piggin
vmalloc_to_page returns NULL for addresses mapped by larger pages[*]. Whether or not a vmap is huge depends on the architecture details, alignments, boot options, etc., which the caller can not be expected to know. Therefore HUGE_VMAP is a regression for vmalloc_to_page. This change teaches vmallo

[PATCH v7 00/12] huge vmalloc mappings

2020-08-25 Thread Nicholas Piggin
I think it's ready to go into -mm if it gets acks for the arch changes. Thanks, Nick Since v6: - Fixed a false positive warning introduced in patch 2, found by kbuild test robot. Since v5: - Split arch changes out better and make the constant folding work - Avoid most of the 80 column wrap, fi

Re: [PATCH 17/29] fs_enet: Avoid comma separated statements

2020-08-25 Thread David Miller
From: Joe Perches Date: Mon, 24 Aug 2020 21:56:14 -0700 > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied.

Re: [PATCH v8 2/8] powerpc/vdso: Remove __kernel_datapage_offset and simplify __get_datapage()

2020-08-25 Thread Christophe Leroy
Le 04/08/2020 à 13:17, Christophe Leroy a écrit : On 07/16/2020 02:59 AM, Michael Ellerman wrote: Christophe Leroy writes: The VDSO datapage and the text pages are always located immediately next to each other, so it can be hardcoded without an indirection through __kernel_datapage_offset

[PATCH v1 8/9] powerpc/vdso: Remove __kernel_datapage_offset and simplify __get_datapage()

2020-08-25 Thread Christophe Leroy
The VDSO datapage and the text pages are always located immediately next to each other, so it can be hardcoded without an indirection through __kernel_datapage_offset Before: clock-getres-realtime-coarse:vdso: 714 nsec/call clock-gettime-realtime-coarse:vdso: 792 nsec/call clock-gettime-re

[PATCH v1 6/9] powerpc/vdso: Provide vdso_remap()

2020-08-25 Thread Christophe Leroy
Provide vdso_remap() through _install_special_mapping() and drop arch_remap(). This adds a test of the size and returns -EINVAL if the size is not correct. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/mm-arch-hooks.h | 25 - arch/powerpc/kernel/vdso.c

[PATCH v1 7/9] powerpc/vdso: Move vdso datapage up front

2020-08-25 Thread Christophe Leroy
Move the vdso datapage in front of the VDSO area, before vdso test. This will allow to remove the __kernel_datapage_offset symbol and simplify __get_datapage() in the following patch. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/mmu_context.h | 4 +++- arch/powerpc/kernel/vdso.

[PATCH v1 9/9] powerpc/vdso: Remove unused \tmp param in __get_datapage()

2020-08-25 Thread Christophe Leroy
The \tmp param is not used anymore, remove it. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/vdso/gettimeofday.h | 4 ++-- arch/powerpc/include/asm/vdso_datapage.h | 2 +- arch/powerpc/kernel/vdso32/cacheflush.S | 2 +- arch/powerpc/kernel/vdso32/datapage.S| 4 ++-

[PATCH v1 5/9] powerpc/vdso: move to _install_special_mapping() and remove arch_vma_name()

2020-08-25 Thread Christophe Leroy
>From commit 2fea7f6c98f5 ("arm64: vdso: move to _install_special_mapping and remove arch_vma_name"). Use the new _install_special_mapping() API added by commit a62c34bd2a8a ("x86, mm: Improve _install_special_mapping and fix x86 vdso naming") which obsolete install_special_mapping(). And remove

[PATCH v1 4/9] powerpc/vdso: Remove unnecessary ifdefs in vdso_pagelist initialization

2020-08-25 Thread Christophe Leroy
No need of all those #ifdefs around the pagelist initialisation, use IS_ENABLED(), GCC will kick out unused static variables. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/vdso.c | 57 +++--- 1 file changed, 22 insertions(+), 35 deletions(-) diff --git

[PATCH v1 2/9] powerpc/vdso: Remove get_page() in vdso_pagelist initialization

2020-08-25 Thread Christophe Leroy
Partly copied from commit 16fb1a9bec61 ("arm64: vdso: clean up vdso_pagelist initialization"). No need to get_page() the vdso text/data - these are part of the kernel image. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/vdso.c | 18 ++ 1 file changed, 6 insertions(+),

[PATCH v1 3/9] powerpc/vdso: Remove NULL termination element in vdso_pagelist

2020-08-25 Thread Christophe Leroy
No need of a NULL last element in pagelists, install_special_mapping() knows how long the list is. Remove that element. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/vdso.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/vdso.c b/arch

[PATCH v1 1/9] powerpc/vdso: Remove BUG_ON() in vdso_init()

2020-08-25 Thread Christophe Leroy
If we are not able to allocate memory for the pagelists, bail out. There is no reason to crash the machine, just have vdso init fail. Signed-off-by: Christophe Leroy --- This series is based on top of the series switching to C VDSO implementation, but in fact only the last patch depends on that

Re: [PATCH net] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread Brian W Hart
On Mon, Aug 24, 2020 at 07:49:23PM -0400, Dany Madden wrote: > From: Mingming Cao > > At the time of do_reset, ibmvnic tries to re-initalize the tx_pools > and rx_pools to avoid re-allocating the long term buffer. However > there is a window inside do_reset that the tx_pools and > rx_pools were f

Re: [PATCH] powerpc: Update documentation of ISA versions for Power10

2020-08-25 Thread Jordan Niethe
On Tue, Aug 25, 2020 at 10:41 PM Gabriel Paubert wrote: > > On Tue, Aug 25, 2020 at 09:45:07PM +1000, Jordan Niethe wrote: > > Update the CPU to ISA Version Mapping document to include Power10 and > > ISA v3.1. > > > > Signed-off-by: Jordan Niethe > > --- > > Documentation/powerpc/isa-versions.r

[PATCH v11 5/5] powerpc/vdso: Provide __kernel_clock_gettime64() on vdso32

2020-08-25 Thread Christophe Leroy
Provides __kernel_clock_gettime64() on vdso32. This is the 64 bits version of __kernel_clock_gettime() which is y2038 compliant. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/vdso32/gettimeofday.S | 9 + arch/powerpc/kernel/vdso32/vdso32.lds.S| 1 + arch/powerpc/kernel/vds

[PATCH v11 4/5] powerpc/vdso: Switch VDSO to generic C implementation.

2020-08-25 Thread Christophe Leroy
For VDSO32 on PPC64, we create a fake 32 bits config, on the same principle as MIPS architecture, in order to get the correct parts of the different asm header files. With the C VDSO, the performance is slightly lower, but it is worth it as it will ease maintenance and evolution, and also brings c

[PATCH v11 3/5] powerpc/vdso: Save and restore TOC pointer on PPC64

2020-08-25 Thread Christophe Leroy
On PPC64, the TOC pointer needs to be saved and restored. Suggested-by: Michael Ellerman Signed-off-by: Christophe Leroy --- v9: New. I'm not sure this is really needed, I can't see the VDSO C code doing anything with r2, at least on ppc64_defconfig. So I let you decide whether you take it or

[PATCH v11 1/5] powerpc/processor: Move cpu_relax() into asm/vdso/processor.h

2020-08-25 Thread Christophe Leroy
cpu_relax() need to be in asm/vdso/processor.h to be used by the C VDSO generic library. Move it there. Signed-off-by: Christophe Leroy --- v9: Forgot to remove cpu_relax() from processor.h in v8 --- arch/powerpc/include/asm/processor.h | 13 ++--- arch/powerpc/include/asm/vdso/pro

[PATCH v11 0/5] powerpc: switch VDSO to C implementation

2020-08-25 Thread Christophe Leroy
This is the tenth version of a series to switch powerpc VDSO to generic C implementation. Changes in v11: - Rebased to today's powerpc/merge branch - Prototype of __arch_get_hw_counter() was modified in mainline (patch 2) Changes in v10 are: - Added a comment explaining the reason for the double

[PATCH v11 2/5] powerpc/vdso: Prepare for switching VDSO to generic C implementation.

2020-08-25 Thread Christophe Leroy
Prepare for switching VDSO to generic C implementation in following patch. Here, we: - Prepare the helpers to call the C VDSO functions - Prepare the required callbacks for the C VDSO functions - Prepare the clocksource.h files to define VDSO_ARCH_CLOCKMODES - Add the C trampolines to the generic C

[PATCH V2] ASoC: fsl: imx-es8328: add missing put_device() call in imx_es8328_probe()

2020-08-25 Thread Yu Kuai
if of_find_device_by_node() succeed, imx_es8328_probe() doesn't have a corresponding put_device(). Thus add a jump target to fix the exception handling for this function implementation. Fixes: 7e7292dba215 ("ASoC: fsl: add imx-es8328 machine driver") Signed-off-by: Yu Kuai --- Changes from V1: -

Re: [PATCH 1/2] ASoC: fsl: imx-es8328: add missing kfree() call in imx_es8328_probe()

2020-08-25 Thread yukuai (C)
On 2020/08/25 20:11, Mark Brown wrote: On Tue, Aug 25, 2020 at 08:05:30PM +0800, Yu Kuai wrote: If memory allocation for 'data' or 'comp' succeed, imx_es8328_probe() doesn't have corresponding kfree() in exception handling. Thus add kfree() for this function implementation. @@ -151,7 +151,7

[PATCH 2/2] ASoC: fsl: imx-es8328: add missing put_device() call in imx_es8328_probe()

2020-08-25 Thread Yu Kuai
if of_find_device_by_node() succeed, imx_es8328_probe() doesn't have a corresponding put_device(). Thus add a jump target to fix the exception handling for this function implementation. Fixes: 7e7292dba215 ("ASoC: fsl: add imx-es8328 machine driver") Signed-off-by: Yu Kuai --- sound/soc/fsl/imx-

[PATCH 0/2] do exception handling appropriately in imx_es8328_probe()

2020-08-25 Thread Yu Kuai
Yu Kuai (2): ASoC: fsl: imx-es8328: add missing kfree() call in imx_es8328_probe() ASoC: fsl: imx-es8328: add missing put_device() call in imx_es8328_probe() sound/soc/fsl/imx-es8328.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) -- 2.25.4

[PATCH 1/2] ASoC: fsl: imx-es8328: add missing kfree() call in imx_es8328_probe()

2020-08-25 Thread Yu Kuai
If memory allocation for 'data' or 'comp' succeed, imx_es8328_probe() doesn't have corresponding kfree() in exception handling. Thus add kfree() for this function implementation. Fixes: 7e7292dba215 ("ASoC: fsl: add imx-es8328 machine driver") Signed-off-by: Yu Kuai --- sound/soc/fsl/imx-es8328.

Re: [PATCH] powerpc: Update documentation of ISA versions for Power10

2020-08-25 Thread Gabriel Paubert
On Tue, Aug 25, 2020 at 09:45:07PM +1000, Jordan Niethe wrote: > Update the CPU to ISA Version Mapping document to include Power10 and > ISA v3.1. > > Signed-off-by: Jordan Niethe > --- > Documentation/powerpc/isa-versions.rst | 4 > 1 file changed, 4 insertions(+) > > diff --git a/Documen

Re: [PATCH 1/2] ASoC: fsl: imx-es8328: add missing kfree() call in imx_es8328_probe()

2020-08-25 Thread Mark Brown
On Tue, Aug 25, 2020 at 08:05:30PM +0800, Yu Kuai wrote: > If memory allocation for 'data' or 'comp' succeed, imx_es8328_probe() > doesn't have corresponding kfree() in exception handling. Thus add > kfree() for this function implementation. > @@ -151,7 +151,7 @@ static int imx_es8328_probe(struct

Re: [PATCH v5 5/8] powerpc/watchpoint: Fix exception handling for CONFIG_HAVE_HW_BREAKPOINT=N

2020-08-25 Thread Christophe Leroy
Le 25/08/2020 à 13:07, Ravi Bangoria a écrit : Hi Christophe, diff --git a/arch/powerpc/kernel/ptrace/ptrace-noadv.c b/arch/powerpc/kernel/ptrace/ptrace-noadv.c index 57a0ab822334..866597b407bc 100644 --- a/arch/powerpc/kernel/ptrace/ptrace-noadv.c +++ b/arch/powerpc/kernel/ptrace/ptrace-no

Re: [PATCH v5 4/8] powerpc/watchpoint: Move DAWR detection logic outside of hw_breakpoint.c

2020-08-25 Thread Christophe Leroy
Le 25/08/2020 à 13:08, Ravi Bangoria a écrit : Hi Christophe, +static int cache_op_size(void) +{ +#ifdef __powerpc64__ +    return ppc64_caches.l1d.block_size; +#else +    return L1_CACHE_BYTES; +#endif +} You've got l1_dcache_bytes() in arch/powerpc/include/asm/cache.h to do that. + +

[PATCH] powerpc: Update documentation of ISA versions for Power10

2020-08-25 Thread Jordan Niethe
Update the CPU to ISA Version Mapping document to include Power10 and ISA v3.1. Signed-off-by: Jordan Niethe --- Documentation/powerpc/isa-versions.rst | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/powerpc/isa-versions.rst b/Documentation/powerpc/isa-versions.rst index a

Re: [PATCH v5 4/8] powerpc/watchpoint: Move DAWR detection logic outside of hw_breakpoint.c

2020-08-25 Thread Ravi Bangoria
Hi Christophe, +static int cache_op_size(void) +{ +#ifdef __powerpc64__ +    return ppc64_caches.l1d.block_size; +#else +    return L1_CACHE_BYTES; +#endif +} You've got l1_dcache_bytes() in arch/powerpc/include/asm/cache.h to do that. + +void wp_get_instr_detail(struct pt_regs *regs, struct

Re: [PATCH v5 5/8] powerpc/watchpoint: Fix exception handling for CONFIG_HAVE_HW_BREAKPOINT=N

2020-08-25 Thread Ravi Bangoria
Hi Christophe, diff --git a/arch/powerpc/kernel/ptrace/ptrace-noadv.c b/arch/powerpc/kernel/ptrace/ptrace-noadv.c index 57a0ab822334..866597b407bc 100644 --- a/arch/powerpc/kernel/ptrace/ptrace-noadv.c +++ b/arch/powerpc/kernel/ptrace/ptrace-noadv.c @@ -286,11 +286,16 @@ long ppc_del_hwdebug(st

Re: [RFT][PATCH 0/7] Avoid overflow at boundary_size

2020-08-25 Thread Niklas Schnelle
On 8/21/20 1:19 AM, Nicolin Chen wrote: > We are expending the default DMA segmentation boundary to its > possible maximum value (ULONG_MAX) to indicate that a device > doesn't specify a boundary limit. So all dma_get_seg_boundary > callers should take a precaution with the return values since >

Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe

2020-08-25 Thread Joakim Tjernlund
On Tue, 2020-08-25 at 11:53 +0300, Felipe Balbi wrote: Joakim Tjernlund mailto:joakim.tjernl...@infinera.com>> writes: > On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote: >> Joakim Tjernlund >> mailto:joakim.tjernl...@infinera.com>> writes: >> >> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH

Re: [PATCH v5 5/8] powerpc/watchpoint: Fix exception handling for CONFIG_HAVE_HW_BREAKPOINT=N

2020-08-25 Thread Christophe Leroy
Le 25/08/2020 à 06:36, Ravi Bangoria a écrit : On powerpc, ptrace watchpoint works in one-shot mode. i.e. kernel disables event every time it fires and user has to re-enable it. Also, in case of ptrace watchpoint, kernel notifies ptrace user before executing instruction. With CONFIG_HAVE_HW_B

[PATCH] powerpc/64s: Fix crash in load_fp_state() due to fpexc_mode

2020-08-25 Thread Michael Ellerman
The recent commit 01eb01877f33 ("powerpc/64s: Fix restore_math unnecessarily changing MSR") changed some of the handling of floating point/vector restore. In particular it caused current->thread.fpexc_mode to be copied into the current MSR (via msr_check_and_set()), rather than just into regs->msr

Re: [PATCH v5 4/8] powerpc/watchpoint: Move DAWR detection logic outside of hw_breakpoint.c

2020-08-25 Thread Christophe Leroy
Le 25/08/2020 à 06:36, Ravi Bangoria a écrit : Power10 hw has multiple DAWRs but hw doesn't tell which DAWR caused the exception. So we have a sw logic to detect that in hw_breakpoint.c. But hw_breakpoint.c gets compiled only with CONFIG_HAVE_HW_BREAKPOINT=Y. Move DAWR detection logic outside

Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe

2020-08-25 Thread Felipe Balbi
Joakim Tjernlund writes: > On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote: >> Joakim Tjernlund writes: >> >> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: >> > > >> > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: >> > > > Signed-off-by: Ye Bin >> > > >> > > I can't t

Re: Build regressions/improvements in v5.9-rc2

2020-08-25 Thread Geert Uytterhoeven
On Tue, Aug 25, 2020 at 10:23 AM Geert Uytterhoeven wrote: > JFYI, when comparing v5.9-rc2[1] to v5.9-rc1[3], the summaries are: > - build errors: +12/-0 + /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c: error: implicit declaration of function 'disable_kernel_vsx' [-We

[PATCH] powerpc/pseries: add new branch prediction security bits for link stack

2020-08-25 Thread Nicholas Piggin
The hypervisor interface has defined branch prediction security bits for handling the link stack. Wire them up. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/hvcall.h | 2 ++ arch/powerpc/platforms/pseries/setup.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/arch

[PATCH] powerpc/64s: handle ISA v3.1 local copy-paste context switches

2020-08-25 Thread Nicholas Piggin
The ISA v3.1 the copy-paste facility has a new memory move functionality which allows the copy buffer to be pasted to domestic memory (RAM) as opposed to foreign memory (accelerator). This means the POWER9 trick of avoiding the cp_abort on context switch if the process had not mapped foreign memor

[PATCH] powerpc/64s: Add cp_abort after tlbiel to invalidate copy-buffer address

2020-08-25 Thread Nicholas Piggin
The copy buffer is implemented as a real address in the nest which is translated from EA by copy, and used for memory access by paste. This requires that it be invalidated by TLB invalidation. TLBIE does invalidate the copy buffer, but TLBIEL does not. Add cp_abort to the tlbiel sequence. Signed-

[PATCH] powerpc/64s: scv entry should set PPR

2020-08-25 Thread Nicholas Piggin
Kernel entry sets PPR to HMT_MEDIUM by convention. The scv entry path missed this. Fixes: 7fa95f9adaee ("powerpc/64s: system call support for scv/rfscv instructions") Signed-off-by: Nicholas Piggin --- arch/powerpc/kernel/entry_64.S | 4 1 file changed, 4 insertions(+) diff --git a/arch/p

Re: fsl_espi errors on v5.7.15

2020-08-25 Thread Heiner Kallweit
On 25.08.2020 05:54, Chris Packham wrote: > > On 25/08/20 10:04 am, Chris Packham wrote: >> >> On 20/08/20 9:08 am, Chris Packham wrote: >>> >>> On 19/08/20 6:15 pm, Heiner Kallweit wrote: On 19.08.2020 00:44, Chris Packham wrote: > Hi Again, > > On 17/08/20 9:09 am, Chris Packham