Re: [PATCH 3/3] [RFC] powerpc: Book3S 64-bit outline-only KASAN support

2022-05-17 Thread Paul Mackerras
On Sun, May 15, 2022 at 07:33:52AM +, Christophe Leroy wrote: > > > Le 11/05/2022 à 09:28, Paul Mackerras a écrit : > > From: Daniel Axtens > > > > Implement a limited form of KASAN for Book3S 64-bit machines running under > > the Radix MMU, supporting only outline mode. [snip] > > diff

Re: [PATCH v1 0/4] Kill the time spent in patch_instruction()

2022-05-17 Thread Christophe Leroy
Le 15/05/2022 à 12:28, Michael Ellerman a écrit : > On Tue, 22 Mar 2022 16:40:17 +0100, Christophe Leroy wrote: >> This series reduces by 70% the time required to activate >> ftrace on an 8xx with CONFIG_STRICT_KERNEL_RWX. >> >> Measure is performed in function ftrace_replace_code() using mftb()

Re: [PATCH 3/3] [RFC] powerpc: Book3S 64-bit outline-only KASAN support

2022-05-17 Thread Christophe Leroy
Le 17/05/2022 à 09:31, Paul Mackerras a écrit : > On Sun, May 15, 2022 at 07:33:52AM +, Christophe Leroy wrote: >> >> >> Le 11/05/2022 à 09:28, Paul Mackerras a écrit : >>> From: Daniel Axtens >>> >>> Implement a limited form of KASAN for Book3S 64-bit machines running under >>> the Radix

[Bug 215389] pagealloc: memory corruption at building glibc-2.33 and running its' testsuite

2022-05-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215389 --- Comment #24 from Christophe Leroy (christophe.le...@csgroup.eu) --- Seems like with Inline KASAN your kernel is far too big compared to what we support at the time being: c2468000 T __end_rodata c280 T __init_begin c280 T _sinittext

Re: [PATCH v1 0/4] Kill the time spent in patch_instruction()

2022-05-17 Thread Michael Ellerman
Christophe Leroy writes: > Le 15/05/2022 à 12:28, Michael Ellerman a écrit : >> On Tue, 22 Mar 2022 16:40:17 +0100, Christophe Leroy wrote: >>> This series reduces by 70% the time required to activate >>> ftrace on an 8xx with CONFIG_STRICT_KERNEL_RWX. >>> >>> Measure is performed in function

[Bug 215389] pagealloc: memory corruption at building glibc-2.33 and running its' testsuite

2022-05-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215389 --- Comment #25 from Christophe Leroy (christophe.le...@csgroup.eu) --- The Kernel stack overflow looks odd. Value of R1 is wrong and LR is NULL. Don't know how we ended up here, but probably not by a real stack overflow. -- You may reply to

Re: [PATCH] kexec_file: Drop pr_err in weak implementations of arch_kexec_apply_relocations[_add]

2022-05-17 Thread Naveen N. Rao
Baoquan He wrote: On 04/25/22 at 11:11pm, Naveen N. Rao wrote: kexec_load_purgatory() can fail for many reasons - there is no need to print an error when encountering unsupported relocations. This solves a build issue on powerpc with binutils v2.36 and newer [1]. Since commit d1bcae833b32f1

Re: [PATCH] kexec_file: Drop pr_err in weak implementations of arch_kexec_apply_relocations[_add]

2022-05-17 Thread Naveen N. Rao
Naveen N. Rao wrote: kexec_load_purgatory() can fail for many reasons - there is no need to print an error when encountering unsupported relocations. This solves a build issue on powerpc with binutils v2.36 and newer [1]. Since commit d1bcae833b32f1 ("ELF: Don't generate unused section

Re: [PATCH] kexec_file: Drop pr_err in weak implementations of arch_kexec_apply_relocations[_add]

2022-05-17 Thread Baoquan He
On 04/25/22 at 11:11pm, Naveen N. Rao wrote: > kexec_load_purgatory() can fail for many reasons - there is no need to > print an error when encountering unsupported relocations. > > This solves a build issue on powerpc with binutils v2.36 and newer [1]. > Since commit d1bcae833b32f1 ("ELF: Don't

Re: [PATCH] powerpc/vdso: Fix incorrect CFI in gettimeofday.S

2022-05-17 Thread Naveen N. Rao
Michael Ellerman wrote: diff --git a/arch/powerpc/kernel/vdso/gettimeofday.S b/arch/powerpc/kernel/vdso/gettimeofday.S index eb9c81e1c218..0aee255e9cbb 100644 --- a/arch/powerpc/kernel/vdso/gettimeofday.S +++ b/arch/powerpc/kernel/vdso/gettimeofday.S @@ -22,12 +22,15 @@ .macro cvdso_call

[Bug 215389] pagealloc: memory corruption at building glibc-2.33 and running its' testsuite

2022-05-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215389 --- Comment #26 from Christophe Leroy (christophe.le...@csgroup.eu) --- Note that THREAD_SHIFT is set to 14 when using KASAN: config THREAD_SHIFT int "Thread shift" if EXPERT range 13 15 default "15" if PPC_256K_PAGES

Re: [PATCH -next] powerpc/book3e: Fix build error

2022-05-17 Thread Christophe Leroy
Le 17/05/2022 à 11:48, YueHaibing a écrit : > arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’: > arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of > function ‘early_get_first_memblock_info’ > [-Werror=implicit-function-declaration] >

Re: [PATCH] powerpc/vdso: Fix incorrect CFI in gettimeofday.S

2022-05-17 Thread Michael Ellerman
"Naveen N. Rao" writes: > Michael Ellerman wrote: >> >> diff --git a/arch/powerpc/kernel/vdso/gettimeofday.S >> b/arch/powerpc/kernel/vdso/gettimeofday.S >> index eb9c81e1c218..0aee255e9cbb 100644 >> --- a/arch/powerpc/kernel/vdso/gettimeofday.S >> +++ b/arch/powerpc/kernel/vdso/gettimeofday.S

Re: [PATCH] powerpc/irq: Remove arch_local_irq_restore() for !CONFIG_CC_HAS_ASM_GOTO

2022-05-17 Thread Michael Ellerman
Christophe Leroy writes: > All supported versions of GCC support asm goto. I thought clang was the one that only recently added support for asm goto. Apparently clang added support in 2019, in clang 9. The earliest clang we claim to support is 11. So this patch is good, I'll just adjust the

Re: [PATCH 2/2] powerpc/perf: Fix the threshold compare group constraint for power9

2022-05-17 Thread Athira Rajeev
> On 06-May-2022, at 11:40 AM, Kajol Jain wrote: > > Thresh compare bits for a event is used to program thresh compare > field in Monitor Mode Control Register A (MMCRA: 9-18 bits for power9). > When scheduling events as a group, all events in that group should > match value in threshold bits

Re: [PATCH 15/30] bus: brcmstb_gisb: Clean-up panic/die notifiers

2022-05-17 Thread Guilherme G. Piccoli
On 10/05/2022 12:28, Petr Mladek wrote: > [...] > IMHO, the check of the @self parameter was the proper solution. > > "gisb_die_notifier" list uses @val from enum die_val. > "gisb_panic_notifier" list uses @val from enum panic_notifier_val. > > These are unrelated types. It might easily break

Re: [PATCH] kexec_file: Drop pr_err in weak implementations of arch_kexec_apply_relocations[_add]

2022-05-17 Thread Eric W. Biederman
Looking at this the pr_err is absolutely needed. If an unsupported case winds up in the purgatory blob and the code can't handle it things will fail silently much worse later. So the proposed patch is unfortunately the wrong direction. "Naveen N. Rao" writes: > Baoquan He wrote: >> On

Re: [PATCH 14/30] panic: Properly identify the panic event to the notifiers' callbacks

2022-05-17 Thread Guilherme G. Piccoli
On 17/05/2022 10:11, Petr Mladek wrote: > [...] >> You mentioned 2 cases: >> >> (a) Same notifier_list used in different situations; >> >> (b) Same *notifier callback* used in different lists; >> >> Mine is case (b), right? Can you show me an example of case (a)? > > There are many examples of

Re: [PATCH 17/30] tracing: Improve panic/die notifiers

2022-05-17 Thread Guilherme G. Piccoli
On 11/05/2022 08:45, Petr Mladek wrote: > [...] > DIE_OOPS and PANIC_NOTIFIER are from different enum. > It feels like comparing apples with oranges here. > > IMHO, the proper way to unify the two notifiers is > a check of the @self parameter. Something like: > > static int

Re: [PATCH v2 4/4] powerpc/52xx: Convert to use fwnode API

2022-05-17 Thread Andy Shevchenko
On Tue, May 17, 2022 at 09:38:56AM +1000, Michael Ellerman wrote: > Andy Shevchenko writes: > > On Mon, May 16, 2022 at 05:05:12PM +0300, Andy Shevchenko wrote: > >> On Mon, May 16, 2022 at 11:48:05PM +1000, Michael Ellerman wrote: > >> > Andy Shevchenko writes: > >> > > We may convert the GPT

Re: [PATCH v6 21/29] x86/nmi: Add an NMI_WATCHDOG NMI handler category

2022-05-17 Thread Ricardo Neri
On Mon, May 09, 2022 at 03:59:40PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 17:00, Ricardo Neri wrote: > > Add a NMI_WATCHDOG as a new category of NMI handler. This new category > > is to be used with the HPET-based hardlockup detector. This detector > > does not have a direct way of

Looking for old boards with Galileo / Marvell Discovery chips on them.

2022-05-17 Thread Steven J. Hill
Hello. Currently looking for old EV64260 and EV64360 development boards. If you have any to sell, please contact me. Tried contacting Mark Greer of list, but not sure if he got any of my email. Oh, also looking for a BDI2000 or BDI3000 if you have one to sell. Thank you. -Steve

[powerpc:next-test 141/145] arch/powerpc/kernel/trace/ftrace.c:714:6: error: redefinition of 'ftrace_free_init_tramp'

2022-05-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test head: 2e4a9942261f89ad204a8189634029a4b1f0efb6 commit: 0cad223e88229b1f021f9e167bdb2ba7b0d0c369 [141/145] powerpc/ftrace: Remove ftrace init tramp once kernel init is complete config:

[powerpc:next-test 139/145] arch/powerpc/sysdev/mpc5xxx_clocks.c:26:2: error: call to undeclared function 'fwnode_for_each_parent_node'; ISO C99 and later do not support implicit function declarations

2022-05-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test head: 2e4a9942261f89ad204a8189634029a4b1f0efb6 commit: f9724684ea2198caaab132514ca104175ed2f15f [139/145] powerpc/mpc5xxx: Switch mpc5xxx_get_bus_frequency() to use fwnode config: powerpc-mpc512x_defconfig

Re: [PATCH v6 28/29] x86/tsc: Restart NMI watchdog after refining tsc_khz

2022-05-17 Thread Ricardo Neri
On Tue, May 10, 2022 at 09:16:21PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > > The HPET hardlockup detector relies on tsc_khz to estimate the value of > > that the TSC will have when its HPET channel fires. A refined tsc_khz > > helps to

RE: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

2022-05-17 Thread Luck, Tony
> What I'm planning to do in the altera_edac notifier is: > > if (kdump_is_set) > return; Yes. That's what I think should happen. -Tony

Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

2022-05-17 Thread Guilherme G. Piccoli
On 17/05/2022 14:02, Luck, Tony wrote: >> Tony / Dinh - can I just *skip* this notifier *if kdump* is set or else >> we run the code as-is? Does that make sense to you? > > The "skip" option sounds like it needs some special flag associated with > an entry on the notifier chain. But there are

[powerpc:topic/ppc-kvm] BUILD SUCCESS 2852ebfa10afdcefff35ec72c8da97141df9845c

2022-05-17 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git topic/ppc-kvm branch HEAD: 2852ebfa10afdcefff35ec72c8da97141df9845c KVM: PPC: Book3S HV Nested: L2 LPCR should inherit L1 LPES setting elapsed time: 724m configs tested: 119 configs skipped: 104 The following

Re: [PATCH v3] PCI/AER: Handle Multi UnCorrectable/Correctable errors properly

2022-05-17 Thread Bjorn Helgaas
On Wed, May 11, 2022 at 05:29:45PM -0700, Sathyanarayanan Kuppuswamy wrote: > > > On 5/11/22 4:40 PM, Bjorn Helgaas wrote: > > On Mon, Apr 18, 2022 at 03:02:37PM +, Kuppuswamy Sathyanarayanan wrote: > > > Currently the aer_irq() handler returns IRQ_NONE for cases without bits > > >

Re: [PATCH] kexec_file: Drop pr_err in weak implementations of arch_kexec_apply_relocations[_add]

2022-05-17 Thread Michael Ellerman
"Eric W. Biederman" writes: > Looking at this the pr_err is absolutely needed. If an unsupported case > winds up in the purgatory blob and the code can't handle it things > will fail silently much worse later. It won't fail later, it will fail the syscall. sys_kexec_file_load()

Re: [PATCH v4] locking/csd_lock: change csdlock_debug from early_param to __setup

2022-05-17 Thread Paul E. McKenney
On Tue, May 17, 2022 at 11:22:04AM +0800, Chen Zhongjin wrote: > On 2022/5/10 17:46, Chen Zhongjin wrote: > > csdlock_debug uses early_param and static_branch_enable() to enable > > csd_lock_wait feature, which triggers a panic on arm64 with config: > > CONFIG_SPARSEMEM=y > >

Re: [PATCH] net: unexport csum_and_copy_{from,to}_user

2022-05-17 Thread Al Viro
On Thu, Apr 21, 2022 at 09:04:40AM +0200, Christoph Hellwig wrote: > csum_and_copy_from_user and csum_and_copy_to_user are exported by > a few architectures, but not actually used in modular code. Drop > the exports. > > Signed-off-by: Christoph Hellwig Acked-by: Al Viro Not sure which tree

Re: [PATCH v6 28/29] x86/tsc: Restart NMI watchdog after refining tsc_khz

2022-05-17 Thread Ricardo Neri
On Tue, May 10, 2022 at 01:44:05PM +0200, Thomas Gleixner wrote: > On Tue, May 10 2022 at 21:16, Nicholas Piggin wrote: > > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > >> + /* > >> + * If in use, the HPET hardlockup detector relies on tsc_khz. > >> + * Reconfigure it to

Re: [PATCH v6 15/29] x86/hpet: Add helper function hpet_set_comparator_periodic()

2022-05-17 Thread Ricardo Neri
On Sat, May 14, 2022 at 10:17:38AM +0200, Thomas Gleixner wrote: > On Fri, May 13 2022 at 14:19, Ricardo Neri wrote: > > On Fri, May 06, 2022 at 11:41:13PM +0200, Thomas Gleixner wrote: > >> The argument about not bloating the code > >> with an "obvious???" function which is quite small is

Re: [PATCH 05/30] misc/pvpanic: Convert regular spinlock into trylock on panic path

2022-05-17 Thread Guilherme G. Piccoli
On 17/05/2022 07:58, Petr Mladek wrote: > [...] >> Thanks for the review Petr. Patch was already merged - my goal was to be >> concise, i.e., a patch per driver / module, so the patch kinda fixes >> whatever I think is wrong with the driver with regards panic handling. >> >> Do you think it worth

Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

2022-05-17 Thread Guilherme G. Piccoli
On 17/05/2022 11:11, Petr Mladek wrote: > [...] >>> Then notifiers could make an informed choice on whether to deep dive to >>> get all the possible details (when there is no kdump) or just skim the high >>> level stuff (to maximize chance of getting a successful kdump). >>> >>> -Tony >> >> Good

RE: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

2022-05-17 Thread Luck, Tony
> Tony / Dinh - can I just *skip* this notifier *if kdump* is set or else > we run the code as-is? Does that make sense to you? The "skip" option sounds like it needs some special flag associated with an entry on the notifier chain. But there are other notifier chains ... so that sounds messy to

Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list

2022-05-17 Thread Guilherme G. Piccoli
On 17/05/2022 10:28, Petr Mladek wrote: > [...] >>> Disagree here. I'm looping Google maintainers, so they can comment. >>> (CCed Evan, David, Julius) >>> >>> This notifier is clearly a hypervisor notification mechanism. I've fixed >>> a locking stuff there (in previous patch), I feel it's

Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list

2022-05-17 Thread Guilherme G. Piccoli
On 17/05/2022 10:57, Petr Mladek wrote: > [...] --- a/drivers/misc/bcm-vk/bcm_vk_dev.c +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c @@ -1446,7 +1446,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) >>> [... snip ...] >>> It seems to reset some

Re: [PATCH] net: unexport csum_and_copy_{from,to}_user

2022-05-17 Thread Michael Ellerman
Al Viro writes: > On Thu, Apr 21, 2022 at 09:04:40AM +0200, Christoph Hellwig wrote: >> csum_and_copy_from_user and csum_and_copy_to_user are exported by >> a few architectures, but not actually used in modular code. Drop >> the exports. >> >> Signed-off-by: Christoph Hellwig > > Acked-by: Al

Re: [PATCH -next] powerpc/book3e: Fix build error

2022-05-17 Thread Michael Ellerman
YueHaibing writes: > On 2022/5/17 18:45, Christophe Leroy wrote: >> Le 17/05/2022 à 11:48, YueHaibing a écrit : >>> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’: >>> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of >>> function