Re: [PATCH 2/2] drm/tiny: Add ofdrm for Open Firmware framebuffers

2022-05-19 Thread Thomas Zimmermann
Hi Am 19.05.22 um 09:11 schrieb Geert Uytterhoeven: Hi Michal, On Wed, May 18, 2022 at 8:54 PM Michal Suchánek wrote: On Wed, May 18, 2022 at 08:30:06PM +0200, Thomas Zimmermann wrote: --- a/drivers/gpu/drm/tiny/Kconfig +++ b/drivers/gpu/drm/tiny/Kconfig @@ -51,6 +51,18 @@ config

Re: [PATCH] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add]

2022-05-19 Thread Naveen N. Rao
Andrew Morton wrote: On Wed, 18 May 2022 23:48:28 +0530 "Naveen N. Rao" wrote: Since commit d1bcae833b32f1 ("ELF: Don't generate unused section symbols") [1], binutils (v2.36+) started dropping section symbols that it thought were unused. This isn't an issue in general, but with

Re: [PATCH 2/2] drm/tiny: Add ofdrm for Open Firmware framebuffers

2022-05-19 Thread Geert Uytterhoeven
Hi Michal, On Wed, May 18, 2022 at 8:54 PM Michal Suchánek wrote: > On Wed, May 18, 2022 at 08:30:06PM +0200, Thomas Zimmermann wrote: > > --- a/drivers/gpu/drm/tiny/Kconfig > > +++ b/drivers/gpu/drm/tiny/Kconfig > > @@ -51,6 +51,18 @@ config DRM_GM12U320 > >This is a KMS driver for

[PATCH v2] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add]

2022-05-19 Thread Naveen N. Rao
Since commit d1bcae833b32f1 ("ELF: Don't generate unused section symbols") [1], binutils (v2.36+) started dropping section symbols that it thought were unused. This isn't an issue in general, but with kexec_file.c, gcc is placing kexec_arch_apply_relocations[_add] into a separate .text.unlikely

Re: [PATCH 2/2] drm/tiny: Add ofdrm for Open Firmware framebuffers

2022-05-19 Thread Michal Suchánek
On Wed, May 18, 2022 at 10:11:03PM +0100, Mark Cave-Ayland wrote: > On 18/05/2022 19:30, Thomas Zimmermann wrote: > > > Open Firmware provides basic display output via the 'display' node. > > DT platform code already provides a device that represents the node's > > framebuffer. Add a DRM driver

Re: [PATCH v1 3/4] powerpc/code-patching: Use jump_label for testing freed initmem

2022-05-19 Thread Christophe Leroy
Le 19/05/2022 à 04:17, Guenter Roeck a écrit : > On Tue, Mar 22, 2022 at 04:40:20PM +0100, Christophe Leroy wrote: >> Once init is done, initmem is freed forever so no need to >> test system_state at every call to patch_instruction(). >> >> Use jump_label. >> >> This reduces by 2% the time

Re: [PATCH] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add]

2022-05-19 Thread Naveen N. Rao
Baoquan He wrote: Hi Eric, On 05/18/22 at 04:59pm, Eric W. Biederman wrote: "Naveen N. Rao" writes: > Since commit d1bcae833b32f1 ("ELF: Don't generate unused section > symbols") [1], binutils (v2.36+) started dropping section symbols that > it thought were unused. This isn't an issue in

[PATCH] powerpc/kasan: Mark more real-mode code as not to be instrumented

2022-05-19 Thread Paul Mackerras
This marks more files and functions that can possibly be called in real mode as not to be instrumented by KASAN. Most were found by inspection, except for get_pseries_errorlog() which was reported as causing a crash in testing. Reported-by: Nageswara R Sastry Signed-off-by: Paul Mackerras ---

Re: [PATCH 2/2] drm/tiny: Add ofdrm for Open Firmware framebuffers

2022-05-19 Thread Thomas Zimmermann
Hi Am 18.05.22 um 23:11 schrieb Mark Cave-Ayland: On 18/05/2022 19:30, Thomas Zimmermann wrote: Open Firmware provides basic display output via the 'display' node. DT platform code already provides a device that represents the node's framebuffer. Add a DRM driver for the device. The display

Re: [PATCH] powerpc/powernv/pci: Drop VF MPS fixup

2022-05-19 Thread Michael Ellerman
Christophe Leroy writes: > Le 02/09/2020 à 05:51, Oliver O'Halloran a écrit : >> The MPS field in the VF config space is marked as reserved in current >> versions of the SR-IOV spec. In other words, this fixup doesn't do >> anything. >> >> Signed-off-by: Oliver O'Halloran > > A lot of cleanup

[PATCH] powerpc/microwatt: Add mmu bits to device tree

2022-05-19 Thread Joel Stanley
In commit 5402e239d09f ("powerpc/64s: Get LPID bit width from device tree") the kernel tried to determine the pid and lpid bits from the device tree. If they are not found, there is a fallback, but Microwatt wasn't covered as has the unusual configuration of being both !HV and bare metal. Set the

Re: [PATCH] tools/perf/test: Fix perf all PMU test to skip hv_24x7/hv_gpci tests on powerpc

2022-05-19 Thread Athira Rajeev
> On 18-May-2022, at 6:35 PM, Michael Ellerman wrote: > > Athira Rajeev writes: >> "perf all PMU test" picks the input events from >> "perf list --raw-dump pmu" list and runs "perf stat -e" >> for each of the event in the list. In case of powerpc, the >> PowerVM environment supports events

Re: [PATCH] powerpc/powernv/pci: Drop VF MPS fixup

2022-05-19 Thread Oliver O'Halloran
On Thu, May 19, 2022 at 10:38 PM Michael Ellerman wrote: > > Christophe Leroy writes: > > Le 02/09/2020 à 05:51, Oliver O'Halloran a écrit : > >> The MPS field in the VF config space is marked as reserved in current > >> versions of the SR-IOV spec. In other words, this fixup doesn't do > >>

Re: [PATCH V2 1/2] powerpc/perf: Add support for caps under sysfs in powerpc

2022-05-19 Thread Athira Rajeev
> On 19-May-2022, at 10:12 AM, Ian Rogers wrote: > > On Wed, May 18, 2022 at 1:55 AM Athira Rajeev > wrote: >> >> Add caps support under "/sys/bus/event_source/devices//" >> for powerpc. This directory can be used to expose some of the >> specific features that powerpc PMU supports to the

[PATCH 2/2] powerpc/64s: Add CPU_FTRS_POWER10 to ALWAYS mask

2022-05-19 Thread Michael Ellerman
CPU_FTRS_POWER10 is missing from the CPU_FTRS_ALWAYS mask. Currently that doesn't cause any bug, because it is a superset of the POWER9 mask, which the exception of CPU_FTR_TM, but POWER7 doesn't have CPU_FTR_TM, so CPU_FTR_TM is not in the ALWAYS mask to begin with. However for consistency, and

[PATCH 1/2] powerpc/64s: Add CPU_FTRS_POWER9_DD2_2 to CPU_FTRS_ALWAYS mask

2022-05-19 Thread Michael Ellerman
CPU_FTRS_POWER9_DD2_2 is missing from CPU_FTRS_ALWAYS. That doesn't cause any bug, because CPU_FTRS_POWER9_DD2_2 adds new bits that don't appear in other values, so when anded with the other masks the result is the same. But for consistency we should have all values in the CPU_FTRS_ALWAYS mask,

Re: [PATCH] powerpc: Fix all occurences of "the the"

2022-05-19 Thread Brian W Hart
On Thu, May 19, 2022 at 12:26:29AM +1000, Michael Ellerman wrote: > Rather than waiting for the bots to fix these one-by-one, fix all > occurences of "the the" throughout arch/powerpc. > > Signed-off-by: Michael Ellerman > --- > arch/powerpc/boot/wrapper | 2 +- >

[PATCH V2] tools/perf/test: Fix perf all PMU test to skip hv_24x7/hv_gpci tests on powerpc

2022-05-19 Thread Athira Rajeev
"perf all PMU test" picks the input events from "perf list --raw-dump pmu" list and runs "perf stat -e" for each of the event in the list. In case of powerpc, the PowerVM environment supports events from hv_24x7 and hv_gpci PMU which is of example format like below: -

Re: [PATCH 00/35] Add group constraints and event code test as part of selftest

2022-05-19 Thread Athira Rajeev
> On 18-May-2022, at 6:53 PM, Michael Ellerman wrote: > > Kajol Jain writes: >> Patch series extends the perf interface selftests >> to cover scenarios for event code checking, >> group constraints, and also thresholding/branch related >> interface tests in sampling area. > > There are

Re: [PATCH v2] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add]

2022-05-19 Thread kernel test robot
Hi "Naveen, I love your patch! Yet something to improve: [auto build test ERROR on f993aed406eaf968ba3867a76bb46c95336a33d0] url: https://github.com/intel-lab-lkp/linux/commits/Naveen-N-Rao/kexec_file-Drop-weak-attribute-from-arch_kexec_apply_relocations-_add/20220519-171432

[PATCH] powerpc/fsl_book3e: Don't set rodata RO too early

2022-05-19 Thread Christophe Leroy
On fsl_book3e, rodata is set read-only at the same time as init text is set NX at the end of init. That's too early. As both action are performed at the same time, delay both actions to the time rodata is expected to be made read-only. It means we will have a small window with init mem freed but

Re: [PATCH V12 00/20] riscv: Add COMPAT mode support for 64BIT

2022-05-19 Thread Palmer Dabbelt
On Tue, 05 Apr 2022 00:12:54 PDT (-0700), guo...@kernel.org wrote: From: Guo Ren Currently, most 64-bit architectures (x86, parisc, powerpc, arm64, s390, mips, sparc) have supported COMPAT mode. But they all have history issues and can't use standard linux unistd.h. RISC-V would be first

Re: [PATCH] powerpc/fsl_book3e: Don't set rodata RO too early

2022-05-19 Thread Guenter Roeck
On Thu, May 19, 2022 at 07:24:15PM +0200, Christophe Leroy wrote: > On fsl_book3e, rodata is set read-only at the same time as > init text is set NX at the end of init. That's too early. > > As both action are performed at the same time, delay both > actions to the time rodata is expected to be

Re: [PATCH v1 3/4] powerpc/code-patching: Use jump_label for testing freed initmem

2022-05-19 Thread Christophe Leroy
Le 19/05/2022 à 08:27, Christophe Leroy a écrit : Le 19/05/2022 à 04:17, Guenter Roeck a écrit : On Tue, Mar 22, 2022 at 04:40:20PM +0100, Christophe Leroy wrote: Once init is done, initmem is freed forever so no need to test system_state at every call to patch_instruction(). Use

Re: [PATCH] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add]

2022-05-19 Thread Eric W. Biederman
Baoquan He writes: > Hi Eric, > > On 05/18/22 at 04:59pm, Eric W. Biederman wrote: >> "Naveen N. Rao" writes: >> >> > Since commit d1bcae833b32f1 ("ELF: Don't generate unused section >> > symbols") [1], binutils (v2.36+) started dropping section symbols that >> > it thought were unused. This

[PATCH] net: fs_enet: sync rx dma buffer before reading

2022-05-19 Thread Mans Rullgard
The dma_sync_single_for_cpu() call must precede reading the received data. Fix this. Fixes: 070e1f01827c ("net: fs_enet: don't unmap DMA when packet len is below copybreak") Signed-off-by: Mans Rullgard --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 8 1 file changed, 4

Re: [PATCH v1 3/4] powerpc/code-patching: Use jump_label for testing freed initmem

2022-05-19 Thread Christophe Leroy
Le 19/05/2022 à 08:53, Christophe Leroy a écrit : Le 19/05/2022 à 08:27, Christophe Leroy a écrit : Le 19/05/2022 à 04:17, Guenter Roeck a écrit : On Tue, Mar 22, 2022 at 04:40:20PM +0100, Christophe Leroy wrote: Once init is done, initmem is freed forever so no need to test

[PATCH v2 26/28] powerpc: Convert to printbuf

2022-05-19 Thread Kent Overstreet
This converts from seq_buf to printbuf. We're using printbuf in external buffer mode, so it's a direct conversion, aside from some trivial refactoring in cpu_show_meltdown() to make the code more consistent. Signed-off-by: Kent Overstreet Cc: linuxppc-dev@lists.ozlabs.org ---

Re: [PATCH v2] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add]

2022-05-19 Thread Andrew Morton
en-N-Rao/kexec_file-Drop-weak-attribute-from-arch_kexec_apply_relocations-_add/20220519-171432 > base: f993aed406eaf968ba3867a76bb46c95336a33d0 > config: s390-allmodconfig > (https://download.01.org/0day-ci/archive/20220519/202205192320.coxevcfr-...@intel.com/config) > compiler

Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list

2022-05-19 Thread Guilherme G. Piccoli
On 19/05/2022 04:03, Petr Mladek wrote: > [...] > I would ignore it for now. If anyone would want to safe the log > then they would need to read it. They will most likely use > the existing kmsg_dump() infastructure. In fact, they should > use it to avoid a code duplication. > > Best Regards, >

Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list

2022-05-19 Thread Guilherme G. Piccoli
On 18/05/2022 19:17, Scott Branden wrote: > Hi Guilherme, > > +Desmond > [...] I'm afraid it breaks kdump if this device is not reset beforehand - it's a doorbell write, so not high risk I think... But in case the not-reset device can be probed normally in kdump kernel,

Re: [PATCH] powerpc/microwatt: Add mmu bits to device tree

2022-05-19 Thread Nicholas Piggin
Excerpts from Joel Stanley's message of May 19, 2022 10:57 pm: > In commit 5402e239d09f ("powerpc/64s: Get LPID bit width from device > tree") the kernel tried to determine the pid and lpid bits from the > device tree. If they are not found, there is a fallback, but Microwatt > wasn't covered as

Re: [PATCH v6 20/29] init/main: Delay initialization of the lockup detector after smp_init()

2022-05-19 Thread Nicholas Piggin
Excerpts from Ricardo Neri's message of May 14, 2022 9:16 am: > On Tue, May 10, 2022 at 08:38:22PM +1000, Nicholas Piggin wrote: >> Excerpts from Ricardo Neri's message of May 6, 2022 9:59 am: >> > Certain implementations of the hardlockup detector require support for >> > Inter-Processor

[RFC Linux patch] powerpc: add documentation for HWCAPs

2022-05-19 Thread Nicholas Piggin
This takes the arm64 file and adjusts it for powerpc. Feature descriptions are vaguely handwaved by me. --- Anybody care to expand on or correct the meaning of these entries or bikeshed the wording of the intro? Many of them are no longer used anywhere by upstream kernels and even where they are

Re: [PATCH 1/2] MAINTAINERS: Broaden scope of simpledrm entry

2022-05-19 Thread Javier Martinez Canillas
Hello Thomas, On 5/18/22 20:30, Thomas Zimmermann wrote: > There will be more DRM drivers for firmware-provided framebuffers. Use > the existing entry for simpledrm instead of adding a new one for each > driver. Also add DRM's aperture helpers, which are part of the driver's > infrastructure. >

Re: linux-next: Signed-off-by missing for commit in the powerpc tree

2022-05-19 Thread Nicholas Piggin
Excerpts from Stephen Rothwell's message of May 20, 2022 8:31 am: > Hi all, > > Commits > > 03a2e65f54b3 ("KVM: PPC: Book3S Nested: Use explicit 4096 LPID maximum") > 18827eeef022 ("KVM: PPC: Remove kvmppc_claim_lpid") > > are missing a Signed-off-by from their authors. Sorry. > The first

Re: [PATCH] net: fs_enet: sync rx dma buffer before reading

2022-05-19 Thread Christophe Leroy
Le 19/05/2022 à 21:24, Mans Rullgard a écrit : > The dma_sync_single_for_cpu() call must precede reading the received > data. Fix this. See original commit 070e1f01827c. It explicitely says that the cache must be invalidate _AFTER_ the copy. The cache is initialy invalidated by

linux-next: manual merge of the modules tree with the powerpc tree

2022-05-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the modules tree got a conflict in: arch/powerpc/Kconfig between commit: b91d4eea5bff ("powerpc: Book3S 64-bit outline-only KASAN support") from the powerpc tree and commit: eeaec7801c42 ("powerpc: Select ARCH_WANTS_MODULES_DATA_IN_VMALLOC on

linux-next: Signed-off-by missing for commit in the powerpc tree

2022-05-19 Thread Stephen Rothwell
Hi all, Commits 03a2e65f54b3 ("KVM: PPC: Book3S Nested: Use explicit 4096 LPID maximum") 18827eeef022 ("KVM: PPC: Remove kvmppc_claim_lpid") are missing a Signed-off-by from their authors. The first is just "Signed-of-by" misspelling. The second is missing. -- Cheers, Stephen Rothwell

Re: [PATCH 24/30] panic: Refactor the panic path

2022-05-19 Thread Baoquan He
On 05/15/22 at 07:47pm, Guilherme G. Piccoli wrote: > On 12/05/2022 11:03, Petr Mladek wrote: .. > > OK, the question is how to make it better. Let's start with > > a clear picture of the problem: > > > > 1. panic() has basically two funtions: > > > > + show/store debug information

[powerpc:topic/ppc-kvm] BUILD SUCCESS ad55bae7dc364417434b69dd6c30104f20d0f84d

2022-05-19 Thread kernel test robot
x86_64 rhel-8.3 x86_64 rhel-8.3-func x86_64 rhel-8.3-syz x86_64 rhel-8.3-kunit clang tested configs: powerpc randconfig-c003-20220519 x86_64randconfig-c007

Re: [PATCH 11/12] powerpc: wiiu: don't enforce flat memory

2022-05-19 Thread Ash Logan
On 14/5/22 08:43, Pali Rohár wrote: > On Wednesday 02 March 2022 15:44:05 Ash Logan wrote: >> pgtable_32.c:mapin_ram loops over each valid memory range, which means >> non-contiguous memory just works. > > Hello! Does it mean that non-contiguous memory works for any 32-bit > powerpc platform, and