Re: [PATCH v13 16/35] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-10-31 Thread Sean Christopherson
On Tue, Oct 31, 2023, David Matlack wrote: > On 2023-10-27 11:21 AM, Sean Christopherson wrote: > > Introduce an ioctl(), KVM_CREATE_GUEST_MEMFD, to allow creating file-based > > memory that is tied to a specific KVM virtual machine and whose primary > > purpose is to serve guest memory. > > > >

Re: [PATCH v13 16/35] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-10-31 Thread Paolo Bonzini
On Tue, Oct 31, 2023 at 11:13 PM Sean Christopherson wrote: > On Tue, Oct 31, 2023, Fuad Tabba wrote: > > On Fri, Oct 27, 2023 at 7:23 PM Sean Christopherson > > wrote: > Since we now know that at least pKVM will use guest_memfd for shared memory, > and > odds are quite good that "regular" VMs

Re: [PATCH v13 16/35] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-10-31 Thread David Matlack
On Tue, Oct 31, 2023 at 2:36 PM Sean Christopherson wrote: > On Tue, Oct 31, 2023, David Matlack wrote: > > On 2023-10-27 11:21 AM, Sean Christopherson wrote: > > > Introduce an ioctl(), KVM_CREATE_GUEST_MEMFD, to allow creating file-based > > > memory that is tied to a specific KVM virtual

Re: [PATCH v13 16/35] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-10-31 Thread Sean Christopherson
On Tue, Oct 31, 2023, Fuad Tabba wrote: > Hi, > > On Fri, Oct 27, 2023 at 7:23 PM Sean Christopherson wrote: > > ... > > > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > > index e2252c748fd6..e82c69d5e755 100644 > > --- a/Documentation/virt/kvm/api.rst > > +++

Re: [ppc64le] WARN at crypto/testmgr.c:5804

2023-10-31 Thread Dimitri John Ledkov
On Tue, 31 Oct 2023 at 14:09, Sachin Sant wrote: > > Following warning is observed during boot of latest -next > kernel (6.6.0-rc7-next-20231030 and todays -next) on IBM Power server. > > [ 0.085775] workingset: timestamp_bits=38 max_order=20 bucket_order=0 > [ 0.085801] zbud: loaded > [

Re: [PATCH v13 16/35] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-10-31 Thread David Matlack
On 2023-10-27 11:21 AM, Sean Christopherson wrote: > Introduce an ioctl(), KVM_CREATE_GUEST_MEMFD, to allow creating file-based > memory that is tied to a specific KVM virtual machine and whose primary > purpose is to serve guest memory. > > A guest-first memory subsystem allows for optimizations

Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b

2023-10-31 Thread Nick Desaulniers
On Tue, Oct 31, 2023 at 7:56 AM Bjorn Helgaas wrote: > > [+cc powerpc, clang folks] > > On Sat, Oct 28, 2023 at 08:22:54PM +0800, kernel test robot wrote: > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git > > controller/xilinx-xdma > > branch HEAD:

Re: [linux-next:master] BUILD REGRESSION c503e3eec382ac708ee7adf874add37b77c5d312

2023-10-31 Thread Dan Williams
Bjorn Helgaas wrote: > On Tue, Oct 31, 2023 at 04:35:23AM +0800, kernel test robot wrote: > > tree/branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > branch HEAD: c503e3eec382ac708ee7adf874add37b77c5d312 Add linux-next > > specific files for 20231030 > >

Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b

2023-10-31 Thread Bjorn Helgaas
On Tue, Oct 31, 2023 at 09:59:29AM -0700, Nick Desaulniers wrote: > On Tue, Oct 31, 2023 at 7:56 AM Bjorn Helgaas wrote: > > On Sat, Oct 28, 2023 at 08:22:54PM +0800, kernel test robot wrote: > > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git > > >

Re: [linux-next:master] BUILD REGRESSION c503e3eec382ac708ee7adf874add37b77c5d312

2023-10-31 Thread Dan Williams
Dan Williams wrote: > Bjorn Helgaas wrote: > > On Tue, Oct 31, 2023 at 04:35:23AM +0800, kernel test robot wrote: > > > tree/branch: > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > branch HEAD: c503e3eec382ac708ee7adf874add37b77c5d312 Add linux-next > > >

Re: [PATCH v13 16/35] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-10-31 Thread Chao Gao
>+int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) >+{ >+ loff_t size = args->size; >+ u64 flags = args->flags; >+ u64 valid_flags = 0; >+ >+ if (flags & ~valid_flags) >+ return -EINVAL; >+ >+ if (size < 0 || !PAGE_ALIGNED(size)) >+

Re: [PATCH 00/10] Remove obsolete and orphaned wifi drivers

2023-10-31 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > As discussed previously, a lot of the older wifi drivers are likely > entirely unused, Though we can't know for sure. > > As suggested by both Greg and Jakub, let's remove the ones that look > are most likely to have no users left and also get in

Re: [PATCH v13 17/35] KVM: Add transparent hugepage support for dedicated guest memory

2023-10-31 Thread Xiaoyao Li
On 10/28/2023 2:21 AM, Sean Christopherson wrote: Extended guest_memfd to allow backing guest memory with transparent hugepages. Require userspace to opt-in via a flag even though there's no known/anticipated use case for forcing small pages as THP is optional, i.e. to avoid ending up in a

Re: [PATCH v2 29/37] powerpc/nohash: Replace pte_user() by pte_read()

2023-10-31 Thread Aneesh Kumar K.V
Christophe Leroy writes: > pte_user() is now only used in pte_access_permitted() to check > access on vmas. User flag is cleared to make a page unreadable. > > So rename it pte_read() and remove pte_user() which isn't used > anymore. > > For the time being it checks _PAGE_USER but in the near

[ppc64le] WARN at crypto/testmgr.c:5804

2023-10-31 Thread Sachin Sant
Following warning is observed during boot of latest -next kernel (6.6.0-rc7-next-20231030 and todays -next) on IBM Power server. [ 0.085775] workingset: timestamp_bits=38 max_order=20 bucket_order=0 [ 0.085801] zbud: loaded [ 0.086473] [ cut here ] [ 0.086477] WARNING:

Re: [linux-next:master] BUILD REGRESSION c503e3eec382ac708ee7adf874add37b77c5d312

2023-10-31 Thread Bjorn Helgaas
On Tue, Oct 31, 2023 at 04:35:23AM +0800, kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: c503e3eec382ac708ee7adf874add37b77c5d312 Add linux-next > specific files for 20231030 > > Error/Warning reports: > ...

Re: [PATCH v13 13/35] KVM: Introduce per-page memory attributes

2023-10-31 Thread David Matlack
On 2023-10-27 11:21 AM, Sean Christopherson wrote: > From: Chao Peng > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 89c1a991a3b8..df573229651b 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -808,6 +809,9 @@ struct kvm { > > #ifdef

[Bug 206203] kmemleak reports various leaks in drivers/of/unittest.c

2023-10-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206203 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Status|REOPENED|RESOLVED

Re: Several kmemleak reports + "refcount_t: underflow; use-after-free" at boot when OF_UNITTEST + OF_OVERLAY is set (Kernel v6.6-rc6, PowerMac G5 11,2)

2023-10-31 Thread Erhard Furtner
On Mon, 30 Oct 2023 11:26:48 -0500 Rob Herring wrote: > The test tells you to expect a use-after-free... > > > ---[ end trace <> ]--- ### dt-test ### pass > > of_unittest_lifecycle():3209 > > [ cut here ] > > refcount_t: underflow; use-after-free. > > Then you get a

Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b

2023-10-31 Thread Segher Boessenkool
On Tue, Oct 31, 2023 at 09:56:00AM -0500, Bjorn Helgaas wrote: > That said, the unused functions do look legit: > > grackle_set_stg() is a static function and the only call is under > "#if 0". It is a static inline. It is *normal* that that is uncalled. It is very similar to a macro that has

Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b

2023-10-31 Thread Bjorn Helgaas
[+cc powerpc, clang folks] On Sat, Oct 28, 2023 at 08:22:54PM +0800, kernel test robot wrote: > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git > controller/xilinx-xdma > branch HEAD: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add > Xilinx XDMA Root

Re: [PATCH v13 16/35] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-10-31 Thread Fuad Tabba
Hi, On Fri, Oct 27, 2023 at 7:23 PM Sean Christopherson wrote: ... > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > index e2252c748fd6..e82c69d5e755 100644 > --- a/Documentation/virt/kvm/api.rst > +++ b/Documentation/virt/kvm/api.rst > @@ -6079,6 +6079,15 @@

Re: [PATCH v13 08/35] KVM: Introduce KVM_SET_USER_MEMORY_REGION2

2023-10-31 Thread Sean Christopherson
On Tue, Oct 31, 2023, Xiaoyao Li wrote: > On 10/28/2023 2:21 AM, Sean Christopherson wrote: > > Introduce a "version 2" of KVM_SET_USER_MEMORY_REGION so that additional > > information can be supplied without setting userspace up to fail. The > > padding in the new kvm_userspace_memory_region2

Re: [PATCH v13 16/35] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-10-31 Thread Sean Christopherson
On Tue, Oct 31, 2023, Chao Gao wrote: > >+int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) > >+{ > >+loff_t size = args->size; > >+u64 flags = args->flags; > >+u64 valid_flags = 0; > >+ > >+if (flags & ~valid_flags) > >+return -EINVAL; > >+ > >+

Re: [PATCH v13 17/35] KVM: Add transparent hugepage support for dedicated guest memory

2023-10-31 Thread Sean Christopherson
On Tue, Oct 31, 2023, Xiaoyao Li wrote: > On 10/28/2023 2:21 AM, Sean Christopherson wrote: > > Extended guest_memfd to allow backing guest memory with transparent > > hugepages. Require userspace to opt-in via a flag even though there's no > > known/anticipated use case for forcing small pages as