Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-11 Thread Gavin Shan
On Fri, Oct 11, 2013 at 04:49:56PM +1100, Benjamin Herrenschmidt wrote: On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: On Thu, Sep 05, 2013 at 03:55:27PM +0800, Yijing Wang wrote: Use pci_is_pcie() to simplify code. Acked-by: Kumar Gala ga...@kernel.crashing.org Reviewed-by:

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-11 Thread Yijing Wang
On 2013/10/11 14:16, Gavin Shan wrote: On Fri, Oct 11, 2013 at 04:49:56PM +1100, Benjamin Herrenschmidt wrote: On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: On Thu, Sep 05, 2013 at 03:55:27PM +0800, Yijing Wang wrote: Use pci_is_pcie() to simplify code. Acked-by: Kumar Gala

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-11 Thread Yijing Wang
On 2013/10/11 13:49, Benjamin Herrenschmidt wrote: On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: On Thu, Sep 05, 2013 at 03:55:27PM +0800, Yijing Wang wrote: Use pci_is_pcie() to simplify code. Acked-by: Kumar Gala ga...@kernel.crashing.org Reviewed-by: Gavin Shan

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-11 Thread Gavin Shan
On Fri, Oct 11, 2013 at 02:33:58PM +0800, Yijing Wang wrote: On 2013/10/11 14:16, Gavin Shan wrote: On Fri, Oct 11, 2013 at 04:49:56PM +1100, Benjamin Herrenschmidt wrote: On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: On Thu, Sep 05, 2013 at 03:55:27PM +0800, Yijing Wang wrote:

Re: [PATCH 1/2] tty/hvc_console: Add DTR/RTS callback to handle HUPCL control

2013-10-11 Thread Benjamin Herrenschmidt
On Tue, 2013-07-02 at 17:07 +0200, Hendrik Brueckner wrote: Introduce a new callback to explicitly handle the HUPCL termios control flag. This prepares for a follow-up commit for the hvc_iucv device driver to improve handling when to drop an established network connection. The callback

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-11 Thread Yijing Wang
On 2013/10/11 14:53, Gavin Shan wrote: On Fri, Oct 11, 2013 at 02:33:58PM +0800, Yijing Wang wrote: On 2013/10/11 14:16, Gavin Shan wrote: On Fri, Oct 11, 2013 at 04:49:56PM +1100, Benjamin Herrenschmidt wrote: On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: On Thu, Sep 05, 2013 at

RE: [PATCH v4 4/4] powerpc/85xx: add sysfs for pw20 state and altivec idle

2013-10-11 Thread Wang Dongsheng-B40534
-Original Message- From: Wood Scott-B07421 Sent: Tuesday, October 08, 2013 10:50 PM To: Wang Dongsheng-B40534 Cc: Wood Scott-B07421; Bhushan Bharat-R65777; linuxppc- d...@lists.ozlabs.org Subject: Re: [PATCH v4 4/4] powerpc/85xx: add sysfs for pw20 state and altivec idle On

Re: Gianfar driver crashes in Kernel v3.10

2013-10-11 Thread Claudiu Manoil
On 10/11/2013 12:41 AM, Scott Wood wrote: On Thu, 2013-10-10 at 14:07 +0300, Claudiu Manoil wrote: On 10/4/2013 3:28 PM, Thomas Hühn wrote: [code] [ 2671.841927] Oops: Exception in kernel mode, sig: 5 [#1] [ 2671.847141] Freescale P1014 [ 2671.849925] Modules linked in: ath9k pppoe

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-11 Thread Gavin Shan
On Fri, Oct 11, 2013 at 03:28:02PM +0800, Yijing Wang wrote: On 2013/10/11 14:53, Gavin Shan wrote: On Fri, Oct 11, 2013 at 02:33:58PM +0800, Yijing Wang wrote: On 2013/10/11 14:16, Gavin Shan wrote: On Fri, Oct 11, 2013 at 04:49:56PM +1100, Benjamin Herrenschmidt wrote: On Fri, 2013-09-06 at

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-11 Thread Yijing Wang
In my idea, dev-pcie_cap(here is pci_dev-pcie_cap) will update in set_pcie_port_type() function, and this function always be called after allocate pci device. We get pci_dev by eeh_dev_to_pci_dev(), I think pci_dev has been initialized completely. This function has possibility to be

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-11 Thread Alexander Gordeev
On Thu, Oct 10, 2013 at 07:17:18PM -0400, Mark Lord wrote: Just to help us all understand the loop issue.. Here's an example of driver code which uses the existing MSI-X interfaces, for a device which can work with either 16, 8, 4, 2, or 1 MSI-X interrupt. This is from a new driver I'm

Fwd: Gianfar driver crashes in Kernel v3.10

2013-10-11 Thread Thomas Hühn
Hi Claudiu, Does this show up on a half duplex (100Mb/s) link? In my testsetup I always used 1GBit Ethernet connections, so no 100MBit tested yet. Should I do so ? Could you provide following for the gianfar interface, on your setup: sure: # ethtool ethX root@Bluse-home:~# ethtool eth0

Re: Gianfar driver crashes in Kernel v3.10

2013-10-11 Thread Thomas Hühn
Hi Scott, On 09.10.2013, at 00:09, Scott Wood scottw...@freescale.com wrote: On Fri, 2013-10-04 at 12:03 +, Thomas Hühn wrote: [code] [ 2671.841927] Oops: Exception in kernel mode, sig: 5 [#1] [ 2671.847141] Freescale P1014 [ 2671.849925] Modules linked in: ath9k pppoe ppp_async

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Mark Rutland
On Fri, Oct 11, 2013 at 04:18:18AM +0100, Tang Yuantian-B29983 wrote: Thanks for your review. See my reply inline -Original Message- From: Mark Rutland [mailto:mark.rutl...@arm.com] Sent: 2013年10月10日 星期四 18:04 To: Tang Yuantian-B29983 Cc: ga...@kernel.crashing.org;

Re: [PATCH 1/2] tty/hvc_console: Add DTR/RTS callback to handle HUPCL control

2013-10-11 Thread Hendrik Brueckner
Hi Benjamin, On Fri, Oct 11, 2013 at 06:15:11PM +1100, Benjamin Herrenschmidt wrote: On Tue, 2013-07-02 at 17:07 +0200, Hendrik Brueckner wrote: Introduce a new callback to explicitly handle the HUPCL termios control flag. This prepares for a follow-up commit for the hvc_iucv device

[PATCH] powerpc 8xx: Fixing memory init issue with CONFIG_PIN_TLB

2013-10-11 Thread Christophe Leroy
Activating CONFIG_PIN_TLB allows access to the 24 first Mbytes of memory at bootup instead of 8. It is needed for big kernels for instance when activating CONFIG_LOCKDEP_SUPPORT. This needs to be taken into account in init_32 too, otherwise memory allocation soon fails after startup.

Re: Elbc device driver

2013-10-11 Thread Mercier Ivan
Hi, this should be correct (I'm using chip select 3 for this device) lbc: localbus@ffe124000 { reg = 0xf 0xfe124000 0 0x1000; ranges = 3 0 0xf 0xe000 0x0800; a3p400{ #address-cells = 1;

Re: [PATCH] powerpc 8xx: Fixing memory init issue with CONFIG_PIN_TLB

2013-10-11 Thread Joakim Tjernlund
Linuxppc-dev linuxppc-dev-bounces+joakim.tjernlund=transmode...@lists.ozlabs.org wrote on 2013/10/11 14:56:40: Activating CONFIG_PIN_TLB allows access to the 24 first Mbytes of memory at bootup instead of 8. It is needed for big kernels for instance when activating CONFIG_LOCKDEP_SUPPORT.

[PATCH] powerpc/mpc512x: remove unnecessary #if

2013-10-11 Thread Brian Norris
Several functions are only ever referenced locally, so make them static. Of those functions, many of them are protected by an #if. However, the code which can compile fine in either case. Now that (1) the unneeded code is marked 'static' and (2) the code is only used under a C 'if

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-10-11 Thread Brian Norris
Hi, On Thu, Oct 10, 2013 at 12:37 PM, Anatolij Gustschin ag...@denx.de wrote: On Thu, 10 Oct 2013 11:23:55 -0700 Brian Norris computersforpe...@gmail.com wrote: Yes, we also have to remove CONFIG_FB_FSL_DIU ifdef in arch/powerpc/sysdev/fsl_soc.h and building should work then. Still want

Re: Elbc device driver

2013-10-11 Thread Scott Wood
On Fri, 2013-10-11 at 17:03 +0200, Mercier Ivan wrote: Hi, this should be correct (I'm using chip select 3 for this device) lbc: localbus@ffe124000 { reg = 0xf 0xfe124000 0 0x1000; ranges = 3 0 0xf 0xe000 0x0800; a3p400{

Re: [PATCH] powerpc/mpc512x: remove unnecessary #if

2013-10-11 Thread Brian Norris
Hi, I'm sorry, ignore this version. I left out a diff I meant to include. On Fri, Oct 11, 2013 at 10:32 AM, Brian Norris computersforpe...@gmail.com wrote: Several functions are only ever referenced locally, so make them static. Of those functions, many of them are protected by an #if.

[PATCH v2] powerpc/mpc512x: remove unnecessary #if

2013-10-11 Thread Brian Norris
Several functions are only ever referenced locally, so make them static. Of those functions, many of them are protected by an #if. However, the code which can compile fine in either case. Now that (1) the unneeded code is marked 'static' and (2) the code is only used under a C 'if

Re: Gianfar driver crashes in Kernel v3.10

2013-10-11 Thread Scott Wood
On Fri, 2013-10-11 at 11:17 +0200, Thomas Hühn wrote: Hi Scott, On 09.10.2013, at 00:09, Scott Wood scottw...@freescale.com wrote: On Fri, 2013-10-04 at 12:03 +, Thomas Hühn wrote: [code] [ 2671.841927] Oops: Exception in kernel mode, sig: 5 [#1] [ 2671.847141] Freescale P1014

Re: Gianfar driver crashes in Kernel v3.10

2013-10-11 Thread Scott Wood
On Fri, 2013-10-11 at 12:49 -0500, Scott Wood wrote: On Fri, 2013-10-11 at 11:17 +0200, Thomas Hühn wrote: Hi Scott, On 09.10.2013, at 00:09, Scott Wood scottw...@freescale.com wrote: On Fri, 2013-10-04 at 12:03 +, Thomas Hühn wrote: [code] [ 2671.841927] Oops: Exception in

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Scott Wood
On Fri, 2013-10-11 at 10:25 +0100, Mark Rutland wrote: On Fri, Oct 11, 2013 at 04:18:18AM +0100, Tang Yuantian-B29983 wrote: Thanks for your review. See my reply inline -Original Message- From: Mark Rutland [mailto:mark.rutl...@arm.com] Sent: 2013年10月10日 星期四 18:04 To:

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Scott Wood
On Wed, 2013-10-09 at 14:38 +0800, yuantian.t...@freescale.com wrote: From: Tang Yuantian yuantian.tang@frovider: +/ { + clockgen: global-utilities@e1000 { + compatible = fsl,p5020-clockgen, fsl,qoriq-clockgen-1.0; + reg = 0xe1000 0x1000; +

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-11 Thread Mark Lord
On 13-10-11 04:41 AM, Alexander Gordeev wrote: On Thu, Oct 10, 2013 at 07:17:18PM -0400, Mark Lord wrote: Just to help us all understand the loop issue.. Here's an example of driver code which uses the existing MSI-X interfaces, for a device which can work with either 16, 8, 4, 2, or 1 MSI-X

Re: [PATCH 1/2] tty/hvc_console: Add DTR/RTS callback to handle HUPCL control

2013-10-11 Thread Benjamin Herrenschmidt
On Fri, 2013-10-11 at 14:47 +0200, Hendrik Brueckner wrote: The tiocmget/tiocmset callbacks are used to set and get modem status and triggered through an tty ioctl. The dtr_rts() callback is different and it is used for DTS/RTS handshaking between the hvc_console (or any other tty_port) and

Re: PCIE device errors after linux kernel upgrade

2013-10-11 Thread Bjorn Helgaas
On Fri, Aug 16, 2013 at 4:05 PM, Bjorn Helgaas bhelg...@google.com wrote: On Tue, Aug 6, 2013 at 11:41 PM, Leon Ravich lrav...@gmail.com wrote: From comparison of pci printout from the two kernel , beside the EDAC errors I noticed other strange differences: In 3.8.13 I got BAR 7 and BAR 8: [

Re: [PATCH v2 1/3] powerpc/booke64: add sync after writing PTE

2013-10-11 Thread Scott Wood
On Fri, 2013-10-11 at 10:51 +1100, Benjamin Herrenschmidt wrote: On Thu, 2013-10-10 at 18:25 -0500, Scott Wood wrote: Looking at some of the code in mm/, I suspect that the normal callers of set_pte_at() already have an unlock (and thus a sync) Unlock is lwsync actually... Oops, I was

Re: [PATCH v2 1/3] powerpc/booke64: add sync after writing PTE

2013-10-11 Thread Benjamin Herrenschmidt
On Fri, 2013-10-11 at 17:07 -0500, Scott Wood wrote: On Fri, 2013-10-11 at 10:51 +1100, Benjamin Herrenschmidt wrote: On Thu, 2013-10-10 at 18:25 -0500, Scott Wood wrote: Looking at some of the code in mm/, I suspect that the normal callers of set_pte_at() already have an unlock (and

[PATCH v3 2/3] powerpc/e6500: TLB miss handler with hardware tablewalk support

2013-10-11 Thread Scott Wood
There are a few things that make the existing hw tablewalk handlers unsuitable for e6500: - Indirect entries go in TLB1 (though the resulting direct entries go in TLB0). - It has threads, but no tlbsrx. -- so we need a spinlock and a normal tlbsx. Because we need this lock, hardware

[PATCH v3 3/3] powerpc/fsl-book3e-64: Use paca for hugetlb TLB1 entry selection

2013-10-11 Thread Scott Wood
This keeps usage coordinated for hugetlb and indirect entries, which should make entry selection more predictable and probably improve overall performance when mixing the two. Signed-off-by: Scott Wood scottw...@freescale.com --- v3: no changes v2: new patch ---

[PATCH v3 1/3] powerpc: add barrier after writing kernel PTE

2013-10-11 Thread Scott Wood
There is no barrier between something like ioremap() writing to a PTE, and returning the value to a caller that may then store the pointer in a place that is visible to other CPUs. Such callers generally don't perform barriers of their own. Even if callers of ioremap() and similar things did use

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Tang Yuantian-B29983
Thanks for your review. -Original Message- From: Wood Scott-B07421 Sent: 2013年10月12日 星期六 3:07 To: Mark Rutland Cc: Tang Yuantian-B29983; devicet...@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; Li Yang-Leo-R58472 Subject: Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Tang Yuantian-B29983
Thanks for your review. -Original Message- From: Wood Scott-B07421 Sent: 2013年10月12日 星期六 3:08 To: Tang Yuantian-B29983 Cc: ga...@kernel.crashing.org; devicet...@vger.kernel.org; linuxppc- d...@lists.ozlabs.org Subject: Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Tang Yuantian-B29983
Thanks for your review. +- reg: Offset and length of the clock register set +- clock-frequency: Indicates input clock frequency of clock block. + Will be set by u-boot Why does the fact this is set by u-boot matter to the binding? OK, I will remove it. +