Re: [PATCH v3 05/11] drivers/base/memory: Pass a block_id to init_memory_block()

2019-06-03 Thread David Hildenbrand
On 03.06.19 23:49, Wei Yang wrote: > On Mon, May 27, 2019 at 01:11:46PM +0200, David Hildenbrand wrote: >> We'll rework hotplug_memory_register() shortly, so it no longer consumes >> pass a section. >> >> Cc: Greg Kroah-Hartman >> Cc: "Rafael J. Wysocki" >> Signed-off-by: David Hildenbrand >> --

Re: [PATCH v3 04/11] arm64/mm: Add temporary arch_remove_memory() implementation

2019-06-03 Thread David Hildenbrand
On 03.06.19 23:41, Wei Yang wrote: > On Mon, May 27, 2019 at 01:11:45PM +0200, David Hildenbrand wrote: >> A proper arch_remove_memory() implementation is on its way, which also >> cleanly removes page tables in arch_add_memory() in case something goes >> wrong. > > Would this be better to underst

Re: [RFC V2] mm: Generalize notify_page_fault()

2019-06-03 Thread Peter Zijlstra
On Tue, Jun 04, 2019 at 12:04:06PM +0530, Anshuman Khandual wrote: > diff --git a/mm/memory.c b/mm/memory.c > index ddf20bd..b6bae8f 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -52,6 +52,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -14

[RFC V2] mm: Generalize notify_page_fault()

2019-06-03 Thread Anshuman Khandual
Similar notify_page_fault() definitions are being used by architectures duplicating much of the same code. This attempts to unify them into a single implementation, generalize it and then move it to a common place. kprobes_built_in() can detect CONFIG_KPROBES, hence notify_page_fault() need not be

Re: [PATCH] PCI: rpaphp: Avoid a sometimes-uninitialized warning

2019-06-03 Thread Christophe Leroy
Quoting Nathan Chancellor : When building with -Wsometimes-uninitialized, clang warns: drivers/pci/hotplug/rpaphp_core.c:243:14: warning: variable 'fndit' is used uninitialized whenever 'for' loop exits because its condition is false [-Wsometimes-uninitialized] for (j = 0; j < entries

[PATCH] powerpc/configs: Disable latencytop

2019-06-03 Thread Anton Blanchard
latencytop adds almost 4kB to each and every task struct and as such it doesn't deserve to be in our defconfigs. Signed-off-by: Anton Blanchard --- arch/powerpc/configs/g5_defconfig | 1 - arch/powerpc/configs/gamecube_defconfig | 1 - arch/powerpc/configs/maple_defconfig| 1 - arch/po

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread Alexey Kardashevskiy
On 04/06/2019 09:42, Segher Boessenkool wrote: > Hi! > > On Mon, Jun 03, 2019 at 12:56:26PM +1000, Alexey Kardashevskiy wrote: >> On 03/06/2019 09:23, Segher Boessenkool wrote: So I go for the simple one and agree with Alexey's idea. >>> >>> When dealing with a whole device tree you have t

[PATCH v2] perf ioctl: Add check for the sample_period value

2019-06-03 Thread Ravi Bangoria
perf_event_open() limits the sample_period to 63 bits. See commit 0819b2e30ccb ("perf: Limit perf_event_attr::sample_period to 63 bits"). Make ioctl() consistent with it. Also on powerpc, negative sample_period could cause a recursive PMIs leading to a hang (reported when running perf-fuzzer). Si

Re: [RFC PATCH v2] powerpc/xmon: restrict when kernel is locked down

2019-06-03 Thread Andrew Donnellan
On 4/6/19 1:05 pm, Christopher M Riedl wrote:>>> + if (!xmon_is_ro) { + xmon_is_ro = kernel_is_locked_down("Using xmon write-access", + LOCKDOWN_INTEGRITY); + if (xmon_is_ro) { + printf("xmon: R

crash after NX error

2019-06-03 Thread Stewart Smith
On my two socket POWER9 system (powernv) with 842 zwap set up, I recently got a crash with the Ubuntu kernel (I haven't tried with upstream, and this is the first time the system has died like this, so I'm not sure how repeatable it is). [2.891463] zswap: loaded using pool 842-nx/zbud ... [156

[PATCH v5 1/2] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool

2019-06-03 Thread Michael Neuling
From: Mathieu Malaterre In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 option") the following piece of code was added: smp_call_function((smp_call_func_t)set_dawr, &null_brk, 0); Since GCC 8 this triggers the following warning about incompatible function types: arch/powe

[PATCH v5 2/2] powerpc: Fix compile issue with force DAWR

2019-06-03 Thread Michael Neuling
If you compile with KVM but without CONFIG_HAVE_HW_BREAKPOINT you fail at linking with: arch/powerpc/kvm/book3s_hv_rmhandlers.o:(.text+0x708): undefined reference to `dawr_force_enable' This was caused by commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 option"). This moves a bunc

Re: [RFC PATCH v2] powerpc/xmon: restrict when kernel is locked down

2019-06-03 Thread Christopher M Riedl
> On June 3, 2019 at 1:36 AM Andrew Donnellan wrote: > > > On 24/5/19 10:38 pm, Christopher M. Riedl wrote: > > Xmon should be either fully or partially disabled depending on the > > kernel lockdown state. > > > > Put xmon into read-only mode for lockdown=integrity and completely > > disable

Re: [PATCH v4 2/2] powerpc: Fix compile issue with force DAWR

2019-06-03 Thread Michael Neuling
I agree with all the below and will address in v5. Mikey On Tue, 2019-05-28 at 23:28 -0700, Christoph Hellwig wrote: > > +config PPC_DAWR > > + bool > > + default n > > "default n" is the default default. No need to write this line. > > > +++ b/arch/powerpc/kernel/dawr.c > > @@ -0,0 +1,100

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread David Gibson
On Mon, Jun 03, 2019 at 06:49:32PM -0500, Segher Boessenkool wrote: > On Tue, Jun 04, 2019 at 07:18:42AM +1000, Benjamin Herrenschmidt wrote: > > Yes we could make property fetching faster but mostly by creating a new > > bulk interface which is quite a bit of work, a new API, and will in > > pract

Re: [PATCH v2 1/5] powerpc/powernv: Move SCOM access code into powernv platform

2019-06-03 Thread Andrew Donnellan
On 9/5/19 3:11 pm, Andrew Donnellan wrote: The powernv platform is the only one that directly accesses SCOMs. Move the support code to platforms/powernv, and get rid of the PPC_SCOM Kconfig option, as SCOM support is always selected when compiling for powernv. This also means that the Kconfig it

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-06-03 Thread Michael S. Tsirkin
On Mon, Jun 03, 2019 at 10:13:59PM -0300, Thiago Jung Bauermann wrote: > > > Michael S. Tsirkin writes: > > > On Wed, Apr 17, 2019 at 06:42:00PM -0300, Thiago Jung Bauermann wrote: > >> I rephrased it in terms of address translation. What do you think of > >> this version? The flag name is slig

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-06-03 Thread Thiago Jung Bauermann
Michael S. Tsirkin writes: > On Wed, Apr 17, 2019 at 06:42:00PM -0300, Thiago Jung Bauermann wrote: >> I rephrased it in terms of address translation. What do you think of >> this version? The flag name is slightly different too: >> >> >> VIRTIO_F_ACCESS_PLATFORM_NO_TRANSLATION This feature ha

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread Benjamin Herrenschmidt
On Mon, 2019-06-03 at 18:42 -0500, Segher Boessenkool wrote: > Hi! > > On Mon, Jun 03, 2019 at 12:56:26PM +1000, Alexey Kardashevskiy wrote: > > On 03/06/2019 09:23, Segher Boessenkool wrote: > > > > So I go for the simple one and agree with Alexey's idea. > > > > > > When dealing with a whole de

Re: [PATCH v2] PCI: rpaphp: Avoid a sometimes-uninitialized warning

2019-06-03 Thread Tyrel Datwyler
On 06/03/2019 03:11 PM, Nathan Chancellor wrote: > When building with -Wsometimes-uninitialized, clang warns: > > drivers/pci/hotplug/rpaphp_core.c:243:14: warning: variable 'fndit' is > used uninitialized whenever 'for' loop exits because its condition is > false [-Wsometimes-uninitialized] >

Re: [PATCH v3] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-03 Thread Tyrel Datwyler
On 06/03/2019 04:44 PM, Nathan Chancellor wrote: > clang warns: > > drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used > uninitialized whenever switch case is taken [-Wsometimes-uninitialized] > case IBMVSCSI_HOST_ACTION_NONE: > ^ >

Re: [WIP RFC PATCH 0/6] Generic Firmware Variable Filesystem

2019-06-03 Thread Daniel Axtens
Hi Greg, >> >> As PowerNV moves towards secure boot, we need a place to put secure >> >> variables. One option that has been canvassed is to make our secure >> >> variables look like EFI variables. This is an early sketch of another >> >> approach where we create a generic firmware variable file s

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread Segher Boessenkool
On Tue, Jun 04, 2019 at 07:18:42AM +1000, Benjamin Herrenschmidt wrote: > Yes we could make property fetching faster but mostly by creating a new > bulk interface which is quite a bit of work, a new API, and will in > practice not be used for anything other than creating the FDT. In that > case, no

[PATCH v3] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-03 Thread Nathan Chancellor
clang warns: drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case IBMVSCSI_HOST_ACTION_NONE: ^ drivers/scsi/ibmvscsi/ibmvscsi.c:2151:6: note: uninitialized u

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread Segher Boessenkool
Hi! On Mon, Jun 03, 2019 at 12:56:26PM +1000, Alexey Kardashevskiy wrote: > On 03/06/2019 09:23, Segher Boessenkool wrote: > >> So I go for the simple one and agree with Alexey's idea. > > > > When dealing with a whole device tree you have to know about the various > > dynamically generated nodes

Re: [PATCH v2] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-03 Thread Tyrel Datwyler
On 06/03/2019 04:34 PM, Tyrel Datwyler wrote: > On 06/03/2019 04:25 PM, Tyrel Datwyler wrote: >> On 06/03/2019 03:19 PM, Nathan Chancellor wrote: >>> clang warns: >>> >>> drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used >>> uninitialized whenever switch case is taken [-Wsomet

Re: [PATCH v2] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-03 Thread Tyrel Datwyler
On 06/03/2019 04:25 PM, Tyrel Datwyler wrote: > On 06/03/2019 03:19 PM, Nathan Chancellor wrote: >> clang warns: >> >> drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used >> uninitialized whenever switch case is taken [-Wsometimes-uninitialized] >> case IBMVSCSI_HOST_ACT

Re: [PATCH] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-03 Thread Tyrel Datwyler
On 06/02/2019 03:15 AM, Michael Ellerman wrote: > Hi Nathan, > > Nathan Chancellor writes: >> clang warns: >> >> drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used >> uninitialized whenever switch case is taken [-Wsometimes-uninitialized] >> case IBMVSCSI_HOST_ACTION_

Re: [PATCH v2] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-03 Thread Tyrel Datwyler
On 06/03/2019 03:19 PM, Nathan Chancellor wrote: > clang warns: > > drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used > uninitialized whenever switch case is taken [-Wsometimes-uninitialized] > case IBMVSCSI_HOST_ACTION_NONE: > ^ >

[PATCH v2] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-03 Thread Nathan Chancellor
clang warns: drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case IBMVSCSI_HOST_ACTION_NONE: ^ drivers/scsi/ibmvscsi/ibmvscsi.c:2151:6: note: uninitialized u

Re: [PATCH v3 06/11] mm/memory_hotplug: Allow arch_remove_pages() without CONFIG_MEMORY_HOTREMOVE

2019-06-03 Thread Wei Yang
Allow arch_remove_pages() or arch_remove_memory()? And want to confirm the kernel build on affected arch succeed? On Mon, May 27, 2019 at 01:11:47PM +0200, David Hildenbrand wrote: >We want to improve error handling while adding memory by allowing >to use arch_remove_memory() and __remove_pages()

[PATCH v2] PCI: rpaphp: Avoid a sometimes-uninitialized warning

2019-06-03 Thread Nathan Chancellor
When building with -Wsometimes-uninitialized, clang warns: drivers/pci/hotplug/rpaphp_core.c:243:14: warning: variable 'fndit' is used uninitialized whenever 'for' loop exits because its condition is false [-Wsometimes-uninitialized] for (j = 0; j < entries; j++) { ^~~~

Re: [PATCH] PCI: rpaphp: Avoid a sometimes-uninitialized warning

2019-06-03 Thread Nathan Chancellor
Hi Nick, On Mon, Jun 03, 2019 at 02:07:50PM -0700, Nick Desaulniers wrote: > On Mon, Jun 3, 2019 at 10:44 AM Nathan Chancellor > wrote: > > Looking at the loop in a vacuum as clang would, fndit could be > > uninitialized if entries was ever zero or the if statement was > > always true within the

Re: [PATCH v3 05/11] drivers/base/memory: Pass a block_id to init_memory_block()

2019-06-03 Thread Wei Yang
On Mon, May 27, 2019 at 01:11:46PM +0200, David Hildenbrand wrote: >We'll rework hotplug_memory_register() shortly, so it no longer consumes >pass a section. > >Cc: Greg Kroah-Hartman >Cc: "Rafael J. Wysocki" >Signed-off-by: David Hildenbrand >--- > drivers/base/memory.c | 15 +++ > 1

Re: [PATCH v3 00/11] mm/memory_hotplug: Factor out memory block devicehandling

2019-06-03 Thread David Hildenbrand
On 03.06.19 23:21, Wei Yang wrote: > IMHO, there is some typo. Yes, thanks. > > s/devicehandling/device handling/ > > On Mon, May 27, 2019 at 01:11:41PM +0200, David Hildenbrand wrote: >> We only want memory block devices for memory to be onlined/offlined >> (add/remove from the buddy). This is

Re: [PATCH v3 00/11] mm/memory_hotplug: Factor out memory block devicehandling

2019-06-03 Thread Wei Yang
IMHO, there is some typo. s/devicehandling/device handling/ On Mon, May 27, 2019 at 01:11:41PM +0200, David Hildenbrand wrote: >We only want memory block devices for memory to be onlined/offlined >(add/remove from the buddy). This is required so user space can >online/offline memory and kdump get

Re: [PATCH v3 0/6] soc/fsl/qe: cleanups and new DT binding

2019-06-03 Thread Rasmus Villemoes
On 13/05/2019 13.14, Rasmus Villemoes wrote: > This small series consists of some small cleanups and simplifications > of the QUICC engine driver, and introduces a new DT binding that makes > it much easier to support other variants of the QUICC engine IP block > that appears in the wild: There's n

[PATCH] powerpc: Enable kernel XZ compression option on PPC_85xx

2019-06-03 Thread Pawel Dembicki
Enable kernel XZ compression option on PPC_85xx. Tested with simpleImage on TP-Link TL-WDR4900 (Freescale P1014 processor). Suggested-by: Christian Lamparter Signed-off-by: Pawel Dembicki --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/K

Re: [PATCH 22/22] docs: fix broken documentation links

2019-06-03 Thread Mark Brown
On Wed, May 29, 2019 at 08:23:53PM -0300, Mauro Carvalho Chehab wrote: > Mostly due to x86 and acpi conversion, several documentation > links are still pointing to the old file. Fix them. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v3 04/11] arm64/mm: Add temporary arch_remove_memory() implementation

2019-06-03 Thread Wei Yang
On Mon, May 27, 2019 at 01:11:45PM +0200, David Hildenbrand wrote: >A proper arch_remove_memory() implementation is on its way, which also >cleanly removes page tables in arch_add_memory() in case something goes >wrong. Would this be better to understand? removes page tables created in arch_a

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread Benjamin Herrenschmidt
On Mon, 2019-06-03 at 12:56 +1000, Alexey Kardashevskiy wrote: > > > That is all you need if you do not want to use OF at all. > > ? We also need OF drivers to boot grub and the system, and a default > console for early booting, but yes, we do not want to keep using slof > that much. > > > If yo

RE: [PATCH v3 0/6] soc/fsl/qe: cleanups and new DT binding

2019-06-03 Thread Leo Li
> -Original Message- > From: Rasmus Villemoes > Sent: Monday, June 3, 2019 2:54 PM > To: devicet...@vger.kernel.org; Qiang Zhao ; Leo Li > > Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-ker...@lists.infradead.org; > linux-ker...@vger.kernel.org; Rob Herring ; Scott > Wood ; Christophe L

Re: [PATCH v3] mm: add account_locked_vm utility function

2019-06-03 Thread Alex Williamson
On Wed, 29 May 2019 16:50:19 -0400 Daniel Jordan wrote: > locked_vm accounting is done roughly the same way in five places, so > unify them in a helper. > > Include the helper's caller in the debug print to distinguish between > callsites. > > Error codes stay the same, so user-visible behavior

[PATCH] PCI: rpaphp: Avoid a sometimes-uninitialized warning

2019-06-03 Thread Nathan Chancellor
When building with -Wsometimes-uninitialized, clang warns: drivers/pci/hotplug/rpaphp_core.c:243:14: warning: variable 'fndit' is used uninitialized whenever 'for' loop exits because its condition is false [-Wsometimes-uninitialized] for (j = 0; j < entries; j++) { ^~~~

Re: [PATCH 03/16] mm: simplify gup_fast_permitted

2019-06-03 Thread Linus Torvalds
On Mon, Jun 3, 2019 at 9:08 AM Linus Torvalds wrote: > > The new code has no test at all for "nr_pages == 0", afaik. Note that it really is important to check for that, because right now we do if (gup_fast_permitted(start, nr_pages)) { local_irq_save(flags);

Re: [PATCH v3 0/6] Prerequisites for NXP LS104xA SMMU enablement

2019-06-03 Thread Andreas Färber
Am 31.05.19 um 19:32 schrieb Laurentiu Tudor: >> -Original Message- >> From: Andreas Färber >> Sent: Friday, May 31, 2019 8:04 PM >> >> Hello Laurentiu, >> >> Am 31.05.19 um 18:46 schrieb Laurentiu Tudor: -Original Message- From: Andreas Färber Sent: Friday, May 31,

Re: [PATCH 03/16] mm: simplify gup_fast_permitted

2019-06-03 Thread Linus Torvalds
On Mon, Jun 3, 2019 at 12:41 AM Christoph Hellwig wrote: > > I only removed a duplicate of it. I don't see any remaining cases. > The full (old) code in get_user_pages_fast() looks like this: > > if (nr_pages <= 0) > return 0; > > if (unlikely(!access_ok((void __u

Re: [PATCH 01/16] uaccess: add untagged_addr definition for other arches

2019-06-03 Thread Khalid Aziz
On 6/1/19 1:49 AM, Christoph Hellwig wrote: > From: Andrey Konovalov > > To allow arm64 syscalls to accept tagged pointers from userspace, we must > untag them when they are passed to the kernel. Since untagging is done in > generic parts of the kernel, the untagged_addr macro needs to be defined

[PATCH] powerpc/32s: fix booting with CONFIG_PPC_EARLY_DEBUG_BOOTX

2019-06-03 Thread Christophe Leroy
When booting through OF, setup_disp_bat() does nothing because disp_BAT are not set. By change, it used to work because BOOTX buffer is mapped 1:1 at address 0x8100 by the bootloader, and btext_setup_display() sets virt addr same as phys addr. But since commit 215b823707ce ("powerpc/32s: set u

Re: [PATCH] dlpar: Fix a missing-check bug in dlpar_parse_cc_property()

2019-06-03 Thread Michael Ellerman
On Sun, 2019-05-26 at 02:42:40 UTC, Gen Zhang wrote: > In dlpar_parse_cc_property(), 'prop->name' is allocated by kstrdup(). > kstrdup() may return NULL, so it should be checked and handle error. > And prop should be freed if 'prop->name' is NULL. > > Signed-off-by: Gen Zhang > Acked-by: Nathan L

Re: [PATCH] powerpc/powernv: Update firmware archaeology around OPAL_HANDLE_HMI

2019-06-03 Thread Michael Ellerman
On Fri, 2019-05-24 at 05:09:56 UTC, Stewart Smith wrote: > The first machines to ship with OPAL firmware all got firmware updates > that have the new call, but just in case someone is foolish enough to > believe the first 4 months of firmware is the best, we keep this code > around. > > Comment is

Re: [PATCH] powerpc/powernv: Show checkstop reason for NPU2 HMIs

2019-06-03 Thread Michael Ellerman
On Thu, 2019-05-23 at 12:28:04 UTC, Frederic Barrat wrote: > If the kernel is notified of an HMI caused by the NPU2, it's currently > not being recognized and it logs the default message: > > Unknown Malfunction Alert of type 3 > > The NPU on Power 9 has 3 Fault Isolation Registers, so that's

Re: [PATCH] powerpc: Remove variable ‘path’ since not used

2019-06-03 Thread Michael Ellerman
On Thu, 2019-05-23 at 10:25:20 UTC, Mathieu Malaterre wrote: > In commit eab00a208eb6 ("powerpc: Move `path` variable inside > DEBUG_PROM") DEBUG_PROM sentinels were added to silence a warning > (treated as error with W=1): > > arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set b

Re: [PATCH] powerpc/pseries: Fix xive=off command line

2019-06-03 Thread Michael Ellerman
On Wed, 2019-05-15 at 10:05:01 UTC, Greg Kurz wrote: > On POWER9, if the hypervisor supports XIVE exploitation mode, the guest OS > will unconditionally requests for the XIVE interrupt mode even if XIVE was > deactivated with the kernel command line xive=off. Later on, when the spapr > XIVE init co

Re: [PATCH 1/2] powerpc/lib: fix redundant inclusion of quad.o

2019-06-03 Thread Michael Ellerman
On Mon, 2019-05-13 at 10:00:14 UTC, Christophe Leroy wrote: > quad.o is only for PPC64, and already included in obj64-y, > so it doesn't have to be in obj-y > > Fixes: 31bfdb036f12 ("powerpc: Use instruction emulation infrastructure to > handle alignment faults") > Signed-off-by: Christophe Leroy

Re: [PATCH -next] misc: ocxl: Make ocxl_remove static

2019-06-03 Thread Michael Ellerman
On Sat, 2019-05-04 at 10:27:20 UTC, YueHaibing wrote: > Fix sparse warning: > > drivers/misc/ocxl/pci.c:44:6: warning: > symbol 'ocxl_remove' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > Acked-by: Andrew Donnellan Applied to powerpc next, t

Re: [PATCH -next] powerpc/book3s64: Make some symbols static

2019-06-03 Thread Michael Ellerman
On Sat, 2019-05-04 at 10:24:27 UTC, YueHaibing wrote: > Fix sparse warnings: > > arch/powerpc/mm/book3s64/radix_pgtable.c:326:13: warning: symbol > 'radix_init_pgtable' was not declared. Should it be static? > arch/powerpc/mm/book3s64/hash_native.c:48:1: warning: symbol > 'native_tlbie_lock' was

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-06-03 Thread Michael Ellerman
On Fri, 2019-04-19 at 15:34:13 UTC, Greg Kurz wrote: > Since 902bdc57451c, get_pci_dev() calls pci_get_domain_bus_and_slot(). This > has the effect of incrementing the reference count of the PCI device, as > explained in drivers/pci/search.c: > > * Given a PCI domain, bus, and slot/function numbe

Re: [PATCH v8 3/7] s390/pci: add support for IOMMU default DMA mode build options

2019-06-03 Thread Sebastian Ott
On Thu, 30 May 2019, Zhen Lei wrote: > The default DMA mode is LAZY on s390, this patch make it can be set to > STRICT at build time. It can be overridden by boot option. > > There is no functional change. > > Signed-off-by: Zhen Lei Acked-by: Sebastian Ott

Re: [PATCH 22/22] docs: fix broken documentation links

2019-06-03 Thread Christophe Leroy
Le 30/05/2019 à 01:23, Mauro Carvalho Chehab a écrit : Mostly due to x86 and acpi conversion, several documentation links are still pointing to the old file. Fix them. Signed-off-by: Mauro Carvalho Chehab --- Documentation/acpi/dsd/leds.txt | 2 +- Documentation/admin-gu

Re: [PATCH v3 14/16] powerpc/32: implement fast entry for syscalls on BOOKE

2019-06-03 Thread Christophe Leroy
On 05/28/2019 05:03 PM, Christophe Leroy wrote: Michael Ellerman a écrit : Christophe Leroy writes: Le 23/05/2019 à 09:00, Christophe Leroy a écrit : [...] arch/powerpc/kernel/head_fsl_booke.o: In function `SystemCall': arch/powerpc/kernel/head_fsl_booke.S:416: undefined reference to `

Re: [PATCH v3 1/3] PCI: Introduce pcibios_ignore_alignment_request

2019-06-03 Thread Shawn Anastasio
On 6/3/19 3:35 AM, Alexey Kardashevskiy wrote: On 03/06/2019 15:02, Alexey Kardashevskiy wrote: On 03/06/2019 12:23, Shawn Anastasio wrote: On 5/30/19 10:56 PM, Alexey Kardashevskiy wrote: On 31/05/2019 08:49, Shawn Anastasio wrote: On 5/29/19 10:39 PM, Alexey Kardashevskiy wrote:

Re: [PATCH v3] powerpc/pseries: Fix cpu_hotplug_lock acquisition in resize_hpt()

2019-06-03 Thread Gautham R Shenoy
Hi, On Wed, May 15, 2019 at 01:15:52PM +0530, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > The calls to arch_add_memory()/arch_remove_memory() are always made > with the read-side cpu_hotplug_lock acquired via > memory_hotplug_begin(). On pSeries, > arch_add_memory()/arch_remove_mem

Re: [PATCH] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-03 Thread Christophe Leroy
Le 31/05/2019 à 20:53, Nathan Chancellor a écrit : clang warns: drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case IBMVSCSI_HOST_ACTION_NONE: ^ driv

Re: [PATCH v3 1/3] PCI: Introduce pcibios_ignore_alignment_request

2019-06-03 Thread Alexey Kardashevskiy
On 03/06/2019 15:02, Alexey Kardashevskiy wrote: > > > On 03/06/2019 12:23, Shawn Anastasio wrote: >> >> >> On 5/30/19 10:56 PM, Alexey Kardashevskiy wrote: >>> >>> >>> On 31/05/2019 08:49, Shawn Anastasio wrote: On 5/29/19 10:39 PM, Alexey Kardashevskiy wrote: > > > On 28/05/

[PATCH v3] powerpc: fix kexec failure on book3s/32

2019-06-03 Thread Christophe Leroy
In the old days, _PAGE_EXEC didn't exist on 6xx aka book3s/32. Therefore, allthough __mapin_ram_chunk() was already mapping kernel text with PAGE_KERNEL_TEXT and the rest with PAGE_KERNEL, the entire memory was executable. Part of the memory (first 512kbytes) was mapped with BATs instead of page ta

Re: [PATCH BACKPORTv2 4.19, 5.0, 5.1] crypto: vmx - ghash: do nosimd fallback manually

2019-06-03 Thread Greg KH
On Mon, Jun 03, 2019 at 12:08:48PM +1000, Daniel Axtens wrote: > commit 357d065a44cdd77ed5ff35155a989f2a763e96ef upstream. > [backported: the VMX driver did not use crypto_simd_usable() until > after 5.1] > > VMX ghash was using a fallback that did not support interleaving simd > and nosimd opera

Re: [PATCH 10/16] sparc64: use the generic get_user_pages_fast code

2019-06-03 Thread Christoph Hellwig
On Sun, Jun 02, 2019 at 03:39:48PM +0800, Hillf Danton wrote: > > Hi Christoph > > On Sat, 1 Jun 2019 09:49:53 +0200 Christoph Hellwig wrote: > > > > diff --git a/arch/sparc/include/asm/pgtable_64.h > > b/arch/sparc/include/asm/pgtable_64.h > > index a93eca29e85a..2301ab5250e4 100644 > > ---

Re: [PATCH 08/16] sparc64: add the missing pgd_page definition

2019-06-03 Thread Christoph Hellwig
On Sat, Jun 01, 2019 at 09:28:54AM -0700, Linus Torvalds wrote: > Both sparc64 and sh had this pattern, but now that I look at it more > closely, I think your version is wrong, or at least nonoptimal. I bet it is. Then again these symbols are just required for the code to compile, as neither spar

Re: [RFC PATCH] powerpc/64s: __find_linux_pte synchronization vs pmdp_invalidate

2019-06-03 Thread Christophe Leroy
Le 03/06/2019 à 08:44, Nicholas Piggin a écrit : The pmd_none check does not catch hugepage collapse, nor does the pmd_present check in pmd_trans_huge, because hugepage collapse sets !_PAGE_PRESENT && _PAGE_INVALID (which results in !pmd_none and pmd_present). Aneesh noticed we might need thi

Re: [PATCH 03/16] mm: simplify gup_fast_permitted

2019-06-03 Thread Christoph Hellwig
On Sat, Jun 01, 2019 at 09:14:17AM -0700, Linus Torvalds wrote: > On Sat, Jun 1, 2019 at 12:50 AM Christoph Hellwig wrote: > > > > Pass in the already calculated end value instead of recomputing it, and > > leave the end > start check in the callers instead of duplicating them > > in the arch code

Re: [PATCH] powerpc/64s: Fix THP PMD collapse serialisation

2019-06-03 Thread Nicholas Piggin
Aneesh Kumar K.V's on June 3, 2019 4:43 pm: > On 6/3/19 11:35 AM, Nicholas Piggin wrote: >> Commit 1b2443a547f9 ("powerpc/book3s64: Avoid multiple endian conversion >> in pte helpers") changed the actual bitwise tests in pte_access_permitted >> by using pte_write() and pte_present() helpers rather

Re: [PATCH 09/22] docs: mark orphan documents as such

2019-06-03 Thread Christophe Leroy
Le 30/05/2019 à 01:23, Mauro Carvalho Chehab a écrit : Sphinx doesn't like orphan documents: Documentation/accelerators/ocxl.rst: WARNING: document isn't included in any toctree Documentation/arm/stm32/overview.rst: WARNING: document isn't included in any toctree Documentatio

Re: [WIP RFC PATCH 0/6] Generic Firmware Variable Filesystem

2019-06-03 Thread Greg KH
On Mon, Jun 03, 2019 at 04:04:32PM +1000, Daniel Axtens wrote: > Hi Nayna, > > >> As PowerNV moves towards secure boot, we need a place to put secure > >> variables. One option that has been canvassed is to make our secure > >> variables look like EFI variables. This is an early sketch of another

RE: [next-20190530] Boot failure on PowerPC

2019-06-03 Thread Lili Deng (Wicresoft North America Ltd)
ACK for ' but it fixes the get_swap_device warning messages during the boot.' Double check for kernel panic issue, without this patch, it seems not repro in my local manual environment, so please ignore my previous mail for 'the patch fixes the kernel panic'. Sorry for the confusion. -Origi

Re: [RFC PATCH] powerpc/book3e: KASAN Full support for 64bit

2019-06-03 Thread Christophe Leroy
Hi, Ok, can you share your .config ? Christophe Le 31/05/2019 à 03:29, Daniel Axtens a écrit : Hi Christophe, I tried this on the t4240rdb and it fails to boot if KASAN is enabled. It does boot with the patch applied but KASAN disabled, so that narrows it down a little bit. I need to focus o