[PATCH v2 3/3] ASoC: fsl_micfil: Use SET_SYSTEM_SLEEP_PM_OPS to simplify PM

2023-08-01 Thread Chancel Liu
Use SET_SYSTEM_SLEEP_PM_OPS to simplify suspend and resume function. fsl_micfil_suspend() and fsl_micfil_resume() can be deleted. Signed-off-by: Chancel Liu --- sound/soc/fsl/fsl_micfil.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git

[PATCH v2 2/3] ASoC: fsl_micfil: Add fsl_micfil_use_verid function

2023-08-01 Thread Chancel Liu
fsl_micfil_use_verid() can help to parse the version info in VERID and PARAM registers. Since the two registers are added only on i.MX93 platform, a member flag called use_verid is introduced to soc data structure which indicates acquiring MICFIL version. Signed-off-by: Chancel Liu ---

[PATCH v2 1/3] ASoC: fsl_micfil: Add new registers and new bit definition

2023-08-01 Thread Chancel Liu
MICFIL IP is upgraded on i.MX93 platform. These new registers and new bit definition are added to complete the register list. Signed-off-by: Chancel Liu --- sound/soc/fsl/fsl_micfil.c | 6 ++ sound/soc/fsl/fsl_micfil.h | 28 2 files changed, 34 insertions(+)

[PATCH v2 0/3] Update the register list of MICFIL

2023-08-01 Thread Chancel Liu
MICFIL IP is upgraded on i.MX93 platform. Add new registers and new bit definition. changes in v2: - rename check_version to use_verid to make it more explicit - rename fsl_micfil_check_version to fsl_micfil_use_verid Chancel Liu (3): ASoC: fsl_micfil: Add new registers and new bit definition

Re: [PATCH v7 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block

2023-08-01 Thread Aneesh Kumar K V
On 8/2/23 4:40 AM, Verma, Vishal L wrote: > On Tue, 2023-08-01 at 10:11 +0530, Aneesh Kumar K.V wrote: >> With memmap on memory, some architecture needs more details w.r.t altmap >> such as base_pfn, end_pfn, etc to unmap vmemmap memory. Instead of >> computing them again when we remove a memory

Re: [PATCH v7 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter

2023-08-01 Thread Aneesh Kumar K V
On 8/1/23 4:20 PM, Michal Hocko wrote: > On Tue 01-08-23 14:58:29, Aneesh Kumar K V wrote: >> On 8/1/23 2:28 PM, Michal Hocko wrote: >>> On Tue 01-08-23 10:11:16, Aneesh Kumar K.V wrote: Allow updating memmap_on_memory mode after the kernel boot. Memory hotplug done after the mode update

Re: [PATCH v7 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block

2023-08-01 Thread Verma, Vishal L
On Tue, 2023-08-01 at 10:11 +0530, Aneesh Kumar K.V wrote: > With memmap on memory, some architecture needs more details w.r.t altmap > such as base_pfn, end_pfn, etc to unmap vmemmap memory. Instead of > computing them again when we remove a memory block, embed vmem_altmap > details in struct

Re: [PATCH v7 2/2] PCI: rpaphp: Error out on busy status from get-sensor-state

2023-08-01 Thread Bjorn Helgaas
On Mon, Jul 24, 2023 at 02:25:19PM +0530, Mahesh Salgaonkar wrote: > When certain PHB HW failure causes pHyp to recover PHB, it marks the PE > state as temporarily unavailable until recovery is complete. This also > triggers an EEH handler in Linux which needs to notify drivers, and perform >

[PATCH] powerpc/rtas_flash: allow user copy to flash block cache objects

2023-08-01 Thread Nathan Lynch via B4 Relay
From: Nathan Lynch With hardened usercopy enabled (CONFIG_HARDENED_USERCOPY=y), using the /proc/powerpc/rtas/firmware_update interface to prepare a system firmware update yields a BUG(): kernel BUG at mm/usercopy.c:102! Oops: Exception in kernel mode, sig: 5 [#1] LE PAGE_SIZE=64K MMU=Hash SMP

Re: Login broken with old userspace (was Re: [PATCH v2] selinux: introduce an initial SID for early boot processes)

2023-08-01 Thread Paul Moore
On Tue, Aug 1, 2023 at 9:24 AM Ondrej Mosnacek wrote: > On Fri, Jul 28, 2023 at 5:12 PM Paul Moore wrote: > > > > On Fri, Jul 28, 2023 at 9:24 AM Christian Göttsche > > wrote: > > > > > > On Fri, 28 Jul 2023 at 15:14, Ondrej Mosnacek wrote: > > > > > > > > On Fri, Jul 28, 2023 at 1:52 PM

Re: [PATCH v2] dmaengine: Explicitly include correct DT includes

2023-08-01 Thread Vinod Koul
On Tue, 18 Jul 2023 08:31:35 -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other.

Re: [RFC PATCH v2 5/7] media: imx: fsl_asrc: Add memory to memory driver

2023-08-01 Thread Daniel Baluta
On Tue, Jul 25, 2023 at 10:31 AM Shengjiu Wang wrote: > > Implement the ASRC memory to memory function using > the v4l2 framework, user can use this function with > v4l2 ioctl interface. > > User send the output and capture buffer to driver and > driver store the converted data to the capture

Re: [RFC PATCH v2 1/7] ASoC: fsl_asrc: define functions for memory to memory usage

2023-08-01 Thread Daniel Baluta
> +static int fsl_asrc_m2m_check_format(u8 dir, u32 rate, u32 channels, u32 > format) > +{ > + u64 support_format = FSL_ASRC_FORMATS; > + > + if (channels < 1 || channels > 10) > + return -EINVAL; > + > + if (rate < 5512 || rate > 192000) > + return

Re: Login broken with old userspace (was Re: [PATCH v2] selinux: introduce an initial SID for early boot processes)

2023-08-01 Thread Ondrej Mosnacek
On Fri, Jul 28, 2023 at 5:12 PM Paul Moore wrote: > > On Fri, Jul 28, 2023 at 9:24 AM Christian Göttsche > wrote: > > > > On Fri, 28 Jul 2023 at 15:14, Ondrej Mosnacek wrote: > > > > > > On Fri, Jul 28, 2023 at 1:52 PM Stephen Smalley > > > wrote: > > > > > > > > On Fri, Jul 28, 2023 at 7:36 

Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer

2023-08-01 Thread Herve Codina
On Tue, 1 Aug 2023 12:52:29 +0200 Andrew Lunn wrote: > > > > +static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 > > > > nbr, u8 isr) > > > > +{ > > > > + dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr); > > > > +} > > > > > > Should this be rate

Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer

2023-08-01 Thread Andrew Lunn
> > > +static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 nbr, > > > u8 isr) > > > +{ > > > + dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr); > > > +} > > > > Should this be rate limited? It is going to be very noise if it gets > > called once per frame time.

Re: [PATCH v7 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter

2023-08-01 Thread Michal Hocko
On Tue 01-08-23 14:58:29, Aneesh Kumar K V wrote: > On 8/1/23 2:28 PM, Michal Hocko wrote: > > On Tue 01-08-23 10:11:16, Aneesh Kumar K.V wrote: > >> Allow updating memmap_on_memory mode after the kernel boot. Memory > >> hotplug done after the mode update will use the new mmemap_on_memory > >>

Re: [PATCH v2 26/28] ASoC: codecs: Add support for the framer codec

2023-08-01 Thread Herve Codina
On Tue, 1 Aug 2023 12:30:26 +0200 Andrew Lunn wrote: > On Wed, Jul 26, 2023 at 05:02:22PM +0200, Herve Codina wrote: > > The framer codec interracts with a framer. > > It allows to use some of the framer timeslots as audio channels to > > transport audio data over the framer E1/T1/J1 lines. > >

Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer

2023-08-01 Thread Herve Codina
On Tue, 1 Aug 2023 12:22:39 +0200 Andrew Lunn wrote: > > +static inline u8 pef2256_read8(struct pef2256 *pef2256, int offset) > > +{ > > + int val; > > + > > + regmap_read(pef2256->regmap, offset, ); > > + return val; > > +} > > + > > +static inline void pef2256_write8(struct pef2256

Re: [PATCH v2 21/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-08-01 Thread Herve Codina
On Tue, 1 Aug 2023 12:05:07 +0200 Andrew Lunn wrote: > > + clocks: > > +items: > > + - description: Master clock > > + - description: Receive System Clock > > + - description: Transmit System Clock > > + > > + clock-names: > > +items: > > + - const: mclk > > +

Re: [PATCH v2 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer

2023-08-01 Thread Andrew Lunn
> The generic framer has: > - 2 consumers (QMC HDLC drv and codec) > - 1 provider (PEF2256) > > So, the design is the following: > +--+ +-+ > | QMC | <- TDM -> | PEF2256 | <-> E1 > +-+

Re: [PATCH v2 20/28] net: wan: Add framer framework support

2023-08-01 Thread Herve Codina
On Tue, 1 Aug 2023 11:56:12 +0200 Andrew Lunn wrote: > > +int framer_pm_runtime_get(struct framer *framer) > > +{ > > + int ret; > > + > > + if (!framer) > > + return 0; > > Can framer be a NULL pointer? This sort of test often covers up > bugs. So either let it dereference the

Re: [PATCH v2 26/28] ASoC: codecs: Add support for the framer codec

2023-08-01 Thread Andrew Lunn
On Wed, Jul 26, 2023 at 05:02:22PM +0200, Herve Codina wrote: > The framer codec interracts with a framer. > It allows to use some of the framer timeslots as audio channels to > transport audio data over the framer E1/T1/J1 lines. > It also reports line carrier detection events through the ALSA

[PATCH] powerpc/64e: Fix secondary thread bringup for ELFv2 kernels

2023-08-01 Thread Michael Ellerman
When booting on e6500 with an ELF v2 ABI kernel, the secondary threads do not start correctly: [0.051118] smp: Bringing up secondary CPUs ... [5.072700] Processor 1 is stuck. This occurs because the startup code is written to use function descriptors when loading the entry point

Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*

2023-08-01 Thread Herve Codina
On Tue, 1 Aug 2023 11:36:43 +0200 Andrew Lunn wrote: > > +static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set) > > +{ > > + qmc_write16(addr, (qmc_read16(addr) & ~clr) | set); > > +} > > + > > Please don't use inline in .c files. Let the compiler decide. > >

Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer

2023-08-01 Thread Andrew Lunn
> +static inline u8 pef2256_read8(struct pef2256 *pef2256, int offset) > +{ > + int val; > + > + regmap_read(pef2256->regmap, offset, ); > + return val; > +} > + > +static inline void pef2256_write8(struct pef2256 *pef2256, int offset, u8 > val) > +{ > +

Re: [PATCH v2 06/28] net: wan: Add support for QMC HDLC

2023-08-01 Thread Herve Codina
On Tue, 1 Aug 2023 11:31:32 +0200 Andrew Lunn wrote: > > +static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device > > *netdev) > > +{ > > + return (struct qmc_hdlc *)dev_to_hdlc(netdev)->priv; > > priv is a void *, so you don't need the cast. > Right, I will change in the

Re: [PATCH v2 08/28] soc: fsl: cpm1: qmc: Introduce available timeslots masks

2023-08-01 Thread Herve Codina
On Tue, 1 Aug 2023 11:33:39 +0200 Andrew Lunn wrote: > On Wed, Jul 26, 2023 at 05:02:04PM +0200, Herve Codina wrote: > > Available timeslots masks define timeslots available for the related > > channel. These timeslots are defined by the QMC binding. > > > > Timeslots used are initialized to

Re: [PATCH v2 21/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-08-01 Thread Andrew Lunn
> + clocks: > +items: > + - description: Master clock > + - description: Receive System Clock > + - description: Transmit System Clock > + > + clock-names: > +items: > + - const: mclk > + - const: sclkr > + - const: sclkx Nit pick, but "Receive System

Re: [PATCH v2 20/28] net: wan: Add framer framework support

2023-08-01 Thread Andrew Lunn
> +int framer_pm_runtime_get(struct framer *framer) > +{ > + int ret; > + > + if (!framer) > + return 0; Can framer be a NULL pointer? This sort of test often covers up bugs. So either let it dereference the NULL pointer and opps, or return -EINVAL. Andrew

Re: [PATCH 0/7] Rework perf and ptrace watchpoint tracking

2023-08-01 Thread Christophe Leroy
Le 01/08/2023 à 03:17, Benjamin Gray a écrit : > Syzkaller triggered a null pointer dereference in the > arch_unregister_hw_breakpoint() hook. This is due to accessing > the bp->ctx->task field changing to -1 while we iterate the breakpoints. > > This series refactors the breakpoint tracking

Re: [RFC PATCH v2 4/7] media: v4l2: Add audio capture and output support

2023-08-01 Thread Shengjiu Wang
On Fri, Jul 28, 2023 at 3:59 PM Tomasz Figa wrote: > > Hi Shengjiu, > > On Tue, Jul 25, 2023 at 02:12:17PM +0800, Shengjiu Wang wrote: > > Audio signal processing has the requirement for memory to > > memory similar as Video. > > > > This patch is to add this support in v4l2 framework, defined >

Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*

2023-08-01 Thread Andrew Lunn
> +static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set) > +{ > + qmc_write16(addr, (qmc_read16(addr) & ~clr) | set); > +} > + Please don't use inline in .c files. Let the compiler decide. Andrew

Re: [PATCH v2 08/28] soc: fsl: cpm1: qmc: Introduce available timeslots masks

2023-08-01 Thread Andrew Lunn
On Wed, Jul 26, 2023 at 05:02:04PM +0200, Herve Codina wrote: > Available timeslots masks define timeslots available for the related > channel. These timeslots are defined by the QMC binding. > > Timeslots used are initialized to available timeslots but can be a > subset of available timeslots. >

Re: [PATCH v2 06/28] net: wan: Add support for QMC HDLC

2023-08-01 Thread Andrew Lunn
> +static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device *netdev) > +{ > + return (struct qmc_hdlc *)dev_to_hdlc(netdev)->priv; priv is a void *, so you don't need the cast. Andrew

Re: [PATCH v7 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter

2023-08-01 Thread Aneesh Kumar K V
On 8/1/23 2:28 PM, Michal Hocko wrote: > On Tue 01-08-23 10:11:16, Aneesh Kumar K.V wrote: >> Allow updating memmap_on_memory mode after the kernel boot. Memory >> hotplug done after the mode update will use the new mmemap_on_memory >> value. > > Well, this is a user space kABI extension and as

Re: [syzbot] [btrfs?] WARNING in btrfs_free_reserved_data_space_noquota

2023-08-01 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 487c20b016dc48230367a7be017f40313e53e3bd Author: Linus Torvalds Date: Thu Mar 30 21:53:51 2023 + iov: improve copy_iovec_from_user() code generation bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17cfdf19a8

Re: [PATCH v7 0/7] Add support for memmap on memory feature on ppc64

2023-08-01 Thread Michal Hocko
I cannot really judge the ppc specific part but other patches seem reasonable. Patch 4 could print a more useful information about the wastage but this is nothing really earth shattering. I am not sure about the last patch which makes the on-memory property dynamic. This needs much more

Re: [PATCH v7 4/7] mm/memory_hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks

2023-08-01 Thread Michal Hocko
On Tue 01-08-23 10:11:13, Aneesh Kumar K.V wrote: [...] > + if (mode == MEMMAP_ON_MEMORY_FORCE) { > + unsigned long memmap_pages = > memory_block_memmap_on_memory_pages(); unsigned long wastage = memmap_pages - PFN_UP(memory_block_memmap_size());

Re: [PATCH v7 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter

2023-08-01 Thread Michal Hocko
On Tue 01-08-23 10:11:16, Aneesh Kumar K.V wrote: > Allow updating memmap_on_memory mode after the kernel boot. Memory > hotplug done after the mode update will use the new mmemap_on_memory > value. Well, this is a user space kABI extension and as such you should spend more words about the

Re: [PATCH] Documentation: devices.txt: reconcile serial/ucc_uart minor numers

2023-08-01 Thread Christophe Leroy
Le 01/08/2023 à 07:30, Randy Dunlap a écrit : > Hi Christophe, > > On 7/31/23 22:21, Christophe Leroy wrote: >> >> >> Le 24/07/2023 à 08:33, Randy Dunlap a écrit : >>> Reconcile devices.txt with serial/ucc_uart.c regarding device number >>> assignments. ucc_uart.c supports 4 ports and uses