Re: [PATCH 0/3] Fix for shellcheck issues with version "0.6"

2023-09-27 Thread Namhyung Kim
On Tue, Sep 26, 2023 at 9:29 PM Athira Rajeev wrote: > > > > > On 25-Sep-2023, at 1:34 PM, kajoljain wrote: > > > > > > > > On 9/7/23 22:45, Athira Rajeev wrote: > >> From: root > >> > >> shellcheck was run on perf tool shell scripts s a pre-requisite > >> to include a build option for

Re: Fwd: [PATCH] powerpc/ptrace: Fix buffer overflow when handling PTRACE_PEEKUSER and PTRACE_POKEUSER

2023-09-27 Thread Michael Ellerman
Hi Ariel, I'm sorry about the way I handled your patch. I should have spent more time working with you to develop your patch. I agree that the Reported-by tag doesn't properly reflect the contribution you made, I should have realised that at the time. cheers (Apologies for the brief reply,

[PATCH v2 2/9] iommu/vt-d: Update the definition of the blocking domain

2023-09-27 Thread Jason Gunthorpe
The global static should pre-define the type and the NOP free function can be now left as NULL. Reviewed-by: Lu Baolu Signed-off-by: Jason Gunthorpe --- drivers/iommu/intel/iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/intel/iommu.c

[PATCH v2 0/9] iommu: Convert dart & iommufd to the new domain_alloc_paging()

2023-09-27 Thread Jason Gunthorpe
Continue converting drivers to the new interface. Introduce ops->blocked_domain to hold the global static BLOCKED domain and convert all drivers supporting BLOCKED to use it. This makes it trivial for dart and iommufd to convert over to domain_alloc_paging(). There are six drivers remaining:

[PATCH v2 9/9] iommu/dart: Remove the force_bypass variable

2023-09-27 Thread Jason Gunthorpe
This flag just caches if the IO page size is larger than the CPU PAGE_SIZE. This only needs to be checked in two places so remove the confusingly named cache. dart would like to not support paging domains at all if the IO page size is larger than the CPU page size. In this case we should ideally

[PATCH v2 4/9] iommufd: Convert to alloc_domain_paging()

2023-09-27 Thread Jason Gunthorpe
Move the global static blocked domain to the ops and convert the unmanaged domain to domain_alloc_paging. Signed-off-by: Jason Gunthorpe --- drivers/iommu/iommufd/selftest.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/iommufd/selftest.c

[PATCH v2 8/9] iommu/dart: Call apple_dart_finalize_domain() as part of alloc_paging()

2023-09-27 Thread Jason Gunthorpe
In many cases the dev argument will now be !NULL so we should use it to finalize the domain at allocation. Make apple_dart_finalize_domain() accept the correct type. Reviewed-by: Janne Grunau Signed-off-by: Jason Gunthorpe --- drivers/iommu/apple-dart.c | 28 +++- 1

[PATCH v2 5/9] iommu/dart: Use static global identity domains

2023-09-27 Thread Jason Gunthorpe
Move to the new static global for identity domains. Move the identity specific code to apple_dart_attach_dev_identity(). Reviewed-by: Janne Grunau Signed-off-by: Jason Gunthorpe --- drivers/iommu/apple-dart.c | 39 +++--- 1 file changed, 28 insertions(+), 11

[PATCH v2 1/9] iommu: Move IOMMU_DOMAIN_BLOCKED global statics to ops->blocked_domain

2023-09-27 Thread Jason Gunthorpe
Following the pattern of identity domains, just assign the BLOCKED domain global statics to a value in ops. Update the core code to use the global static directly. Update powerpc to use the new scheme and remove its empty domain_alloc callback. Reviewed-by: Lu Baolu Signed-off-by: Jason

[PATCH v2 6/9] iommu/dart: Move the blocked domain support to a global static

2023-09-27 Thread Jason Gunthorpe
Move to the new static global for blocked domains. Move the blocked specific code to apple_dart_attach_dev_blocked(). Reviewed-by: Janne Grunau Signed-off-by: Jason Gunthorpe --- drivers/iommu/apple-dart.c | 53 +++--- 1 file changed, 32 insertions(+), 21

[PATCH v2 7/9] iommu/dart: Convert to domain_alloc_paging()

2023-09-27 Thread Jason Gunthorpe
Since the IDENTITY and BLOCKED behaviors were moved to global statics all that remains is the paging domain. Rename to apple_dart_attach_dev_paging() and remove the left over type check. Reviewed-by: Janne Grunau Signed-off-by: Jason Gunthorpe --- drivers/iommu/apple-dart.c | 13 +

[PATCH v2 3/9] iommu/vt-d: Use ops->blocked_domain

2023-09-27 Thread Jason Gunthorpe
Trivially migrate to the ops->blocked_domain for the existing global static. Reviewed-by: Lu Baolu Signed-off-by: Jason Gunthorpe --- drivers/iommu/intel/iommu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c

Re: [PATCH 00/40] soc: Convert to platform remove callback returning void

2023-09-27 Thread Bjorn Andersson
On Wed, Sep 27, 2023 at 10:43:16AM +0200, Arnd Bergmann wrote: > On Wed, Sep 27, 2023, at 04:25, Joel Stanley wrote: > > On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König > > wrote: > >> > >> this series converts all platform drivers below drivers/soc to use > >> .remove_new(). The motivation is

Re: [PATCH v7 1/3 RESEND] block:sed-opal: SED Opal keystore

2023-09-27 Thread Nick Desaulniers
On Wed, Sep 27, 2023 at 1:26 PM Greg Joyce wrote: > > On Wed, 2023-09-13 at 13:49 -0700, Nick Desaulniers wrote: > > On Wed, Sep 13, 2023 at 9:56 AM Nathan Chancellor > > wrote: > > > Hi Greg, > > > > > > On Fri, Sep 08, 2023 at 10:30:54AM -0500, gjo...@linux.vnet.ibm.com > > > wrote: > > > >

Re: [PATCH v7 1/3 RESEND] block:sed-opal: SED Opal keystore

2023-09-27 Thread Greg Joyce
On Wed, 2023-09-13 at 13:49 -0700, Nick Desaulniers wrote: > On Wed, Sep 13, 2023 at 9:56 AM Nathan Chancellor > wrote: > > Hi Greg, > > > > On Fri, Sep 08, 2023 at 10:30:54AM -0500, gjo...@linux.vnet.ibm.com > > wrote: > > > From: Greg Joyce > > > > > > Add read and write functions that

Re: Fwd: [PATCH] powerpc/ptrace: Fix buffer overflow when handling PTRACE_PEEKUSER and PTRACE_POKEUSER

2023-09-27 Thread Ariel Miculas
On Wed, Sep 27, 2023 at 7:01 PM Christophe Leroy wrote: > > > > Le 27/09/2023 à 17:27, Ariel Miculas a écrit : > > I've forwarded this old email thread for visibility and discussion's > > sake around my recent blog post [1][2] > > Ah, right, it's been superseded by >

[PATCH V3] perf test: Fix parse-events tests to skip parametrized events

2023-09-27 Thread Athira Rajeev
Testcase "Parsing of all PMU events from sysfs" parse events for all PMUs, and not just cpu. In case of powerpc, the PowerVM environment supports events from hv_24x7 and hv_gpci PMU which is of example format like below: - hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/ - hv_gpci/event,partition_id=?/

Re: [PATCH v7 3/3 RESEND] powerpc/pseries: PLPKS SED Opal keystore support

2023-09-27 Thread Greg Joyce
On Wed, 2023-09-13 at 13:15 -0600, Jens Axboe wrote: > On 9/13/23 12:59 PM, Nathan Chancellor wrote: > > Hi Greg, > > > > On Fri, Sep 08, 2023 at 10:30:56AM -0500, gjo...@linux.vnet.ibm.com > > wrote: > > > From: Greg Joyce > > > > > > Define operations for SED Opal to read/write keys > > >

Re: [PATCH] uapi/auxvec: Define AT_HWCAP3 and AT_HWCAP4 aux vector, entries

2023-09-27 Thread Adhemerval Zanella Netto
On 26/09/23 19:02, Peter Bergner wrote: > The powerpc toolchain keeps a copy of the HWCAP bit masks in our TCB for fast > access by our __builtin_cpu_supports built-in function. The TCB space for > the HWCAP entries - which are created in pairs - is an ABI extension, so > waiting to create the

Re: Fwd: [PATCH] powerpc/ptrace: Fix buffer overflow when handling PTRACE_PEEKUSER and PTRACE_POKEUSER

2023-09-27 Thread Christophe Leroy
Le 27/09/2023 à 17:27, Ariel Miculas a écrit : > I've forwarded this old email thread for visibility and discussion's > sake around my recent blog post [1][2] Ah, right, it's been superseded by https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220609133245.573565-1-...@ellerman.id.au/

[PATCH v11 17/20] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

2023-09-27 Thread Robert Richter
In Restricted CXL Device (RCD) mode a CXL device is exposed as an RCiEP, but CXL downstream and upstream ports are not enumerated and not visible in the PCIe hierarchy. [1] Protocol and link errors from these non-enumerated ports are signaled as internal AER errors, either Uncorrectable Internal

[PATCH v11 18/20] PCI/AER: Unmask RCEC internal errors to enable RCH downstream port error handling

2023-09-27 Thread Robert Richter
AER corrected and uncorrectable internal errors (CIE/UIE) are masked in their corresponding mask registers per default once in power-up state. [1][2] Enable internal errors for RCECs to receive CXL downstream port errors of Restricted CXL Hosts (RCHs). [1] CXL 3.0 Spec, 12.2.1.1 - RCH Downstream

[PATCH v11 12/20] PCI/AER: Refactor cper_print_aer() for use by CXL driver module

2023-09-27 Thread Robert Richter
From: Terry Bowman The CXL driver plans to use cper_print_aer() for logging restricted CXL host (RCH) AER errors. cper_print_aer() is not currently exported and therefore not usable by the CXL drivers built as loadable modules. Export the cper_print_aer() function. Use the EXPORT_SYMBOL_NS_GPL()

Re: Fwd: [PATCH] powerpc/ptrace: Fix buffer overflow when handling PTRACE_PEEKUSER and PTRACE_POKEUSER

2023-09-27 Thread Ariel Miculas
I've forwarded this old email thread for visibility and discussion's sake around my recent blog post [1][2] Regards, Ariel [1] https://news.ycombinator.com/item?id=37671991 [2]

Re: [PATCH V4 2/2] tools/perf/tests: Fix object code reading to skip address that falls out of text section

2023-09-27 Thread Athira Rajeev
> On 27-Sep-2023, at 5:45 AM, Namhyung Kim wrote: > > On Thu, Sep 14, 2023 at 10:40 PM Athira Rajeev > wrote: >> >> The testcase "Object code reading" fails in somecases >> for "fs_something" sub test as below: >> >>Reading object code for memory address: 0xc00807f0142c >>File

Re: Fwd: [PATCH] powerpc/ptrace: Fix buffer overflow when handling PTRACE_PEEKUSER and PTRACE_POKEUSER

2023-09-27 Thread Christophe Leroy
Hello, Le 27/09/2023 à 12:13, Ariel Miculas a écrit : > -- Forwarded message - > From: Ariel Miculas > Date: Thu, Jun 9, 2022 at 1:31 PM > Subject: Fwd: [PATCH] powerpc/ptrace: Fix buffer overflow when > handling PTRACE_PEEKUSER and PTRACE_POKEUSER > To: Any reason for

RE: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-27 Thread Roy Zang
> -Original Message- > From: Frank Li > Sent: Tuesday, September 26, 2023 9:05 AM > From: Guanhua Gao > > Set DMA mask and coherent DMA mask to enable 64-bit addressing. > > Signed-off-by: Guanhua Gao > Signed-off-by: Hou Zhiqiang > Signed-off-by: Frank Li > --- > > Notes: >

Re: [PATCH 6/8] iommu/dart: Move the blocked domain support to a global static

2023-09-27 Thread Jason Gunthorpe
On Tue, Sep 26, 2023 at 09:05:08PM +0200, Janne Grunau wrote: > > +static int apple_dart_attach_dev_blocked(struct iommu_domain *domain, > > +struct device *dev) > > +{ > > + struct apple_dart_master_cfg *cfg = dev_iommu_priv_get(dev); > > + struct

Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-27 Thread Manivannan Sadhasivam
On Tue, Sep 26, 2023 at 10:04:45AM -0400, Frank Li wrote: > From: Guanhua Gao > > Set DMA mask and coherent DMA mask to enable 64-bit addressing. > > Signed-off-by: Guanhua Gao > Signed-off-by: Hou Zhiqiang > Signed-off-by: Frank Li Acked-by: Manivannan Sadhasivam - Mani > --- > >

Fwd: [PATCH] powerpc/ptrace: Fix buffer overflow when handling PTRACE_PEEKUSER and PTRACE_POKEUSER

2023-09-27 Thread Ariel Miculas
-- Forwarded message - From: Ariel Miculas Date: Thu, Jun 9, 2022 at 1:31 PM Subject: Fwd: [PATCH] powerpc/ptrace: Fix buffer overflow when handling PTRACE_PEEKUSER and PTRACE_POKEUSER To: Forwarded Conversation Subject: [PATCH] powerpc/ptrace: Fix buffer overflow when

Re: Re: [PATCH v2 1/2] ASoC: dt-bindings: fsl_rpmsg: List DAPM endpoints ignoring system suspend

2023-09-27 Thread Mark Brown
On Wed, Sep 27, 2023 at 03:07:49AM +, Chancel Liu wrote: > > This is a fairly standard DSP playback case as far as I can see so it > > should work with DAPM without needing this obviously use case specific > > stuff peering into the Linux implementation. Generally this is done by > > tagging

Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-27 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

Re: [PATCH v2] cpufreq: pmac32: Use of_property_read_reg() to parse "reg"

2023-09-27 Thread Viresh Kumar
On 25-09-23, 14:02, Rob Herring wrote: > Use the recently added of_property_read_reg() helper to get the > untranslated "reg" address value. > > Acked-by: Viresh Kumar > Signed-off-by: Rob Herring > --- > v2: > - Add missing include > --- > drivers/cpufreq/pmac32-cpufreq.c | 7 +++ > 1

Re: [PATCH 00/40] soc: Convert to platform remove callback returning void

2023-09-27 Thread Arnd Bergmann
On Wed, Sep 27, 2023, at 04:25, Joel Stanley wrote: > On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König > wrote: >> >> this series converts all platform drivers below drivers/soc to use >> .remove_new(). The motivation is to get rid of an integer return code >> that is (mostly) ignored by the

Re: [PATCH v6 08/30] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC

2023-09-27 Thread Herve Codina
Hi Krzysztof, On Tue, 26 Sep 2023 22:59:14 +0200 Krzysztof Kozlowski wrote: > On 25/09/2023 15:50, Herve Codina wrote: > > With these details, do you still think I need to change the child > > (channel) > > compatible ? > > From OS point of view, you have a driver

Re: [PATCH 06/40] soc/fsl: cpm: qmc: Convert to platform remove callback returning void

2023-09-27 Thread Herve Codina
On Mon, 25 Sep 2023 11:54:57 +0200 Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting

Re: [PATCH 07/40] soc/fsl: cpm: tsa: Convert to platform remove callback returning void

2023-09-27 Thread Herve Codina
Hi Uwe, On Mon, 25 Sep 2023 11:54:58 +0200 Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from

Re: [PATCH v3 2/3] KEYS: trusted: Introduce support for NXP DCP-based trusted keys

2023-09-27 Thread David Gstir
Jarkko, > On 25.09.2023, at 17:34, Jarkko Sakkinen wrote: > > On Mon Sep 18, 2023 at 5:18 PM EEST, David Gstir wrote: >> DCP (Data Co-Processor) is the little brother of NXP's CAAM IP. >> >> Beside of accelerated crypto operations, it also offers support for >> hardware-bound keys. Using this

Re: [PATCH v3 1/3] crypto: mxs-dcp: Add support for hardware provided keys

2023-09-27 Thread David Gstir
Jarkko, > On 25.09.2023, at 17:22, Jarkko Sakkinen wrote: > > On Mon Sep 18, 2023 at 5:18 PM EEST, David Gstir wrote: >> DCP is capable to performing AES with hardware-bound keys. >> These keys are not stored in main memory and are therefore not directly >> accessible by the operating system.