Re: [PATCH v0 1/2] DMA: fsldma: Disable DMA_INTERRUPT when Async_tx enabled

2009-10-16 Thread Ira W. Snyder
On Thu, Oct 15, 2009 at 06:25:14PM -0700, Dan Williams wrote: [ added Leo and Timur to the Cc ] On Wed, Oct 14, 2009 at 11:41 PM, Vishnu Suresh vis...@freescale.com wrote: This patch disables the use of DMA_INTERRUPT capability with Async_tx The fsldma produces a null transfer with

Re: PCI interrupt question

2009-12-03 Thread Ira W. Snyder
On Thu, Dec 03, 2009 at 11:52:25AM -0800, David Hawkins wrote: Hi Jeff, yes. We are using a canyonlands board with 460ex. Ok. 2. You have some PCI device - what? Have you tested it works in a standard PCI bus? Eg. ran lspci from an x86 host. It is a FPGA board that we are

Re: PCI interrupt question

2009-12-03 Thread Ira W. Snyder
On Thu, Dec 03, 2009 at 11:39:00AM -0800, Jeff Hane wrote: On Thu, 2009-12-03 at 09:11 -0800, David Hawkins wrote: Hi Jeff, I'm trying to get interrupts working for my PCI device on a 460ex and am having problem. My ISR never triggers. I'm new to PCI(and ppc) and LDD said that

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-17 Thread Ira W. Snyder
On Wed, Dec 16, 2009 at 03:47:48PM -0700, Dan Williams wrote: Kumar Gala wrote: Changes with respect to v1 as per comments received o. Rebased to linux-next as of 20091216 o. The selection is based exclusive of fsldma o. Intoduced a new Kernel Configuration variable *. This enables

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-26 Thread Ira W. Snyder
On Fri, Dec 18, 2009 at 03:17:42PM -0700, Dan Williams wrote: On Fri, Dec 18, 2009 at 8:02 AM, Li Yang-R58472 r58...@freescale.com wrote: Subject: Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload Ira W. Snyder wrote: Yes, I have used the device_prep_dma_interrupt

fsldma: cleanup driver and fix async_tx compatibility

2009-12-31 Thread Ira W. Snyder
This patch series cleans up the Freescale DMAEngine driver, including verifying the locking and making sure that all code paths are correct. There were a few places that seemed suspicious, and they have been fixed. I have written a quick memory-memory DMAEngine test driver, and the performance is

[PATCH 2/8] fsldma: remove unused structure members

2009-12-31 Thread Ira W. Snyder
Remove some unused members from the fsldma data structures. A few trivial uses of struct resource were converted to use the stack rather than keeping the memory allocated for the lifetime of the driver. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 17

[PATCH 1/8] fsldma: reduce kernel text size

2009-12-31 Thread Ira W. Snyder
-52 fsl_chan_xfer_ld_queue 500 436 -64 Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 83 +++--- 1 files changed, 45 insertions(+), 38 deletions(-) diff --git a/drivers/dma/fsldma.c b

[PATCH 4/8] fsldma: rename dest to dst for uniformity

2009-12-31 Thread Ira W. Snyder
Most functions in the standard library use dst as a parameter, rather than dest. This renames all use of dest to dst to match the usual convention. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 32 drivers/dma/fsldma.h |2

[PATCH 3/8] fsldma: rename struct fsl_dma_chan to struct fsldma_chan

2009-12-31 Thread Ira W. Snyder
This is the beginning of a cleanup which will change all instances of fsl_dma to fsldma to match the name of the driver itself. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 128 ++--- drivers/dma/fsldma.h | 26

[PATCH 6/8] fsldma: simplify IRQ probing and handling

2009-12-31 Thread Ira W. Snyder
by removing the controller's interrupt property from the device tree. Testing has not shown any problems with this configuration. All in-tree device trees already have an interrupt property specified for each channel. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- Documentation/powerpc/dts

[PATCH 5/8] fsldma: clean up the OF subsystem routines

2009-12-31 Thread Ira W. Snyder
This fixes some errors in the cleanup paths of the OF subsystem, including missing checks for ioremap failing. Also, some variables were renamed for brevity. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 259

[PATCH 8/8] fsldma: major cleanups and fixes

2009-12-31 Thread Ira W. Snyder
of descriptors are freed in a loop. Create functions to handle this, and use them instead of open-coding the loop each time. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 386 ++--- drivers/dma/fsldma.h |3 +- 2 files

[PATCH 7/8] fsldma: rename fsl_chan to fchan

2009-12-31 Thread Ira W. Snyder
The name fsl_chan seems too long, so it has been shortened to fchan. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 446 +- 1 files changed, 223 insertions(+), 223 deletions(-) diff --git a/drivers/dma/fsldma.c b

Re: [PATCH 7/8] fsldma: rename fsl_chan to fchan

2010-01-06 Thread Ira W. Snyder
On Wed, Jan 06, 2010 at 12:04:22PM -0600, Scott Wood wrote: On Thu, Dec 31, 2009 at 10:10:45PM -0800, Ira W. Snyder wrote: The name fsl_chan seems too long, so it has been shortened to fchan. Could be just chan, no need for namespacing here. True. A few functions have a parameter struct

Re: [PATCH 6/8] fsldma: simplify IRQ probing and handling

2010-01-06 Thread Ira W. Snyder
On Wed, Jan 06, 2010 at 12:02:26PM -0600, Scott Wood wrote: On Thu, Dec 31, 2009 at 10:10:44PM -0800, Ira W. Snyder wrote: The IRQ probing is needlessly complex. All off the 83xx device trees in arch/powerpc/boot/dts/ specify 5 interrupts per DMA controller: one for the controller, and one

Re: [PATCH 7/8] fsldma: rename fsl_chan to fchan

2010-01-06 Thread Ira W. Snyder
On Wed, Jan 06, 2010 at 12:27:11PM -0600, Scott Wood wrote: Ira W. Snyder wrote: On Wed, Jan 06, 2010 at 12:04:22PM -0600, Scott Wood wrote: On Thu, Dec 31, 2009 at 10:10:45PM -0800, Ira W. Snyder wrote: The name fsl_chan seems too long, so it has been shortened to fchan. Could be just

[PATCH 0/8 v2] fsldma: cleanup driver and fix async_tx compatibility

2010-01-06 Thread Ira W. Snyder
This patch series cleans up the Freescale DMAEngine driver, including verifying the locking and making sure that all code paths are correct. There were a few places that seemed suspicious, and they have been fixed. I have written a quick memory-memory DMAEngine test driver, and the performance is

[PATCH 4/8] fsldma: rename dest to dst for uniformity

2010-01-06 Thread Ira W. Snyder
Most functions in the standard library use dst as a parameter, rather than dest. This renames all use of dest to dst to match the usual convention. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 32 drivers/dma/fsldma.h |2

[PATCH 1/8] fsldma: reduce kernel text size

2010-01-06 Thread Ira W. Snyder
-52 fsl_chan_xfer_ld_queue 500 436 -64 Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 83 +++--- 1 files changed, 45 insertions(+), 38 deletions(-) diff --git a/drivers/dma/fsldma.c b

[PATCH 2/8] fsldma: remove unused structure members

2010-01-06 Thread Ira W. Snyder
Remove some unused members from the fsldma data structures. A few trivial uses of struct resource were converted to use the stack rather than keeping the memory allocated for the lifetime of the driver. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 17

[PATCH 3/8] fsldma: rename struct fsl_dma_chan to struct fsldma_chan

2010-01-06 Thread Ira W. Snyder
This is the beginning of a cleanup which will change all instances of fsl_dma to fsldma to match the name of the driver itself. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 128 ++--- drivers/dma/fsldma.h | 26

[PATCH 7/8] fsldma: rename fsl_chan to chan

2010-01-06 Thread Ira W. Snyder
The name fsl_chan seems too long, so it has been shortened to chan. There are only a few places where the higher level struct dma_chan *chan name conflicts. These have been changed to struct dma_chan *dchan instead. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c

Re: fsldma: cleanup driver and fix async_tx compatibility

2010-01-11 Thread Ira W. Snyder
(approx 100,000 ns / 0.1ms). This is probably at or near the limits of my measurement accuracy. Ira Regards, Dipen -Original Message- From: Dudhat Dipen-B09055 Sent: Tuesday, January 05, 2010 11:38 AM To: 'Ira W. Snyder'; dan.j.willi...@intel.com Cc: ga...@kernel.crashing.org

Re: [async_tx-next PATCH 1/2] fsldma: Fix cookie issues

2010-02-25 Thread Ira W. Snyder
On Mon, Feb 22, 2010 at 11:40:31AM -0600, Steven J. Magnani wrote: fsl_dma_tx_submit() only sets the cookie on the first descriptor of a transaction. It should set the cookie on all. Signed-off-by: Steven J. Magnani st...@digidescorp.com --- diff -uprN a/drivers/dma/fsldma.c

Re: [async_tx-next PATCH 2/2] fsldma: Fix cookie issues

2010-02-25 Thread Ira W. Snyder
On Mon, Feb 22, 2010 at 09:26:13PM +0100, Guennadi Liakhovetski wrote: On Mon, 22 Feb 2010, Steven J. Magnani wrote: diff -uprN a/include/linux/dmaengine.h b/include/linux/dmaengine.h --- a/include/linux/dmaengine.h 2010-02-22 11:18:11.0 -0600 +++ b/include/linux/dmaengine.h

Re: [RFC v3] net: add PCINet driver

2010-03-31 Thread Ira W. Snyder
() and friends * add message unit to MPC8349EMDS dts file Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- This is the third RFC posting of this driver. I got some feedback, and have corrected the problems. Thanks to everyone who has done review! I have gotten off-list feedback

Re: [Patch v2 1/2] 5200/mpc: improve i2c bus error recovery

2010-05-05 Thread Ira W. Snyder
On Wed, Feb 17, 2010 at 07:59:14PM +0100, Albrecht Dreß wrote: This patch improves the recovery of the MPC's I2C bus from errors like bus hangs resulting in timeouts: 1. make the bus timeout configurable, as it depends on the bus clock and the attached slave chip(s); default is still 1

Re: How to use mpc8xxx_gpio.c device driver

2010-08-11 Thread Ira W. Snyder
On Wed, Aug 11, 2010 at 07:49:40PM +0530, Ravi Gupta wrote: Also, when I try to export a gpio in sysfs echo 9 /sys/class/gpio/export It gives me an error in dmesg gpio_request: gpio-9 (sysfs) status -22 export_store: status -22 Here is a look of sysfs on my machine # ls

Re: How to use mpc8xxx_gpio.c device driver

2010-08-12 Thread Ira W. Snyder
On Thu, Aug 12, 2010 at 03:55:49PM +0530, Ravi Gupta wrote: On Wed, Aug 11, 2010 at 9:45 PM, MJ embd mj.e...@gmail.com wrote: u can directly access GPIO registers in kernel, by ioremap of GPIO memory mapped registers. you might need to check - muxing of gpio -mj Hi MJ,

Re: Distinguish between kernel and user space

2010-08-16 Thread Ira W. Snyder
On Mon, Aug 16, 2010 at 05:52:41PM +0530, Ravi Gupta wrote: Hi, I have defined a header file for ioctls macros definitions. I am including it in both, my user space application as well as in my device driver. Now there are some macros that I want to be visible only in device drive and some

Re: make uImage issue with new kernels

2010-08-17 Thread Ira W. Snyder
On Tue, Aug 17, 2010 at 03:05:05PM -0700, Tirumala Marri wrote: I am seeing weird issue with latest kernel. “make uImage” failes with “no rule to make target” error message. Has anything changed recently ? ---msg {tma...@svdclab61} make 44x/canyonlands_defconfig

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-19 Thread Ira W. Snyder
On Thu, Aug 19, 2010 at 02:29:49PM +0200, Arnd Bergmann wrote: On Thursday 19 August 2010, Richard Cochran wrote: On Wed, Aug 18, 2010 at 05:02:03PM +0200, Arnd Bergmann wrote: You might want to use callbacks for these system calls that you can register to at module load time, like it

[PATCH] fsldma: fix missing header include

2010-09-02 Thread Ira W. Snyder
The slab.h header is required to use the kmalloc() family of functions. Due to recent kernel changes, this header must be directly included by code that calls into the memory allocator. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- Without this patch, any code which includes this header

Where to put board-specific drivers

2010-09-02 Thread Ira W. Snyder
Hello all, I've written several drivers for a custom board. The board is basically an mpc8349_mds board with some extra FPGAs for data processing. All of the drivers were written to interface with a custom system controller FPGA, which handles things like LED control, FPGA programming, and fast

Re: Where to put board-specific drivers

2010-09-02 Thread Ira W. Snyder
On Thu, Sep 02, 2010 at 03:17:52PM -0500, Kumar Gala wrote: On Sep 2, 2010, at 3:04 PM, Ira W. Snyder wrote: Hello all, I've written several drivers for a custom board. The board is basically an mpc8349_mds board with some extra FPGAs for data processing. All of the drivers were

Re: Where to put board-specific drivers

2010-09-02 Thread Ira W. Snyder
On Thu, Sep 02, 2010 at 05:24:34PM -0400, Sean MacLennan wrote: On Thu, 2 Sep 2010 14:12:22 -0700 Ira W. Snyder i...@ovro.caltech.edu wrote: To give you three example drivers: 1) Data processing FPGA access driver This driver provides a simple character device to userspace which

[PATCH RFCv1 0/3] CARMA Board Support

2010-09-03 Thread Ira W. Snyder
layout is expected to change soon, so I won't post the driver until that is finished. The PPS driver will be posted seperately from this patch series; it is very generic. Thanks for any review and comments you can offer! Ira Ira W. Snyder (3): fpga: add basic CARMA board support fpga: add

[PATCH RFCv1 1/3] fpga: add basic CARMA board support

2010-09-03 Thread Ira W. Snyder
This adds basic support for the system controller FPGA on the OVRO CARMA board. This patch only adds infrastructure that will be used by later drivers. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/Kconfig |2 + drivers/Makefile|1 + drivers/fpga

[PATCH RFCv1 2/3] fpga: add CARMA DATA-FPGA Access Driver

2010-09-03 Thread Ira W. Snyder
of correlation data from the FPGAs. This lowers the realtime scheduling requirements for the userspace process reading the device. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/fpga/carma/Kconfig |9 + drivers/fpga/carma/Makefile |1 + drivers/fpga/carma/carma

[PATCH RFCv1 3/3] fpga: add CARMA DATA-FPGA Programmer support

2010-09-03 Thread Ira W. Snyder
This adds support for programming the data processing FPGAs on the OVRO CARMA board. These FPGAs have a special programming sequence that requires that we program the Freescale DMA engine, which is only available inside the kernel. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers

Re: [PATCH] fsldma: fix missing header include

2010-09-03 Thread Ira W. Snyder
On Fri, Sep 03, 2010 at 04:40:33PM -0700, Andrew Morton wrote: On Thu, 2 Sep 2010 12:47:52 -0700 Ira W. Snyder i...@ovro.caltech.edu wrote: The slab.h header is required to use the kmalloc() family of functions. Due to recent kernel changes, this header must be directly included by code

[PATCH RFCv2 0/5] CARMA Board Support

2010-09-08 Thread Ira W. Snyder
won't post the driver until that is finished. The PPS driver will be posted seperately from this patch series; it is very generic. Thanks for any review and comments you can offer! Ira Ira W. Snyder (5): fsldma: fix missing header include fsldma: move DMA_SLAVE support functions to the driver

[PATCH 1/5] fsldma: fix missing header include

2010-09-08 Thread Ira W. Snyder
The slab.h header is required to use the kmalloc() family of functions. Due to recent kernel changes, this header must be directly included by code that calls into the memory allocator. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- arch/powerpc/include/asm/fsldma.h |1 + 1 files

[PATCH 2/5] fsldma: move DMA_SLAVE support functions to the driver

2010-09-08 Thread Ira W. Snyder
The DMA_SLAVE support functions all existed as static inlines in the driver specific header arch/powerpc/include/asm/fsldma.h. Move the body of the functions to the driver itself, and EXPORT_SYMBOL_GPL() them. At the same time, add the missing linux/list.h header. Signed-off-by: Ira W. Snyder i

[PATCH 5/5] fpga: add CARMA DATA-FPGA Programmer support

2010-09-08 Thread Ira W. Snyder
This adds support for programming the data processing FPGAs on the OVRO CARMA board. These FPGAs have a special programming sequence that requires that we program the Freescale DMA engine, which is only available inside the kernel. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers

CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-08 Thread Ira W. Snyder
Hello everyone, I'm running Linux on a Freescale MPC8349EA board (PowerPC 6xx processor). When I enable the CONFIG_PROVE_LOCKING option, the kernel fails to boot. If I toggle that option (and ONLY that option) off, the kernel boots normally. The lockup happens very, very early during boot. Much

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-08 Thread Ira W. Snyder
On Thu, Sep 09, 2010 at 11:02:36AM +1000, Benjamin Herrenschmidt wrote: On Wed, 2010-09-08 at 16:21 -0700, Ira W. Snyder wrote: I am happy to provide more information if it will help. I'm not especially good at working the debugger. I can't get it to stop at machine_init() and let

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Ira W. Snyder
On Thu, Sep 09, 2010 at 12:58:16PM +1000, Benjamin Herrenschmidt wrote: On Wed, 2010-09-08 at 19:52 -0700, Ira W. Snyder wrote: I will attempt to get the debugger to stop at start_kernel. I'm having trouble driving the JTAG debugger (a BDI2000). I have used Denx's guide [1] in the past

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Ira W. Snyder
On Thu, Sep 09, 2010 at 09:23:07AM -0700, Ira W. Snyder wrote: On Thu, Sep 09, 2010 at 12:58:16PM +1000, Benjamin Herrenschmidt wrote: On Wed, 2010-09-08 at 19:52 -0700, Ira W. Snyder wrote: I will attempt to get the debugger to stop at start_kernel. I'm having trouble driving

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Ira W. Snyder
On Thu, Sep 09, 2010 at 11:44:46AM -0700, Ira W. Snyder wrote: [ snip a bunch of info: summary below ] I've also found that setting a breakpoint at 0x0 stops right when the Linux kernel starts, at symbol _start. AFAIK, the MMU is not yet enabled, so I have to subtract 0xc000 from all

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Ira W. Snyder
On Thu, Sep 09, 2010 at 02:10:59PM -0500, Timur Tabi wrote: On Thu, Sep 9, 2010 at 1:44 PM, Ira W. Snyder i...@ovro.caltech.edu wrote: Single stepping through the initial assembly portion of kernel startup shows that the FDT gets clobbered during the function early_init(). This trace

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Ira W. Snyder
On Thu, Sep 09, 2010 at 02:40:50PM -0500, Timur Tabi wrote: Ira W. Snyder wrote: As noted in another email, it appears that U-Boot puts the FDT in such a place that Linux overwrites it with the BSS. The CONFIG_PROVE_LOCKING=y option expands the BSS by a large amount, which causes the error

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Ira W. Snyder
On Thu, Sep 09, 2010 at 03:36:31PM -0500, Timur Tabi wrote: Ira W. Snyder wrote: That did it! Yea! I'm using include/configs/MPC8349EMDS.h. On that board, CONFIG_SYS_BOOTMAPSZ is 8MB. Boosting it to 16MB fixed the problem and the kernel now boots. Ah, yes. I believe the reason

Re: [PATCH RFCv2 0/5] CARMA Board Support

2010-09-17 Thread Ira W. Snyder
On Wed, Sep 08, 2010 at 09:41:17AM -0700, Ira W. Snyder wrote: Hello everyone, This is the second posting of these drivers, taking into account comments from the RFCv1 post. Thanks to all that contributed. Any comments on this series? I haven't heard anything for more than a week

[PATCH RFCv1 0/2] dma: add support for sg-to-sg transfers

2010-09-24 Thread Ira W. Snyder
not be fragmented into multiple smaller chains. This is what is achieved by submitting all descriptors without using chaining. Ira W. Snyder (2): dmaengine: add support for scatterlist to scatterlist transfers fsldma: use generic support for scatterlist to scatterlist transfers arch/powerpc

[PATCH RFCv1 1/2] dmaengine: add support for scatterlist to scatterlist transfers

2010-09-24 Thread Ira W. Snyder
This adds support for scatterlist to scatterlist DMA transfers. As requested by Dan, this is hidden behind an ifdef so that it can be selected by the drivers that need it. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/Kconfig |4 ++ drivers/dma/dmaengine.c | 119

[PATCH RFCv1 2/2] fsldma: use generic support for scatterlist to scatterlist transfers

2010-09-24 Thread Ira W. Snyder
to scatterlist transfers, this operation is no longer needed. The generic support is used for scatterlist to scatterlist transfers. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- arch/powerpc/include/asm/fsldma.h | 115 ++-- drivers/dma/fsldma.c | 219

Re: [PATCH RFCv1 1/2] dmaengine: add support for scatterlist to scatterlist transfers

2010-09-24 Thread Ira W. Snyder
On Fri, Sep 24, 2010 at 01:40:56PM -0700, Dan Williams wrote: On Fri, Sep 24, 2010 at 12:46 PM, Ira W. Snyder i...@ovro.caltech.edu wrote: This adds support for scatterlist to scatterlist DMA transfers. As requested by Dan, this is hidden behind an ifdef so that it can be selected

Re: [PATCH RFCv1 1/2] dmaengine: add support for scatterlist to scatterlist transfers

2010-09-24 Thread Ira W. Snyder
On Fri, Sep 24, 2010 at 02:53:14PM -0700, Dan Williams wrote: On Fri, 2010-09-24 at 14:24 -0700, Ira W. Snyder wrote: On Fri, Sep 24, 2010 at 01:40:56PM -0700, Dan Williams wrote: I don't think any dma channels gracefully handle descriptors that were prepped but not submitted. You would

Re: [PATCH RFCv1 1/2] dmaengine: add support for scatterlist to scatterlist transfers

2010-09-24 Thread Ira W. Snyder
On Fri, Sep 24, 2010 at 03:04:19PM -0700, Ira W. Snyder wrote: On Fri, Sep 24, 2010 at 02:53:14PM -0700, Dan Williams wrote: On Fri, 2010-09-24 at 14:24 -0700, Ira W. Snyder wrote: On Fri, Sep 24, 2010 at 01:40:56PM -0700, Dan Williams wrote: I don't think any dma channels gracefully

[PATCH RFCv2 0/2] dma: add support for sg-to-sg transfers

2010-09-24 Thread Ira W. Snyder
would recommend against committing this until I've tested it on real hardware. Ira W. Snyder (2): dmaengine: add support for scatterlist to scatterlist transfers fsldma: use generic support for scatterlist to scatterlist transfers arch/powerpc/include/asm/fsldma.h | 115

[PATCH RFCv2 1/2] dmaengine: add support for scatterlist to scatterlist transfers

2010-09-24 Thread Ira W. Snyder
This adds support for scatterlist to scatterlist DMA transfers. This is currently hidden behind a configuration option, which will allow drivers which need this functionality to select it individually. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/Kconfig |3

[PATCH RFCv2 2/2] fsldma: use generic support for scatterlist to scatterlist transfers

2010-09-24 Thread Ira W. Snyder
to scatterlist transfers, this operation is no longer needed. The generic support is used for scatterlist to scatterlist transfers. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- arch/powerpc/include/asm/fsldma.h | 115 ++-- drivers/dma/fsldma.c | 219

Re: [PATCH RFCv2 1/2] dmaengine: add support for scatterlist to scatterlist transfers

2010-09-27 Thread Ira W. Snyder
On Mon, Sep 27, 2010 at 05:23:34PM +0200, Linus Walleij wrote: 2010/9/25 Ira W. Snyder i...@ovro.caltech.edu: This adds support for scatterlist to scatterlist DMA transfers. This is a good idea, we have a local function to do this in DMA40 already, stedma40_memcpy_sg(). I think

[PATCH RFCv3 0/4] dma: add support for scatterlist to scatterlist copy

2010-09-27 Thread Ira W. Snyder
of the ste_dma40 driver which should do the right thing, but the authors should check and make sure. Ira W. Snyder (4): dma: add support for scatterlist to scatterlist copy fsldma: implement support for scatterlist to scatterlist copy fsldma: remove DMA_SLAVE support ste_dma40: implement support

[PATCH 1/4] dma: add support for scatterlist to scatterlist copy

2010-09-27 Thread Ira W. Snyder
DMAEngine API. Futher patches will add support in individual drivers. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/dmaengine.c |2 ++ include/linux/dmaengine.h |6 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/dma/dmaengine.c b/drivers/dma

[PATCH 3/4] fsldma: remove DMA_SLAVE support

2010-09-27 Thread Ira W. Snyder
configuration, such as enabling external control. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- arch/powerpc/include/asm/fsldma.h | 115 ++-- drivers/dma/fsldma.c | 219 +++-- 2 files changed, 48 insertions(+), 286 deletions(-) diff

Re: Parsing a bus fault message?

2010-09-28 Thread Ira W. Snyder
On Tue, Sep 28, 2010 at 09:26:51AM -0500, david.hag...@gmail.com wrote: I finally found my problems accessing the PPC OWBAR registers as an endpoint (copy/paste brown paper bag bug on my part), but I still get a bus fault trying to access the device. The problem is that I don't know if the

Re: [PATCH 3/4] fsldma: remove DMA_SLAVE support

2010-09-29 Thread Ira W. Snyder
On Wed, Sep 29, 2010 at 02:52:16PM -0700, Dan Williams wrote: On Mon, Sep 27, 2010 at 3:57 PM, Ira W. Snyder i...@ovro.caltech.edu wrote: Now that the generic DMAEngine API has support for scatterlist to scatterlist copying, this implementation of the DMA_SLAVE API is no longer necessary

[PATCH v4 2/4] fsldma: implement support for scatterlist to scatterlist copy

2010-09-30 Thread Ira W. Snyder
Now that the DMAEngine API has support for scatterlist to scatterlist copy, implement support for the Freescale DMA controller. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 128 - 1 files changed, 125 insertions

[PATCH v4 0/4] dma: add support for scatterlist to scatterlist copy

2010-09-30 Thread Ira W. Snyder
for external control - fsldma now uses the standard struct dma_slave_config - tested on real hardware Ira W. Snyder (4): dma: add support for scatterlist to scatterlist copy fsldma: implement support for scatterlist to scatterlist copy fsldma: improved DMA_SLAVE support ste_dma40: implement

[PATCH v4 3/4] fsldma: improved DMA_SLAVE support

2010-09-30 Thread Ira W. Snyder
- * - * Copyright (c) 2009 Ira W. Snyder i...@ovro.caltech.edu - * - * This file is licensed under the terms of the GNU General Public License - * version 2. This program is licensed as is without any warranty of any - * kind, whether express or implied. - */ - -#ifndef __ARCH_POWERPC_ASM_FSLDMA_H__ -#define

Re: Ethernet over PCIe driver for Inter-Processor Communication

2013-08-22 Thread Ira W. Snyder
On Thu, Aug 22, 2013 at 02:43:38PM -0700, David Hawkins wrote: Hi S.Saravanan, I have a custom board with four MPC8640 nodes connected over a transparent PCI express switch . In this configuration one node is configured as host(Root Complex) and others as agents(End Point). Thus the

Re: Replacement to of_register_platform_driver ?

2012-06-13 Thread Ira W. Snyder
On Wed, Jun 13, 2012 at 05:21:22PM +0200, Guillaume Dargaud wrote: Hello all, I just updated to the most recent kernel and a driver I wrote last year won't compile: xad.c:534:2: error: implicit declaration of function 'of_register_platform_driver' I see references to this function as

Re: [PATCH v2 2/4] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

2012-07-11 Thread Ira W. Snyder
. Other than that, you can add my: Acked-by: Ira W. Snyder i...@ovro.caltech.edu Cc: Dan Williams dan.j.willi...@intel.com Cc: Vinod Koul vinod.k...@intel.com Cc: Li Yang le...@freescale.com Signed-off-by: Qiang Liu qiang@freescale.com --- drivers/dma/fsldma.c | 31

Re: [PATCH v2 3/4] fsl-dma: change the release process of dma descriptor

2012-07-11 Thread Ira W. Snyder
On Wed, Jul 11, 2012 at 05:01:25PM +0800, Qiang Liu wrote: Modify the release process of dma descriptor for avoiding exception when enable config NET_DMA, release dma descriptor from 1st to last second, the last descriptor which is reserved in current descriptor register may not be completed,

Re: [PATCH v3 3/4] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-16 Thread Ira W. Snyder
vinod.k...@intel.com Cc: Li Yang le...@freescale.com Cc: Ira W. Snyder i...@ovro.caltech.edu Signed-off-by: Qiang Liu qiang@freescale.com --- drivers/dma/fsldma.c | 378 + drivers/dma/fsldma.h |1 + 2 files changed, 225 insertions

Re: [PATCH v3 3/4] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-17 Thread Ira W. Snyder
On Tue, Jul 17, 2012 at 07:06:33AM +, Liu Qiang-B32616 wrote: -Original Message- From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] Sent: Tuesday, July 17, 2012 4:01 AM To: Liu Qiang-B32616 Cc: linux-cry...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Phillips Kim-R1AAHA

Re: [linuxppc-release] [PATCH v4 7/7] fsl-dma: add memcpy self test interface

2012-07-30 Thread Ira W. Snyder
On Mon, Jul 30, 2012 at 12:48:41PM -0500, Timur Tabi wrote: qiang@freescale.com wrote: Add memory copy self test when probe device, fsl-dma will be disabled if self test failed. Is this a real problem that can occur? The DMA driver used to have a self-test, but I removed it a long

Re: [PATCH v4 3/7] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-30 Thread Ira W. Snyder
] [c0429080] raid5d+0x3d4/0x5b4 [ecf41f40] [c04329b8] md_thread+0x138/0x16c [ecf41f90] [c008277c] kthread+0x8c/0x90 [ecf41ff0] [c0011630] kernel_thread+0x4c/0x68 Cc: Dan Williams dan.j.willi...@intel.com Cc: Vinod Koul vinod.k...@intel.com Cc: Li Yang le...@freescale.com Cc: Ira W. Snyder i

Re: [PATCH v4 3/7] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-31 Thread Ira W. Snyder
On Tue, Jul 31, 2012 at 04:09:28AM +, Liu Qiang-B32616 wrote: -Original Message- From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] Sent: Tuesday, July 31, 2012 5:10 AM To: Liu Qiang-B32616 Cc: linux-cry...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Phillips Kim-R1AAHA

[PATCH 0/7] fsl-dma: fixes for Freescale DMA driver

2012-07-31 Thread Ira W. Snyder
From: Ira W. Snyder i...@ovro.caltech.edu Hello everyone, This is my alternative (simpler) attempt at solving the problems reported by Qiang Liu with the async_tx API and MD RAID hardware offload support when using the Freescale DMA driver. The bug is caused by this driver freeing descriptors

[PATCH 1/7] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

2012-07-31 Thread Ira W. Snyder
...@freescale.com Signed-off-by: Qiang Liu qiang@freescale.com Acked-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 31 --- 1 files changed, 0 insertions(+), 31 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 8f84761..4f2f212

[PATCH 3/7] fsl-dma: add fsl_dma_free_descriptor() to reduce code duplication

2012-07-31 Thread Ira W. Snyder
From: Ira W. Snyder i...@ovro.caltech.edu There are several places where descriptors are freed using identical code. Put this code into a function to reduce code duplication. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 32 ++-- 1

[PATCH 2/7] fsl-dma: minimize locking overhead

2012-07-31 Thread Ira W. Snyder
From: Ira W. Snyder i...@ovro.caltech.edu The use of spin_lock_irqsave() was a stronger locking mechanism than was actually needed in many cases. As the current code is written, spin_lock_bh() everywhere is sufficient. The next patch in this series will add some code to hardware interrupt

[PATCH 4/7] fsl-dma: move functions to avoid forward declarations

2012-07-31 Thread Ira W. Snyder
From: Ira W. Snyder i...@ovro.caltech.edu This function will be modified in the next patch in the series. By moving the function in a patch separate from the changes, it will make review easier. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 96

[PATCH 5/7] fsl-dma: fix support for async_tx API

2012-07-31 Thread Ira W. Snyder
From: Ira W. Snyder i...@ovro.caltech.edu The current fsldma driver does not support the async_tx API. This is due to a bug: all descriptors are released when the hardware is finished with them. The async_tx API requires that the ACK bit is set by software before descriptors are freed. This bug

[PATCH 6/7] fsl-dma: fix a warning of unitialized cookie

2012-07-31 Thread Ira W. Snyder
From: Qiang Liu qiang@freescale.com Fix a warning of unitialized value when compile with -Wuninitialized. Cc: Dan Williams dan.j.willi...@intel.com Cc: Vinod Koul vinod.k...@intel.com Cc: Li Yang le...@freescale.com Signed-off-by: Qiang Liu qiang@freescale.com Cc: Kim Phillips

[PATCH 7/7] carma: remove unnecessary DMA_INTERRUPT capability

2012-07-31 Thread Ira W. Snyder
From: Ira W. Snyder i...@ovro.caltech.edu These drivers set the DMA_INTERRUPT capability bit when requesting a DMA controller channel. This was historical, and is no longer needed. Recent changes to the drivers/dma/fsldma.c driver have removed support for this flag. This makes the carma drivers

Re: [PATCH v5 4/6] fsl-dma: move the function ahead of its invoke function

2012-08-01 Thread Ira W. Snyder
On Wed, Aug 01, 2012 at 04:49:43PM +0800, qiang@freescale.com wrote: From: Qiang Liu qiang@freescale.com Move the function fsldma_cleanup_descriptor() and fsl_chan_xfer_ld_queue() ahead of its invoke function for avoiding redundant definition. Cc: Dan Williams

Re: [PATCH v5 2/6] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

2012-08-01 Thread Ira W. Snyder
exclusively. Cc: Dan Williams dan.j.willi...@intel.com Cc: Vinod Koul vinod.k...@intel.com Cc: Li Yang le...@freescale.com Signed-off-by: Qiang Liu qiang@freescale.com Acked-by: Ira W. Snyder i...@ovro.caltech.edu --- drivers/dma/fsldma.c | 31 --- 1 files

Re: [PATCH v5 3/6] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-08-01 Thread Ira W. Snyder
you intend to fix it? Cc: Dan Williams dan.j.willi...@intel.com Cc: Dan Williams dan.j.willi...@gmail.com Cc: Vinod Koul vinod.k...@intel.com Cc: Li Yang le...@freescale.com Cc: Ira W. Snyder i...@ovro.caltech.edu Signed-off-by: Qiang Liu qiang@freescale.com --- drivers/dma/fsldma.c

Re: [PATCH v5 6/6] fsl-dma: fix a warning of unitialized cookie

2012-08-01 Thread Ira W. Snyder
On Wed, Aug 01, 2012 at 04:50:27PM +0800, qiang@freescale.com wrote: From: Qiang Liu qiang@freescale.com Fix a warning of unitialized value when compile with -Wuninitialized. Looks good to me. Acked-by: Ira W. Snyder i...@ovro.caltech.edu Cc: Dan Williams dan.j.willi...@intel.com

Re: [PATCH v5 5/6] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-08-01 Thread Ira W. Snyder
manipulation of protected fields is done using tasklet context or weaker, which makes spin_lock_bh() the correct choice. Other than that, Acked-by: Ira W. Snyder i...@ovro.caltech.edu Cc: Dan Williams dan.j.willi...@intel.com Cc: Vinod Koul vinod.k...@intel.com Cc: Li Yang le...@freescale.com Cc

Re: [PATCH v5 3/6] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-08-02 Thread Ira W. Snyder
On Thu, Aug 02, 2012 at 07:21:51AM +, Liu Qiang-B32616 wrote: -Original Message- From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] Sent: Thursday, August 02, 2012 1:25 AM To: Liu Qiang-B32616 Cc: linux-cry...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- ker

Re: [PATCH v6 5/8] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-08-06 Thread Ira W. Snyder
...@gmail.com Cc: Vinod Koul vinod.k...@intel.com Cc: Li Yang le...@freescale.com Signed-off-by: Qiang Liu qiang@freescale.com Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu There are two minor nitpicks below. Other than that, the patch looks excellent to me. Ira --- drivers/dma

Re: [PATCH v7 0/8] Raid: enable talitos xor offload for improving performance

2012-08-09 Thread Ira W. Snyder
On Thu, Aug 09, 2012 at 04:19:35PM +0800, qiang@freescale.com wrote: Hi all, The following 8 patches enabling fsl-dma and talitos offload raid operations for improving raid performance and balancing CPU load. These patches include talitos, fsl-dma and carma module (caram uses some

Re: recommended method of netbooting kernel/dtb in u-boot?

2013-04-11 Thread Ira W. Snyder
On Thu, Apr 11, 2013 at 12:39:00PM -0600, Chris Friesen wrote: On 04/11/2013 12:12 PM, Kumar Gala wrote: On Apr 11, 2013, at 10:44 AM, Chris Friesen wrote: Hi all, We've got a powerpc system that uses u-boot. In our environment on bootup u-boot does a DHCP to get networking info,

Re: [RFC v2] virtio: add virtio-over-PCI driver

2011-05-06 Thread Ira W. Snyder
On Fri, May 06, 2011 at 12:00:34PM +, Kushwaha Prabhakar-B32579 wrote: Hi, I want to use this patch as base patch for FSL 85xx platform to support PCIe Agent. The work looks to be little old now. So wanted to understand if any development has happened further on it. In case no, I

  1   2   >